October 2007 - Wine-devel - list.winehq.org

notepad: Dangling pointer fix
by Andrew Talbot 18 Oct '07

18 Oct '07

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA (try 2)
by Detlef Riekenberg 18 Oct '07

18 Oct '07

On Mi, 2007-10-17 at 13:17 -0700, Nigel Liang wrote: > + urlCompa.dwStructSize = sizeof(urlCompa); > + bRet = InternetCrackUrlA(sUrl, 11, 0, &urlCompa); > + ZeroMemory(&urlCompa, sizeof(urlCompa)); > + ZeroMemory(&szBuf, sizeof(char)*1024); > + urlCompa.dwUserNameLength = 1024; It looks much better, when you avoid constant numbers. I suggest to use sizeof() instead. (but never use "sizeof()" in "ok()" or in "trace()".) Thanks for helping wine. -- By by ... Detlef

1 0

Re: widl [4/4]: Detect conformant arrays of user types correctly.
by Robert Shearman 18 Oct '07

18 Oct '07

Dan Hipschman wrote: > @@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields) > case RPC_FC_OP: > case RPC_FC_CARRAY: > case RPC_FC_CVARRAY: > + case RPC_FC_BOGUS_ARRAY: > has_pointer = 1; > break; > > @@ -1897,15 +1898,9 @@ static int get_struct_type(var_list_t *fields) > /* fallthru - treat it as complex */ > > /* as soon as we see one of these these members, it's bogus... */ > - case RPC_FC_IP: > case RPC_FC_ENCAPSULATED_UNION: > case RPC_FC_NON_ENCAPSULATED_UNION: > - case RPC_FC_TRANSMIT_AS: > - case RPC_FC_REPRESENT_AS: > - case RPC_FC_PAD: > - case RPC_FC_EMBEDDED_COMPLEX: > case RPC_FC_BOGUS_STRUCT: > - case RPC_FC_BOGUS_ARRAY: > return RPC_FC_BOGUS_STRUCT; > } > } > Hi Dan, What's the reasoning behind this part of the patch? It seems to me like most of the cases that you removed from becoming a complex structure are actually valid. The hunk further up also confuses me - the presence of a complex array shouldn't just make the resulting structure into a pointer structure, it should make it into a complex structure, since it can't be marshalled solely by using memcpy. -- Rob Shearman

2 1

Priority/severity of test suite hangs
by Dan Kegel 18 Oct '07

18 Oct '07

I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: [2/3] hlink: Undefine the GetObject macro when compiling the Wine source to avoid errors.
by Jacek Caban 18 Oct '07

18 Oct '07

Hi Francois, Francois Gouget wrote: > > +/* GetObject is defined in wingdi.h as WINELIB_NAME_AW(GetObject), > + * which resolves to a compilation failure if WINE_NO_UNICODE_MACROS is > + * defined, but GetObject is used as a valid method name below, so we have > + * to undefine it in that case */ > +cpp_quote("#ifdef WINE_NO_UNICODE_MACROS") > +cpp_quote("#undef GetObject") > +cpp_quote("#endif") > + > /***************************************************************************** > * IHlinkBrowseContext interface > */ > I've sent a patch for it yesterday and it's applied now: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a41cab9b52893f472de6c… I've also sent a patch for mshtml.idl patch (but my version didn't include import shtypes.idl): http://source.winehq.org/git/wine.git/?a=commitdiff;h=62894b488d0b03a922b80… Thanks, Jacek

1 0

Re: inkobj: Implement IClassFactory
by Alexandre Julliard 18 Oct '07

18 Oct '07

"John Klehm" <xixsimplicityxix(a)gmail.com> writes: > This patch is largely based on the code found in mshtml. What I did > was separate it into its own file and restyle it to my liking. Restyling it wasn't such a good idea I'm afraid, the original code is better without these ugly casts, and the Release function was correct, unlike yours. Also please don't name your files inkobj_something, they are in the inkobj directory already, no need to repeat that in the file name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW (try 2)
by Alexandre Julliard 18 Oct '07

18 Oct '07

Nigel Liang <ncliang(a)gmail.com> writes: > Previous patch had incorrect bounds for memchrW. There are other places in that function that assume that the string is null-terminated, please fix those too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Added support for installing Gecko from build dir.
by Alexandre Julliard 18 Oct '07

18 Oct '07

Jacek Caban <jacek(a)codeweavers.com> writes: > - static const char gecko_dir[] = "/gecko/"; > - > - data_dir = wine_get_data_dir(); > - if(!data_dir) return FALSE; > + if((data_dir = wine_get_data_dir())) > + subdir = "/gecko/"; > + else if((data_dir = wine_get_build_dir())) > + subdir = "/dlls/mshtml/"; I don't think this file should be inside the build dir, it's not something that can be easily regenerated. Maybe we should look for it in $build_dir/.. ? -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: msi: make the WriteEnvironmentStrings handling of [~] a bit better
by EA Durbin 17 Oct '07

17 Oct '07

The compiler complains at this line about lstrlenW being passed an incompatible pointer type + else if (lstrlenW(value) >= prefix_len) should it be lstrlenW(*value) ? _________________________________________________________________ Climb to the top of the charts! Play Star Shuffle: the word scramble challenge with star power. http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct

2 1

Re: [PATCH] wininet: Close sockets open in http requests
by Misha Koshelev 17 Oct '07

17 Oct '07

> n 10/13/07, Nigel Liang <ncliang at gmail.com> wrote: > > Hi, > > > > Http requests open sockets and forget to close them. Left running over a long > > period, the socket file descriptor starts getting large. Once it exceeds > > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > > > -Nigel > > > > --- > > dlls/wininet/internet.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > > index 0edca74..8e3a98e 100644 > > --- a/dlls/wininet/internet.c > > +++ b/dlls/wininet/internet.c > > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > > return FALSE; > > } > > > > + if (lpwh->htype == WH_HHTTPREQ) > > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > > + > > WININET_Release( lpwh ); > > WININET_FreeHandle( hInternet ); > > > > -- > > 1.4.1 > > > > > > Hi, > > This patch was sent 4 days ago and it hasn't gone in yet. Could anyone > give me some comments on it? Dan filed bug 10032 which is related to > this. While we shouldn't be using select() on high FDs for networking, > this patch closes the sockets that were open by http requests to avoid > getting to high FDs... > > Thanks, > -Nigel Hi, well looking over this very quickly right off the bat it does not seem correct to me. WININET_Release will call the close_connection method of the handle if it is defined, and for WH_HHTTPREQ this is HTTP_CloseConnection, which does call NETCON_Close along with sending all the proper status notifications, etc. So if in fact NETCON_Close is _not_ being called for some reason, you need to track down where involving those functions either why the proper one is not getting called (if that is the case) or if that function somehow needs to call NETCON_Close when it doesn't. Misha

2 3