December 2007 - Wine-devel - list.winehq.org

Re: user32: add stub for GetLayeredWindowAttributes
by Dmitry Timoshkov 20 Dec '07

20 Dec '07

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > +BOOL WINAPI GetLayeredWindowAttributes( HWND hWnd,COLORREF* prgbKey, > + BYTE* pbAlpha, DWORD* pdwFlags ) > +{ > + FIXME("(%p,0x%.8x,%d,%d): stub!\n", hWnd, *prgbKey, *pbAlpha, *pdwFlags); > + return TRUE; > +} Probably a better idea would be to return FALSE, otherwise you have to initialize all the requested data. -- Dmitry.

1 0

Re: mapi32: Resolve FIXME regarding attachment lists in MAPISendMailfunction
by Dmitry Timoshkov 20 Dec '07

20 Dec '07

"Mark Neyhart" <Mark_Neyhart(a)legis.state.ak.us> wrote: > diff --git a/dlls/mapi32/sendmail.c b/dlls/mapi32/sendmail.c > old mode 100644 > new mode 100755 Please fix file permissions before submitting patches. -- Dmitry.

1 0

Re: advapi32: Fix domain length setting in LookupAccountNameW
by Zac Brown 20 Dec '07

20 Dec '07

Zac Brown wrote: > Hi, > > Changelog: > * Fix value setting for *cchReferencedDomainName in LookupAccountNameW > * Fix LookupAccountNameA conversion from WCHAR to CHAR by setting proper '\0' > > Notes: > * This patch addresses bug 10612 > > -Zac Brown > > > ------------------------------------------------------------------------ > > Ignore this patch, it has stupid mistakes in it. Will send a second one thats correct. -Zac

1 0

The #winehq Wine channel
by Andrew Riedi 20 Dec '07

20 Dec '07

There are two main issues I would like to address. 1) Normally the current #winehq OPs to a great job, but they are only human and only have so many waking hours. I noticed recently that it took a little longer than normal for #winehq's topic to be updated to the latest release. I would like to ask for some basic OP rights to update the topic when the regular OPs are unable to, due to real life. Who is in charge of this sort of thing? 2) Rules. Should we provide a set of rules for #winehq use? For general Wine-based channel use? (#winehq, #winehq-social, #winehackers, #crossover) Perhaps state when people deserve a kick, the purposes of each channel, etc. Maybe we should start a wiki page with the information, rules, etc.? -- Andrew Riedi

1 0

Re: [PATCH] Implement BindIoCompletionCallback
by Robert Shearman 20 Dec '07

20 Dec '07

Andrey Turkin wrote: > /****************************************************************************** > * BindIoCompletionCallback (KERNEL32.@) > */ > +extern NTSTATUS WINAPI RtlSetIoCompletionCallback(HANDLE,LPOVERLAPPED_COMPLETION_ROUTINE,ULONG); > This should go in winternl.h. > BOOL WINAPI BindIoCompletionCallback( HANDLE FileHandle, LPOVERLAPPED_COMPLETION_ROUTINE Function, ULONG Flags) > { > - FIXME("%p, %p, %d, stub!\n", FileHandle, Function, Flags); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + NTSTATUS status; > + > + TRACE("(%p, %p, %d)\n", FileHandle, Function, Flags); > + > + status = RtlSetIoCompletionCallback( FileHandle, Function, Flags ); > + if (status == STATUS_SUCCESS) return TRUE; > + SetLastError( RtlNtStatusToDosError(status) ); > return FALSE; > } > -- Rob Shearman

8 12

Re: kernel32: Remove unneeded casts
by Robert Shearman 20 Dec '07

20 Dec '07

Andrew Talbot wrote: > /* All local heap allocations are aligned on 4-byte boundaries */ > #define LALIGN(word) (((word) + 3) & ~3) > > -#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((char*)(ptr)+(arena))) > +#define ARENA_PTR(ptr,arena) ((LOCALARENA *)((ptr)+(arena))) Don't remove casts from macros like this as they then won't be safe if the type that is passed in is changed to something else (like void *). -- Rob Shearman

2 1

Re: try2:winefile:Save font settings for registry
by Dmitry Timoshkov 20 Dec '07

20 Dec '07

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > + if( RegQueryValueExW( hKey, reg_logfont, NULL, &type, > + (LPBYTE) &logfont, &size ) != ERROR_SUCCESS ) { > + hFont=GetStockObject(DEFAULT_GUI_FONT); > + GetObject(hFont,sizeof(logfont),&logfont); > + } There is no need to introduce the hFont variable. > + GetObject(Globals.hfont, sizeof(logfont), &logfont); To make the code more readable this call should be moved where logfont is actually used. > + RegSetValueExW( hKey, reg_logfont, 0, REG_DWORD, > + (LPBYTE) &logfont, sizeof(LOGFONT) ); The type should be set to REG_BINARY. -- Dmitry.

2 2

Re: rpcrt4: Fix regression in NdrConformantStringUnmarshall by doing the memcpy check in safe_copy_from_buffer
by Robert Shearman 20 Dec '07

20 Dec '07

Maarten Lankhorst wrote: > @@ -665,7 +665,8 @@ static inline void safe_copy_from_buffer(MIDL_STUB_MESSAGE *pStubMsg, void *p, U > if ((pStubMsg->Buffer + size < pStubMsg->Buffer) || /* integer overflow of pStubMsg->Buffer */ > (pStubMsg->Buffer + size > pStubMsg->BufferEnd)) > RpcRaiseException(RPC_X_BAD_STUB_DATA); > - memcpy(p, pStubMsg->Buffer, size); > + if (p != pStubMsg->Buffer) > + memcpy(p, pStubMsg->Buffer, size); > pStubMsg->Buffer += size; > } > > @@ -890,8 +891,7 @@ unsigned char *WINAPI NdrConformantStringUnmarshall( PMIDL_STUB_MESSAGE pStubMsg > *ppMemory = NdrAllocate(pStubMsg, memsize); > } > > - if (*ppMemory != pStubMsg->Buffer) > - safe_copy_from_buffer(pStubMsg, *ppMemory, bufsize); > + safe_copy_from_buffer(pStubMsg, *ppMemory, bufsize); > > if (*pFormat == RPC_FC_C_CSTRING) { > TRACE("string=%s\n", debugstr_a((char*)*ppMemory)); > Good work in spotting and fixing the mistake I made, but I think I'd prefer to fix it by making the caller of safe_copy_from_buffer do the incrementing of the buffer. This is to avoid confusion with the name of the function and to avoid the possibility that the buffer is incremented twice. -- Rob Shearman

2 2

Re: kernel32: invalidate local copy of console input event handle while reallocating console.
by Alexandre Julliard 20 Dec '07

20 Dec '07

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > @@ -378,10 +381,7 @@ BOOL WINAPI CloseConsoleHandle(HANDLE handle) > */ > HANDLE WINAPI GetConsoleInputWaitHandle(void) > { > - static HANDLE console_wait_event; > - > - /* FIXME: this is not thread safe */ > - if (!console_wait_event) > + if (console_wait_event == INVALID_HANDLE_VALUE) 0 and INVALID_HANDLE_VALUE are not the same thing. The correct value to use for invalid events is 0. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi: Revert commit 96e4320feb22b3a2c9564de100c09990622edb59
by Mikołaj Zalewski 20 Dec '07

20 Dec '07

> > I have no idea what Mikolaj tried to fix with this patch but As I wrote in http://www.winehq.org/pipermail/wine-patches/2007-October/045479.html the problem was in the Photoshop CS2 installer where the groupbox consumed mouse events. They didn't arrive to the edit box (which was created earlier) what caused it to appear to be disabled. I checked that in that installer the groupbox had the BS_GROUPBOX style. Maybe that depends on some flags? Mikołaj Zalewski

2 1