December 2007 - Wine-devel - list.winehq.org

Re: [patch 1/2, try 2] wined3d: rewrite IWineD3DSurfaceImpl_BltOverride colorfill codepath
by Stefan Dösinger 20 Dec '07

20 Dec '07

Hi Alexander, I had a look at your patches again, and another issue came to my mind: I am not sure how the scissor rectangle and viewport affects ColorFill blits. IDirect3DDevice::Clear is limited by the viewport, the scissor test and the rectangles passed in, but I think that this doesn't apply to ColorFills. If that is true, I think there isn't much point in having a common codepath, and we should just put the glClear() call into COLORFILL itself - Dealing with the differences of those two calls will be more effort than the code shared. But I think we need a test for this. There is a clear() test in dlls/ddraw/tests/visual.c, but the d3d9 test tests a few more things. It should be possible to add a COLORFILL test to the visual.c clear test in ddraw as well, this will show if Windows honors the scissor and viewport in COLORFILL or not. Yes, I know... Start fixing one bug, and you'll run into a lot more. Happens to me all the time as well :-) Stefan

2 1

Re: [5/6] WineD3D: Move the GL info structure into the adapter
by H. Verbeet 20 Dec '07

20 Dec '07

On 20/12/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +#define WINED3D_ATR_TYPE(type) GLINFO_LOCATION.glTypeLookup[type].d3dType > +#define WINED3D_ATR_SIZE(type) GLINFO_LOCATION.glTypeLookup[type].size > +#define WINED3D_ATR_GLTYPE(type) GLINFO_LOCATION.glTypeLookup[type].glType > +#define WINED3D_ATR_NORMALIZED(type) GLINFO_LOCATION.glTypeLookup[type].normalized > +#define WINED3D_ATR_TYPESIZE(type) GLINFO_LOCATION.glTypeLookup[type].typesize Unrelated to the actual patch, but I think it wouldn't hurt to get rid of these macros. They're pretty much unnecessary.

1 0

Re: The BS_GROUPBOX style should only be used if the HasBorderattribute is set
by Dmitry Timoshkov 20 Dec '07

20 Dec '07

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog: > * The BS_GROUPBOX style should only be used if the HasBorder attribute is set. Alexandre, please don't apply this patch. I sent another patch that reverts commit 96e4320feb22b3a2c9564de100c09990622edb59 which is the real source of the problem. Perhaps James' patch is going in the right direction when a group box should really be displayed by a WM_DRAWITEM handler, or BS_GROUPBOX should be used instead in that case. But that needs a test case. -- Dmitry.

1 0

Today's git won't hunt. Server crash, lots of other problems?
by Dan Kegel 19 Dec '07

19 Dec '07

On Dec 18, 2007 10:29 AM, Susan Cragin <susancragin(a)earthlink.net> wrote: > My git won't install DNS9P any more, as of today's git. > Any suggestions? > > susan(a)ubuntu:~/DNS9$ wine setup > fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x34b944 (nil) 0x34b948 0x34b93c - stub > fixme:advapi:LookupAccountNameW (null) L"susan" 0x1463f0 0x34b944 0x146998 0x34b948 0x34b93c - stub > fixme:msi:ITERATE_DuplicateFiles We should track these duplicate files as well > fixme:msi:msi_unimplemented_action_stub RemoveFolders -> 2 ignored L"CreateFolder" table values > fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x34f7fc (nil) 0x34f800 0x34f7f4 - stub > fixme:advapi:LookupAccountNameW (null) L"susan" 0x1423a0 0x34f7fc 0x13ce80 0x34f800 0x34f7f4 - stub > fixme:atl:AtlModuleInit SEMI-STUB (0x40eb40 0x40c040 0x400000) > wineserver crashed, please enable coredumps (ulimit -c unlimited) and restart. I just ran into that myself. ALVIN!!!!!!!!! But it doesn't seem easy to repeat; I keep getting other errors now. Roy next to me says he ran into another regression, he's doing a bisect, maybe it's the same thing. He should be done shortly. - Dan

3 3

Early wine history
by Dan Kegel 19 Dec '07

19 Dec '07

winehq.org doesn't seem to have a link to the message that launched the wine project, so I went looking. The first message I found contemplating it was dated 1 Jun 1993, http://groups.google.com/group/comp.os.linux/msg/0a7c3867abdb4a76 Is that about the right estimate for Wine's birthday? A roughly 1995 writeup about Wine is at http://www.softlookup.com/tutorial/redhat/rhl58.asp It has a screen shot of a game Pipe Dream running under Wine. I just checked; the game is still online at http://members.chello.at/theodor.lauppert/games/pipe1.htm and runs well on today's wine :-)

4 3

Re: [msiexec] A nicer icon
by Alexandre Julliard 19 Dec '07

19 Dec '07

Hervÿffffe9 Chanal <chanal_herve(a)yahoo.fr> writes: > Hello, > > It's a larger nicer icon for msiexec with the svg source. Having icons in .svg format is a nice improvement, but we'll need a tool to build the .ico from the .svg. We also need to include multiple sizes in the .ico, most places want a 32x32 icon, and scaling down the 48x48 looks bad. Of course we should also look into taking advantage of the larger size where that's possible without breaking compatibility. -- Alexandre Julliard julliard(a)winehq.org

2 1

Piddly little erratic valgrind warning in ole32_moniker
by Dan Kegel 19 Dec '07

19 Dec '07

Nothing really new yesterday or today. This one's annoying: http://kegel.com/wine/valgrind/logs-2007-12-19/vg-ole32_moniker-diff.txt + Syscall param write(buf) points to uninitialised byte(s) + at (within /lib/ld-2.5.so) + by WriteFile (file.c:512) + by RPCSS_BecomePipeServer (np_server.c:379) + by main (rpcss_main.c:101) because it keeps looking like it's new every other day $ grep RPCSS_BecomePipeServer logs-*/vg-ole32_mon*diff.txt logs-2007-12-06/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-06/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-06/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-06/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-07/vg-ole32_moniker-diff.txt: fun:RPCSS_BecomePipeServer logs-2007-12-08/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-08/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-08/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-08/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-10/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-10/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-10/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-10/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-12/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-12/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-12/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-12/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-13/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-13/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-14/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-14/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-17/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-17/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-17/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-17/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer logs-2007-12-18/vg-ole32_moniker-diff.txt:- by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-18/vg-ole32_moniker-diff.txt:- fun:RPCSS_BecomePipeServer logs-2007-12-19/vg-ole32_moniker-diff.txt:+ by RPCSS_BecomePipeServer (np_server.c:379) logs-2007-12-19/vg-ole32_moniker-diff.txt:+ fun:RPCSS_BecomePipeServer

1 0

Re: Patch for process title on FreeBSD
by Alexandre Julliard 19 Dec '07

19 Dec '07

Kris Moore <kris(a)pcbsd.com> writes: > --- dlls/kernel32/process.c.orig 2007-12-12 12:34:45.000000000 -0500 > +++ dlls/kernel32/process.c 2007-12-12 12:35:17.000000000 -0500 > @@ -853,6 +853,11 @@ > */ > static void set_process_name( int argc, char *argv[] ) > { > + > +#if defined(__FreeBSD__) > + setproctitle("-%s", argv[1]); > +#endif You should add a configure check for this function, instead of checking for __FreeBSD__. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH 2/3] qmgr: AddRef, QueryInterface, and stub functions for queue manager interface.
by Alexandre Julliard 19 Dec '07

19 Dec '07

Roy Shea <roy(a)cs.hmc.edu> writes: > +static ULONG WINAPI BITS_IBackgroundCopyManager_AddRef( > + IBackgroundCopyManager* iface) > +{ > + ICOM_THIS_MULTI(BackgroundCopyManagerImpl, lpVtbl, iface); There's no reason to use ICOM_THIS_MULTI with a single vtbl. > + if (This == NULL) > + { > + return E_POINTER; > + } Checking This for NULL is a waste of time. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: [PATCH] Implement BindIoCompletionCallback
by Rolf Kalbermatter 19 Dec '07

19 Dec '07

Andrey Turkin wrote: >diff --git a/dlls/kernel32/tests/sync.c b/dlls/kernel32/tests/sync.c >index e402fed..7bbb3e2 100644 >--- a/dlls/kernel32/tests/sync.c >+++ b/dlls/kernel32/tests/sync.c >@@ -327,7 +327,7 @@ static void test_iocp_callback(void) > retb = p_BindIoCompletionCallback(hFile, iocp_callback, 0); > ok(retb == FALSE, "BindIoCompletionCallback succeeded on a file that wasn't created with FILE_FLAG_OVERLAPPED\n"); > if(retb == FALSE && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) { >- todo_wine ok (0, "BindIoCompletionCallback returned ERROR_CALL_NOT_IMPLEMENTED\n"); >+ ok (0, "BindIoCompletionCallback returned ERROR_CALL_NOT_IMPLEMENTED\n"); > return; > } I don't think this check makes much sense after the change anymore. It's at best a skip() for older Windows versions. Rolf Kalbermatter

1 0