December 2007 - Wine-devel - list.winehq.org

Re: msi [2/2]: Sort each table of the join separately
by James Hawkins 18 Dec '07

18 Dec '07

On Dec 17, 2007 7:35 PM, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > This is another fix for the National Instruments LabView mega-installer. > > Changelog: > * Sort each table of the join separately. > Oops, ignore this patch (first one can go in). I forgot to add the freeing code for the order. I'll have to resend it tomorrow. -- James Hawkins

1 0

New valgrind regressions in riched20, rpcrt4
by Dan Kegel 17 Dec '07

17 Dec '07

http://kegel.com/wine/valgrind/logs-2007-12-17-summary.txt shows interesting things happened since Friday in riched20. See http://kegel.com/wine/valgrind/logs-2007-12-17/vg-riched20_editor-diff.txt for a whole heap of new errors. The only change since Friday was Maarten's, http://www.winehq.org/pipermail/wine-cvs/2007-December/038829.html, which seems somewhat unrelated, maybe he's getting slagged unfairly here. (But it would still be nice if he could have a look.) There's also the somewhat questionable new warning + Source and destination overlap in memcpy(0x7F00F844, 0x7F00F844, 22) in http://kegel.com/wine/valgrind/logs-2007-12-17/vg-rpcrt4_ndr_marshall-diff.… which would be Rob's if it turns out to be a real problem. - Dan

2 1

[Fwd: Re: New bugzilla components.]
by James McKenzie 17 Dec '07

17 Dec '07

-------- Original Message -------- Subject: Re: New bugzilla components. Date: Sun, 16 Dec 2007 18:52:40 -0700 From: James McKenzie <jjmckenzie51(a)sprintpcs.com> To: Dmitry Timoshkov <dmitry(a)codeweavers.com> References: <47640A28.7080701(a)kievinfo.com> <004f01c83f9a$cae2e500$a600fea9(a)DMITRY> <22821af30712152034t1ee5318ai38eba71df919d38f(a)mail.gmail.com> <200712160933.09187.kai.blin(a)gmail.com> <001101c83fcc$2b6cd490$a600fea9(a)DMITRY> Dmitry Timoshkov wrote: > > Users are not supposed to set a category the bug belongs to, this requires > an investigation and knowledge of a developer. Personally I'd prefer to have > "default" in the list instead of "wine-misc". > > Better choice: Unknown or intial report. This will allow a user to file a bug without having to get technical. This also allows bug triage and for the appropriate developer or development team to be notified of a new bug. As to listing each and every dll, that would be a mess. Keep it to components and parts and use keywords if necessary to identify offending dlls. James McKenzie

3 3

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW
by devzero＠web.de 17 Dec '07

17 Dec '07

mhhh - since it cost me more then one hour to find out why my machine reboots and triggering a reboot by just _reading_ a file on my system, device node or not is at least very weird behaviour from a user`s perspective. >waiting for an user-space daemon to start handling of /dev/watchdog file (opening it and manipulating it from time to time to show that it's still alive. >When you cat the file, kernel recognizes it as that such an app is taking over control of the watchdog and starts it. it`s looks a little bit too simple for me. triggering a reboot just by some simple open() and read() and close() ? let`s wait what the maintainer has to tell. regards roland > Hi! > I think it's not a bug, it's a normal behaviour. > The kernel watchdog is normally not active when the machine is booted, > waiting for an user-space daemon to start handling of /dev/watchdog file > (opening it and manipulating it from time to time to show that it's still > alive). When you cat the file, kernel recognizes it as that such an app > is taking over control of the watchdog and starts it. However, because > cat closes the file immediately, it is not handled anymore and kernel > recognizes it as a userspace problem, thus rebooting the machine after > the timeout expires. > With regards, Pavel Troller > > -----Ursprüngliche Nachricht----- > Von: Pavel Troller <patrol(a)sinus.cz> > Gesendet: 20.11.07 08:49:53 > An: devzero(a)web.de > CC: Hans Leidekker <hans(a)it.vu.nl>, wine-devel(a)winehq.org > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > > i`ve tracked this down to a watchdog issue. > > > > whenever i do "cat /dev/watchdog" - my system reboots after ~1 minute. > > > > i`ve contacted the maintainer of the watchdog subsystem. > > > > looks like a bug to me. > > > > thanks > > roland > > > Hi! > I think it's not a bug, it's a normal behaviour. > The kernel watchdog is normally not active when the machine is booted, > waiting for an user-space daemon to start handling of /dev/watchdog file > (opening it and manipulating it from time to time to show that it's still > alive). When you cat the file, kernel recognizes it as that such an app > is taking over control of the watchdog and starts it. However, because > cat closes the file immediately, it is not handled anymore and kernel > recognizes it as a userspace problem, thus rebooting the machine after > the timeout expires. > With regards, Pavel Troller > ______________________________________________________________________________ Jetzt neu! Im riesigen WEB.DE Club SmartDrive Dateien freigeben und mit Freunden teilen! http://www.freemail.web.de/club/smartdrive_ttc.htm/?mc=021134

3 2

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW
by devzero＠web.de 17 Dec '07

17 Dec '07

> Yes, Wine shouldn't be able to do that. You're not running Wine > as root are you? whoops - i did. shame on me :) i retried with ordinary account and the crash didn`t happen there. anyway - should i expect such problems with root ? >Does your system log reveal anything about the crash? no, unfortunately not regards roland > -----Ursprüngliche Nachricht----- > Von: "Hans Leidekker" <hans(a)it.vu.nl> > Gesendet: 19.11.07 21:22:20 > An: "http://freemail.web.de/" <devzero(a)web.de> > Betreff: Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW > > On Monday 19 November 2007 20:59:46 devzero(a)web.de wrote: > > > when scannnig trough drive z:\ , my notebook reboots ! > > wasn`t wine a userspace application with no kernel related stuff ? > > so it`s weird, that windirstat is crashing my notebook, isn`t it ? > > Yes, Wine shouldn't be able to do that. You're not running Wine > as root are you? Does your system log reveal anything about the crash? > > -Hans > ______________________________________________________________________ XXL-Speicher, PC-Virenschutz, Spartarife & mehr: Nur im WEB.DE Club! Jetzt testen! http://produkte.web.de/club/?mc=021130

3 2

Re: WineX11.drv: create X11 window for client area 1/3
by Alexandre Julliard 17 Dec '07

17 Dec '07

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > + { > + escape.drawable = X11DRV_get_client_window( top ); > + if(!escape.drawable) > + escape.drawable = X11DRV_get_whole_window( top ); You shouldn't need that test, all windows should have a client window; otherwise you have to tell the server about it too. > +static Window create_client_window( Display *display, struct x11drv_win_data *data) > +{ > + RECT rect = data->whole_rect; > + XSetWindowAttributes attr; > + > + OffsetRect( &rect, -data->whole_rect.left, -data->whole_rect.top ); > + data->client_rect = rect; > + > + attr.event_mask = ExposureMask; > + attr.bit_gravity = ForgetGravity; ForgetGravity is wasteful, you should use NorthWestGravity and compute the proper valid rects in SetWindowPos. ForgetGravity may be appropriate for the non-client area though. > @@ -1582,6 +1646,7 @@ void X11DRV_SetParent( HWND hwnd, HWND parent, HWND old_parent ) > { > /* FIXME: we ignore errors since we can't really recover anyway */ > create_whole_window( display, data, GetWindowLongW( hwnd, GWL_STYLE ) ); > + create_client_window( display, data ); You need to destroy the client window in SetParent too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: RESUBMIT [PATCH] enumerate processes in reverse
by Alexandre Julliard 17 Dec '07

17 Dec '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > A game does: > Process32First(); > while (Process32First()) { > /* look for stuff */ > } > completely missing the first process. Unfortunately it > is looking for its own child, which gets missed. > > -> reverse enumerate processes > > Also with testcase. > > (I mailed this 4 weeks ago already, any comments?) Are you sure the order is supposed to be reversed between kernel32 and ntdll? That feels a bit strange. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] qmgr: Stub functions for queue manager interface.
by Alexandre Julliard 17 Dec '07

17 Dec '07

Roy Shea <roy(a)cs.hmc.edu> writes: > --- > dlls/qmgr/Makefile.in | 1 + > dlls/qmgr/qmgr.c | 103 +++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/qmgr/qmgr.h | 38 ++++++++++++++++++ > 3 files changed, 142 insertions(+), 0 deletions(-) Sending small patches is good, but they still need to do something useful. So for a stub interface you should at least implement AddRef and Release, and a way to create an instance. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/5] wined3d: create IWineD3DDeviceImpl_ClearSurface routine
by Stefan Dösinger 17 Dec '07

17 Dec '07

Am Montag, 17. Dezember 2007 04:56:14 schrieb Alexander Dorofeyev: > --- > dlls/wined3d/device.c | 162 > ++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d_private.h | > 3 + > 2 files changed, 165 insertions(+), 0 deletions(-) This patch, and 4 and 5 look good to me content wise, but patch 3 doesn't make much sense without either 4 or 5. It's up to AJ to decide, but you could propably combine patches 3 and 4(and keep 5 separate).

2 1

ENTER_GL and ActivateContext question
by Alexander Dorofeyev 17 Dec '07

17 Dec '07

Hello. I was recently experimenting with a fix that involved ActivateContext and needed to figure out whether it is ok if ActivateContext is called inside ENTER_GL()... LEAVE_GL() (also if recursive ENTER_GL is ok). At first I tried to look for example code in wined3d/surface.c, which seemed to indicate this is ok, because it obviously seems to happen in one or few places. Then I found this http://bugs.winehq.org/show_bug.cgi?id=9810 from which it seems it is sort of a bug(?). Can any of 3d guys here clarify this matter - how bad is ActivateContext between ENTER_GL/LEAVE_GL and recursive ENTER_GL, does it definitely need to be avoided and should things like this ENTER_GL(); ... IWineD3DSurface_BindTexture(); ... LEAVE_GL(); (BindTexture does ActivateContext and ENTER_GL) be changed to something like ENTER_GL() ... LEAVE_GL() IWineD3DSurface_BindTexture(); ENTER_GL() ... LEAVE_GL() and submitted as patch if I find it?

6 13