December 2007 - Wine-devel - list.winehq.org

Re: imagehlp: improve last error handling in ImageGetCertificateData
by Juan Lang 12 Dec '07

12 Dec '07

Hi Aric, - if( !Certificate ) + if( *RequiredLength < size ) { *RequiredLength = size; - return TRUE; + SetLastError( ERROR_INSUFFICIENT_BUFFER ); + return FALSE; } - if( *RequiredLength < size ) + if( !Certificate ) { *RequiredLength = size; - SetLastError( ERROR_INSUFFICIENT_BUFFER ); - return FALSE; + return TRUE; } Are you sure this is the order that *RequiredLength and Certificate are checked in? Seems backwards to the normal style to me. I won't bug you for a proper regression test, as I failed to produce one too :) --Juan

2 3

wine proccess list
by Kris Moore 11 Dec '07

11 Dec '07

Gonzalo sent me this thread, and I may be able to get a patch put together here soon. First, I wanted to make sure I'm on the right path: Can somebody confirm for me that this is the right location where I should be trying to fix this? http://source.winehq.org/source/loader/preloader.c#L1006 FreeBSD has a function called setproctitle(), which I'm pretty sure is the right one for this task. http://www.freebsd.org/cgi/man.cgi?query=setproctitle&apropos=0&sektion=0&m… I'll probably try and see about a patch here in the next day or so. Who do I send it to if I can get it working? -- Kris Moore PC-BSD Software http://www.pcbsd.com Am Dienstag, 11. Dezember 2007 20:25:20 schrieb Gonzalo Martinez - Sanjuan Sanchez: > El Tuesday 11 December 2007 7:34:49 pm escribió: > > Am Dienstag, 11. Dezember 2007 18:02:53 schrieb Gonzalo Martinez - > > Sanjuan > > > > Sanchez: > > > Hello to all. > > > > > > I have something in mind that I would like to ask to Wine developers. > > > Is it possible using a hack/trick or a hidden option to change the > > > name of wine in the proccess lists? > > > I mean, Is it possible to list 'wine' proccess as, for example > > > 'iexplorer' when I use Internet Explorer under Wine? > > > > > > Thanks a lot for your work, hope my question find the answer here. > > > > This is done since quite some time. apps are usually called > > "iexplore.exe", or they have the name of the file that was passed to > > wine, like C:\Program Files\Internet Explorer\iexplore.exe > > > > If you still see "wine", "wineloader" or something similar you have a > > very outdated version of wine. > > Well, im talking about Wine 0.9.48 under FreeBSD/PC-BSD OS. Ow, ah, this is a different business. I think we use some Linux-only feature to set the name, and Alexandre told me that at least MacOS doesn't have it. I have no idea if there is a way to change the process name under BSD. If there is, feel free to implement it and send a patch

3 2

Re: wintrust: implementations for WTHelperGetFileName and WTHelperGetFIleHandle
by Jacek Caban 11 Dec '07

11 Dec '07

Hi Aric, Aric Stewart wrote: > + else > + return (HANDLE)0xffffffff; That's what is INVALID_HANDLE_VALUE for. Jacek

1 0

Monday's valgrind results: no new errors
by Dan Kegel 11 Dec '07

11 Dec '07

http://kegel.com/wine/valgrind/logs-2007-12-10-summary.txt seems to show lots of valgrind regressions in mshtml, but http://kegel.com/wine/valgrind/logs-2007-12-10/vg-mshtml_dom-diff.txt shows the difference is that I happen to have installed Gecko. So they aren't really regressions (or if there are any, they're buried in the noise), and today's git is probably about as Valgrind-clean as Saturday's. - Dan

2 3

Re: winspool: implement EnumFormsA/W for form level 1, add a few builtinforms
by Dmitry Timoshkov 11 Dec '07

11 Dec '07

"Marcel Partap" <mpartap(a)gmx.net> wrote: > +static const struct builtin_form builtin_forms[] = { > + {{'L','e','t','t','e','r',0}, {{216000,279000}, {0,0,216000,279000}, 0, FORM_BUILTIN}}, > + {{'A','3',0}, {{297000,420000}, {0,0,297000,420000}, 0, FORM_BUILTIN}}, > + {{'A','4',0}, {{210000,297000}, {0,0,210000,297000}, 0, FORM_BUILTIN}}, > + {{'A','5',0}, {{148000,210000}, {0,0,148000,210000}, 0, FORM_BUILTIN}} }; I guess this info should be fetched from the printer, not hard coded. -- Dmitry.

2 1

Re: ntdll: Initialize APC call and result variables to suppress valgrind warnings
by Alexandre Julliard 11 Dec '07

11 Dec '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Alexandre said that it's OK to use memset for server requests because of > backwards compatibility. It's OK for requests, but why do you want to initialize the result structure too? -- Alexandre Julliard julliard(a)winehq.org

2 2

Wine Weekly News
by Kai Blin 11 Dec '07

11 Dec '07

Hi Zach, thanks for getting a new WWN issue out there. Finally there's more than one release after the other. I think WWN is a really valuable ressource for our users. Also, I hope it'll be a platform to get some GSoC exposure on the front page, especially without me having to take care of it. ;) Thanks, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

12 19

Re: kernel32: cpu: Detect AMD 64bit CPUs
by Alexandre Julliard 11 Dec '07

11 Dec '07

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > kernel32: cpu: Detect AMD 64bit CPUs Are you really supposed to return a 64bit CPU in 32-bit mode? Do you have a test case? -- Alexandre Julliard julliard(a)winehq.org

3 2

Work legalities
by Nathan Williams 11 Dec '07

11 Dec '07

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

Re: winex11drv: Treat CapsLock and NumLock keys as normal keys. They should toggle on button down.
by Alexandre Julliard 11 Dec '07

11 Dec '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > On winxp both keys toggle on button down not button up. So no need for any extra treatment. > Fixes bug 10446. You still have to handle the case when the state has been toggled outside of Wine, you can't just get rid of the whole thing. -- Alexandre Julliard julliard(a)winehq.org

2 2