December 2007 - Wine-devel - list.winehq.org

Re: [PATCH] use a better size to lstrcpynW
by Alexandre Julliard 14 Dec '07

14 Dec '07

Marcus Meissner <meissner(a)suse.de> writes: > - lstrcpynW( num, begin + 1, end - begin ); > - begin += end - begin + 1; > + > + xcnt = end - begin; > + if (xcnt > sizeof(num)/sizeof(WCHAR)) > + xcnt = sizeof(num)/sizeof(WCHAR); > + lstrcpynW( num, begin + 1, xcnt ); > + begin += xcnt + 1; Truncating the string is not a correct fix. Overflow should either be treated as an error, or a buffer should be allocated dynamically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Create a 'take bug' option in bugzilla?
by Maarten Lankhorst 14 Dec '07

14 Dec '07

Hi all, I'm getting tired of having to do 3 changes to take a bug. First I have to set the status to 'assigned', this makes the bug assigned to wine-bugs. Now that it is assigned, I can set the assignee to my own email address, that automatically changes the status to 'new', and I have to set the status to 'assigned' again. Is it at least possible that an option 'assign to me' shows up and works for people with sufficient bugzilla access? -Maarten

1 0

Re: [PATCH 3/4] quartz: make test_aggregation non-static
by Alexandre Julliard 14 Dec '07

14 Dec '07

"Lei Zhang" <thestig(a)google.com> writes: > Hi, > > This lets us call test_aggregation() from other files. In general it's better to avoid sharing functions across tests, it makes it hard to grab a single test and quickly build it on Windows. In this case you could test all the interfaces in the same file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: style changes can change a managed window to unmanaged
by Alexandre Julliard 14 Dec '07

14 Dec '07

Ken Thomases <ken(a)codeweavers.com> writes: > This fixes an issue with Internet Explorer's tooltips. On the Mac, at least, > they steal focus from the main window, disrupting user interaction. This won't work with many window managers; the only way would be to destroy the window and create a brand new one, but that's fairly tricky to get right. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GDI32: GetSystemPaletteEntries should fill with default palette in non-palette video mode (with tests)
by Alex Villacís Lasso 13 Dec '07

13 Dec '07

Alex Villacís Lasso escribió: > Patches originally by Alexander Dorofeyev <alexd14(a)hushmail.com>. > > This patch tries to fix bug #201 (igowin shows black squares instead > of proper transparency). It was sent back in October, but there was no > feedback back then. So I am resending a rediff against current git. > > Changelog: > * GetSystemPaletteEntries() should fill entries with default 20-color > system palette when called in a non-palette video mode. > * Tests for above behavior. > > ------------------------------------------------------------------------ > > Any feedback on this patch? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 0

Re: Alexandre Julliard : hhctrl.ocx: Store a copy of the string pointers to enable freeing them without casting away const .
by Robert Shearman 13 Dec '07

13 Dec '07

Alexandre Julliard wrote: > hhctrl.ocx: Store a copy of the string pointers to enable freeing them without casting away const. I've noticed that there is a trend of doing more and more of this type of fix. Is it really worth the performance penalty of doing this instead of adding in an appropriate macro or just not turning on the warning? -- Rob Shearman

2 1

Re: urlmon #1: Fixed handling MIME type in Binding object.
by Alexandre Julliard 13 Dec '07

13 Dec '07

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/urlmon/binding.c | 97 > +++++++++++++++++++++++++++++++++++--------- This breaks the tests for me: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so htmldoc.c && touch htmldoc.ok htmldoc.c:3069: Test failed: unexpected fontname "(null)" htmldoc.c:3069: Test failed: unexpected fontname "Arial" htmldoc.c:3069: Test failed: unexpected fontname "(null)" htmldoc.c:3948: Test failed: (60) cmdf=00000003, expected 00000007 htmldoc.c:3956: Test failed: (57) cmdf=00000003, expected 00000007 make: *** [htmldoc.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shlwapi:ordinal:Add comment to a function. [resend]
by Alexandre Julliard 13 Dec '07

13 Dec '07

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Add comment to a function SHCreateShellPalette(). There's no point in resending doc patches that have clearly been written by looking at the MSDN docs, they won't be applied. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntoskrnl.exe: DPRINTF -> TRACE.
by Robert Shearman 13 Dec '07

13 Dec '07

Andrew Riedi wrote: > - if (TRACE_ON(relay)) > - DPRINTF( "%04x:Call driver dispatch %p (device=%p,irp=%p)\n", > - GetCurrentThreadId(), dispatch, device, &irp ); > + TRACE_(relay)( "%04x:Call driver dispatch %p (device=%p,irp=%p)\n", > + GetCurrentThreadId(), dispatch, device, &irp ); Please don't change relay traces to use TRACE. This channel has specific requirements and so doesn't benefit from using TRACE instead of DPRINTF. -- Rob Shearman

1 0

Re: user32: DPRINTF -> TRACE.
by Alexandre Julliard 13 Dec '07

13 Dec '07

"Andrew Riedi" <andrewriedi(a)gmail.com> writes: > LRESULT ret; > > - if (TRACE_ON(relay)) > - DPRINTF( "%04x:Call hook proc %p (id=%s,code=%x,wp=%08lx,lp=%08lx)\n", > - GetCurrentThreadId(), proc, hook_names[id-WH_MINHOOK], code, wparam, lparam ); > + TRACE_(relay)( "%04x:Call hook proc %p (id=%s,code=%x,wp=%08lx,lp=%08lx)\n", > + GetCurrentThreadId(), proc, hook_names[id-WH_MINHOOK], code, > + wparam, lparam ); Relay traces are different, they must not use TRACE. -- Alexandre Julliard julliard(a)winehq.org

1 0