December 2007 - Wine-devel - list.winehq.org

Re: [5/5] gdi: Test bitmap depths
by Jesse Allen 15 Dec '07

15 Dec '07

This is good since 15-bpp DIB is not supported in my DIB engine. As it is right now, the 15-bit DIB stuff in winex11/gdi is not really correct (even if it might work). On Dec 11, 2007 1:31 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > > > >

3 4

Re: [PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)
by Vitaliy Margolen 15 Dec '07

15 Dec '07

First of all your patch is wrapped. Second, do not send white space changes only. Same for formatting - do not change formatting only. If you can't read it, reformat for yourself, or get used to reading some one else's code. What's wrong with gotos? If you don't like it doesn't mean everyone else can't use them. Don't change that part. Copying 10 lines of code into 10 places doesn't justify removing 10 lines of code. You should probably check the patch requirements: http://winehq.org/site/sending_patches Vitaliy. Adam Rimon wrote: > --- > > dlls/dinput/mouse.c | 415 > +++++++++++++++++++++++++++++---------------------- > 1 files changed, 235 insertions(+), 180 deletions(-) >

4 5

re: winex11.drv:clipboard.c: Adds zero to the end of string.
by Dan Kegel 15 Dec '07

15 Dec '07

Anatoly wrote: > We do it to make sure that the strings will terminate by zero. What bug does this fix? Can you add a conformance test? - Dan

1 0

Tracking down missing controls (drawn)
by Alistair Leslie-Hughes 14 Dec '07

14 Dec '07

Hi, I've manage to get MS Money 2008 loading there sample file, (with some help from Juan). The next issue is trying to get the information to display correctly. The first image is the one currently running in WINE, and the second is within WinXP http://members.dodo.com.au/~lesliehughes/MS_Money2008.png http://members.dodo.com.au/~lesliehughes/Msmoney2008real.PNG As you can see the control at the bottom doesnt display as it should. Where can I start to look to workout how to get this control(s) to display correctly? Best Regards Alistair Leslie-Hughes

2 2

Re: msi: Fix an off-by-one error
by James Hawkins 14 Dec '07

14 Dec '07

On Dec 14, 2007 3:18 PM, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > Changelog: > * Fix an off-by-one error. > Please ignore this patch. This whole function needs to be rewritten. -- James Hawkins

1 0

msi valgrind regression around Dec 4th
by Dan Kegel 14 Dec '07

14 Dec '07

This error Conditional jump or move depends on uninitialised value(s) at ACTION_AppSearchSigName (appsearch.c:435) by ITERATE_CCPSearch (appsearch.c:916) by MSI_IterateRecords (msiquery.c:190) by ACTION_CCPSearch (appsearch.c:943) by ACTION_HandleStandardAction (action.c:974) by ACTION_PerformUIAction (action.c:1042) by MsiDoActionW (install.c:108) by MsiDoActionA (install.c:56) by test_ccpsearch (package.c:4954) by func_package (package.c:5384) by run_test (test.h:387) by main (test.h:436) appeared between Nov 30 and Dec 4, and is still present in today's, http://kegel.com/wine/valgrind/logs-2007-12-14/vg-msi_package.txt I pinged James about it and a few others on Dec 5th; he seems to have fixed the others, but this one remains. - Dan

2 1

docu - broken links
by Rico Schüller 14 Dec '07

14 Dec '07

Hi, while I was looking in the docu (html) I found some links that are broken. In some cases these are typos, in other I don't know. Here is a list width broken links, I've found. I would like to fix this. But I don't know which one are typos and which one are broken because the function which is referred to isn't documented. This is e.g. a typo I think: file ChosseFontW.html in ChooseFontA.html not found. *** ChosseFontW.html -> ChooseFontW.html Could someone with more knowledge take a look at this list and say which one are typos? Regards Rico file ICreateTypeInfo_AddRefTypeInfo.html in ICreateTypeInfo2_AddRefTypeInfo.html not found. file SHGetFileInfoW.html in SHGetFileInfoWrapW.html not found. file ITypeLib_GetTypeInfoType.html in ITypeLib2_GetTypeInfoType.html not found. file EnumCalendarInfoAW.html in EnumCalendarInfoA.html not found. file _findnext.html in MSVCRT__findnexti64.html not found. file SetCurrentDirectoryA.html in _chdrive.html not found. file CreateDirectoryA.html in MSVCRT__mkdir.html not found. file ITypeInfo_GetVarDesc.html in ITypeInfo2_GetVarDesc.html not found. file ShellExecuteExW.html in ShellExecuteExWrapW.html not found. file SHBrowseForFolderW.html in SHBrowseForFolderWrapW.html not found. file IUnknown_AddRef.html in IQueryAssociations_AddRef.html not found. file GetColorDirectoryW.html in GetColorDirectoryA.html not found. file IUnknown_QueryInterface.html in ITypeInfo2_QueryInterface.html not found. file ICreateTypeLib_SetName.html in ICreateTypeLib2_SetName.html not found. file ICreateTypeLib_SaveAllChanges.html in ICreateTypeLib2_SaveAllChanges.html not found. file EnumCalendarInfoAW.html in EnumCalendarInfoW.html not found. file IUnknown_Release.html in IQueryAssociations_Release.html not found. file UserUnInstStubWrapperW.html in UserUnInstStubWrapperA.html not found. file IUnknown_AddRef.html in ICreateTypeInfo2_AddRef.html not found. file SHLWAPI_183.html in SHRegisterClassW.html not found. file ICreateTypeLib_SetGuid.html in ICreateTypeLib2_SetGuid.html not found. file ITypeLib_GetTypeInfo.html in ITypeLib2_GetTypeInfo.html not found. file FindNextFileA.html in MSVCRT__findnext.html not found. file ICreateTypeInfo_SetVersion.html in ICreateTypeInfo2_SetVersion.html not found. file SysAllocStringByteLen16.html in SysReAllocStringLen16.html not found. file EnumCalendarInfoAW.html in EnumCalendarInfoExW.html not found. file ICreateTypeLib_SetLibFlags.html in ICreateTypeLib2_SetLibFlags.html not found. file ICreateTypeInfo_SetFuncAndParamNames.html in ICreateTypeInfo2_SetFuncAndParamNames.html not found. file GetFileVersionInfoW.html in GetFileVersionInfoWrapW.html not found. file ICreateTypeInfo_SetSchema.html in ICreateTypeInfo2_SetSchema.html not found. file IUnknown_AddRef.html in UlAddRef.html not found. file _rmdir.html in _wrmdir.html not found. file IUnknown_QueryInterface.html in ITypeLib2_QueryInterface.html not found. file NtDeleteKey.html in RtlpNtMakeTemporaryKey.html not found. file ICreateTypeInfo_SetGuid.html in ICreateTypeInfo2_SetGuid.html not found. file _findfirst.html in MSVCRT__findfirsti64.html not found. file _chdir.html in _wchdir.html not found. file CreatMailslotW.html in CreateMailslotA.html not found. file ICreateTypeInfo_AddImplType.html in ICreateTypeInfo2_AddImplType.html not found. file DragQueryFileW.html in DragQueryFileWrapW.html not found. file ITypeInfo_GetMops.html in ITypeInfo2_GetMops.html not found. file SSHAnsiToAnsi.html in SHUnicodeToUnicode.html not found. file ITypeLib_IsName.html in ITypeLib2_IsName.html not found. file ICreateTypeLib_SetHelpFileName.html in ICreateTypeLib2_SetHelpFileName.html not found. file IUnknown_QueryInterface.html in IQueryAssociations_QueryInterface.html not found. file RemoveDirectoryA.html in MSVCRT__rmdir.html not found. file IUnknown_QueryInterface.html in IDispatch_QueryInterface.html not found. file IUnknown_Release.html in ITypeInfo2_Release.html not found. file SetCurrentDirectoryA.html in MSVCRT__chdir.html not found. file AddPrinterDriverExW.html in AddPrinterDriverExA.html not found. file ITypeInfo_ReleaseVarDesc.html in ITypeInfo2_ReleaseVarDesc.html not found. file SHFileOperationW.html in SHFileOperationWrapW.html not found. file ExtractIconW.html in ExtractIconWrapW.html not found. file NtOpenProcessToken.html in OpenProcessToken.html not found. file ICreateTypeInfo_SetVarDocString.html in ICreateTypeInfo2_SetVarDocString.html not found. file ICreateTypeInfo_SetImplTypeFlags.html in ICreateTypeInfo2_SetImplTypeFlags.html not found. file FileSaveRestoreOnINFW.html in FileSaveRestoreOnINFA.html not found. file _findnext.html in MSVCRT__wfindnext.html not found. file BitBlt16.html in WinGBitBlt16.html not found. file IUnknown_QueryInterface.html in ICreateTypeLib2_QueryInterface.html not found. file _mkdir.html in _wmkdir.html not found. file PlaySoundW.html in PlaySoundWrapW.html not found. file ITypeInfo_GetTypeComp.html in ITypeInfo2_GetTypeComp.html not found. file IUnknown_Release.html in UlRelease.html not found. file ICreateTypeInfo_SetMops.html in ICreateTypeInfo2_SetMops.html not found. file ITypeInfo_GetDocumentation.html in ITypeInfo2_GetDocumentation.html not found. file ICreateTypeInfo_SetFuncDocString.html in ICreateTypeInfo2_SetFuncDocString.html not found. file WNetRestoreConnectionW.html in WNetRestoreConnectionWrapW.html not found. file ITypeInfo_GetTypeAttr.html in ITypeInfo2_GetTypeAttr.html not found. file GetFileVersionInfoSizeW.html in GetFileVersionInfoSizeWrapW.html not found. file FindFirstFileA.html in MSVCRT__findfirst.html not found. file ICreateTypeInfo_SetAlignment.html in ICreateTypeInfo2_SetAlignment.html not found. file NtCreateKey.html in RtlpNtCreateKey.html not found. file ICreateTypeInfo_SetDocString.html in ICreateTypeInfo2_SetDocString.html not found. file ICreateTypeLib_SetLcid.html in ICreateTypeLib2_SetLcid.html not found. file IUnknown_Release.html in IDispatch_Release.html not found. file SysAllocStringByteLen16.html in SysAllocStringLen16.html not found. file ICreateTypeLib_SetVersion.html in ICreateTypeLib2_SetVersion.html not found. file _findfirst.html in MSVCRT__wfindfirst.html not found. file EnumCalendarInfoAW.html in EnumCalendarInfoExA.html not found. file IUnknown_Release.html in ITypeLib2_Release.html not found. file NtOpenKey.html in RtlpNtOpenKey.html not found. file ITypeInfo_GetIDsOfNames.html in ITypeInfo2_GetIDsOfNames.html not found. file SHDefExtractIconW.html in SHDefExtractIconWrapW.html not found. file ITypeInfo_GetRefTypeInfo.html in ITypeInfo2_GetRefTypeInfo.html not found. file NtOpenThreadToken.html in OpenThreadToken.html not found. file ldap_memfreeW.html in ldap_memfreeA.html not found. file ITypeInfo_GetRefTypeOfImplType.html in ITypeInfo2_GetRefTypeOfImplType.html not found. file EnableScrollBar.html in FlatSB_EnableScrollBar.html not found. file ICreateTypeInfo_SetTypeFlags.html in ICreateTypeInfo2_SetTypeFlags.html not found. file ICreateTypeLib_SetHelpContext.html in ICreateTypeLib2_SetHelpContext.html not found. file NtAdjustPrivilegesToken.html in AdjustTokenPrivileges.html not found. file AddPrinterDriverW.html in AddPrinterDriverA.html not found. file IUnknown_AddRef.html in ICreateTypeLib2_AddRef.html not found. file _findnexti64.html in MSVCRT__wfindnexti64.html not found. file ITypeLib_GetTypeInfoOfGuid.html in ITypeLib2_GetTypeInfoOfGuid.html not found. file ITypeInfo_ReleaseTypeAttr.html in ITypeInfo2_ReleaseTypeAttr.html not found. file ICreateTypeInfo_SetVarName.html in ICreateTypeInfo2_SetVarName.html not found. file ITypeLib_GetLibAttr.html in ITypeLib2_GetLibAttr.html not found. file _findfirsti64.html in MSVCRT__wfindfirsti64.html not found. file ChosseFontW.html in ChooseFontA.html not found. file ITypeInfo_GetContainingTypeLib.html in ITypeInfo2_GetContainingTypeLib.html not found. file IUnknown_AddRef.html in IDispatch_AddRef.html not found. file ITypeInfo_GetImplTypeFlags.html in ITypeInfo2_GetImplTypeFlags.html not found. file NtQueryInformationToken.html in GetTokenInformation.html not found. file CopyEnhMetaFileA.html in CopyEnhMetaFileW.html not found. file WNetGetLastErrorW.html in WNetGetLastErrorWrapW.html not found. file ICreateTypeInfo_SetFuncHelpContext.html in ICreateTypeInfo2_SetFuncHelpContext.html not found. file ICreateTypeInfo_LayOut.html in ICreateTypeInfo2_LayOut.html not found. file FindClose.html in MSVCRT__findclose.html not found. file IUnknown_AddRef.html in ITypeInfo2_AddRef.html not found. file IUnknown_Release.html in ICreateTypeInfo2_Release.html not found. file ICreateTypeInfo_AddVarDesc.html in ICreateTypeInfo2_AddVarDesc.html not found. file IUnknown_Release.html in ICreateTypeLib2_Release.html not found. file ITypeInfo_ReleaseFuncDesc.html in ITypeInfo2_ReleaseFuncDesc.html not found. file ldap_start_tls_sW.html in ldap_start_tls_sA.html not found. file VerQueryValueW.html in VerQueryValueWrapW.html not found. file CreatePropertySheetA.html in CreatePropertySheetPageW.html not found. file StretchBlt16.html in WinGStretchBlt16.html not found. file ICreateTypeLib_CreateTypeInfo.html in ICreateTypeLib2_CreateTypeInfo.html not found. file ITypeInfo_GetNames.html in ITypeInfo2_GetNames.html not found. file ITypeLib_GetTypeComp.html in ITypeLib2_GetTypeComp.html not found. file ICreateTypeInfo_SetTypeDescAlias.html in ICreateTypeInfo2_SetTypeDescAlias.html not found. file IUnknown_QueryInterface.html in ICreateTypeInfo2_QueryInterface.html not found. file ITypeInfo_CreateInstance.html in ITypeInfo2_CreateInstance.html not found. file ITypeInfo_Invoke.html in ITypeInfo2_Invoke.html not found. file ITypeLib_GetTypeInfoCount.html in ITypeLib2_GetTypeInfoCount.html not found. file ITypeLib_FindName.html in ITypeLib2_FindName.html not found. file ICreateTypeInfo_SetHelpContext.html in ICreateTypeInfo2_SetHelpContext.html not found. file ITypeInfo_AddressOfMember.html in ITypeInfo2_AddressOfMember.html not found. file ICreateTypeInfo_AddFuncDesc.html in ICreateTypeInfo2_AddFuncDesc.html not found. file ITypeLib_ReleaseTLibAttr.html in ITypeLib2_ReleaseTLibAttr.html not found. file ICreateTypeInfo_SetTypeIdldesc.html in ICreateTypeInfo2_SetTypeIdldesc.html not found. file ICreateTypeLib_SetDocString.html in ICreateTypeLib2_SetDocString.html not found. file IUnknown_AddRef.html in ITypeLib2_AddRef.html not found. file SHGetNewLinkInfoW.html in SHGetNewLinkInfoWrapW.html not found. file ICreateTypeInfo_SetVarHelpContext.html in ICreateTypeInfo2_SetVarHelpContext.html not found. file ITypeLib_GetDocumentation.html in ITypeLib2_GetDocumentation.html not found. file ITypeInfo_GetFuncDesc.html in ITypeInfo2_GetFuncDesc.html not found.

1 0

Re: user32: add tests for handling exposed regions created by other threads
by Clinton Stimpson 14 Dec '07

14 Dec '07

Anything wrong with this patch? I'm guessing its the Sleep(). Any other way to force X server to put expose events in the queue, if any? This is for bug #9875. Clinton Stimpson

1 0

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and 'type'point to the same address
by Dmitry Timoshkov 14 Dec '07

14 Dec '07

"Sam Dennis" <samuel.howard.dennis(a)gmail.com> wrote: > + size = 4; > + ret = RegQueryValueExA(hkey_main, "BIN32", NULL, &size, buffer, &size); > + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); What this test is supposed to test? -- Dmitry.

2 3

dinput - mouse warping -games that needs it?
by Adam Rimon 14 Dec '07

14 Dec '07

Hi, I'm trying to get rid of the warping patch, or at least to change it to something that won't make the mouse stuck in the middle of the screen in some games (Next Life for instance). Can you give me names of games that need this warping? (I had found in the archives a mention of Quake II, but when I downloaded it's demo and tried to play it with a dinput.dll that doesn't have this warping, everything worked just fine.) Thanks, -Adam

4 3