April 2007 - Wine-devel - list.winehq.org

Setting debug channels in 20040914 version
by Bill Medland 02 Apr '07

02 Apr '07

Can someone remind me how we used to set the debug channels back in late 2004?

4 3

[PATCH] winmm_test.exe fix for CALLBACK_THREAD
by Stéphan Kochen 02 Apr '07

02 Apr '07

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello again, "wine winmm_test.exe wave" reliably locks up for me after calling waveOutOpen() with the CALLBACK_THREAD flag, waiting for a WOM_OPEN message to arrive. Which never happens because I believe the thread doesn't have a message queue. This patch implements the solution mentioned in the "remarks" section of the MSDN page on PostThreadMessage: http://msdn2.microsoft.com/en-us/library/ms644946.aspx Fixed it for me. - -- Stéphan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGERkUcFUq0gzqDwQRAlwCAKD1rVdMXjawPzJOddfU5Oh9hK8cagCgzB2g 6b6JbG23fjGqk+Mj9xvHnF8= =rXu0 -----END PGP SIGNATURE-----

3 2

So long, and thanks for all the Wine!
by Dan Kegel 02 Apr '07

02 Apr '07

Wine was a fine dream, but come on, there's no way a bunch of volunteers could put together an emulator for a real operating system like Windows. Heck, after 14 years, Wine can't even run the average Visual Basic program! So I'm bowing to the inevitable, and have accepted a job with a popular operating system vendor working on fixing something called a "start menu"; I haven't heard the details yet, but it sounds very complex. They say I'll be leading a team of 50. If anyone's interested, please let me know; (I think the new start menu will be implemented in a mix of C# and VBScript for efficiency, so no C programmers need apply.) Cheers, Dan

7 7

Re: [3/3] ddraw: Enumerate explicitly using valid formats
by Stefan Dösinger 02 Apr '07

02 Apr '07

Am Montag 02 April 2007 10:20 schrieb Chris Robinson: > Instead of relying on WINED3DFMT_UNKNOWN to do the "right thing". Fixes a > reported regression in AOE. You can run the modes test in the ddraw testsuite on windows to find the formats windows supports.

1 0

Re: [PATCH 1/8] CMD.exe: Attempt launch even if fails to locate program
by Alexandre Julliard 02 Apr '07

02 Apr '07

Jason Edmeades <us(a)edmeades.me.uk> writes: > + /* Internal programs wont be picked up by this, so try one final > + createprocess and wait for it to complete. > + Note: Ideally we could tell between a console app (wait) and a > + windows app, but the API's for it fail in this case */ > + ZeroMemory (&st, sizeof(STARTUPINFO)); > + st.cb = sizeof(STARTUPINFO); > + init_msvcrt_io_block(&st); > + > + /* Launch the process and assume CUI so wait on it to complete */ > + status = CreateProcess (NULL, command, NULL, NULL, TRUE, > + 0, NULL, NULL, &st, &pe); > + > + if ((opt_c || opt_k) && !opt_s && !status && > + GetLastError()==ERROR_FILE_NOT_FOUND && command[0]=='\"') { > + /* strip first and last quote characters and try again */ > + WCMD_opt_s_strip_quotes(command); > + opt_s=1; > + WCMD_run_program(command, called); > + return; > + } > + > + /* If it still fails, give up */ > + if (!status) { > + SetLastError(ERROR_FILE_NOT_FOUND); > + WCMD_print_error (); > + /* If a command fails to launch, it sets errorlevel 9009 - which > + does not seem to have any associated constant definition */ > + errorlevel = 9009; > + return; > + } > + > + /* Wait for it to end */ > + WaitForSingleObject (pe.hProcess, INFINITE); > + GetExitCodeProcess (pe.hProcess, &errorlevel); > + if (errorlevel == STILL_ACTIVE) errorlevel = 0; > + CloseHandle(pe.hProcess); > + CloseHandle(pe.hThread); You should use the existing CreateProcess code instead of duplicating it all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Named pipes to remote machines?
by Dan Kegel 02 Apr '07

02 Apr '07

A user asked in http://groups.google.com/group/comp.emulators.ms-windows.wine/msg/06fbfdfb5… whether Wine could communicate with remote machines via named pipes yet (he needs it to talk with an SQLServer box). I know Alexandre's been poking around in that area, but I think he's working on local networking, not remote. I also know Kai Blin had looked at this, but I don't know where he left it. Can someone summarize the current state and plan, if any? Here are some past discussions on the topic: http://www.kerneltraffic.org/wine/wn20060428_312_print.html#3 http://www.winehq.org/pipermail/wine-devel/2005-September/039680.html http://kerneltraffic.org/wine/wn20040109_204.html#3 Thanks, Dan

2 1

Re: RegDeleteTreeA
by Paul Vriens 02 Apr '07

02 Apr '07

Stefan Leichter wrote: > ChangeLog > -------------- > add some tests for RegDeleteTreeA > Hi Stefan good to see someone picked up this thing. I ran your new tests on Vista Ultimate and comments are below. (I ran the tests while bypassing UAC, as administrator). > > ------------------------------------------------------------------------ > > --- ../wine-git/dlls/advapi32/tests/registry.c 2007-03-17 08:36:33.000000000 +0100 > +++ dlls/advapi32/tests/registry.c 2007-04-01 14:00:12.000000000 +0200 > @@ -35,6 +35,7 @@ > > static HMODULE hadvapi32; > static DWORD (WINAPI *pRegGetValueA)(HKEY,LPCSTR,LPCSTR,DWORD,LPDWORD,PVOID,LPDWORD); > +static DWORD (WINAPI *pRegDeleteTreeA)(HKEY,LPCSTR); > > #define ADVAPI32_GET_PROC(func) \ > p ## func = (void*)GetProcAddress(hadvapi32, #func); \ > @@ -47,6 +48,7 @@ > > /* This function was introduced with Windows 2003 SP1 */ > ADVAPI32_GET_PROC(RegGetValueA) > + ADVAPI32_GET_PROC(RegDeleteTreeA) > } > > /* delete key and all its subkeys */ > @@ -872,6 +874,53 @@ > RegDeleteKeyA(subkey, ""); > } > > +static void test_reg_delete_tree(void) > +{ > + CHAR buffer[MAX_PATH]; > + HKEY subkey, subkey2; > + LONG size, ret; > + > + if(!pRegDeleteTreeA) return; Can you add a skip here? > + > + ret = RegCreateKeyA(hkey_main, "subkey", &subkey); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCreateKeyA(subkey, "subkey2", &subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegSetValueA(subkey, NULL, REG_SZ, "data", 4); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegSetValueA(subkey2, NULL, REG_SZ, "data2", 5); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCloseKey(subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + > + ret = pRegDeleteTreeA(subkey, "subkey2"); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(subkey, "subkey2", &subkey2), > + "subkey2 was not deleted\n"); > + size = MAX_PATH; > + ok(!RegQueryValueA(subkey, "subkey", buffer, &size), > + "Default value of subkey not longer present\n"); This test fails so it must mean the default value should have been deleted. > + > + ret = RegCreateKeyA(subkey, "subkey2", &subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = RegCloseKey(subkey2); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ret = pRegDeleteTreeA(hkey_main, "subkey\\subkey2"); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(subkey, "subkey2", &subkey2), > + "subkey2 was not deleted\n"); > + ok(!RegQueryValueA(subkey, "subkey", buffer, &size), > + "Default value of subkey not longer present\n"); This test fails so it must mean the default value should have been deleted. > + > + ret = pRegDeleteTreeA(subkey, NULL); > + ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); > + ok(RegOpenKeyA(hkey_main, "subkey", &subkey), > + "subkey was not deleted\n"); The subkey will not be deleted by RegDeleteTree (see MSDN). This is the main difference between RegDeleteTree and SHDeleteKey (where the main key is deleted). > + > + ret = pRegDeleteTreeA(hkey_main, "not-here"); > + trace("deleting an not existing key returned %d\n", ret); The answer to this one is 2 : ERROR_FILE_NOT_FOUND > +} > + > START_TEST(registry) > { > /* Load pointers for functions that are not available in all Windows versions */ > @@ -901,6 +950,8 @@ > set_privileges(SE_RESTORE_NAME, FALSE); > } > > + test_reg_delete_tree(); > + > /* cleanup */ > delete_key( hkey_main ); > > > > ------------------------------------------------------------------------ > > Cheers, Paul.

2 2

Re: [PATCH 1/1] wined3d: Make 8bpp a valid depth in EnumAdapterModes
by Chris Robinson 02 Apr '07

02 Apr '07

On Friday 30 March 2007 08:11:54 pm Vitaly Budovski wrote: > Make 8bpp a valid depth in EnumAdapterModes. This allows Age of Empires to > start. > --- > dlls/wined3d/directx.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) This causes the d3d8 device test to fail for me: device.c:755: Test failed: Unexpected display mode returned for mode 42: 0x29 ...all the way through to... device.c:755: Test failed: Unexpected display mode returned for mode 83: 0x29 D3D8 only supports 32-bit X8R8G8B8 and 16-bit R5G6B5 modes as far as Windows testing has shown, and passing WINED3DFMT_UNKNOWN to WineD3D for mode enumeration makes it work on D3D8 modes only. You'll probably need to wait for Stefan or Henri to respond to figure out what to do. Though, it appears DDraw can be patched to do a second enumeration loop with WINED3DFORMAT_P8 if the first was with WINED3DFMT_UNKNOWN.. whether or not this is acceptable, I'm not sure, but it's an idea I just had.

3 4

Re: gdi32: simple test for bad pointer
by James Hawkins 01 Apr '07

01 Apr '07

On 4/1/07, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this test shows similar problem as in bug 7380. On windows SetDIBits > returns 0, when a bogus pointer is passed in by the application. Wine > crashes on this test. I'll send in anoter try to fix this bug hereafter. > You can't send in a test that crashes without fixing it first or in the same patch. -- James Hawkins

1 0

Re: winecfg and cdrom drives
by EA Durbin 01 Apr '07

01 Apr '07

Does anyone who is Mac saavy have ideas on the best way to accomplish cdrom detection in wineprefixcreate across Mac OSX and *nix platforms? >From: "Dan Kegel" <dank06(a)kegel.com> >To: "EA Durbin" <ead1234(a)hotmail.com> >Subject: Re: winecfg and cdrom drives >Date: Sun, 1 Apr 2007 08:33:37 -0700 > >I haven't looked at it myself... >You want this to work on macosx, too, so be careful. > >On 4/1/07, EA Durbin <ead1234(a)hotmail.com> wrote: >> >>Nice, I didn't know that was performed by a bash script. What's the best >>way >>to go about detecting cdrom/dvd drives, just grep fstab? >> >> >From: "Dan Kegel" <dank06(a)kegel.com> >> >To: "EA Durbin" <ead1234(a)hotmail.com> >> >Subject: Re: winecfg and cdrom drives >> >Date: Sun, 1 Apr 2007 08:10:51 -0700 >> > >> >On 4/1/07, EA Durbin <ead1234(a)hotmail.com> wrote: >> >>Is there a reason we don't detect cdrom drives in winecfg and have to >> >>enter >> >>them manually? >> > >> >cd rom drives should be detected without user intervention, imho >> > >> >users shouldn't have to run a special gui config tool to get their >> >drives recognized >> > >> >so if it needs fixing, let's fix it in e.g. wineprefixcreate >> >> >> > > >-- >Wine for Windows ISVs: http://kegel.com/wine/isv

4 5