April 2007 - Wine-devel - list.winehq.org

string comparison functions
by Tomas Kuliavas 07 Apr '07

07 Apr '07

Hi, Sorry for cross posting. I've already asked same question on wine-users list and only reply redirected me to devel list. What rules are used when Wine libraries compare Unicode strings? I need to know when ascii characters can match their approximate Unicode equivalents. For example: 'U+1D49 MODIFIER LETTER SMALL E' matches 'U+0065 LATIN SMALL LETTER E' on Wine. I am debugging IE javascript security issues. IE6 on Wine (Linux Debian) matches more Unicode equivalents than IE6 on Win98 and WinXP. If you need more information, I can provide sample html that works on Wine and does not work on Win98/XP. I am not C/C++ programmer. I only need to know which library provides mapping of unicode equivalents in string comparison functions. Is it standard C library? glibc 2.3.6 on Debian Etch. -- Tomas

2 1

ntdll/kernel32: LoadLibrary fails to load some dependent libs
by Clinton Stimpson 07 Apr '07

07 Apr '07

So I have this case: An application that can load libraries at runtime (plugins). Plugins reside in a different directory than the application directory. Some plugins have dependent dlls found only in the plugin directory. Wine fails to load the dependent dlls. I can copy the dependent dlls into the application directory and the plugins load successfully. I traced the execution into ntdll/loader.c : load_native_dll load_path included the the application directory and some system paths. name is the full path of the library to load. The call to fixup_imports fails. Should the path to the library be added to load_path in load_native_dll? Or is there another appropriate way to fix this? Thanks, Clint

2 2

re: Contributing money to WINE?
by Dan Kegel 07 Apr '07

07 Apr '07

Tim wrote: >I find myself in a similar dilemma... What if a few of us banded >together and put a bounty on a feature / app, or contracted >codeweavers to implement it? I think that would be great. Assuming >we can agree on something we'd like to fund, it would be a little more >targeted than just voting in CW's appdb. Problem is, most of the things you might want to have fixed are pretty expensive. Let's say a bug takes ten days to fix. Assuming $100/hr (which is not far off for contract development), that's $8K right there. Lots of folks have thought about how to solve the problem, but dealing with money is complicated. It'd be better for you to donate time triaging bugs, IMHO. ( http://kegel.com/wine/qa/ ) Just reproduce one bugzilla entry a day for a week, and document what you find, and we'd be very happy!

2 1

Re: [resend] notepad: Improve printing considerably
by Alexandre Julliard 06 Apr '07

06 Apr '07

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> writes: > Changelog > programs/notepad/dialog.c > programs/notepad/main.c > programs/notepad/main.h > Improve printing considerably That's not a very useful log message... Could you please describe a bit how it is improved? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Improve printing considerably
by Dmitry Timoshkov 06 Apr '07

06 Apr '07

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> wrote: > +#include <tchar.h> What is this for? According to the Alexandre's comments we should convert all the Wine builtin apps to unicode intead of promoting usage of TCHAR that leads to a lot of trouble in multibyte locales, besides it looks like tchar.h is not used at all. -- Dmitry.

2 1

Using signals to turn logging on and off
by Dan Kegel 06 Apr '07

06 Apr '07

I tried the patch in the wiki to control logging with f12, but it wasn't quite satisfying, because only one process has the keyboard, so you can only turn one process' logging on and off. This isn't so great if the process you're interested in never has the keyboard. (Like com servers started up during installers.) So I played around with using unix signals instead. And rather than having a signal toggle the enable status, I used one signal for enable and another for disable. The feature is only turned on if you set the WINEDEBUGSIG environment var. Problem is, all I can do is turn logging off; turning it on doesn't work for some reason. Feh. Can somebody spot what I did wrong? It's at http://kegel.com/wine/debugsig.patch It was monkey-see-monkey-do code, to some extent, so I wouldn't be surprised if there's an obvious problem. Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: notepad: Use the more explicitly UNICODE character type.
by Dmitry Timoshkov 06 Apr '07

06 Apr '07

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > Changelog: > Use the more explicitly UNICODE character type. Then you have to simultaneously explicitly start using unicode Win32 APIs. I'd suggest you to start with the application that presumably doesn't work properly in multibyte locales and which you already started to look at - regedit, and leave notepad alone until there are real problems discovered. -- Dmitry.

2 1

re: kernel32: Implement ReplaceFileA/ReplaceFileW (revised, resubmit)
by Dan Kegel 06 Apr '07

06 Apr '07

Kudos for your persistance. I hope this makes it in soon. I see two remaining problems: + /* + * This case should never occur, we've already checked permissions earlier + * and we are holding the file handle open. + */ + ERR("Replacement file may not be deleted!\n"); You need to handle this case better; it happens in real life sometimes that the filesystem lies when it tells you you can write. It should be a WARN, and you need to return the proper error code. Are you quite sure you need to do any file copying? Wouldn't a series of renames be more efficient? - Dan

2 1

Re: [2/2] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride
by H. Verbeet 06 Apr '07

06 Apr '07

On 05/04/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > > > From b369a9384beb831dfae6460418d861f30a9cef3e Mon Sep 17 00:00:00 2001 > From: Fabian Bieler <der.fabe(a)gmx.net> > Date: Thu, 5 Apr 2007 21:52:44 +0200 > Subject: [PATCH] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride > This doesn't work for the general case, ie blitting any surface to another surface. I've got a more complete patch for this in my tree.

1 1

Re: notepad: Fix the wrong '&' operator use.
by Felix Nawothnig 05 Apr '07

05 Apr '07

Byeong-Sik Jeon wrote: > FormatMessage( > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > NULL, error, 0, > - (LPTSTR) &lpMsgBuf, 0, NULL); > + lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used FormatMessage() takes a pointer to a pointer.

2 1