April 2007 - Wine-devel - list.winehq.org

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.
by Detlef Riekenberg 05 Apr '07

05 Apr '07

On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > + /* convert from WCHAR size to maximum required TCHAR size */ > + max_val_name_len *= sizeof(WCHAR) / sizeof(TCHAR); > + > valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * > sizeof(TCHAR)); > valBuf = HeapAlloc(GetProcessHeap(), 0, max_val_size); > if (RegQueryValueEx(hKey, NULL, NULL, &valType, valBuf, &valSize) > == ERROR_FILE_NOT_FOUND) { This looks wrong to me: TCHAR is WCHAR, when compiled with UNICODE, otherwise TCHAR is CHAR The code does already handle the different character-size in HeapAlloc for varName. When the app must handle the case, that sizeof(string) can be > "strlen(string) + sizeof(0)", then we should convert the app to use UNICODE everywhere. For the last quoted line, valSize is not initialized! (RegQueryInfoKey wrote the result to max_val_size) Just checked Coverity: not detected -- By by ... Detlef

5 15

Fedora packages, where are they?
by Louis Lenders 05 Apr '07

05 Apr '07

Hi, the link on the wine-page to get the Fedora- wine packages points to "nowhere". Could this be fixed? Furthermore, anyone know where i can get the wine-rpm for Fedora?

3 2

Re: comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)
by Dmitry Timoshkov 05 Apr '07

05 Apr '07

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > If the DDB format is RGB565, CopyImage uses an RGB555 intermediate DIB > that leads to data loses. This may change the COLOR_BTNFACE pixels > slightly and they won't be recognized as transparent anymore. As this > bug is also present under Windows, I haven't changed CopyImage but wrote > a new function that I hope works correctly. Since it clearly sounds like a CopyImage bug it would be more appropriate to fix CopyImage instead, Microsoft may do that at some point as well. -- Dmitry.

2 1

Re: [PATCH] kernel32: return copy of environment block inGetEnvironmentStringsW
by Dmitry Timoshkov 05 Apr '07

05 Apr '07

"Peter Beutner" <p.beutner(a)gmx.net> wrote: > Make behaviour consistent with GetEnvironmentStringsA. > Prevents crash for confused applications which first call > GetEnvironmentStringsW and then want to free it with FreeEnvironmentStringsA. This patch is wrong: http://blogs.msdn.com/matt_pietrek/archive/2004/08/25/220330.aspx Probably an exception handler should be added inside of RtlFreeHeap instead. -- Dmitry.

3 4

Re: wined3d: Fix GLSL cnd instruction
by H. Verbeet 05 Apr '07

05 Apr '07

On 05/04/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > According to MSDN the cnd instruction should translate: > dst = src0 > 0.5 ? src1 : src2; > > This matches the ARB implementation in wined3d and fixes the borders in civ4. > > Note: On nvidia hardware this patch breaks the outro of Half-Life 2 with > dxlevel 80 and GLSL due to a driver bug. > You should update the comment above the instruction as well then.

1 0

Re: [AppDB] Use objectMakeLink()/Url() in more places
by Marty Schmidt 05 Apr '07

05 Apr '07

I can not open the attachment on this message ----- Original Message ----- From: "Alexander Nicolaysen Sørnes" <alex(a)thehandofagony.com> To: <wine-patches(a)winehq.org>; "Chris Morgan" <cmorgan(a)alum.wpi.edu> Sent: Sunday, April 01, 2007 4:38 PM Subject: [AppDB] Use objectMakeLink()/Url() in more places Use objectMakeLink()/Url() in more places. Regards, Alexander N. Sørnes -------------------------------------------------------------------------------- > >

2 1

Re: winspool: Add a test for DeviceCapabilities, fix some bugs found
by Detlef Riekenberg 04 Apr '07

04 Apr '07

On Di, 2007-04-03 at 23:40 +0900, Dmitry Timoshkov wrote: > Changelog: > winspool: Add a test for DeviceCapabilities, fix some bugs found. > + hComdlg32 = LoadLibrary("comdlg32.dll"); > + assert(hComdlg32); > + pPrintDlg = GetProcAddress(hComdlg32, "PrintDlgA"); > + assert(pPrintDlg); Why are you using assert() and kill the test? Is skip not enough? > + ok(dm != NULL, "GlobalLock(prn_dlg.hDevMode) failed\n"); > + trace("dmDeviceName \"%s\"\n", dm->dmDeviceName); You added a ok() for "dm =! NULL", but "dm" is accessed always and will crash the test. > + ok(dn != NULL, "GlobalLock(prn_dlg.hDevNames) failed\n"); > + ok(dn->wDriverOffset, "expected not 0 wDriverOffset\n"); Same here for "dn". > + ok(lstrcmp((const char *)dm->dmDeviceName, (const char *)dn + dn->wDeviceOffset) == 0, "device names not match\n"); You introduced the same bug, as you did in in your previous Patch! (test_DocumentProperties) dm->dmDeviceName is limited to CCHDEVICENAME > + trace("fields %x\n", fields); > +todo_wine > + ok(fields == dm->dmFields, "fields %x != dmFields %x\n", fields, dm->dmFields); info.c:2093:fields 7b13 info.c:2095: Test succeeded inside todo block: fields 7b13 != dmFields 7b13 I get the same "succeeded inside todo" for all printers > test_SetDefaultPrinter(); > test_XcvDataW_MonitorUI(); > test_XcvDataW_PortIsValid(); > + test_DeviceCapabilities(); > Why is it so difficult to add the tests in alphabetic order? This Patch dump a lot of unneeded data. Please remove the traces (or dump the data only in interactive mode). Thanks -- By by ... Detlef

2 2

Re: [winmm/winearts] Kill off winearts
by Chris Morgan 04 Apr '07

04 Apr '07

On 4/4/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > As far as I can tell, it has been disabled for at least 4 months, and I didn't hear anyone about it, so it seems like a good idea to remove winearts, if anybody feels like reviving it, it would be easy to do so by reversing this commit, but KDE itself is moving away from arts, so I dont see a point in keeping this broken, disabled audio backend. As the original author I'll second that opinion. Btw, it would be nice if someone with low level knowledge of threading/glibc could take a look at winejack. Jack is a much better audio interface than arts and its a shame that it hasn't worked better and I haven't been able to debug the issues that winejack has had. Chris

1 0

Re: RegDeleteTreeA [2nd]
by Paul Vriens 04 Apr '07

04 Apr '07

On 4/2/07, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > ChangeLog > -------------- > add some tests for RegDeleteTreeA > > > > > Hi Stefan, You're patch wasn't against latest GIT (or actually you reverted the last two registry test patches applied to GIT). Maybe my last mail wasn't clear but the last test now fails: Test failed: "Expected data got" (btw you forgot a newline for this ok call). The test should be that 'data' is not present anymore (the data for default should be empty). Cheers, Paul.

2 2

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs
by Stefan Dösinger 04 Apr '07

04 Apr '07

Am Dienstag 03 April 2007 23:38 schrieb Felix Nawothnig: > --- > dlls/wined3d/state.c | 24 ++++++++++++------------ > 1 files changed, 12 insertions(+), 12 deletions(-) Some of them should technically be ERRs because we tell the application that we do not support those features, so they should never be used. However, since we want to implement them somewhen I think its fine to downgrade them to FIXMEs

2 1