April 2007 - Wine-devel - list.winehq.org

Re: RegDeleteTree [3rd]
by Robert Shearman 25 Apr '07

25 Apr '07

Stefan Leichter wrote: > Am Thursday 19 April 2007 12:14 schrieb Alexandre Julliard: > >> Stefan Leichter <Stefan.Leichter(a)camline.com> writes: >> >> >>> + } else { >>> + if (!ret) >>> + ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0); >>> >> The function is supposed to delete the key values, that's not what >> this does. >> >> You probably need to write some test cases... >> > Hello Alexandre, > > i 'm not sure what you mean with this point. I have now added a loop to delete > all value/data pairs, but this loop is only executed for the default entry > (value NULL). > > If the implementation is not fine for you, can you please suggest detailed > test cases to be proved. > Perhaps: s/RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0)/RegDeleteValueW(hSubKey, NULL)/ -- Rob Shearman

2 1

Uninstaller: 2 questions
by Tom Spear 25 Apr '07

25 Apr '07

Why do we show a dialog if there are no uninstall entries found in the registry? Windows does not do that, and I think we shouldn't either. However, on that same note, I think we should, since this uninstaller is not designed to mimic Windows' Add/Remove Programs, catch when a program's uninstaller does not remove it's uninstall entry from the registry, after the process exits, and go ahead and remove the entry. I already have a patch for the 2nd question ready to be committed once my patch to check HKCU is committed, however I am waiting for comment before I actually send it. The first question I will wait to write a patch for, however it is only like a 4 line patch.. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

4 7

Re: [Generic] Add --disable-tests
by Saulius Krasuckas 25 Apr '07

25 Apr '07

* On Tue, 9 Jan 2007, Maarten Lankhorst wrote: > > This patch adds --disable-tests, but keeps --enable-tests by default, > this is very useful for regression testing with a specific app because > it saves a lot of building time. Can this patch go into the GIT, any objections?

1 1

Winscard support (for smart cards)
by mounir.idrassi＠idrix.Fr 25 Apr '07

25 Apr '07

Hi, We have noticed that wine doesn't have the winscard dll responsible for the support of smart cards under windows. For the need of one of our projects, we are currently developing this dll for wine under Linux based on the pcsc-lite library. Once done, we'll share it with the community. However, we would like to known the reason behind the lack of winscard support. Is it simply because no one needed it before or maybe there is an issue with the pcsc-lite license? Thanks in advance for your information. Cheers, Mounir IDRASSI IDRIX http://www.idrix.fr

5 4

re: Winscard support (for smart cards)
by Dan Kegel 25 Apr '07

25 Apr '07

I'm thrilled you're working on this! I must urge you to submit code early and often to Wine. The first patch you should send should just implement a stub dll. We can help you with that if you need it. Here's a good example of a new stuff DLL: http://winehq.org/pipermail/wine-patches/2007-April/038141.html By submitting a patch like this, you will pave the way for later submission of more code. - Dan

1 0

[programs/uninstaller (Try 6)] Scan HKCU
by Tom Spear 25 Apr '07

25 Apr '07

Scan HKCU for uninstall entries. Separated out the trace fix, moved the HeapAlloc for entries outside the for loop, realigned the 2nd line of code for a trace. This patch obsoletes all previous ones. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

[Try 5] Check HKCU for uninstall entries
by Tom Spear 25 Apr '07

25 Apr '07

Hopefully this will be the last try. Instead of just checking HKLM for uninstall entries, check HKCU as well. Converted all instances of entries[numentries-1].xxx to entry->xxx Fixed a bug with a trace. Ran the file thru kwrite to make SURE there are NO tabs! Double checked the diff to make sure no whitespaces were removed by adding new lines. Any comments? This is sent to wine-patches, so if there are no problems with this patch, it is ready for commit. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1

Server Failure
by Robert Lunnon 25 Apr '07

25 Apr '07

I'm having the wineserver sparodically return a failure STATUS_NO_SUCH_FILE I think this is possibly because wineserver didn't get compiled with a threadsafe errno but I'd welcome other ideas Heres the context (WINEDEBUG=+server) 0014: new_thread() = 0 { tid=003a, handle=12c } 003b: terminate_thread( handle=fffffffe, exit_code=207 ) 003b: terminate_thread() = 0 { self=1, last=0 } 003b: get_window_children( parent=0, atom=0000, tid=0000 ) 003b: get_window_children() = ERROR_INVALID_WINDOW_HANDLE { count=0, children={} } 003b: close_handle( handle=0 ) 003b: close_handle() = INVALID_HANDLE 003b: *killed* exit_code=207 003a: *fd* 53 <- 66 003a: *fd* 55 <- 67 003a: init_thread( unix_pid=21133, unix_tid=-1, debug_level=1, teb=7e090000, peb=7ffd0000, entry=40edf7, ldt_copy=d1f90cc0, reply_fd=53, wait_fd=55 ) 003a: init_thread() = NO_SUCH_FILE { pid=0008, tid=003a, info_size=0, server_start=1c786d460b0ba38 (-11.5351480), version=298 } wine client error:3a: init_thread failed with status c000000f

2 1

Re: [Try 3] [programs/uninstaller] Check HKCU for uninstall entries
by James Hawkins 25 Apr '07

25 Apr '07

On 4/24/07, Tom Spear <speeddymon(a)gmail.com> wrote: > This patch makes the wine uninstaller check HKCU for uninstall entries > in addition to HKLM. > +const int numrootkeys = 2; +static const DWORD maxSubkeyNameLen = 255; const variables should be all uppercase to differentiate them from non-const variables. One of the const variables is static and the other not, what gives? @@ -148,7 +149,6 @@ WINE_ERR( "The remove option requires a parameter.\n"); return 1; } - RemoveSpecificProgram( argv[i++] ); Don't make random whitespace changes. + for (x=0; x<sizeof(hkeyroot[0]); ++x) + { sizeof(hkeyroot[0]) = 4, which means you're going to index hkeyroot two indexes out of bounds. I think you're looking for sizeof(hkeyroot) / sizeof(hkeyroot[0]). + WINE_TRACE("allocated entry #%d: %s (%s), %s\n", + numentries, wine_dbgstr_w(entries[numentries-1].key), wine_dbgstr_w(entries[numentries-1].descr), wine_dbgstr_w(entries[numentries-1].command)); You mixed tabs and spaces, and that line is too long. -- James Hawkins

3 3

Re: [4/20] DDraw: Get rid of FVFs
by H. Verbeet 25 Apr '07

25 Apr '07

On 24/04/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + hr = IWineD3DDevice_CreateVertexDeclarationFromFVF(This->wineD3DDevice, > + &pDecl, > + (IUnknown *) ICOM_INTERFACE(This, IDirectDraw7), > + fvf); Is this right? Passing the IDirectDrawImpl as parent looks a bit questionable.

2 3