April 2007 - Wine-devel - list.winehq.org

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF
by H. Verbeet 25 Apr '07

25 Apr '07

On 24/04/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > How do you intend for this to be used? In particular, how should this work with eg. IDirect3DVertexDeclaration9::GetDeclaration or IDirect3DDevice8::GetVertexShaderDeclaration?

2 3

Using A- instead of W-calls in tests
by Paul Vriens 25 Apr '07

25 Apr '07

Hi, There are several tests where we use W-calls where we could use A-calls to accomplish the same test goal. Most of the time this means some of these will fail on Win9x or WinME as they are not by default Unicode enabled. Do we need write our tests with A-calls ? For Wine this doesn't matter if we're forwarding the call to a W-call. I do think it could matter on Windows or does Windows also do the forwarding? As an example: there are several CryptAcquireContextW calls in the cert tests for crypt32. These fail with an ERROR_CALL_NOT_IMPLEMENTED on win98 and following tests that rely on the return valuse also fail. Should these tests be re-written to use CryptAcquireContextA or should we skip to avoid the hassle. I just want some opinions. I know Alexandre already mentioned not being to worried about failing win98 tests but I like to see an all green (with some blue borders) tests.winehq.org page :-). Cheers, Paul.

2 1

D3DRM: Thanks a lot, Wine people
by David.Adam＠math.cnrs.fr 25 Apr '07

25 Apr '07

Hello, my first "real" patches for wine were accepted. I would to thank all wine people for their kindness, and their help to make these patche accepted. Now I can play Motocross Madness 2 out the box :D :D :D Specially, I would like to thanks Vijay for his help to start the implementation, and Dmitry who gave a lot of advice without becoming nervous in view of my unabilty in wine. I thanks too Alexandre to accept these patch and modify them silently :) In the modifications, I saw that the defintion of vectors, quaternions... in d3drmdef.h was replaced by a call to d3dtypes.h In fact I copied the beginning of d3drmdef.f from the dsound.h file. Can we not modify this file too? David

2 1

Re: schannel: Implement SpLsaModeInitialize (update)
by Alexandre Julliard 25 Apr '07

25 Apr '07

Yuval Fledel <yuvalfl(a)gmail.com> writes: > +static const SECPKG_FUNCTION_TABLE secPkgFunctionTable[2] = > + { { > + .InitializePackage = NULL, > + .LsaLogonUser = NULL, > + .CallPackage = NULL, Please don't use C99 syntax, it won't work on older compilers. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF
by Ivan Gyurdiev 25 Apr '07

25 Apr '07

> Stefan Dösinger wrote: You're returning a size_t here, which does not match the WINED3DERR_OUTOFVIDEOMEMORY returned on the HeapAlloc (granted, that's probably incorrect behavior by d3d9, but at least the return types should be consistent). Does that mean we'll be removing the other two versions of this code in existence (d3d9, and drawprim conv)? By the way, who wrote the very first version - I was looking through git history to figure out the proper copyright attribution, and it predates the git tree. I guess we should update the copyright in d3d9/vertexdeclaration.c to list that person if it isn't done already. I was just curious... Ivan

2 1

SambaXP 2007 Report, Day 2
by Kai Blin 25 Apr '07

25 Apr '07

Hi folks, time for the second part of the SambaXP status report. On tuesday, I had the chance to talk to Sam Ranji from Microsoft at lunch. He is leading the open source compatibility lab at Microsoft, a lab running only open source software. He told us that he was at SambaXP to figure out how Microsoft could help the Samba community and Samba customers. The conversation was very polite, but not very much to a point. Sam seems to be pretty reasonable about talking to the open source community, but there is only so much he can do on the Microsoft side. Microsoft seems to acknowledge that there is need for a product like Samba out there and it looks like they have decided to play along. Sam mentioned that there were some bugs in Vista that severely hurt Samba interoperability and that Microsoft fixed them prior to the Vista release. Simo Sorce then pointed out some cases where Microsoft used to cooperate with Samba and now stopped talking. Dan Shearer told an amusing anecdote about one project manager at Microsoft who wanted to use ports > 1024 for privileged services, and how Tridge wrote a perl script exploiting this potential vulnerability, before it even existed. Sam seems to be really interested in cooperating with Samba in the area of bug reports, and see where the cooperation can go from there. While this doesn't mean much for Wine, it seems like Microsoft finally is accepting that they can't just will open source software away. We will see how this develops. ---- Centeris is producing Centeris Likewise, a product that supports managing Linux/Unix products using standard Windows administration tools. Centeris' Krishna Ganugapati had a fast-paced talk about Likewise and named a couple of requirements for porting their .NET/Mono based management applications to Linux. Among the things they need are a library similar to netapi32, a library doing DCE/RPC and remote named pipes. Now, if you remember part 1 of my report, remote named pipes is something I already got started on. Talking to Krishna after his talk, we both realized that cooperating in this area will give Centeris a way to port their product and Wine a way to just thunk to a native library instead of reinventing the wheel. Centeris is happy to fund development in that area and then release this under a free license. I will get into that some more after SoC. ---- Most conversations I had in the breaks and at the social event are not really interesting from a Wine point of view, but we will see how that develops after my talk this afternoon. Signing off to listen to another interesting talk, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

Now, I am writing tests for this. Windows crashes if I pass NULL pointer to these function. Crash can be easily avoided in wine. Should we crash too? And how the windows crash can be caught? Or just I should not write such test-case? Thanks, -- Kirill

2 1

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

> > > > For containing backshash. Yes, comment must be better. > > A comment that states you're looking for a backslash is superfluous; > the code makes that obvious. A better comment would be 'check for > filename only' or something along those lines. Maybe, 'MSDN claims that if filename contains backshash then return value is always TRUE'? > How do you know that's > what this function does if you haven't tested it? I've mentioned an MSDN article in the patch. There are some glimpses what this function does. Easy, isn't it? ;-) That MSDN article is rather strange: it claims, that filename is the name of executable file, but in wine traces of cmd.exe I can see '.' (dot) as an argument. -- Kirill

2 1

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 25 Apr '07

25 Apr '07

> On 4/24/07, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > > Hi, > > I've sent the patch: > > http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html > > about a week ago and it has not been applied. Please, explain, what is > > wrong with it? > > You haven't sent in any tests for this function. Is there some app > that needs it? I've mentioned it in the first try: windows 2003 cmd.exe. > + static const WCHAR env_name[] = > {'N','o','D','e','f','a','u','l','t','C','u','r','r','e','n','t','D','i','r >','e','c','t','o','r','y','I','n','E','x','e','P','a','t','h',0}; > > That's a really long line. We try to keep the lines to a length of 80. Hm... I've improve it. > + /* Check name first */ > + if (strchrW(name, '\\')) > + return TRUE; > > You should probably check name for NULL, but you'll have to test how > Windows handles this. That's a pretty bad comment too; check name for > what? For containing backshash. Yes, comment must be better. Thanks, -- Kirill

2 1

FillGLCaps foreign context question
by Jesse Allen 25 Apr '07

25 Apr '07

Jan, In a patch from Nov 23, you changed FillGLCaps to return false when we get a foreign context. This causes SW Battlefront to crash while loading sometime after calling IWineD3DImpl_GetAdapterIdentifier, at least on my system. IWineD3DImpl_GetAdapterIdentifier calls FillGLCaps, and when it gets the false, it uses dummy values. Why can't we use the caps from a foreign context? Attached patch fixes loading the game. See http://source.winehq.org/git/wine.git/?a=commit;h=ee44a19966fec922ab2273449… Any ideas on what might be the problem? Jesse

1 0