April 2007 - Wine-devel - list.winehq.org

Re: [Try 4] Check HKCU for uninstall entries
by James Hawkins 25 Apr '07

25 Apr '07

On 4/24/07, Tom Spear <speeddymon(a)gmail.com> wrote: > All previous patches are obsoleted by this one. > > Instead of just checking HKLM for uninstall entries, check HKCU as well. > + if (!entries) + entries = HeapAlloc(GetProcessHeap(), 0, sizeof(uninst_entry)); You're still mixing tabs and spaces. -- James Hawkins

1 0

Re: schannel: Implement SpUserModeInitialize
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Yuval Fledel <yuvalfl(a)gmail.com> wrote: > > + if (LsaVersion != 0x10000) What is 0x10000? If it's not defined in the SDK, then please use a #define to clarify what it means. -- James Hawkins

2 4

Re: winealsa: Improved handling of SysEx MIDI messages
by Christian Costa 24 Apr '07

24 Apr '07

Seems fine. Michał Wiernowolski a écrit : > This patch puts together pieces of SysEx messages until > End-of-Exclusive (F7) arrives or the buffer gets filled. > This improves current behavior (giving up on all multi-buffer sysex > msgs), fixing partially bug #6788. > > ------------------------------------------------------------------------ > > >From 0102a6ed573916067f0c2fd84b5218bd4200fede Mon Sep 17 00:00:00 2001 > From: =?ISO-8859-2?q?Micha=B3_Wiernowolski?= <mihalw(a)gmail.com> > Date: Tue, 24 Apr 2007 19:17:34 +0200 > Subject: [PATCH] winealsa: Improved handling of SysEx MIDI messages (Bug #6788) > > --- > dlls/winealsa.drv/midi.c | 20 +++++++++++--------- > 1 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c > index 09018aa..90d52e6 100644 > --- a/dlls/winealsa.drv/midi.c > +++ b/dlls/winealsa.drv/midi.c > @@ -351,17 +351,19 @@ static DWORD WINAPI midRecThread(LPVOID arg) > LPBYTE ptr = (BYTE*) ev->data.ext.ptr; > LPMIDIHDR lpMidiHdr; > > - /* FIXME: Should handle sysex greater that a single buffer */ > + /* FIXME: Should handle sysex greater than lpMidiHdr->dwBufferLength */ > EnterCriticalSection(&crit_sect); > if ((lpMidiHdr = MidiInDev[wDevID].lpQueueHdr) != NULL) { > - if (len <= lpMidiHdr->dwBufferLength) { > - lpMidiHdr->dwBytesRecorded = len; > - memcpy(lpMidiHdr->lpData, ptr, len); > - lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > - lpMidiHdr->dwFlags |= MHDR_DONE; > - MidiInDev[wDevID].lpQueueHdr = (LPMIDIHDR)lpMidiHdr->lpNext; > - if (MIDI_NotifyClient(wDevID, MIM_LONGDATA, (DWORD)lpMidiHdr, dwTime) != MMSYSERR_NOERROR) > - WARN("Couldn't notify client\n"); > + if (lpMidiHdr->dwBytesRecorded + len <= lpMidiHdr->dwBufferLength) { > + memcpy(lpMidiHdr->lpData + lpMidiHdr->dwBytesRecorded, ptr, len); > + lpMidiHdr->dwBytesRecorded += len; > + if (*(ptr + (len-1)) == 0xF7) { > + lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > + lpMidiHdr->dwFlags |= MHDR_DONE; > + MidiInDev[wDevID].lpQueueHdr = (LPMIDIHDR)lpMidiHdr->lpNext; > + if (MIDI_NotifyClient(wDevID, MIM_LONGDATA, (DWORD)lpMidiHdr, dwTime) != MMSYSERR_NOERROR) > + WARN("Couldn't notify client\n"); > + } > } else > FIXME("No enough space in the buffer to store sysex!\n"); > } else > > ------------------------------------------------------------------------ > > >

1 0

Disabled Wine PostScript Driver?
by Alisson Gomes 24 Apr '07

24 Apr '07

Hello, In first time, I like congratulations by great job, the wine. Fantastic. In second time, i have the problem with Wine. How do disable Wine PostScript Driver? Is possible? by configuration, by compilation, etc. ps: I send e-mail in many discursion list: WineConf, Wine Users and others, nobody positively answers. Thanks, Alisson Gomes

3 3

Re: schannel: Tests for Sp[Lsa,User]ModeInitialize and GetInfo
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Yuval Fledel <yuvalfl(a)gmail.com> wrote: > > +#if 0 + /* NULL parameters: All 3 crash as of Windows XP */ + status = pSpLsaModeInitialize(0x10000, NULL, &pTables, &cTables); + status = pSpLsaModeInitialize(0x10000, &Version, NULL, &cTables); + status = pSpLsaModeInitialize(0x10000, &Version, &pTables, NULL); +#endif We try to avoid #if 0/#endif constructs. Just add a comment that states that the function crashes in XP if any of those three params are NULL. -- James Hawkins

2 1

NONE folder ???
by Tom Spear 24 Apr '07

24 Apr '07

While looking thru my ~/.wine/drive_c and my home directory today, I noticed that there is a folder called NONE that was created after I redid my wine install from the ground up last night. Looking thru it, there is a subfolder called var/cache/fontconfig and in that folder is a bunch of files that have filenames that look like md5 checksums with -x86.cache-2 at the end. The files are binary files, so I can't tell what they are used for, but since the name has fontconfig in them, I know they were created by fontforge. Question is, why does this folder and these files exist in my home directory, as well as every directory on my drive_c, and what are they for? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Should we handle this?
by Tom Spear 24 Apr '07

24 Apr '07

While testing my uninstaller patch, I ran into the issue that was a problem in Win95, where the uninstaller did not handle deletion of it's uninstall registry key. What I did was install a program that I new put it's registry key under HKLM. Then I copied that key to HKCU. Then I installed a program that I knew put its key under HKCU and copied that key to HKLM. Then I uninstalled each one with the copied key. The program's uninstaller removed the key that it was instructed to take out, but left the other one behind. My question is this. If an uninstaller (outside of my test environment) does not remove it's registry key before the process exits, should our uninstaller check for that after the process exits, and go ahead and remove the key, or should we make the user press the uninstall button again and ask them if they want to remove the key (like we already do, in the event they manually removed the program, by deleting the folder)? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 3

Re: ADVAPI32: Make service_start_process return the pid to the caller
by James Hawkins 24 Apr '07

24 Apr '07

On 4/24/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/service.c > - Make service_start_process return the pid to the caller > - /* FIXME: Put the pid into the service struct */ + if (ppid) *ppid = pi.dwProcessId; The fixme says to put the pid in the service struct, not return it in another parameter. -- James Hawkins

2 1

[try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?
by Kirill K. Smirnov 24 Apr '07

24 Apr '07

Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? Thanks -- Kirill

2 1

Typo fix
by Tom Spear 24 Apr '07

24 Apr '07

Just curious. I sent a patch to wine-patches last week to fix a typo in a trace for regedit, but it was not committed. Should I go ahead and resend it? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

2 1