July 2007 - Wine-devel - list.winehq.org

Re: [advapi32/service] Test for duplicate displayname
by James Hawkins 18 Jul '07

18 Jul '07

On 7/17/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > Another test that shows that windows checks if the displayname already exists. > > Changelog > Test for duplicate displayname > > Cheers, > + /* To find an existing displayname we check the 'Spooler' service. Although the registry doesn't show DisplayName on NT4, this call That's a really long comment at 136 cols. There are other really long lines in the rest of the patch too. -- James Hawkins

2 3

System font choice...
by Dan Kegel 18 Jul '07

18 Jul '07

A user complained that with wine-0.9.41, the font chosen by Winefile looks bad: https://bugs.launchpad.net/ubuntu/+source/wine/+bug/69569/comments/4 http://launchpadlibrarian.net/8517354/Screenshot-Wine%20File.png I'm guessing it's because vgasys.fon was chosen as the system font: trace:font:WineEngCreateFontInstance Chosen: L"System" L"Regular" (/usr/bin/../lib/../share/wine/fonts/vgasys.fon:0) What's the suggested way to choose a different font? I did 'sudo apt-get install msttcorefonts', didn't change anything. - Dan

2 2

Re: [PATCH 1/6] urlmon/tests: Expand framework to allow todo_wine'd tests and differences between Windows versions.
by Alexandre Julliard 18 Jul '07

18 Jul '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > #define CHECK_EXPECT(func) \ > do { \ > - ok(expect_ ##func, "unexpected call " #func "\n"); \ > - expect_ ## func = FALSE; \ > + if (!expect_ ##func && wine_allow_ ##func) \ > + { \ > + todo_wine ok(expect_ ##func, "unexpected call " #func "\n"); \ > + wine_allow_ ##func = FALSE; \ > + } \ > + else \ > + { \ > + ok(expect_ ##func, "unexpected call " #func "\n"); \ > + expect_ ## func = FALSE; \ > + } \ > called_ ## func = TRUE; \ > }while(0) This is becoming really ugly. You should fix this to use normal C code instead of macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

winedbg no longer working
by James Hawkins 18 Jul '07

18 Jul '07

Hi, Can someone else verify with git that winedbg no longer works? $ winedbg winecfg WineDbg starting on pid 000a Wine-dbg>c Exception c0000005 Wine-dbg>q wine: Unhandled page fault on read access to 0x0000005c at address 0x7e5ac5d2 (thread 0009), starting debugger... Can't attach process 0008: error 87 Thanks, James Hawkins

3 2

Re: winex11.drv: draw dashed lines for extended pens
by Alexandre Julliard 17 Jul '07

17 Jul '07

"Evan Stade" <estade(a)gmail.com> writes: > I'm only pretty sure this patch is correct. Specifically, note that > there are now HeapAlloc()s in X11DRV_SelectPen that rely on > X11DRV_SelectPen being called again to free. So what is supposed to > happen is that X11DRV_SelectPen called with some dash style will free > the last "dashes" array, and possibly allocate a new one. So this > method requires DeleteDC to call something along the lines of > > SelectObject( hdc, GetStockObject(BLACK_PEN) ); The dash array is always small, there's no reason to allocate it on the heap, you can store an array in the pen object. Also there shouldn't be any need to store the 'ext' flag if you take it into account when building the array. > +#define COPY_DASHDATA(ext, name) \ > + if(ext){ \ > + physDev->pen.dash_len = sizeof(EXTPEN_##name)/sizeof(*EXTPEN_##name); \ > + physDev->pen.dashes = HeapAlloc(GetProcessHeap(), 0, physDev->pen.dash_len); \ > + memcpy(physDev->pen.dashes, EXTPEN_##name, physDev->pen.dash_len);} \ > + else { \ > + physDev->pen.dash_len = sizeof(PEN_##name)/sizeof(*PEN_##name); \ > + physDev->pen.dashes = HeapAlloc(GetProcessHeap(), 0, physDev->pen.dash_len);\ > + memcpy(physDev->pen.dashes, PEN_##name, physDev->pen.dash_len);} > + That macro is ugly, please avoid it. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]
by Dmitry Timoshkov 17 Jul '07

17 Jul '07

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > /* test for switch maximized MDI children */ > + ShowWindow(mdi_client, SW_SHOW); > trace("creating maximized visible MDI child window 1(Switch test)\n"); > mdi_child = CreateWindowExA(WS_EX_MDICHILD, "MDI_child_class", "MDI child", > WS_CHILD | WS_VISIBLE | WS_MAXIMIZEBOX | WS_MAXIMIZE, Did you run the test under Windows after this change? For me this test doesn't pass under up to date XP neither in current, nor in new state. -- Dmitry.

2 11

Re: [PATCH 1/2] winepath: add option to output paths in the current Windows ANSI code page
by Alexandre Julliard 16 Jul '07

16 Jul '07

"Lei Zhang" <thestig(a)google.com> writes: > It's occasionally useful to be able to get the Windows path in the > Windows ANSI code page, so I added the --ansi command option to > winepath. The ansi code page is not supposed to leak out of a process. What do you need this for? -- Alexandre Julliard julliard(a)winehq.org

2 2

How should the win16 test suite be arranged?
by Dan Kegel 16 Jul '07

16 Jul '07

So we're collecting the existing win16 tests, updating and fixing them, and will post them to wine-patches sometime soon. At first, the test harness is going to be trivial: a top-level batch file to build all the tests with openwatcom c compiler (it's free, but not quite free enough to make it into debian), and another top-level batch file to run all the tests. (We'll also provide a batch file to install open watcom.) Given that not many developers will bother installing openwatcom just to be able to compile the win16 tests, I suspect that might be enough of a test harness for now. Objections? - Dan

2 4

SUBLANG Rules
by Colin Finck 16 Jul '07

16 Jul '07

Hello, The Wiki page at http://wiki.winehq.org/SublangNeutral says that specific SUBLANGs should be used for the languages Chinese, Norwegian and Portuguese. This is okay if you always have a translation specifically for every sublanguage of these languages, but we might run into problems if a translation for one of these sublanguages does not exist. For example if we have a translation for LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN, but don't have a translation for SUBLANG_PORTUGUESE_PORTUGAL and the user set his locale to "Portuguese (Portugal)", he will see the English translation, although we have a Brazilian Portuguese translation. If we would use SUBLANG_NEUTRAL here, the same translation would be used for both Portuguese variants. The question is now: What are the preferences of these users? Would it be better for them if they see the Brazilian Portuguese translation or the English one? The same goes for Chinese and Norwegian users, if we only have one translation for these languages. It would be nice if some native Chinese, Norwegian and Portuguese speakers could share their opinion about this. Best regards, Colin Finck

4 5

Re: programs/net: Add russian resources
by Dmitry Timoshkov 16 Jul '07

16 Jul '07

"Konstantin Kondratyuk" <kondratyuk(a)etersoft.ru> wrote: > Changelog: > add russian resources in programs/net Did you test this translation? You are using KOI8-R which won't work properly in russian resources. -- Dmitry.

2 1