July 2007 - Wine-devel - list.winehq.org

re: Direct3D Game test framework
by Dan Kegel 11 Jul '07

11 Jul '07

Michal Okresa wrote: >We (people around CxTest) think that extending CxTest is better approach >to achieve your goals rather than writing new application or modifying >existing. It could be done with smaller effort (in opposite of >AutoHotkey, AutoIt, ...) because CxTest is specialised for testing Wine >and CrossOver and it can deal with wine's specifics. I agree that CxTest has many good features, and that any tests we write should run under CxTest. However, I think it's useful and important for us to write tests that can easily be run with no complicated CxTest installation. I also think it's useful and important for us to be able to run our tests on Windows. That's why I started yawt; it's a single python source file that runs automated tests written in AutoHotkey (and a little python). It runs perfectly well on both Windows and Wine, and my goal is to make yawt plug in to CxTest so yawt tests can still easily be run on Windows or Linux standalone, *or* be run from inside the CxTest machinery. I'm sure there will always be some tests that are better written directly in CxTest, but I'm going to try to push yawt forward, too. With luck we'll have the two test systems working well together in a month or two. - Dan

2 2

configure complains about liblcms not being there
by Paul Vriens 11 Jul '07

11 Jul '07

Hi, Since the last patches to configure.ac and friends (I haven't seen the warnings before) I get: configure: liblcms development files not found. Wine will be built without Color Management support. (mscms.dll) It look like configure is checking for the availability of lcms.h: configure:6948: checking lcms.h usability configure:6965: gcc -m32 -c -Wcast-qual conftest.c >&5 configure:6971: $? = 0 configure:6985: result: yes configure:6989: checking lcms.h presence configure:7004: gcc -m32 -E conftest.c configure:7010: $? = 0 configure:7024: result: yes configure:7057: checking for lcms.h configure:7065: result: yes configure:6948: checking lcms/lcms.h usability configure:6965: gcc -m32 -c -Wcast-qual conftest.c >&5 conftest.c:65:23: error: lcms/lcms.h: No such file or directory Mine is at /usr/include/lcms.h (and it's found). Shouldn't that be enough to satisfy configure? I doubt anyone will have both. My version for lcms: lcms-1.16-3 lcms-devel-1.16-3 Any idea? Cheers, Paul.

4 6

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]
by Alexandre Julliard 11 Jul '07

11 Jul '07

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > + if ( GetThreadLocale() == CyrLCID ) > + { > + /* Create directory with Cyrillic long name */ > + helper_GetShortPathNameW( pathRL ); > + > + /* Create directory with Cyrillic short name */ > + helper_GetShortPathNameW( pathRS ); > + } > + else > + skip( "Not Cyrillic locale.Test skipped.\n" ); There's nothing specific about the Cyrillic locale in GetShortPathName; the only thing that could possibly matter is the file system encoding, but that's not the same thing. What are you trying to test here? -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [1/10] gdiplus: moved two helpers to gdiplus.c
by Alexandre Julliard 11 Jul '07

11 Jul '07

"Evan Stade" <estade(a)gmail.com> writes: > +inline INT roundr(REAL x) > +{ > + return (INT) floorf(x + 0.5); > +} > + > +inline REAL deg2rad(REAL degrees) > +{ > + return M_PI * degrees / 180.0; > +} If you want them to be inlined they should be defined in the header file. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel: use VirtualAlloc in GlobalAlloc16 to make such memory executable
by Alexandre Julliard 11 Jul '07

11 Jul '07

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > This patch is not enough to run Win16 programs on NX protected > systems as there is also some code placed in the UMB by > winedos/himem.c. I have a patch that makes the DOS area executable > (see bug #8744) but I will have to look if that's what Windows > does. In the mean time I'd like to know if there are some comments > about this patch. It's extremely wasteful, most GlobalAlloc blocks are fairly small. What you should do is allocate them from an executable heap instead of the default process heap. -- Alexandre Julliard julliard(a)winehq.org

1 0

Fw: shell32: implementation of SheGetDirA/W and SheChangeDirA/W
by Martin Fuchs 11 Jul '07

11 Jul '07

Hi, any hint why this patch was not yet applied? Regards, Martin On 13.05.2007 19:04:25 Martin Fuchs wrote: Changelog: implement SheGetDirA/W and SheChangeDirA/W in shell32 This functions are needed for the good old winfile.exe of NT4. Index: dlls/shell32/shlfileop.c =================================================================== ... -- Martin Fuchs fuchs.martin(a)gmail.com

1 0

Font changes?
by Andrew Talbot 10 Jul '07

10 Jul '07

I thought it useful to mention that if the rendering of your fonts has changed significantly (in the development build) since 4 July 2007, you might need to install the 32-bit development package for libXrender. -- Andy.

1 0

Error compiling Wine (current GIT)
by Paul Vriens 10 Jul '07

10 Jul '07

Hi, 'make depend && make' fails for me: make[2]: Entering directory `/wine/wine-git/dlls/gdiplus/tests' ../../../tools/makedep -C. -S../../.. -T../../.. brush.c graphicspath.c pen.c math.h: No such file or directory math.h was first included from graphicspath.c:24 make[2]: [Makefile] Error 1 (ignored) ../../../tools/makedep -C. -S../../.. -T../../.. brush.c graphicspath.c pen.c math.h: No such file or directory math.h was first included from graphicspath.c:24 make[2]: *** [depend] Error 1 make[2]: Leaving directory `/wine/wine-git/dlls/gdiplus/tests' make[1]: *** [gdiplus/tests/__depend__] Error 2 make[1]: Leaving directory `/wine/wine-git/dlls' make: *** [dlls/__depend__] Error 2 Following patch fixes the compile for me, but I'm not sure it's correct: diff --git a/dlls/gdiplus/tests/graphicspath.c b/dlls/gdiplus/tests/graphicspath.c index f7cfedb..d71aab8 100644 --- a/dlls/gdiplus/tests/graphicspath.c +++ b/dlls/gdiplus/tests/graphicspath.c @@ -21,7 +21,7 @@ #include "windows.h" #include "gdiplus.h" #include "wine/test.h" -#include "math.h" +#include "msvcrt/math.h" #define expect(expected, got) ok(got == expected, "Expected %.8x, got %.8x\n", expected, got) #define POINT_TYPE_MAX_LEN (75) Cheers, Paul.

2 1

Re: [kernel32] CreateProcess should always specify the child's current directory
by James Hawkins 10 Jul '07

10 Jul '07

On 7/9/07, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > This fixes an unusual bug where an older Winzip self-extracting > archive starts the executable just extracted in the wrong current > directory. > > Changelog: > * CreateProcess should always specify the child's current directory. > Tests would be nice. -- James Hawkins

1 0

Re[2]: EV_RXFLAG emulation
by Valentine Sinitsyn 10 Jul '07

10 Jul '07

Hi, UB> The problem with EV_RXFLAG is, that the UNIX spec doesn't know it (to my UB> knowledge). So most if not all kernel level drivers don't implement it. So UB> we have to workaround or propose a kernel driver change. Yeah, that's was what I wrote in the second item of the list (actually, for my own internal developments, I've just implemented missing ioctl() in the Linux TTY driver but I'm almost sure the change wouldn't get accepted upstream). The question is - what's a best way (in design terms: buffer serial I/O in ntdll/serial.c, at the server level etc - there are many ways to do the same thing and nearly all of them would probably work) to workaround the problem and I'm kindly asking someone with a decent knowledge of the Wine architecture at the whole to comment on my idea. UB> As the latter is probably harder then to write code that Alexandre accepts, UB> try to implement you proposal in a clean way. Start with adding test for the UB> test suite, that really run on the different Win Flavours. Than implement UB> your idea that make wine succeed in the test, and your test run on wine. That's a tough part - it implies that I must have those different Windows versions. UB> Otherwise, in 2000 Ove Karven did some implementation for EV_RXFLAG UB> http://source.winehq.org/source/misc/comm.c?v=wine20001002 UB> The code probably got lost in the move to handle devices in the server. Thanks, I saw this one. The idea is somewhat close to mine although implementation is different - I need to look further into it. Regards, Valentine Sinitsyn

1 0