July 2007 - Wine-devel - list.winehq.org

Re: programs/winefontcfg: Add winefontcfg (try 3)
by Paul Vriens 13 Jul '07

13 Jul '07

Nigel Liang wrote: > Hi, > > Some changes suggested by Dan. > > Changelist: > - Initialize non-static local arrays at runtime or make them static > - Use CompareStringW to do case-insensitive comparison > - Initialize some static variables before use and clear them after > - Rename a global variable > - Move some hard-coded strings into En.rc > - Got rid of some magic numbers in the code > - Use 4 space indentation > > -Nigel > > > ------------------------------------------------------------------------ > > Hi, You leak several registry handles in failure cases, for example in GetFilenameFromFacename: + if (lRet != ERROR_SUCCESS) { + WINE_TRACE("RegQueryValueExW facename: %s, returned: %ld\n", + wine_dbgstr_w(facename), lRet); + return 1; + } or ClearFontLinkRegistry: + if (lReturn != ERROR_SUCCESS) { + WINE_TRACE("RegSetValueExW returned: %ld\n", lReturn); + return 1; + } and a few more. Cheers, Paul.

1 0

Proposal to phase out *winehq.com email addresses
by Duane Clark 13 Jul '07

13 Jul '07

Due to the rather large amount of spam sent to the *winehq.com email addresses (as opposed to *winehq.org), I would like to phase them out. I will state up front that this proposal benefits only me or any future moderator. Since I have been doing that for about 6 years now, hopefully I'll get a bit of sympathy ;) A cursory inspection of postings to this list show that almost everyone already posts to *winehq.org. I would propose that for a few weeks, I'll simply keep track of where people are posting to, and send private emails to the very few who post to .com. Once everyone is posting to the .org address, I'll implement a filter in mailman that simply drops the others. I have already done this as a test on the announce, bugs, and cvs lists, and this eliminates about half of the spam. And while I am at it, anyone who wants to help with the moderation and is willing to stick with it for the long term, let me know.

5 6

Missing dependency at debian packages.
by Marcelo Boveto Shima 12 Jul '07

12 Jul '07

Hello Karl! I added lots of missing dependency on the debian packages. Would be nice to have the binary updated. This should fix lots of rsvg missing dependency. Regards Marcelo Shima

1 1

Re: dinput: Convert IDirectInput into multi-interface object.
by Stefan Dösinger 12 Jul '07

12 Jul '07

Am Donnerstag, 12. Juli 2007 06:51 schrieb Vitaliy Margolen: > Fixes bug 5920. > --- > dlls/dinput/dinput_main.c | 467 > +++++++++++++++++++++++++++--------------- dlls/dinput/dinput_private.h | > 6 +- > 2 files changed, 311 insertions(+), 162 deletions(-) Did you test which interfaces can be QueryInterfaced from which interface? In theory all interfaces should be queryable from all interfaces, but in practise Microsoft violates their own COM rules in ddraw, so I'd expect them to do so in other DirectX DLLs. In DDraw we do not(yet) implement the restrictions, but we have some todo_wine tests to document it.

2 1

ANNOUNCE: Wine/Mono Regression Test Suite
by Matt Jones 11 Jul '07

11 Jul '07

Hi Everyone - I'm working on getting mono to run happily under wine, thus opening wine (& linux) up to a much larger range of .NET applications. Unfortunately, mono-under-wine fails in rather cryptic ways at the moment, so I've found that running the mono regression test suite has given me a better idea of how to approach debugging mono/wine. Double unfortunately, running the mono regression test suite on linux, windows & wine presents a large series of interesting problems. So I've developed a python driver for the tests that spits out some html highlighting interesting test results and unifies the testing method on all three platforms. The code is available at [1] There is a git repository at [2] The scripts can generate static html pages for tests run, which are available at: [3] (you can download the entire set of gzipped pages from [4]) Many of the tests fail as a result of bug 8757, which causes mono to lock up while running a GC cycle. For now the scripts kill test cases after 5 minutes, but I've also included patches against wine to prevent the lockup (horrible hacks - disable modal message boxes & the debugbreak function). If you want to save time when running the tests, you can apply these patches in a git branch and test against that. The tests are designed to require little-to-no user interaction - after an initial linux & windows test run are performed (sample test data at [5]), an automated update script (nightly-update.sh) can be called to automatically update wine, run the tests and publish the results. Feedback is greatly appreciated - the tests are very temperamental, so it wouldn't surprise me at all if things break on other machines (I've tested pretty extensively and documented any non-automated actions necessary, but I want to make sure I didn't miss anything.) Thanks, Matt Jones [1] http://mhjones.org/wine/wine-tests/wine-test-reader.tar.gz [2] http://mhjones.org/wine/wine-tests/wine-test-reader.git [3] http://mhjones.org/wine/wine-tests/htmltest/index.py.html [4] http://mhjones.org/wine/wine-tests/htmltest.tar.gz [5] http://mhjones.org/wine/wine-tests/test-runs-example.tar.bz2

1 0

Re: shlwapi: Use publicly defined structure DATABLOCK_HEADER instead of redefining it locally
by James Hawkins 11 Jul '07

11 Jul '07

On 7/11/07, Thomas Weidenmueller <wine-patches(a)reactsoft.com> wrote: > Update the datablock list code to use the DATABLOCK_HEADER structure > defined in shlobj.h rather than re-defining it locally. > > - Thomas > > > You forgot the patch. -- James Hawkins

1 0

Re: winex11.drv: send proper file path for drag and drop
by Damjan Jovanovic 11 Jul '07

11 Jul '07

On 7/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > Drag and drop currently sends the file path as "\path\to\file" which > does not work properly for some applications. This patch converts the > file path to a proper Windows file path, i.e. z:\path\to\file. > I'm not sure we should even be trying to do anything special with the "text/plain" MIME type like extract a file list: that would generate WM_DROPFILES when you drag text into an application. My patch (http://www.winehq.org/pipermail/wine-cvs/2007-June/033705.html) that's already in wine 0.9.40 sends WM_DROPFILES on "text/uri-list" like the X file drag spec says. You're probably seeing the badly formed paths because both my code and the old code are both building CF_HDROP formats, and X11DRV_XDND_SendDropFiles just uses the first one in the list. So, the old code needs to go... Damjan

2 1

Performance testing experiences
by Stefan Dösinger 11 Jul '07

11 Jul '07

Hi, In the past days I've been actively hacking on automated performance testing. I have test scripts for Half Life 2, 3Dmark2000 and 3dmark2001 and a small z buffer test app. I am playing around with UT2004 and I want to take a look at plain old unreal tornament. I have the tests running on my old laptop and my amd 64 box. I want to extend that to my mac too. To collect some experience I've built a quick and dirty server "app", consisting of 200 lines of php, to get a better idea about what I want. Failed bechmark attempts are Half Life 1 and the codecreatures engine benchmark. Both failed because I did not find a way to write the results to a file. In HL1 this may work by marking a bit of text with the right mouse coords and copying it to clipboard. With codecreatures we're out of luck, unless we use OCR. Final Fantasy XI has the same problem, but I knew that already. My server side graphs can be seen here: http://84.112.174.163/~stefan/ The amd64/ and laptop/ folders contain folders for each test, which contains a result.php which calls gnuplot to generate graphs and build a formatted table. It's all highly inflexible and not meant as a permanent solution. Adding a new test or a new computer means major copypaste and find / replace work. Some problems I've come accross are recording cxtest scripts, which just does not work for games that need 3D in VNC. So I've written them by hand. Games for a big part also resist controllabiliy with the wait_window script. Some games just create their only window when they are started, and then take another X secounds to really start up and react to clicks or keypresses. wait_window causes a 1 secound X server freeze every few secounds, which invalidates benchmark results. For this reason I have put a sleep into the 3DMark2000 test script to freeze cxtest while the benchmark is running. Another problem is that the performance can be quite different from run to run with the same wine version. I'm not sure what causes this, but I will try to run the tests with everything else shut down. Failing that, we can still run all tests repeatadely and find an average result.

1 0

bug triaging
by James Hawkins 11 Jul '07

11 Jul '07

Hi, > ------- Additional Comment #3 From Austin English 2007-07-08 21:16 ------- > > Works fine in wine 0.9.40. > > > ------- Additional Comment #4 From Lei Zhang 2007-07-08 21:32 ------- > > Works here as well with wine 0.9.40 and a clean .wine directory. Ok folks, if you run an installer and it works for you, there's a pretty good chance that the bug has been fixed since the original report, especially if more than one person verifies that it's fixed. Go ahead and marked them fixed, and if the user is still experiencing the problem, they can always reopen the bug. -- James Hawkins

4 5

Re: msi: Add tests for adding properties with a transform during an install
by Paul Vriens 11 Jul '07

11 Jul '07

James Hawkins wrote: > Hi, > > Changelog: > * Add tests for adding properties with a transform during an install. > > dlls/msi/tests/install.c | 235 > ++++++++++++++++++++++++++++++++++++++++++++++ > include/msiquery.h | 5 + > 2 files changed, 240 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Hi James, this patch doesn't compile for me: install.o: In function `generate_transform': install.c:(.text+0x91ff): undefined reference to `MsiCreateTransformSummaryInfoA' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [msi_test.exe.so] Error 2 Is this because MsiCreateTransformSummaryInfo is a stub? Cheers, Paul.

1 0