October 2008 - Wine-devel - list.winehq.org

Re: Wine PulseAudio Driver
by Arthur Taylor 21 Oct '08

21 Oct '08

> Where are the patches? Should they have been attached here? Sorry, I guess I should have specified. The patches are in the bugzilla entry http://bugs.winehq.org/show_bug.cgi?id=10495 . The patches are too big for attaching. -- Arthur Taylor <theycallhimart(a)gmail.com>

1 0

Re: setupapi: Implement installing catalog files
by Alexandre Julliard 21 Oct '08

21 Oct '08

Maarten Lankhorst <maarten(a)codeweavers.com> writes: > + wintrust = LoadLibraryW(wintrust_dll); > + pCryptCATAdminAcquireContext = (void *)GetProcAddress(wintrust, "CryptCATAdminAcquireContext"); > + pCryptCATAdminAddCatalog = (void *)GetProcAddress(wintrust, "CryptCATAdminAddCatalog"); > + pCryptCATAdminReleaseCatalogContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseCatalogContext"); > + pCryptCATAdminReleaseContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseContext"); > + FreeLibrary(wintrust); I doubt that calling functions in an unloaded library is going to give good results... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [TRY 4] msvcrt: updated use of pmode flag in _s_open - set permissions of the file after it's been created.
by Alexandre Julliard 21 Oct '08

21 Oct '08

Ivan Peevski <cyberhorse(a)gmail.com> writes: > ChangeLog: > Followed the documentation at > http://msdn.microsoft.com/en-us/library/w7sa2b22(VS.80).aspx. First, > ignore pmode if the file already exist. Then, apply pmode permissions > to the file, once it has been created. This should be done by passing the right attributes to CreateFile. You shouldn't need a separate chmod call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: No response to updated patch for gdi32/StretchDIBits
by Sergey Novosyolov 21 Oct '08

21 Oct '08

В сообщении от Tuesday 14 October 2008 23:54:54 Mathias Kosch написал(а): > Hallo! > > About two weeks ago I tried to hand in a (corrected version of my) > patch for "StretchDIBits" [1]. > However it isn't accepted until now and I didn't yet notice any > response. > > Would someone please tell me what's wrong or if it was just missed out > accidentally? > > [1] http://www.winehq.org/pipermail/wine-patches/2008-September/062221.html Hi, Mathias. I'm working on DIB Engine for Wine. Some of DIB functions was developed separatly inthe DIB Driver, but it's necessary to develop DIB Engine functions inside GDI 32. What DIB function tests are you working on? Is it only "StretchDIBBits" or something else? I'm developing some DIB tests now and want to avoid any collisions with other developers in this bug.

1 0

Re: latest GIT
by chris ahrendt 21 Oct '08

21 Oct '08

Austin English wrote: > On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <celticht32(a)yahoo.com> wrote: > >> Anyone else having a problem compiling the latest git? >> >> mine has failed 2 times when I compile... one with a clean tree and one >> with an older tree.. >> >> chris >> >> >> >> __________________________________________________ >> Do You Yahoo!? >> Tired of spam? Yahoo! Mail has the best spam protection around >> http://mail.yahoo.com >> >> >> >> > > What error are you getting? What gcc version? > > so has anyone figured out why its broken yet? chris __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

3 2

Re: gdi32: fix a potential NULL pointer dereference
by Alexandre Julliard 21 Oct '08

21 Oct '08

"Austin English" <austinenglish(a)gmail.com> writes: > From bd4408eccc01418077727b75f8383fb4d03d2b90 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Mon, 20 Oct 2008 16:43:27 -0500 > Subject: [PATCH] gdi32: fix a potential NULL point dereference Please don't add NULL checks unless there's a demonstrated need. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 08/12] (resend) LookupAccountSidW() - handles first user account
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 08:29:47 Paul Bryan Roberts wrote: > The conformance tests for LookupAccountName() use LookupAccountSid() so > if the former is to support the 'first user account' SID then so must > the latter and the latter needs prior implementation. There's no guarantee that the first user account will have a RID of 1000. This is just what windows currently seems to use. That being said, the test cases work on a test machine of mine where RID 1000 is not assigned to the first user, so I won't complain. Perhaps the comment should mention that the RID pool starts at 1000 or somesuch. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 12/12] (resend) LookupAccountNameW() - accept account name of the form domain\user
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 08:30:27 Paul Bryan Roberts wrote: > The implementation is backed up with a new conformance case, which was > verified against W2K SP4. After the complete test series, the advapi32/tests/security.c tests pass fine against a Win2k3 DC. Thanks for pushing this further along. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 11/12] LookupAccountNameW() - refactor to eliminate code duplication
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 01:06:45 Paul Bryan Roberts wrote: > - FIXME("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), debugstr_w(lpAccountName), > + TRACE("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), debugstr_w(lpAccountName), > Sid, cbSid, ReferencedDomainName, cchReferencedDomainName, peUse); If you still consider this function a stub, please keep the FIXME, otherwise, please remove the "- stub" from the TRACE. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH 07/12] LookupAccountNameW() - NULL account name handled
by Kai Blin 21 Oct '08

21 Oct '08

On Tuesday 21 October 2008 01:05:34 Paul Bryan Roberts wrote: Hi Paul, I'm glad to see someone tackle this. One minor thing I have with this patch.. > + ok(sid_use == SidTypeDomain, "Expected SidTypeDomain, got %d\n", SidTypeDomain); seems like this should be ok(sid_use == SidTypeDomain, "Expected SidTypeDomain(%d), got %d\n", SidTypeDomain, sid_use); This was wrong before already, but perhaps you could fix that while touching that code anyway. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0