October 2008 - Wine-devel - list.winehq.org

Wine PulseAudio Driver
by Arthur Taylor 21 Oct '08

21 Oct '08

"If someone wants to write a pulseaudio driver, he should feel free to do so, but he should be aware that just writing a simple 20 line linear PCM out driver is not sufficient." http://bugs.winehq.org/show_bug.cgi?id=10495 I have written a waveout/in driver for wine to use pulseaudio which is in bugzilla. I would appreciate feedback on it, as I have received little thus far. I would appreciate it also if people took care to ensure that their instance of pulseaudio is properly setup before trying. Current problems include properly recovering from disconnects of both audio streams and server connections. WaveIn is currently buggy and usually has a larger latency. Multiple instances of one sink/source is also currently a problem. Currently WaveIn / WaveOut wodMessage / widMessage functions use "device IDs" which are basically array indexes of an array of available "devices." Without instance information it is hard to allow an application to open the same device more than once. Thanks - Art

6 14

Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)
by Jacek Caban 21 Oct '08

21 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > Clean up the get function. > Make sure we round down the value passed in. > Corrected test to prove above. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > + + V_VT(&v) = VT_I4; + V_I4(&v) = floor(f); + + if(VariantChangeType(&v, &v, 0, VT_BSTR) == S_OK) - It won't work for some locales - It's probably better to use sprintfW for this and set units to px for free + hres = get_style_attr(This, STYLEID_LEFT, &ret); + if(SUCCEEDED(hres)) + { + if(ret) + *p = atoiW(ret); + } - Your patch adds support only for px values, so you should check if we really return px value. Something like for(ptr=ret; isdigitW(*ptr); ptr++); if(*ptr || strcmp(ptr, pxW)) { FIXME(...); return E_NOTIMPL; } should be fine. - You leak ret - It's better to use get_nsstyle_attr_nsval to avoid one useless memory allocation. And you really want to move these function to separated functions like [get|set]_style_pos that would take styleid_t as an argument to avoid code duplication. Jacek

1 1

DOS game support - just needs a little VGA love?
by Dan Kegel 21 Oct '08

21 Oct '08

Hey, that CGA video support patch today from Peter Dons Tychsen, http://winehq.org/pipermail/wine-patches/2008-October/063417.html reminded me there's an old downloadable DOS game my wife likes to dig out every now and then. I tried it today and discovered that what's stopping it is support for a VGA feature, so I filed a bug: http://bugs.winehq.org/show_bug.cgi?id=15688 There are three other similar bugs, some with patches: http://bugs.winehq.org/buglist.cgi?product=Wine&component=dos&long_desc_typ… Getting old DOS games working might be pretty easy at this point if, like this game, they just need a little VGA love. Let's encourage newcomers to contribute in this area... it'd be fun to see those classic games running in wine. I added an entry to http://wiki.winehq.org/SummerOfCode for this, in case nobody does it before summer. - Dan

7 8

winedos interrupts getting lost.
by Peter Dons Tychsen 20 Oct '08

20 Oct '08

Hello. It starting with me trying to figure out why i was loosing keyboard events in winedos. 1) I then traced the keyboard events to a call to signal(SIGUSR2) in function DOSVM_QueueEvent(). 2) The signal() triggers code in ntdll, which generates an exception EXCEPTION_VM86_STI for the current vm86 context. 3) The exception is supposed to trigger exception_handler(), which will then handle the keyboard event, by kicking the event queue. This never happens however, as the mechanism stops working very quickly. I found out the code gets to raise_vm86_sti_exception in ntdll, and then stops. ntdll_get_thread_data()->vm86_ptr is NULL, so the STI exception is never signaled. Does anyone know more about the exception subsystem, and what could be causing this kind of strange behavior? I can mention that the system can generate EXCEPTION_VM86_INTx exceptions successfully, but fails to execute the EXCEPTION_VM86_STI. Thanks, /pedro

2 2

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
by Louis. Lenders 20 Oct '08

20 Oct '08

>Thank you for your answer. >I agree, that before sending a patch I should write a test first. >But the problem is that even a tests are ignored without any explanation. >Maybe my tests aren't good, but why anybody just tell what's wrong. Seems to be common habit on this list. I hope you're not added to the "Julliard ranking s**t list? Yes: REJECT" ( see http://www.winehq.org/?issue=353#WineConf%202008%20Keynote ) like i am. Spent loads of time for more than 3 years trying to help triaging bugs and helping out in appdb, only to find out that all my patches are ignored silently, but everybody seems to be happy with this policy, so i'll stop complaining. Personally this makes me quite sad. Hope you have more luck with your patches. > Have you tried asking on the #winehackers IRC channel? >No, I doesn't use IRC. It's very hard to me to write in english in real-time If people spent quite an amount of time trying to get a patch written, it shouldn't be too much trouble to just drop a note on wine-devel, what the reason is the patch got rejected. But i guess this takes more time then "the few seconds to see that the code is correct? If today is a busy day: IGNORE" Great feedback... >Ok, I try to resend my old tests, and write tests to other patches. >Also there are some functions and stubs implemented, wchich doesn't require >(as I think) a tests. Send instant messages to your online friends http://uk.messenger.yahoo.com Send instant messages to your online friends http://uk.messenger.yahoo.com

4 4

[RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.
by Rob Shearman 20 Oct '08

20 Oct '08

The rule is implemented by FunctionExpression which is reduced using the Statement rule. --- dlls/jscript/parser.y | 37 ------------------------------------- 1 files changed, 0 insertions(+), 37 deletions(-) The tests pass with this change, but I haven't looked in detail as to whether it will break anything. Jacek, can you check that your applications that use jscript still work after this patch is applied?

2 4

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.
by Alexandre Julliard 20 Oct '08

20 Oct '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index 4756d7d..bc1b1d6 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -128,7 +128,7 @@ HKCR,folder\shell\open\ddeexec,,2,"[ViewFolder("%l", %I, %S)]" > HKCR,folder\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,folder\shell\open\ddeexec\application,,2,"Folders" > HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1" > -HKCR,htmlfile\shell\open\command,,2,"%11%\winebrowser.exe -nohome" > +HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome" > HKCR,htmlfile\shell\open\ddeexec,,2,"""%1"",,-1,0,,,," > HKCR,htmlfile\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,htmlfile\shell\open\ddeexec\Application,,2,"IExplore" This isn't look right, the entry works just fine without quotes, we shouldn't have to add them just to satisfy a test. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]
by James Mckenzie 20 Oct '08

20 Oct '08

Andrey Turkin <andrey.turkin(a)gmail.com> on Oct 20, 2008 1:02 AM wrote about Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW] > >2008/10/20 James McKenzie <jjmckenzie51(a)earthlink.net> > >> Was this ever processed through Patchwatcher? >> >> James McKenzie >> >> -------- Original Message -------- >> Subject: mpr: fix NULL pointer dereference in >> WNetGetResourceInformationW >> Date: Tue, 07 Oct 2008 20:18:00 +0400 >> From: Andrey Turkin <andrey.turkin(a)gmail.com> >> Reply-To: wine-devel(a)winehq.org >> To: wine-patches <wine-patches(a)winehq.org> >> >> >> >> The dereference was spotted by Anastasius Focht in bug 13737; this patch >> fixes this bug. >> --- >> dlls/mpr/wnet.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >Yes, the mail is at http://kegel.com/wine/patchwatcher/results/3193.txt and >log is at http://kegel.com/wine/patchwatcher/results/3193.log . >Why, was there any problems with this patch? > >Regards, > Andrey > Thank you. I could not find it last night when I was reviewing PatchWater entries. James McKenize

1 0

today build's broken for me
by Nikolay Sivov 20 Oct '08

20 Oct '08

make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: error: ‘gnutls_transport_set_errno’ undeclared here (not in a function) schannel.c:61: warning: type defaults to ‘int’ in declaration of ‘pgnutls_transport_set_errno’ schannel.c: In function ‘schan_pull’: schannel.c:571: error: called object ‘pgnutls_transport_set_errno’ is not a function schannel.c: In function ‘schan_push’: schannel.c:593: error: called object ‘pgnutls_transport_set_errno’ is not a function make[2]: *** [schannel.o] Error 1 make[2]: Leaving directory `/home/mrlarch/wine/dlls/secur32' make[1]: *** [secur32] Error 2 make[1]: Leaving directory `/home/mrlarch/wine/dlls' make: *** [dlls] Error 2 I'm using libgnutls-dev 1.4.4-3 from etch.

3 2

Today's git won't install DNS10 - IE not found
by Susan Cragin 20 Oct '08

20 Oct '08

I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. The popup messages says that IE 5 or greater is needed. wine-1.1.6-379-g07badc7 Susan fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x1315d0 0x33f88c 0x1320a8 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e1897c4) using GetSystemInfo() fixme:msi:ACTION_HandleStandardAction unhandled standard action L"SetODBCFolders" fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts -> 1 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub MsiUnpublishAssemblies -> 6 ignored L"MsiAssembly" table values fixme:advapi:LookupAccountNameW (null) L"susan" (nil) 0x33f88c (nil) 0x33f890 0x33f884 - stub fixme:advapi:LookupAccountNameW (null) L"susan" 0x133890 0x33f88c 0x132058 0x33f890 0x33f884 - stub fixme:reg:GetNativeSystemInfo (0x7e07b7c4) using GetSystemInfo() fixme:actctx:parse_depend_manifests Could not find dependent assembly L"Microsoft.VC80.MFCLOC" err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. fixme:msi:MsiGetMode 1 2 err:msi:ITERATE_Actions Execution halted, action L"LaunchConditions" returned 1603 susan(a)ubuntu:~/DNS10$

2 1