October 2008 - Wine-devel - list.winehq.org

Re: kernel32/tests: Actually store the return value before using it.
by Paul Vriens 07 Oct '08

07 Oct '08

Kai Blin wrote: > --- > dlls/kernel32/tests/locale.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Kai, Already sent a patch for this : http://www.winehq.org/pipermail/wine-patches/2008-October/062613.html -- Cheers, Paul.

1 0

Re: kernel32/tests: Actually store the return value before using it.
by Kai Blin 07 Oct '08

07 Oct '08

On Tuesday 07 October 2008 06:46:06 Kai Blin wrote: > --- > dlls/kernel32/tests/locale.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) I forgot to mention that Coverity found this one. Alexandre, can you please add (Coverity) to the subject before the commit? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: mapi32: initialize session pointer to zero in MAPILogonEx (3nd resend (added extra spaces))
by James Hawkins 07 Oct '08

07 Oct '08

2008/10/6 Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk>: > fixes a crash reported on userlist: > http://forum.winehq.org/viewtopic.php?t=2447 > > As the function is a complete stub, it's probably a good ides to initialize > it to zero anyway. > You haven't addressed the concerns pointed out by Juan. -- James Hawkins

1 0

Re: [user32/tests] Fix failures on W2K and below
by Dmitry Timoshkov 07 Oct '08

07 Oct '08

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > (Independent from the other user32/tests patch "Run tests on win95 again"). > > Basically the same patch/logic as in commit > 5cf418f5218d46e28c00f15ba2eb5748888794f6 but now for user32. The GetProcAddress > is needed as GetComboBoxInfo is not available on win95. > > I've also changed the ok() test to test for all outcomes of the > SendMessageA(hCombo, CB_ADDSTRING, 0, (LPARAM)&buffer). That's of course is not your fault, but the above SendMessage call is invalid, it should be SendMessageA(hCombo, CB_ADDSTRING, 0, (LPARAM)buffer) instead, notice the removal of '&'. -- Dmitry.

1 0

Re: [1/5] msxml3/tests: Valgrind fix.
by James Hawkins 07 Oct '08

07 Oct '08

On Mon, Oct 6, 2008 at 5:48 PM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > sName is an uninitialized pointer if GetMemberName faild. > --- > dlls/msxml3/tests/domdoc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index 1ad168b..0703f3d 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -1565,7 +1565,8 @@ static void test_getElementsByTagName(void) > > r = IDispatchEx_GetMemberName(dispex, dispid, &sName); > ok(r == E_NOTIMPL, "expected E_NOTIMPL got %08x\n", r); > - SysFreeString(sName); > + if( !FAILED(r) ) > + SysFreeString(sName); > aka SUCCEEDED(r). -- James Hawkins

1 0

Re: msi: Added MsiInstallMissingComponentW stub implementation.
by James Hawkins 07 Oct '08

07 Oct '08

On Mon, Oct 6, 2008 at 4:05 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/msi/msi.c | 9 +++++++++ > dlls/msi/msi.spec | 2 +- > include/msi.h | 4 ++++ > 3 files changed, 14 insertions(+), 1 deletions(-) > +{ + FIXME("(%s %s %d\n", debugstr_w(szProduct), debugstr_w(szComponent), eInstallState); + return ERROR_SUCCESS; +} Missing the closing parenthesis on the format string. -- James Hawkins

1 0

Translation Patches for wine-1.0.1
by Michael Stefaniuc 06 Oct '08

06 Oct '08

Hello Alexandre, please cherry-pick the attached list of translation patches into the "stable" aka wine-1.0.x branch. Some of the patches seem to be already cherry-picked but as a git cherry-pick will just do nothing for those I didn't bother to find them and remove them. The list was generated by the attached shell script. It isn't beautiful nor fast but it gets the job done. The idea was to get all the patches that touch a language rc file up to but not including the first patch that modified the En.rc. That way it was trivial to make sure that the translation patch doesn't breaks the translation. The patches were cherry-picked onto a branch tracking "origin/stable", the generated commits were visually inspected and a "git diff --stat origin/stable.." shows only .rc files were modified. The resulting tree was compile tested with "wrc --verify-translation" and there were no DIFF or ERR lines introduced (means no translation errors). bye michael 2cb5773d7baefd56b4d83cbee63231569aa93fe1 shell32: Update Russian translation. 605d1e2f1e869927f9fe6d6fa74d5f35cbbf820c mshtml: Update Russian translation. 56c1ea6af415e76bfe562f796543c7dce87503bd regedit: Update Russian translation. 30899341cd6e6753f159dcf806c0cbb1f6bf7f94 winhlp32: Update Polish translation. ad0c267f748339f98fb27af11637284de1016674 oleview: Add Russian translation. 87b5e9448034e580f45541f4bf649604b89fc72e taskmgr: Add Russian translation. 2eee5fbfbe650541b3589f011bba2a589148f490 hhctrl.ocx: Update Russian translation. 872077674921c3e813b6be6760ec06b036606b58 notepad: Update simplified Chinese resource. f9bc73e25f549a8cf225929c269ee390b302c9e4 notepad: Update Japanese translation. b46ffb40c654e9175ebcffb6691660385641d4f7 clock: Update simplified Chinese resource. 5070763a0ea27934a350659658bdf995603de75b winefile: Update simplified Chinese resource. 1897f8369aa8f2abad0711c4e3863c52321072bc winconsole: Update simplified Chinese resource. d9e45488f62ede4b5801f39ee2c117266a6e0136 progman: Update simplified Chinese resource. d24b6e424fef650747fe1b37699f4570b9c1516f user32: Update simplified Chinese resource. 7fe167eeae1cb4a5659cc7f8c5fdf024403f6a24 comdlg32: Update simplified Chinese resource. a8a359ac6860f1801b7030ae427cee4c3246a7d2 comctl32: Update simplified Chinese resource. 7654b6aa7243f55ce9b01bdd65258f48c83e0cca comdlg32: Update Japanese translation. 4b8134a2427183c7b24d93127440e7a5aea3f7c5 user32: Update Japanese translation. 0eaabac5457467e7a53eafb6d0f8c4164f27f16d wineconsole: Convert simplified Chinese resource to utf8. 252243e932474d43e267ef4f82e24f3f0c3953c3 winefile: Convert simplified Chinese resource to utf8. 50b6ed4bb6b83f30ee2f9b5db9c239f17fc1a974 progman: Convert simplified Chinese resource to utf8. e2f5ab434ab775fe2cf8a72b587a2b14ae20c10e comctl32: Convert simplified Chinese resource to utf8. e3712879719faed51116bef658d7aafd81057b9c notepad: Convert simplified Chinese resource to utf8. 1ae5258472b2e421dcd64db890d932aef2a3ccd0 comdlg32: Convert traditional Chinese resource to utf8. 27670e715a7cc685ba643b6d7798000f198bab4f comdlg32: Convert simplified Chinese resource to utf8. adb63f9e8780d2d8451d91d84f42e4088f9bd334 user32: Convert Chinese resource to utf8. c808b9063a01ae27f557583671248a60caeeb9db clock: Convert simplified Chinese resource to utf8. 0b091fa5cb4d9d89d7779aa96eb2208f7e86dbe8 clock: Add traditional Chinese resource. c75fde2c0ab5421ae142ee5150497a058e4ed82d progman: Add traditional Chinese resource. e0676d2777904f843e7ced33eb77d14930996bcf winefile: Add traditional Chinese resource. a10d6ede6858b4fd7bc9e60dcb2899ab5c9b9d8e wineconsole: Add traditional Chinese resource. ecc1bf3d0e5a80f8e7de1dbfc5335296b55a9c0d notepad: Add traditional Chinese resource. 11295e708fcb17e10e803e7e6d1dc0332d7bec97 user32: Update traditional Chinese resource. b76433452ca239ef1cab06177b00586381af550c comdlg32: Update traditional Chinese resource. 698e8727513012d23e50ad242d93722042d45700 comdlg32: Update simplified Chinese resource. f4d2477b6c41cd9bbb299100d254c71b1670a4f0 comdlg32: Merge Chinese resources into a single file. c5ef467f4dd6d1d225294289f78113c5fd1eed7d comctl32: Rename the Chinese resources to comctl_Zh.rc. 5f680f92e50792b1bc79143d108b83085486f938 comdlg32: Update simplified Chinese resource. 0ef830d66b8e35d4687d508ef0db3734ef6100cd notepad: Update Chinese resources - dialog font. 0a11607dc85fbaad3ada576e68ad453e39772201 wineboot: Add simplified and traditional Chinese resources. d6017c1bedfffa09ffe9016201e7339e783a826d view: Add simplified and traditional Chinese resources. c8bafc3817abdcc32c0631044a198acd8c574d96 notepad: Remove spaces before '\n' in the Chinese resources. 874ff81640d1b4493911512e4cd0d93b79355007 comdlg32: Update Japanese translation. baf3460459c132acd7ceb4b77024bd2902f69db9 credui: Add simplified and traditional Chinese resources. ee288272a501e3a01a6ad331240a74d2c447df83 htctrl: Add simplified and traditional Chinese resources. 2c248cb0b1cef56d5406cd30d7ebfd909751532e localspl: Add simplified and traditional Chinese resources. cd01bf429180c7e04d066d6756879ec3978a5911 localui: Add simplified and traditional Chinese resources. 24a26a1435ee27ca1f01fda3b22cff0bdfb270dd mpr: Add simplified and traditional Chinese resources. dd0239e6cedd662cd1f7f8d96b9571cb00d70fb1 msacm32: Add simplified and traditional Chinese resources. 9eb3a9c1573455dcd4317a1e31fec9ce2b240a7d msi: Add simplified and traditional Chinese resources. 275a454823b296726c0948537a5ec1f9dbe7c8e4 oleaut32: Add simplified and traditional Chinese resources. 68aba12fb16d920bf39a2dccc5d690baca3d980b serialui: Add simplified and traditional Chinese resources. 4648b353e4cfcb0a128af35904ef3e54487a59cc setupapi: Add simplified and traditional Chinese resources. 7d35b15539530979533da3abb92ac1b33251c74d shlwapi: Add simplified and traditional Chinese resources. 2656c02dd64dc7a7acbfef4bfa2c27669ba55c59 winspool: Add simplified and traditional Chinese resources. fcb488f3f82ee44277c5efa615de3ebe5aab15f9 notepad: Update Japanese translation. 8d97c6e1abdf738f5f76648f37b0eb2d142bae6f wininet: Update Japanese translation. 3a6373d1a8942263453acad7f920c7357740bf78 view: Add Japanese resources. 48dfff85771ed9e915f0ffe62576fa8512b38af9 cmdlgtst: Add Japanese resources. 2ca3a80ba8d14ff89a732b367322343d3ff616d0 comdlg32: Update Japanese translation. 521ad0c7e5e693bb8da90addaca3d00377a7f5d8 wineboot: Use "MS Shell Dlg" 9 in Japanese resources. f94ab4f482c87021fc0070a1b5d51f3731140b09 notepad: Use "MS Shell Dlg" 9 in Japanese resources. 5fb9ed227d77c96ead8857ebb561541293d3e950 avifil32: Use "MS Shell Dlg" 9 in Japanese resources. 8448a9f1f4dd468ec5bfae8447fc9ec2f1637a18 setupapi: Use "MS Shell Dlg" 9 in Japanese resources. bcff2eb2880f7c9d3a3a56af96b269f5554ae8f6 user32: Use "MS Shell Dlg" 9 in Japanese resources. 4d41ea4f7b7307421ab3d874fe7cd1765717855e wineps.drv: Use "MS Shell Dlg" 9 in Japanese resources. 6c0c3fdaace2a34a68ad364043f9f77c5b6a1515 wininet: Use "MS Shell Dlg" 9 in Japanese resources. adb32f76fc05b7db2939f15caf56f2bbceb5da85 comctl32: Use "MS Shell Dlg" 9 in Japanese resources. d1fbd962431cd3db0d7d548eff733251575dafc0 msacm32: Use "MS Shell Dlg" 9 in Japanese resources. 7d6c52d6472a9527257279594bc626a6a70f32bf oledlg: Use "MS Shell Dlg" 9 in Japanese resources. 10c996acbfe39bd4672b028e45de4a72dd63a671 serialui: Use "MS Shell Dlg" 9 in Japanese resources. 7ddd48da2d1ec12b7cc0896cf0ef97481c2fc672 shlwapi: Use "MS Shell Dlg" 9 in Japanese resources.

1 0

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)
by Juan Lang 06 Oct '08

06 Oct '08

Hi Louis, this isn't about spaces this time. diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c index 936d435..5aace9a 100644 --- a/dlls/mapi32/mapi32_main.c +++ b/dlls/mapi32/mapi32_main.c @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam, LPWSTR profile, { FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam, debugstr_w(profile), password, flags, session); + *session=0; return SUCCESS_SUCCESS; } Are you guaranteed that session is not NULL? A test case would help. --Juan

1 0

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)
by Louis. Lenders 06 Oct '08

06 Oct '08

----- Original Message ---- From: Juan Lang <juan.lang(a)gmail.com> To: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Cc: wine-devel(a)winehq.org Sent: Monday, 6 October, 2008 13:36:52 Subject: Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend) > diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c > index 936d435..5aace9a 100644 > --- a/dlls/mapi32/mapi32_main.c > +++ b/dlls/mapi32/mapi32_main.c > @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam, > LPWSTR profile, > { > FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam, > debugstr_w(profile), password, flags, session); > + *session=0; > return SUCCESS_SUCCESS; > } > > The rest of the file uses ' = 0', so please stay consistent. Also, the indenting is inconsistent: the function uses 2-space indenting, whereas your change uses 4-space indenting. Please match the file's existing style. --Juan Sorry , i don't understand what you mean with that comment above. When i apply the patch i get the code below: HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam, LPWSTR profile, LPWSTR password, ULONG flags, LPMAPISESSION *session) { FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam, debugstr_w(profile), password, flags, session); *session=0; return SUCCESS_SUCCESS; } I don't see any 2-space nor 4-space indention introduced by this patch. I'll try to be more consistent with all this "space-thing" stuff, but is it now policy to reject patches because of missing/too much spaces? I'm just trying to fix a bug you know....... I'll resend this patch, as for the other patch, i sent it in 5 times already, 2 times because of changing "stylish things" i was requested, then 3 times resend because it was not applied and i didn't receive any comments anymore about it. I don't think it's good idea to spam the list with just another resend, if there's another reason why it was rejected i'd be happy to know about it........

3 2

Re: wined3d: quiet a noisy fixme
by Henri Verbeet 06 Oct '08

06 Oct '08

2008/10/6 Austin English <austinenglish(a)gmail.com>: > - if(DepthStencilFormat != WINED3DFMT_D24S8) > - FIXME("Add OpenGL context recreation support to SetDepthStencilSurface\n"); > > + if(DepthStencilFormat != WINED3DFMT_D24S8) { > + if (warn) { > + FIXME("Add OpenGL context recreation support to SetDepthStencilSurface\n"); > + warn = FALSE; > + } > + } Style issues aside, I don't think so. That FIXME is quite valid, and doesn't get printed *that* often. If you don't want to see the output, run with WINEDEBUG=-all, it should give a small performance boost as well.

3 2