October 2008 - Wine-devel - list.winehq.org

Re: [PATCH 17/17] mshtml: Added DispHTMLIFrame dispinterface declaration.
by Austin English 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 9:54 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > include/mshtmdid.h | 12 + > include/mshtml.idl | 957 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 969 insertions(+), 0 deletions(-) > > > > + [propget, id(DISPID_IHTMLELEMENT2_ONROWSINSERTED), displaybind, bindable] + VARIANT onrowsinserted(); + Extra space before VARIANT

2 1

Re: [PATCH 04/17] mshtml: Use IDs instead of strings in HTMLStyle implementation.
by Austin English 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 9:48 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/mshtml/htmlstyle.c | 108 > ++++++++++++++++++++++++++++------------------- > dlls/mshtml/htmlstyle.h | 21 +++++++++ > 2 files changed, 85 insertions(+), 44 deletions(-) > > > > +/* NOTE: Make sure to keep in sync with stryle_strings in htmlstrle.c */ s/stryle_strings/style_strings && s/htmlstrle.c/htmlstyle.c -Austin

2 1

Re: [PATCH 01/17] mshtml.idl: Added DispHTMLCurrentStyle dispinterface declaration.
by Austin English 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 9:47 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > include/mshtmdid.h | 26 ++++ > include/mshtml.idl | 355 > +++++++++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 380 insertions(+), 1 deletions(-) > > > > + [propget, id(DISPID_IHTMLCURRENTSTYLE_TEXTKASHIDA), displaybind, bindable] + VARIANT textKashida(); + Missing a leading space before VARIANT. -Austin

1 0

Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd resend)
by Austin English 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 12:26 PM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > > 2nd resend. If the patch is wrong, could you just tell me what's wrong with > it? Might be handier, then me having to guess what's wrong... > > > As the function is a complete stub, it's probably a good idea to initialize > it to zero anyway. > > > > > > diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c index 936d435..5aace9a 100644 --- a/dlls/mapi32/mapi32_main.c +++ b/dlls/mapi32/mapi32_main.c @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam, LPWSTR profile, { FIXME("(0x%08lx %s %p 0x%08x %p) Stub\n", uiparam, debugstr_w(profile), password, flags, session); + *session=0; return SUCCESS_SUCCESS; } The rest of the file uses ' = 0', so please stay consistent. - Austin

2 1

Re: msi:add stub for MsiDetermineApplicablePatches{A,W} (3rd resend)
by Austin English 06 Oct '08

06 Oct '08

On Mon, Oct 6, 2008 at 12:23 PM, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > 3rd resend. If the patch is wrong, could you just tell me what's wrong with > it? Might be handier, then me having to guess what's wrong... > > > > > > +typedef enum tagMSIPATCHDATATYPE +{ + MSIPATCH_DATATYPE_PATCHFILE = 0, + MSIPATCH_DATATYPE_XMLPATH = 1, + MSIPATCH_DATATYPE_XMLBLOB =2, +} MSIPATCHDATATYPE, *PMSIPATCHDATATYPE; + Missing a space before the 2.

1 0

re: Wineconf follow up: Cosmetic website changes
by Dan Kegel 06 Oct '08

06 Oct '08

That's right, I foolishly volunteered to put together a draft for winehq.org's front page inspired by openoffice.org's front page. The main constraint discussed at wineconf was that the site navigation should not change with this redesign ('cause that requires lots more work). Also, it's inaccurate to call this a cosmetic change; it's really driven by usability concerns. I have a sneaking suspicion that http://wiki.winehq.org is at this point a better place to send beginners to than http://winehq.org, and that's just wrong... our simplest URL should also be our best foot forward. - Dan

3 4

Re: [6/9] Add usbd.sys.
by Rob Shearman 06 Oct '08

06 Oct '08

2008/10/6 Alexander Morozov <amorozov(a)etersoft.ru>: > +@ stdcall _USBD_CreateConfigurationRequestEx\@8(ptr ptr) USBD_CreateConfigurationRequestEx ... > +@ stdcall _USBD_ParseConfigurationDescriptorEx\@28(ptr ptr long long long long long) USBD_ParseConfigurationDescriptorEx > +@ stub _USBD_ParseDescriptors\@16 The stdcall calling convention specifies a decoration of a leading underscore and an @ followed by the number of bytes to push onto the stack, which is added automatically by winebuild. Is there a reason why you are adding this on yourself? Even if there is a good reason, you don't need to quote the @ symbols. -- Rob Shearman

2 1

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests (try3)
by Dmitry Timoshkov 06 Oct '08

06 Oct '08

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: First of all there is no need to send the configure.ac patch separately. > + /* zero role number - not documented */ > + ret = GetRoleTextA(0, NULL, 0); > + ok(ret > 0, "GetRoleTextA doesn't return length for zero role number, got %d\n", ret); > + ret = GetRoleTextW(0, NULL, 0); > + ok(ret > 0, "GetRoleTextW doesn't return length for zero role number, got %d\n", ret); > + > + /* NULL buffer, return length */ > + ret = GetRoleTextA(ROLE_SYSTEM_TITLEBAR, NULL, 0); > + ok(ret > 0, "GetRoleTextA doesn't return length on NULL buffer, got %d\n", ret); > + ret = GetRoleTextA(ROLE_SYSTEM_TITLEBAR, NULL, 1); > + ok(ret > 0, "GetRoleTextA doesn't return length on NULL buffer, got %d\n", ret); > + ret = GetRoleTextW(ROLE_SYSTEM_TITLEBAR, NULL, 0); > + ok(ret > 0, "GetRoleTextW doesn't return length on NULL buffer, got %d\n", ret); > + ret = GetRoleTextW(ROLE_SYSTEM_TITLEBAR, NULL, 1); > + ok(ret > 0, "GetRoleTextW doesn't return length on NULL buffer, got %d\n", ret); If you mean that the above tests do test that the returned value is the length of the string that's not true, ret > 0 doesn't mean anything. > + /* use bigger buffer */ > + ret = GetRoleTextA(ROLE_SYSTEM_TITLEBAR, NULL, 0); > + buff = HeapAlloc(GetProcessHeap(), 0, 2*ret); > + buff[2*ret-1] = '*'; > + ret = GetRoleTextA(ROLE_SYSTEM_TITLEBAR, buff, 2*ret); > + ok(buff[2*ret-1] == '*', "GetRoleTextA shouldn't fill buffer with NULLs\n"); > + HeapFree(GetProcessHeap(), 0, buff); > + > + ret = GetRoleTextW(ROLE_SYSTEM_TITLEBAR, NULL, 0); > + buffW = HeapAlloc(GetProcessHeap(), 0, 2*ret*sizeof(WCHAR)); > + buffW[2*ret-1] = '*'; > + ret = GetRoleTextW(ROLE_SYSTEM_TITLEBAR, buffW, 2*ret); > + ok(buffW[2*ret-1] == '*', "GetRoleTextW shouldn't fill buffer with NULLs\n"); > + HeapFree(GetProcessHeap(), 0, buffW); > +} You are confusing yourself in the above tests. What that 2*ret and 2*ret*sizeof(WCHAR) above values are supposed to mean? Besides you never check the 'ret' for a presumably expected result. -- Dmitry.

2 5

Re: quartz: check hr so we are not incrementing a NULL (coverity 106)
by Dmitry Timoshkov 06 Oct '08

06 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > - wszPatternString++; /* skip ',' */ > + if (hr == S_OK) > + wszPatternString++; /* skip ',' */ > > if (hr == S_OK) > { Why not just move it into the below block? -- Dmitry.

2 1

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests
by Dmitry Timoshkov 06 Oct '08

06 Oct '08

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > +UINT WINAPI GetRoleTextA(DWORD role, LPSTR lpRole, UINT rolemax) > +{ > + UINT length; > + WCHAR *roletextW; > + CHAR *roletextA; > + > + TRACE("%u %p %u\n", role, lpRole, rolemax); > + > + length = GetRoleTextW(role, NULL, 0); > + if(length == 0) > + return 0; > + > + roletextW = HeapAlloc(GetProcessHeap(), 0, (length + 1)*sizeof(WCHAR)); > + if(!roletextW) > + return 0; > + > + GetRoleTextW(role, roletextW, length + 1); > + > + length = WideCharToMultiByte( CP_ACP, 0, roletextW, -1, NULL, 0, NULL, NULL ); > + > + if(!lpRole){ > + HeapFree(GetProcessHeap(), 0, roletextW); > + return length - 1; > + } > + > + roletextA = HeapAlloc(GetProcessHeap(), 0, length); > + WideCharToMultiByte( CP_ACP, 0, roletextW, -1, roletextA, length, NULL, NULL ); > + > + if(rolemax < length) > + length = rolemax; > + > + memcpy(lpRole, roletextA, length); > + lpRole[length-1] = '\0'; > + > + HeapFree(GetProcessHeap(), 0, roletextA); > + HeapFree(GetProcessHeap(), 0, roletextW); > + > + return length - 1; > +} Why do you need to allocate an intermediate roletextA? -- Dmitry.

2 12