October 2008 - Wine-devel - list.winehq.org

Please Review WWN 353
by Zachary Goldberg 06 Oct '08

06 Oct '08

All, This WWN is all my writing and no quotes, and thus a lot more room for typographical and other errors. Thus I wanted to send everybody the WWN for review before publication. In particular please check the first section for name typos etc. http://home.bluesata.com/WineWWN/WineHQ/?issue=353 -Zach

4 3

Re: [PATCH] also remove backbuffer flags in the v1 DDRAW interface
by Austin English 06 Oct '08

06 Oct '08

On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008 > by also filtering out the backbuffer flag. > > Ciao, Marcus > --- > dlls/ddraw/ddraw_thunks.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c > index b748ad4..c77b3bb 100644 > --- a/dlls/ddraw/ddraw_thunks.c > +++ b/dlls/ddraw/ddraw_thunks.c > @@ -386,10 +386,10 @@ IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc, > IDirectDrawSurfaceImpl *impl; > HRESULT hr; > > - /* Remove front buffer flag, this causes failure in v7, and its added to normal > - * primaries anyway > + /* Remove front and back buffer flag, this causes failure in v7, > + * and its added to normal primaries anyway. Nitpick, but typo there: should be "it's", not "its" -Austin

2 1

Re: [1/2] user32: Converted rcScrollBar to screen coordinates.
by Dmitry Timoshkov 06 Oct '08

06 Oct '08

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > @@ -1252,6 +1253,9 @@ static BOOL SCROLL_GetScrollBarInfo(HWND hwnd, LONG idObject, LPSCROLLBARINFO in > > SCROLL_GetScrollBarRect(hwnd, nBar, &info->rcScrollBar, &nDummy, > &info->dxyLineButton, &info->xyThumbTop); > + /* rcScrollBar needs to be in screen coordinates */ > + GetWindowRect(hwnd, &rect); > + OffsetRect(&info->rcScrollBar, rect.left, rect.top); You need to fix SCROLL_GetScrollBarRect for the SB_CTL case instead. > +static void scrollbar_test4(void) > +{ > + BOOL ret; > + SCROLLBARINFO sbi; > + RECT rect; > + > + /* Test GetScrollBarInfo to make sure it returns rcScrollBar in screen > + * coordinates. */ > + sbi.cbSize = sizeof(sbi); > + ret = GetScrollBarInfo( hScroll, OBJID_CLIENT, &sbi); > + ok( ret, "The GetScrollBarInfo() call should not fail.\n" ); > + GetWindowRect( hScroll, &rect ); > + ok( ret, "The GetWindowRect() call should not fail.\n" ); > + ok( !(sbi.rgstate[0] & (STATE_SYSTEM_INVISIBLE|STATE_SYSTEM_OFFSCREEN)), > + "unexpected rgstate(0x%x)\n", sbi.rgstate[0]); > + ok( !memcmp(&rect, &sbi.rcScrollBar, sizeof(RECT)), > + "WindowRect(%d, %d, %d, %d) != rcScrollBar(%d, %d, %d, %d)\n", EqualRect is better than memcmp. -- Dmitry.

2 2

Wineconf follow up: Cosmetic website changes
by Zachary Goldberg 06 Oct '08

06 Oct '08

Hello all, I just wanted to start up a thread to continue the conversation from Wineconf about revamping the WineHQ homepage. The last notes I took on the subject had Dan Kegel considering doing an actual redesign. --Zach

1 0

request for windows test ddraw/dsurface
by Marcus Meissner 05 Oct '08

05 Oct '08

Hi, I am suspecting that in IDirectDraw1 the behaviour regarding backbuffer creation might change if we have a just created frontbuffer of the same size. (This is similar to behaviour shown by bulanci.exe of http://bugs.winehq.org/show_bug.cgi?id=9008 ) Can someone please try this on Windows please? Ciao, Marcus diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c index fc7bb88..50f6986 100644 --- a/dlls/ddraw/tests/dsurface.c +++ b/dlls/ddraw/tests/dsurface.c @@ -1331,10 +1331,21 @@ static void AttachmentTest(void) /* This old ddraw version happily creates explicit front buffers */ memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); + ddsd.dwHeight = 800; + ddsd.dwWidth = 600; ddsd.dwFlags = DDSD_CAPS; ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_FRONTBUFFER; hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); + + /* MARCUS: Lets try creating a backbuffer with frontbuffer live... */ + memset(&ddsd, 0, sizeof(ddsd)); + ddsd.dwSize = sizeof(ddsd); + ddsd.dwFlags = DDSD_CAPS; + ddsd.ddsCaps.dwCaps = DDSCAPS_BACKBUFFER; + hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface2, NULL); + ok(hr==DDERR_INVALIDCAPS,"CreateSurface backbuffer after frontbuffer returned: %x\n",hr); + IDirectDrawSurface_Release(surface1); /* Try a single primary and two offscreen plain surfaces */

2 1

Re: d3d8: initialize IDirect3DDevice8 *device to NULL incase of immedient cleanup. (coverity 795)
by Rob Shearman 05 Oct '08

05 Oct '08

2008/10/3 Aric Stewart <aric(a)codeweavers.com>: > - IDirect3DDevice8 *device; > + IDirect3DDevice8 *device=NULL; Add spaces around the "=" here to match the rest of the code. -- Rob Shearman

1 0

Re: [try 4][PATCH 1/2] user32/tests: Added test about minimal child windowsizes.
by Dmitry Timoshkov 05 Oct '08

05 Oct '08

"Florian Köberle" <florian(a)fkoeberle.de> wrote: > Changes since try 3: > + I found out that the minimal child window size is "4 + 2*borderWidth" > by testing multiple values for some registery keys like > "HKEY_CURRENT_USER\Control Panel\Desktop\WindowMetrics\BorderWidth" on a > Windows XP machine. I don't know where the 4 comes from, but it could be > hard coded in Windows too. That still looks more like a hack and you still need find what that values mean. "4 + 2*borderWidth" is not something to trust in general. -- Dmitry.

1 0

Wine: Possible typo in dll/msxml3/tests/domdoc.c
by Michael Karcher 04 Oct '08

04 Oct '08

Hello Huw Davies, it looks like test_removeChild (introduced by you in commit 187ab1c0) contains a typo. The test passes both ways, but from the code flow I suspect that node_list2 was obtained for a reason, namely using it. Regards, Michael Karcher This patch fixes the type, if it turn out to really be a typo. diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 29bebb9..0494e9f 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -1785,7 +1785,7 @@ static void test_removeChild(void) r = IXMLDOMNode_get_childNodes( node, &node_list2 ); ok( r == S_OK, "ret %08x\n", r); - r = IXMLDOMNodeList_get_item( node_list, 0, &node4 ); + r = IXMLDOMNodeList_get_item( node_list2, 0, &node4 ); ok( r == S_OK, "ret %08x\n", r); r = IXMLDOMElement_removeChild( element, NULL, &node2 );

2 3

Layered windows required to support Clippy properly?
by Dan Kegel 04 Oct '08

04 Oct '08

I see in wine-1.1.5's announcement that we now have partial support for "Layered Windows", http://msdn.microsoft.com/en-us/library/ms997507.aspx Which apps use this? Seems that it used to make screen captures hard, so one way to find them is to look for apps that say you have to turn on "Capture Alpha-Blending" on in UltraVNC to see them remotely. Candidates include: Visual Studio - tooltips Microsoft Office - Clippy Possibly photoshop cs3 Another way is to look for apps that recommend the Vista Layered Windows Performance hotfix or Vista SP1. Candidates include: Yahoo Messenger for Windows Vista Another way is to look for apps that make Wine output fixme:xrender:X11DRV_AlphaBlend Ignoring SourceConstantAlpha ... Candidates include: Miranda IM http://bugs.winehq.org/show_bug.cgi?id=11902 MSN Messenger http://bugs.winehq.org/show_bug.cgi?id=8555 Skype http://bugs.winehq.org/show_bug.cgi?id=12334 I'm getting the feeling it's widespread. Anyone else know of examples of apps that Wine displays poorly because of the lack of this feature? - Dan

2 1

Re: richedit: Show arrow cursor over scrollbar. (Fixes bug 15334)
by Dylan Smith 04 Oct '08

04 Oct '08

On Sat, Oct 4, 2008 at 1:21 AM, Dylan Smith <dylan.ah.smith(a)gmail.com>wrote: > Implemented the code to check for this condition in the function that > handles WM_SETCURSOR. For each scrollbar I checked for visibility and > checked the MessagePos to see if the mouse was over the scrollbar. > --- > dlls/riched20/editor.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > This fix works alright in Wine, but I found out that it wasn't working when I cross-compiled riched20.dll and wordpad and then ran it on Windows XP. It seems as if GetScrollBarInfo was returning a SCROLLBARINFO struct with an rcScrollBar RECT in client coordinates in Wine and in screen coordinates in Windows XP. This underlying problem should be fixed first before fixing richedit. Later this patch would be modified to move the call to ScreenToClient after the check to see if the position is within the scrollbars, which I found fixes the problem on Windows.

1 0