November 2008 - Wine-devel - list.winehq.org

Fedora 9 and MingW
by Paul Vriens 20 Nov '08

20 Nov '08

Hi, I was still using the rpm's that Hans provided in the past. Some searching shows: https://fcp.surfsite.org/modules/newbb/viewtopic.php?topic_id=61801&forum=11 I've installed these rpm's but the executables use a different naming convention: i686-pc-mingw32* instead of what we check for: i686-mingw32*. Should we add this to our configure? -- Cheers, Paul.

3 2

Re: cryptdlg: Implement FormatVerisignExtension (take 2)
by Alexandre Julliard 20 Nov '08

20 Nov '08

"Juan Lang" <juan.lang(a)gmail.com> writes: > + LPWSTR verisign_statement; > + DWORD bytesNeeded; > + > + LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > + (LPWSTR)&verisign_statement, 0); > + bytesNeeded = (strlenW(verisign_statement) + 1) * sizeof(WCHAR); You can't use strlenW here, the string is not null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw/tests: Make the webbrowser test dpi aware, make is pass in wine
by Paul Vriens 20 Nov '08

20 Nov '08

Detlef Riekenberg wrote: > I set every dpi between 72 and 100 on Windows, wrote down the results > and > multiplied the results with the dpi value. > The formula ist the best guess. > Works on win98, w2k, Wine > Hi Detlef, This one introduces some extra failures now. If I look at the comment in your patch it says: /* The default size is dpi dependent (96:1323x529 / 120:1058x423) */ and if I look at some of the results on test.winehq.org: webbrowser.c:1840: Test failed: size = {1323 529} (expected 1322 529) This suggests that the calculation in the ok() should be rounded up? Or maybe deal with both situations? -- Cheers, Paul.

1 0

Re: dlls/rpcrt4: fixed dead increments (llvm/clang)
by Rob Shearman 19 Nov '08

19 Nov '08

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 3d66740..815ed64 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -479,7 +479,6 @@ static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data, > memcpy(tower_data, networkaddr, networkaddr_size); > else > tower_data[0] = 0; > - tower_data += networkaddr_size; > > return size; > } > @@ -692,7 +691,6 @@ static size_t rpcrt4_ncalrpc_get_top_of_tower(unsigned char *tower_data, > pipe_floor->count_rhs = endpoint_size; > > memcpy(tower_data, endpoint, endpoint_size); > - tower_data += endpoint_size; > > return size; > } These increments are intentional in case the code is copy and pasted and some more data is added to the end, so please don't remove them. -- Rob Shearman

2 1

Re: dlls/ole32: fixed dead assignments (llvm/clang)
by Rob Shearman 19 Nov '08

19 Nov '08

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > @@ -1951,6 +1951,12 @@ HRESULT WINAPI CoRegisterClassObject( > newClass->pMarshaledData, > flags & (REGCLS_MULTIPLEUSE|REGCLS_MULTI_SEPARATE), > &newClass->RpcRegistration); > + MSHLFLAGS_TABLESTRONG); This won't compile. > + if (hr) { > + FIXME("RPC_StartLocalServer failed, %x!\n",hr); You should change this to: ERR("RPC_StartLocalServer failed with error 0x%x\n",hr); > + return hr; > + } > + > } > return S_OK; > } > diff --git a/dlls/ole32/ole16.c b/dlls/ole32/ole16.c > index a8fa59b..21fb1fb 100644 > --- a/dlls/ole32/ole16.c > +++ b/dlls/ole32/ole16.c > @@ -598,13 +598,13 @@ HRESULT WINAPI CLSIDFromProgID16(LPCOLESTR16 progid, LPCLSID riid) > > buf = HeapAlloc(GetProcessHeap(),0,strlen(progid)+8); > sprintf(buf,"%s\\CLSID",progid); > - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { > + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey)) { Since you are changing this anyway, you should explicitly compare the result against ERROR_SUCCESS to improve readability of the code here. > HeapFree(GetProcessHeap(),0,buf); > return CO_E_CLASSSTRING; > } > HeapFree(GetProcessHeap(),0,buf); > buf2len = sizeof(buf2); > - if ((err=RegQueryValueA(xhkey,NULL,buf2,&buf2len))) { > + if (RegQueryValueA(xhkey,NULL,buf2,&buf2len)) { Ditto. > RegCloseKey(xhkey); > return CO_E_CLASSSTRING; > } -- Rob Shearman

1 0

spec file syntax for VARIANT parameter
by Jeremy Drake 19 Nov '08

19 Nov '08

In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will be necessary to change their entries in oleaut32.spec from stub to stdcall. The stdcall syntax wants a list of parameter types, which puts these functions in an unususal situation: they take a VARIANT (which is a struct, in case anyone is not familiar) by value as their first parameter. There does not seem to be any type defined in the spec file that fits this situation. I have been using ptr in my last couple of patches which add stub implementations for these functions, but when I tried to build this on cygwin I got errors like: undefined reference to `_OleLoadPictureFileEx(a)20' undefined reference to `_OleLoadPictureFile(a)8' Looking at the functions that are present in the .o file, I see they are really _OleLoadPictureFileEx(a)32 and _OleLoadPictureFile(a)20. Changing the spec file to list each VARIANT as 4 longs fixes these errors. My question is, should my next version of the patch list the VARIANT as 4 longs, or is there some better way to specify this that I'm not aware of? If not, is there a comment syntax for the spec file where I can explain why there are 4 long params where there should be one VARIANT? Thanks Jeremy

2 1

Re: dlls/msxml3: check some dead store results (llvm/clang)
by Paul Vriens 19 Nov '08

19 Nov '08

ricardo filipe wrote: > only return value checking in this patch. > > _________________________________________________________________ > Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! > http://video.msn.com/?mkt=pt-br > > > ------------------------------------------------------------------------ > > You are mixing tabs and spaces. -- Cheers, Paul.

1 0

RE: netapi32: Actually return a couple of return values.
by ricardo filipe 19 Nov '08

19 Nov '08

it seems you two fixed the same, juan sent a patch in a previous wine-devel email. you might want to check that because you two have different solutions for the first problem, line 415. > From: kai.blin(a)gmail.com > Date: Wed, 19 Nov 2008 12:41:50 +0100 > Subject: netapi32: Actually return a couple of return values. > To: wine-patches(a)winehq.org > > > ricardo filipe <ricardo_barbano(a)hotmail.com> found a couple of dead return > value assignments in nbt.c and netbios.c > > Fix up these error paths. > --- > dlls/netapi32/nbt.c | 12 +++++++++++- > dlls/netapi32/netbios.c | 2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

dead stores in netapi32
by ricardo filipe 19 Nov '08

19 Nov '08

hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

3 3

Contribute to wine
by Krzysztof Drewniak 18 Nov '08

18 Nov '08

I'd like to contribute something to wine, but I don't know what? Can I get a list? Krzys D. P.S. The audio is choppy on Ubuntu 8.10 with latest git.

3 2