November 2008 - Wine-devel - list.winehq.org

Re: mshtml: Add new interfaces into mshtml.idl (try 2)
by Alistair Leslie-Hughes 24 Nov '08

24 Nov '08

Hi Konstantin, > Kondratyuk wrote: > Hello! > > Try 2 changes: > - add missed POINTER_GRAVITY_Max, MARKUP_CONTEXT_TYPE_Max, SELECTION_TYPE_Max > constants > - correct attributes of interfaces: object, pointer_default(unique), uuid(...) > - correct attributes Right and Left methods in IMarkupPointer interface > Non of the Functions in IMarkupPointer should be marked as retval, likewise for IMarkupContainer. IElementSegment functions are in the wrong order, likewise for ISelectionServicesListener, ISelectionServices and IHTMLEditServices. Also you will need to double check the [] values, since you have retval where they are not needed. If you have a copy of the mshtml.tlb you can verify the interfaces by using wine's oleview program. Best Regards Alistair Leslie-Hughes

2 2

adding DEVICEMAP\HARDWARE registry entries
by A C Hurst 24 Nov '08

24 Nov '08

Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it. Andy

3 4

Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
by Reece Dunn 24 Nov '08

24 Nov '08

2008/11/24 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > Since Jacek did not comment on the bug 14311, revert patch in question. It > restores 100% functionality of the scrollbars in Steam. This is not the correct fix. Simply reverting a patch because it broke an application without understanding why is not the right way to go. In this case, some applications (http://bugs.winehq.org/show_bug.cgi?id=13459) specify the DOCHOSTUIFLAG_SCROLL_NO flag to specifically not show any scrollbars. In the case of bug 13459, the intro page does not render correctly if scrollbars are shown (and on Windows you don't see any scrollbars). What is the behaviour on Windows? Can you explain comments 3 and 8? - Reece

2 1

Good news regarding Wine and patent threats
by Scott Ritchie 24 Nov '08

24 Nov '08

There's a groklaw article summarizing recent discussion about the impact of the Bilski case on software patents: http://www.groklaw.net/article.php?story=20081102011538422 "The judge says this kind of cloning could be done without infringing Microsoft's copyrights, but how about its patents? Prior to Bilski, one might give one answer. Now, one might give another." If we thought Wine unlikely to be attacked by Microsoft due to nebulous patent issues and anti-trust implications, it's even less likely now. Thanks, Scott Ritchie

1 0

Spaces before '...' in Slovenian
by Francois Gouget 24 Nov '08

24 Nov '08

Does anyone (especially Rok Mandeljc) know if, in Slovenian: 1) '...' must be preceded by a space 2) '...' must not be preceded by a space 3) either form is valid -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

2 1

Re: adding DEVICEMAP\HARDWARE registry entries
by A C Hurst 24 Nov '08

24 Nov '08

> > The code in oldconfig.c is called by process.c/__wine_kernel_init(), on server startup. > > The entries are volatile, and are dynamically created if you count scanning > wineprefix/dosdevices/ > > and doing a stat() on anything named com[1-9] it finds there every time wine starts up. > > I could just call get_dos_device and let it do the stat calls, but it would be less efficient, > and > > you'd end up with registry entries for the successes of get_default_com_device, not just the > ones > > symlinked in dosdevices > > You don't want to depend on the symlinks, things should work without > requiring the user to create any symlink. It should depend on what > actual devices are present on the machine, and probably be done > somewhere in the HAL support. Would using get_dos_device() be better, since that does fall through to default behaviour when the symlink isn't there? I chose oldconfig.c since that's where the \DEVICEMAP\Scsi entries get built. Would the scsi stuff want moving over to HAL too?

2 1

Re: atl: Remove WINAPI on static functions where not needed.
by Chris Robinson 24 Nov '08

24 Nov '08

On Sunday 23 November 2008 03:15:36 pm Francois Gouget wrote: > To quote Ken Thomases who did the research on this issue with Alexandre: > > This is motivated by a gcc bug that we've encountered on the Mac. On > the Mac, WINAPI (and other declspecs) include the > force_align_arg_pointer attribute. With -O2 optimization (actually > -funit-at-a-time, implied by -O2) the compiler may change the calling > convention used by non-exported functions to take arguments via > registers rather than on the stack. The prologue generated for > force_align_arg_pointer clobbers one of those registers (and hence > one of the arguments). > > Alexandre's preferred solution is to find and eliminate such cases. > Even if/when the compiler bug is fixed, those functions should still > not have the extraneous declspec. Out of curiousity, then, does this affect static functions that are used for COM objects? It's typical for those to be marked as static, their address put into a (possibly static) vtable struct, which is then used as a field for an allocated struct passed to the user.

2 1

Re: d3d9: Remove WINAPI on static functions where not needed.
by Vitaliy Margolen 24 Nov '08

24 Nov '08

Francois Gouget wrote: > --- > > If you know other places where the functions touched by this patch > are used, please let me know. For more details, see: > > /* This isn't in MSDN! > -static HRESULT WINAPI IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface; > FIXME("(%p) : stub\n", This); > return D3D_OK; You can't do that. It's part of the v-table so it can be called by user application. Vitaliy

3 2

FAQ change wrt FontForge
by Francois Gouget 24 Nov '08

24 Nov '08

On Thu, 13 Nov 2008, Wine Wiki wrote: [...] > - Unless you plan to work on the TrueType fonts you don't need > FontForge. If you do, then be aware that the FontForge packages from > Breezy and Dapper are a bit out of date. The fonts generated by most > versions of FontForge will not pass the gdi32/tests/fonts.c tests. > + Be aware that the FontForge packages from Breezy and Dapper are a > bit out of date. The fonts generated by most versions of FontForge > will not pass the gdi32/tests/fonts.c tests. [...] > - Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. Also, unless you plan to work on the > TrueType fonts you don't need FontForge. > + Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. [...] > - Unless you plan to work on the TrueType fonts you don't need FontForge. [...] > - * The following, but ''only'' if you plan to work on the TrueType > fonts, and can install them from ''testing'' - '''do not''' install > these from ''Sarge'': > + * '''Do not''' install these from ''Sarge'': > * fontforge/testing I think these changes are wrong. As far as I know the TrueType fonts are checked into Git so one does not need to have FontForge to build Wine. Or has this changed? Or is FontForge needed to build another type of fonts? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

4 5

Re: mshtml: Add new interfaces into mshtml.idl
by Alistair Leslie-Hughes 24 Nov '08

24 Nov '08

Hi Konstantin, "Konstantin Kondratyuk" <kondratyuk(a)etersoft.ru> wrote in message news:200811232011.33101.kondratyuk(a)etersoft.ru...> I'm sorry, I have sent a wrong patch...> > -- > Best regards,> Konstantin Kondratyuk.> You have missed POINTER_GRAVITY_Max MARKUP_CONTEXT_TYPE_Max SELECTION_TYPE_Max The following interfacess dont contain dual interfaces IHTMLEditDesigner IMarkupContainer IMarkupPointer ISegment ISelectionServicesListener ISelectionServices IHTMLEditServices Best Regards Alistair Leslie-Hughes _________________________________________________________________ Take a summer road trip with Windows Live Hotmail. Multiple prizes and the ultimate dream beach house! http://www.ninemsn.com.au/hotmailroadtrip

2 2