November 2008 - Wine-devel - list.winehq.org

Why do we bother with DllCanUnloadNow?
by Mike Hearn 24 Nov '08

24 Nov '08

Is there a specific reason for implementing this function anymore? The resource savings don't seem worth the new potential for bugs. If all of them were simply returning FALSE then what would be the loss? thanks -mike

1 0

Another happy user
by Dan Kegel 24 Nov '08

24 Nov '08

http://blog.lokonopa.com/sorry-microsoft/ has a nice quote: "Come to think of it, I don't recall the last piece of software that won't install properly with Wine."

1 0

Compiler keyword
by Austin English 24 Nov '08

24 Nov '08

Howdy, Wanted to keep the discussion separate from the OS thread. Would anyone be opposed to a compiler keyword being added? There have been -- -Austin

2 2

re: Bugzilla - Add keyword and remove OS's
by Dan Kegel 24 Nov '08

24 Nov '08

Austin wrote: > The OS list in bugzilla is a bit excessive. There are 16 OS's that I > think we should remove... I think we should keep most of them, but classic Mac OS (pre-X) can go, as we never worked there (not even Darwine), and nobody cares about it anymore. I've deleted Mac System 7, and will delete the rest of the classic mac OS's if there is consensus.

2 3

Accounts in bugzilla and e-mail addresses used to submit patches
by Vitaliy Margolen 23 Nov '08

23 Nov '08

Can please everyone make sure that their e-mail in bugzilla matches the e-mail they use to submit patches? Or at least make it easily guessable. Or can we have all developers create page on Wiki and state their e-mails they use on bugazilla? The reason I'm asking is the standard procedure for a regression testing is to add author of the patch to CC. However sometimes it's impossible to do. As example this commit that introduced regression (bug 16165): e4f7809cc9969c693d910348315502892848aaf9 is first bad commit commit e4f7809cc9969c693d910348315502892848aaf9 Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 20 14:50:58 2008 +0100 winhttp: Prefer builtin over native. Out of 2 e-mail address (the one used to submit patch and the one used to send messages to wine-devel) neither present in bugzilla. Vitaliy.

5 6

Re: jscript: Implement the String.toLowerCase() method.
by Jacek Caban 23 Nov '08

23 Nov '08

Hi Andrew, Andrew Nguyen wrote: > This is an attempt to implement the String.toLowerCase method. The > added jscript tests pass on Windows XP. > --- > dlls/jscript/string.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 11 +++++++++++ > 2 files changed, 50 insertions(+), 2 deletions(-) > > > + res = heap_alloc((length+1)*sizeof(WCHAR)); > + if (!res) > + return E_OUTOFMEMORY; You can avoid this allocation by using SysAllocStringLen. Jacek

1 0

Re: msxml3: Implement IXMLDOMAttribute get/put value
by Alistair Leslie-Hughes 23 Nov '08

23 Nov '08

Ignore this patch. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49269ECA.7070202(a)hotmail.com... > Hi, > > Changelog: > msxml3: Implement IXMLDOMAttribute get/put value > > Best Regards > Alistair Leslie-Hughes > > > -------------------------------------------------------------------------------- > From 485959eb359d1efdf66c4be1aa110ba47877847c Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 21 Nov 2008 21:36:30 +1100 > Subject: [PATCH] Implement IXMLDOMAttribute get/put value > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/attribute.c | 8 ++++---- > dlls/msxml3/node.c | 21 +++++++++++++++------ > dlls/msxml3/tests/domdoc.c | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 10 deletions(-) > > diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c > index 2681a76..92cafad 100644 > --- a/dlls/msxml3/attribute.c > +++ b/dlls/msxml3/attribute.c > @@ -482,16 +482,16 @@ static HRESULT WINAPI domattr_get_value( > IXMLDOMAttribute *iface, > VARIANT *var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_get_nodeValue( This->node, var1 ); > } > > static HRESULT WINAPI domattr_put_value( > IXMLDOMAttribute *iface, > VARIANT var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_put_nodeValue( This->node, var1 ); > } > > static const struct IXMLDOMAttributeVtbl domattr_vtbl = > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 19cee8f..6693803 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -339,13 +339,22 @@ static HRESULT WINAPI xmlnode_put_nodeValue( > > TRACE("%p type(%d)\n", This, This->node->type); > > - VariantInit(&string_value); > - hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > - if(FAILED(hr)) > + /* Attribute nodes treat NULL Variants as empty strings. */ > + if(V_VT(&value) == VT_NULL && This->node->type == XML_ATTRIBUTE_NODE) > { > - VariantClear(&string_value); > - WARN("Couldn't convert to VT_BSTR\n"); > - return hr; > + V_VT(&string_value) = VT_BSTR; > + V_BSTR(&string_value) = SysAllocStringLen(NULL, 0); > + } > + else > + { > + VariantInit(&string_value); > + hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > + if(FAILED(hr)) > + { > + VariantClear(&string_value); > + WARN("Couldn't convert to VT_BSTR\n"); > + return hr; > + } > } > > hr = S_FALSE; > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index e27c506..c975d73 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -2796,12 +2796,18 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + V_VT(&v) = VT_NULL; > + V_I4(&v) = 0; > + hr = IXMLDOMElement_put_nodeValue(pElement, v); > + ok(hr == DISP_E_TYPEMISMATCH, "ret %08x\n", hr ); > + > /* Attribute */ > hr = IXMLDOMDocument_createAttribute(doc, szAttribute, > &pAttrubute); > ok(hr == S_OK, "ret %08x\n", hr ); > if(hr == S_OK) > { > IXMLDOMNode *pNewChild = (IXMLDOMNode *)0x1; > + IXMLDOMNode *pAttrNode = NULL; > > hr = IXMLDOMAttribute_get_nextSibling(pAttrubute, > NULL); > ok(hr == E_INVALIDARG, "ret %08x\n", hr ); > @@ -2876,6 +2882,30 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + /* test value */ > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMAttribute_put_value(pAttrubute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + hr = IXMLDOMAttribute_get_value(pAttrubute, &v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + ok( !lstrcmpW( V_BSTR(&v), _bstr_("") ), "incorrect > get_value string\n"); > + VariantClear(&v); > + > + IXMLDOMAttribute_QueryInterface(pAttrubute, > &IID_IXMLDOMNode, (LPVOID*)&pAttrNode); > + if(hr == S_OK) > + { > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMNode_put_nodeValue(pAttrNode, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + IXMLDOMNode_Release(pAttrNode); > + } > + > IXMLDOMAttribute_Release(pAttrubute); > > /* Check Element again with the Add Attribute*/ > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

re: How do I create a backtrace?
by Dan Kegel 23 Nov '08

23 Nov '08

The FAQ covers this: http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

1 0

How do I create a backtrace?
by Matt Perry 22 Nov '08

22 Nov '08

I've been asked by a Wine developer to provide a backtrace along with a "+relay,+seh" log for a bug that I have filed. I've read through the developer documentation but I can't figure out how to do this. I sent an email to the developer with a request for instructions but have not received a reply. Could someone here instruct me on how to do this? I'm a non-programmer so please take that into consideration with regards to your instructions. Thanks. Matt

2 1

Re: Wine release 1.1.9
by Francois Gouget 22 Nov '08

22 Nov '08

On Fri, 21 Nov 2008, Alexandre Julliard wrote: > The Wine development release 1.1.9 is now available. > > What's new in this release (see below for details): > - A large number of regression test fixes. <nitpick> Actually it's not regression tests, and it's not regression fixes. It's conformance tests, their main goal is to describe the Windows behavior, so that we can then know whether Wine _conforms_ to that behavior or not. And all (or almost all) of the fixes are so that the tests actually describe the Windows behavior. </nitpick> -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

3 3