December 2008 - Wine-devel - list.winehq.org

d3d9 patch include a test needs testing in windows
by Pauli Nieminen 22 Dec '08

22 Dec '08

Hi! I have tried to get Civ4 running in my machine and successed with some minor wine modifications but this patch needs testing in windows how d3d9 handles this case in there. Preferable test system should be include graphic card that supports some but not all shader versions. (That means readeon 8500+ and Geforce 3/4+). I think it should be ok to run in any windows version if there is just dx9 installed. Patch set includes 3 patches but you realy only need to apply the test portion of 2nd patch. The latest patch version is available at http://repe.ath.cx/wine/ and bug report is http://bugs.winehq.org/show_bug.cgi?id=16444 . Thanks for help. Pauli

2 1

RFC: Proposed new web site design
by Jeremy White 22 Dec '08

22 Dec '08

At Wineconf, we made the decision to change the entry page to the Wine web site. The hope was to simplify and stream line it, and to put in place the infrastructure to start moving more content to the Wiki. Jeremy Newman and Jon Parshall have put a lot of time and energy into a proposed new design, following what we took away from the meetings at Wineconf. A mock up of that design is up now here: http://wine.codeweavers.com/winehq_new/ ...and the theming intended for all 'child' pages of the web site, starting with the Wiki: http://wine.codeweavers.com/winehq_new/wiki.html Beyond the normal controversy that any new design sparks there is one major potential controversial change. That is, I am asking for prime placement on the download page on behalf of CodeWeavers instead of the (stale and ugly, sorry) banner ads we used in the past. You can see our current concept around that positioning here: http://wine.codeweavers.com/winehq_new/download.html I hope that the general community sees that as a reasonable exchange for all of the work we put into Wine and hosting the Wine server, and a vast improvement over the banner ads. At any rate, comments and feedback are welcome. And in a vain attempt to prevent all the flames from scorching Jon and Jeremy, I'd like to officially state how much I appreciate their efforts. Cheers, Jeremy

19 32

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.
by Juan Lang 22 Dec '08

22 Dec '08

Hi Hans, this is a really minor comment: +struct cryptcat +{ + DWORD magic; + HANDLE msg; msg's type should be HCRYPTMSG instead. + for (i = 0; i < cc->attr_count; i++) + { + if (!CryptMsgGetParam(hmsg, CMSG_ATTR_CERT_PARAM, i, NULL, &size)) Out of curiosity, how did you test this? --Juan

2 2

Re: Linking to a Mac OS X build of Wine from winehq.org/download ?
by James Mckenzie 22 Dec '08

22 Dec '08

-----Original Message----- >From: Dmitry Timoshkov <dmitry(a)codeweavers.com> >Sent: Dec 21, 2008 10:45 PM >To: Dan Kegel <dank(a)kegel.com>, Roderick Colenbrander <thunderbird2k(a)gmx.net> >Cc: wine-devel(a)winehq.org, zach(a)drayer.name, ies4osx(a)kronenberg.org >Subject: Re: Linking to a Mac OS X build of Wine from winehq.org/download ? > >"Dan Kegel" <dank(a)kegel.com> wrote: > >> On Sun, Dec 21, 2008 at 8:27 AM, Roderick Colenbrander >> <thunderbird2k(a)gmx.net> wrote: >>>> Say, http://www.kronenberg.org/darwine/ seems to be a popular source >>>> of nearly up to date wine builds for the mac. How about we link to it >>>> from http://winehq.org/download/ ? >>>> >>>> Furthermore, are his packages good enough to support? >>>> If so, how 'bout we ask him to add links to bugzilla and >>>> the appdb from his page? >>> >>> Most importantly we need to get rid of the Darwine name. It causes a lot of unneeded confusion. >> >> Yes, I would like to keep Darwine as the name of the old powerpc project >> that combined an x86 emulator and wine. >> >> Can we convince Mike and Zach to switch names to just plain Wine? > >And change the licencing conditions to LGPL, currently that page states >"Darwine and wine are released under the gpl". They also have to remove >any differences between WineHQ sources and their ones, otherwise it can't >be supported via WineHQ. > Dan and Dmitry: What I would like to see is the changes made by Zach and Mike incorporated back into the main Wine code. Both Mike and Zach have approached building Wine releases in the two structures supported by Apple: Drag and Drop where you grab a pre-built Application object and move it into the Applications folder and the use of the Apple installer with an installable 'package' much like the use of apt or yum. There is great debate as to which is the best approach and, basing this on the struggle within and outside of the OpenOffice.org/NeoOffice.org MacOSX porting projects, I would like to avoid this problem as best we can. Firefox and Thunderbird use the first approach, but many projects use the latter. The Wine project should pick one as the formally supported installation method and allow others to support the second. I don't have a favorite, as deinstallation of the program is easy and involves an additional step when using the second installation method. Again, restating my first sentence in the last paragraph is that we need to bring back into the Main Wine codebase those changes needed to successfully complete a build on the Intel MacOSX system. Darwine should remain a project for incorporating the x86 emulator, Qemu and Wine. This should reduce MacOSX user confusion and get all of the pieces together. Further work may be required to fully support all functionality of the Wine project, such as font support, as time progresses. James McKenzie

1 0

Linking to a Mac OS X build of Wine from winehq.org/download ?
by Dan Kegel 22 Dec '08

22 Dec '08

Say, http://www.kronenberg.org/darwine/ seems to be a popular source of nearly up to date wine builds for the mac. How about we link to it from http://winehq.org/download/ ? Furthermore, are his packages good enough to support? If so, how 'bout we ask him to add links to bugzilla and the appdb from his page?

8 11

question about translating winehq.org
by Maik Schulz 22 Dec '08

22 Dec '08

Hi, how can I translate the top navigation bar ("Forums" would be "Foren" in German) and the word "Search" (would be "Suche" in German) next to the search box? Cheers, -Maik

2 1

Re: [07/10] wintrust: Implement CryptCATEnumerateMember.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > @@ -496,12 +496,208 @@ BOOL WINAPI CryptCATClose(HANDLE hCatalog) > return TRUE; > } > > +static BOOL guid_from_string(const WCHAR *str, GUID *guid) > +{ > + unsigned int i = 0; > + unsigned char *b = (unsigned char *)guid; > + const WCHAR *p = str; Please call one of the existing functions for this instead of reinventing the wheel. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [02/10] wintrust: Convert crypt tests to Unicode.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > diff --git a/dlls/wintrust/tests/crypt.c b/dlls/wintrust/tests/crypt.c > index 6811fd4..41cb39a 100644 > --- a/dlls/wintrust/tests/crypt.c > +++ b/dlls/wintrust/tests/crypt.c > @@ -27,8 +27,8 @@ > > #include "wine/test.h" > > -static char selfname[MAX_PATH]; > -static CHAR CURR_DIR[MAX_PATH]; > +static WCHAR selfname[MAX_PATH]; > +static WCHAR current_dir[MAX_PATH]; Is that really useful? It seems to me it will break the tests on Win9x for no good reason. -- Alexandre Julliard julliard(a)winehq.org

2 2

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (redux)
by Stefan Dösinger 22 Dec '08

22 Dec '08

Hmm... Wouldn't this bug also affect surfaces without a PBO? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Nick Burns > Sent: Sunday, December 21, 2008 12:36 PM > To: wine-patches(a)winehq.org > Subject: [PATCH] Fix glReadPixels call from read_from_framebuffer > (redux) > > > This is a resubmission of my previous patch I fixed the issues Jeff > found > 1 - email address in the patch file/git > 2 - move declartions to block beginning (no warnings now) > 3 - hotmail spacing (well i think this is as good as I can make it...) > > > This is my last gfx fix for SHOGO (now its quite legible and playable) > The readpixels call was putting data into the wrong place in the pbo > (fixed with pixelstore) And the y-flip code was flipping the wrong data > as well (set the bottom row to the bottom row and not the height'th > row) > > The code handled fullscreen 2d blits (or blts without any colorkey > masking) correctly However sub-blits had issues (in the pbo path) > 1 - readpixels read into the wrong part of the pbo (as a line and > not a rect) > 2 - the y-flip code would move around the uninited data (from the > readpixels) and it read from the wrong place > 3 - After 1 and 2 the pbo is corrupt and the blt code had no > chance... > > This patch fixes 1 and 2 -- letting the blt code shine This can be seen > in the SHOGO menu (now not corrupt!) > > Changelog > Fix glReadPixels call from read_from_framebuffer > Fix the call to readpixels so that 2d blts going thru the pbo path > end up in the right place and get flipped correctly > > - Nick

2 1

Re: wine.inf: Create fake pidgen.dll.
by Alexandre Julliard 22 Dec '08

22 Dec '08

Hans Leidekker <hans(a)codeweavers.com> writes: > The ie7 installer makes this call: > > LoadLibraryExA("C:\\windows\\system32\\pidgen.dll", 0, LOAD_LIBRARY_AS_DATAFILE) > > which fails if the file doesn't exist. No, it should work just fine. You shouldn't need a fake library for that. -- Alexandre Julliard julliard(a)winehq.org

1 0