December 2008 - Wine-devel - list.winehq.org

re: Symlink vulnerability in winetricks
by Dan Kegel 24 Dec '08

24 Dec '08

Stefan Nordhaus wrote: > Winetricks has a symlink vulnerability... Fixed in today's winetricks (20081223), thanks! - Dan

1 0

Trouble compiling today's git.
by Susan Cragin 24 Dec '08

24 Dec '08

Is anyone else having trouble compiling today's git? Or is it just my flu-addled brain? make[1]: Entering directory `/home/susan/wine/server' ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c completion.c console.c context_alpha.c context_i386.c context_powerpc.c context_sparc.c context_x86_64.c debugger.c device.c directory.c event.c fd.c file.c handle.c hook.c mach.c mailslot.c main.c mapping.c mutex.c named_pipe.c object.c process.c procfs.c ptrace.c queue.c region.c registry.c request.c semaphore.c serial.c signal.c snapshot.c sock.c symlink.c thread.c timer.c token.c trace.c unicode.c user.c window.c winstation.c make[1]: Leaving directory `/home/susan/wine/server' make[1]: Entering directory `/home/susan/wine/server' ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c completion.c console.c context_alpha.c context_i386.c context_powerpc.c context_sparc.c context_x86_64.c debugger.c device.c directory.c event.c fd.c file.c handle.c hook.c mach.c mailslot.c main.c mapping.c mutex.c named_pipe.c object.c process.c procfs.c ptrace.c queue.c region.c registry.c request.c semaphore.c serial.c signal.c snapshot.c sock.c symlink.c thread.c timer.c token.c trace.c unicode.c user.c window.c winstation.c make[1]: Leaving directory `/home/susan/wine/server' make[1]: Entering directory `/home/susan/wine/tools' make[2]: Entering directory `/home/susan/wine/tools/widl' ../../tools/makedep -C. -S../.. -T../.. client.c expr.c hash.c header.c proxy.c server.c typegen.c typelib.c utils.c widl.c write_msft.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/widl' make[2]: Entering directory `/home/susan/wine/tools/widl' ../../tools/makedep -C. -S../.. -T../.. client.c expr.c hash.c header.c proxy.c server.c typegen.c typelib.c utils.c widl.c write_msft.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/widl' make[2]: Entering directory `/home/susan/wine/tools/winebuild' ../../tools/makedep -C. -S../.. -T../.. import.c main.c parser.c relay.c res16.c res32.c spec16.c spec32.c utils.c make[2]: Leaving directory `/home/susan/wine/tools/winebuild' make[2]: Entering directory `/home/susan/wine/tools/winebuild' ../../tools/makedep -C. -S../.. -T../.. import.c main.c parser.c relay.c res16.c res32.c spec16.c spec32.c utils.c make[2]: Leaving directory `/home/susan/wine/tools/winebuild' make[2]: Entering directory `/home/susan/wine/tools/winedump' ../../tools/makedep -C. -S../.. -T../.. debug.c dos.c dump.c emf.c le.c lib.c lnk.c main.c minidump.c misc.c msc.c msmangle.c ne.c output.c pdb.c pe.c search.c symbol.c make[2]: Leaving directory `/home/susan/wine/tools/winedump' make[2]: Entering directory `/home/susan/wine/tools/winedump' ../../tools/makedep -C. -S../.. -T../.. debug.c dos.c dump.c emf.c le.c lib.c lnk.c main.c minidump.c misc.c msc.c msmangle.c ne.c output.c pdb.c pe.c search.c symbol.c make[2]: Leaving directory `/home/susan/wine/tools/winedump' make[2]: Entering directory `/home/susan/wine/tools/winegcc' ../../tools/makedep -C. -S../.. -T../.. utils.c winegcc.c make[2]: Leaving directory `/home/susan/wine/tools/winegcc' make[2]: Entering directory `/home/susan/wine/tools/winegcc' ../../tools/makedep -C. -S../.. -T../.. utils.c winegcc.c make[2]: Leaving directory `/home/susan/wine/tools/winegcc' make[2]: Entering directory `/home/susan/wine/tools/wmc' ../../tools/makedep -C. -S../.. -T../.. lang.c mcl.c utils.c wmc.c write.c mcy.y make[2]: Leaving directory `/home/susan/wine/tools/wmc' make[2]: Entering directory `/home/susan/wine/tools/wmc' ../../tools/makedep -C. -S../.. -T../.. lang.c mcl.c utils.c wmc.c write.c mcy.y make[2]: Leaving directory `/home/susan/wine/tools/wmc' make[2]: Entering directory `/home/susan/wine/tools/wrc' ../../tools/makedep -C. -S../.. -T../.. dumpres.c genres.c newstruc.c readres.c translation.c utils.c wrc.c writeres.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/wrc' make[2]: Entering directory `/home/susan/wine/tools/wrc' ../../tools/makedep -C. -S../.. -T../.. dumpres.c genres.c newstruc.c readres.c translation.c utils.c wrc.c writeres.c parser.y parser.l make[2]: Leaving directory `/home/susan/wine/tools/wrc' ../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c make[1]: Leaving directory `/home/susan/wine/tools' ./tools/makedep -C. -S. -T. make[1]: Entering directory `/home/susan/wine/tools' make[1]: `makedep' is up to date. make[1]: Leaving directory `/home/susan/wine/tools' make[1]: Entering directory `/home/susan/wine/libs' make[2]: Entering directory `/home/susan/wine/libs/port' ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -h -H ../../include/wtypes.h ../../include/wtypes.idl make[2]: ../../tools/widl/widl: Command not found make[2]: *** [../../include/wtypes.h] Error 127 make[2]: Leaving directory `/home/susan/wine/libs/port' make[1]: *** [port] Error 2 make[1]: Leaving directory `/home/susan/wine/libs' make: *** [libs] Error 2 susan(a)ubuntu:~/wine$

2 1

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.
by Maarten Lankhorst 23 Dec '08

23 Dec '08

Hi Juan and Hans, Juan Lang schreef: > Hi Hans, > > >> Maarten, do you remember what the code to store attribute certs was >> needed for? I'd like to address Juan's concern by either adding a test >> or taking the code out. >> > > I wouldn't worry about it. The code looks correct to the eye, it's > just calling part of crypt32 that's stubbed out (and on my list.) > Mainly I was curious if you'd managed to test with native crypt32 > somehow, as that's something I've never managed to make work (on > Linux.) > I was working on some code that needed it, The specific functions were stubbed out (crossover proprietary advantage (TM)) so it's not used, but the correct implementation of CryptCATGetCertAttr/CryptCATEnumCertAttr would need the attributes. Cheers, Maarten.

1 0

how to create a broken .tlb file
by Michael Karcher 23 Dec '08

23 Dec '08

Hello developers, while debugging problems with and old version of Sonic Stage, I found that sonic stage includes broken type libraries, i.e. the TYPEFLAG_FDISPATCHABLE bit is generally missing. As widl (and probably midl too) set this bit automatically, I have some problems in creating a .tlb file for a test case for my one-line patch that also misses this bit. There are some possibilities to get around the problem: a) Include a broken (hand-patched) tlb file as binary file in git b) Include a program that breaks tlb files and call it while building tests c) Include tlb file patching into the testcase (i.e. copy a good tlb, patch it, and perform some tests with the copy, than delete it) Which approach would have the highest chance of getting the fix (including the testcase that tests broken type libraries) included into Wine? Regards, Michael Karcher

2 1

Re: bugfix: resend: fix serial_flush
by Alexandre Julliard 23 Dec '08

23 Dec '08

Wolfgang Walter <wine(a)stwm.de> writes: > @@ -201,7 +202,17 @@ static void serial_flush( struct fd *fd, struct event **event ) > /* MSDN says: If hFile is a handle to a communications device, > * the function only flushes the transmit buffer. > */ > - if (tcflush( get_unix_fd(fd), TCOFLUSH ) == -1) file_set_error(); > + /* FlushFileBuffers does NOT have the semantics of tcflush. > + * Whereas tcflush discards any data not yet transmitted > + * FlushFileBuffers ensures they are written out. > + * The POSIX equivalent is tcdrain > + */ > + while (tcdrain( get_unix_fd(fd)) == -1) { > + if (errno != EINTR) { > + file_set_error(); > + return; > + } This will block, you can't do that in the server. -- Alexandre Julliard julliard(a)winehq.org

2 2

Symlink vulnerability in winetricks
by Stefan Nordhausen 23 Dec '08

23 Dec '08

Hi! Winetricks has a symlink vulnerability, it does (echo "$title"; echo ""; echo "$text") > /tmp/x_showmenu.txt An attacker can exploit this by creating a symlink called /tmp/x_showmenu.txt and have it point to some file that a winetricks user can write (e.g. ~/Documents/important_stuff.odf). Winetricks will then overwrite that file with its data. To solve this, apply the following patch that simply avoids the creation of a temporary file: --- winetricks 2008-12-18 06:34:42.000000000 +0100 +++ winetricks 2008-12-23 18:00:17.000000000 +0100 @@ -207,8 +207,8 @@ args="$args,$1" shift done - (echo "$title"; echo ""; echo "$text") > /tmp/x_showmenu.txt - xmessage -print -file /tmp/x_showmenu.txt -buttons "Cancel,$args" | sed 's/Cancel//' + (echo "$title"; echo ""; echo "$text") | \ + xmessage -print -file - -buttons "Cancel,$args" | sed 's/Cancel//' } showmenu() Merry Christmas Stefan

1 0

DIB Engine
by Massimo Del Fedele 23 Dec '08

23 Dec '08

As my DIB engine is becoming usable (I already use it on Autocad for my job), I'm thinking to publish the patches. As it's still not complete, I'm thinking to add a way to enable it on demand with registry and environment variable : export WINEDIB=ON activates it export WINEDIB=OFF deactivates it if no environment variable, it checks a registry key (I'd like to have some suggestion on where to put it). If no environment variable nor registry entry are present it'll be disabled (by now) as is for testing purposes. How should I publish it ? A big unique patch, 2 patches, one with the (small) changes in gdi32 and another big one with the engine itself, or many small patches ? Is it right to put on wine patches list ? Ciao Max

5 6

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.
by Stefan Dösinger 23 Dec '08

23 Dec '08

I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if it crashes on something like VMWare or other 'noname' cards.

4 4

MSVCP80 implementation
by louis＠museresearch.com 23 Dec '08

23 Dec '08

Hi all, I'm attempting to get software to run which requires some functions in MSVCP80 to be implemented. Using the original DLLs is not an option for us. In particular, a couple of the allocator functions are being called (msvcp80.dll.??0?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAE(a)XZ to give one such example). I am sure there are more after this is fixed too. Browsing the WINE source, I found references to some similarly mangled functions in MSVCRT (the stream classes), but they did not seem to be actually implemented: in msvcrt/tests/cpp.c there was a demangling test, but I didn't find much else that was directly related. So, my question is how WINE handles calls to any STL or C++ library functions which may be included in these DLLs, and what approach I should use to implement or forward calls to these kinds of functions. Any help would be much appreciated. Thanks in advance, Louis Gorenfeld Muse Research

6 5

RE: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error
by Stefan Dösinger 23 Dec '08

23 Dec '08

Hi, Please write a test for this. This behavior differs from function to function unfortunately. Some functions do not set the value to NULL, and some apps depend on this. I think dlls/d3d9/tests/shader.c is a good place to put this test. -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Vincent Pelletier > Sent: Monday, December 22, 2008 11:25 PM > To: wine-patches > Subject: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to > NULL on error > > When IWineD3DDevice_GetVertexShader fails, set *ppShader to NULL. > > This fixes "Black & White 2" here: it used to crash right when first > level intro video ended, before seeing the level. With this patch I can > play a bit (though there are some graphical glitches remaining, mouse > it not so > smooth...) > > -- > Vincent Pelletier

2 2