December 2008 - Wine-devel - list.winehq.org

Re: wininet: Relax a notification test.
by Paul Vriens 18 Dec '08

18 Dec '08

Hans Leidekker wrote: > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index 6554680..8b3a8f8 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -325,8 +325,8 @@ static void InternetReadFile_test(int flags) > SET_EXPECT2(INTERNET_STATUS_REQUEST_SENT, 2); > SET_EXPECT2(INTERNET_STATUS_RECEIVING_RESPONSE, 2); > SET_EXPECT2(INTERNET_STATUS_RESPONSE_RECEIVED, 2); > - SET_EXPECT2(INTERNET_STATUS_CLOSING_CONNECTION, 2); > - SET_EXPECT2(INTERNET_STATUS_CONNECTION_CLOSED, 2); > + SET_OPTIONAL2(INTERNET_STATUS_CLOSING_CONNECTION, 2); > + SET_OPTIONAL2(INTERNET_STATUS_CONNECTION_CLOSED, 2); > SET_EXPECT(INTERNET_STATUS_REDIRECT); > SET_OPTIONAL(INTERNET_STATUS_CONNECTING_TO_SERVER); > SET_OPTIONAL(INTERNET_STATUS_CONNECTED_TO_SERVER); > > > Hi Hans, Apparently that's not enough to fix the tests. Although it's set to be optional we are still using CHECK_NOTIFIED2 that doesn't make use of the optional parameter. -- Cheers, Paul.

1 0

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.
by James Hawkins 18 Dec '08

18 Dec '08

On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon <bsjeon(a)hanmail.net> wrote: > By an analysis of the ImmIsUIMessageA/W disassemble code, > 1. checked msg : > WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, > WM_IME_SETCONTEXT, WM_IME_NOTIFY, > WM_IME_COMPOSITIONFULL, WM_IME_SELECT. > 2. SendMessageA/W is used. > Writing code for Wine based directly off of disassembled code is not allowed. The only way disassembly can be used is clean-room reverse engineering where person A disassembles the code and writes up a very high-level spec file for person B to implement. Unfortunately, this patch cannot be committed and you won't be able to submit patches for the imm32 module anymore. -- James Hawkins

3 3

re: winewtsn: add a new program that shows a dialog to inform about a crash
by Dan Kegel 18 Dec '08

18 Dec '08

Alexandre wrote: > I'd suggest to do that in winedbg, there's no need to add another > Wine-specific program for that. Windows uses three different automatically started debuggers: the visual C++ debugger for average programmers, windbg for superprogrammers, and Dr. Watson for users who just need a user-friendly crash handler. I think Mikolaj was simply trying to provide an implementation of the latter. Does it really make sense to make one program serve both roles, given that Microsoft doesn't do it that way? - Dan

1 0

Re: mshtml: Add some interfaces in mshtml.idl (try 3) (resend)
by Alistair Leslie-Hughes 18 Dec '08

18 Dec '08

Hi Konstantin, "Konstantin Kondratyuk" <kondratyuk(a)etersoft.ru> wrote in message news:200812181251.50439.kondratyuk(a)etersoft.ru... > Add: > ILineInfo > IDisplayPointer > IDisplayPointer > IHTMLComputedStyle > IDisplayServices > IMarkupServices > > -- You have converted some OLECHAR* to "unsigned short* in functions InsertText, CreateElement to name a few. Best Regards Alistair Leslie-Hughes

1 0

Another machine passing tests
by Zachary Goldberg 17 Dec '08

17 Dec '08

All, It seems we have another machine which passes all tests on Wine http://test.winehq.org/data/bd25af9dba280e3d80f3080140f2f5ab2cd0dfb3/ Huzzah! --Zach

5 7

fixing all the not-properly-displaying characters that have suddenly appeared in the appdb
by Rosanne DiMesio 17 Dec '08

17 Dec '08

Since the change to the new design, AppDB entries have been displaying either a ? (Firefox, Konqueror, Opera) or a blank rectangle (IE in Windows) in place of a variety of special characters, including anything with an umlaut (bug 16514). I've played around with it a bit, and the entries can be fixed by manually editing them, but before I undertake the task, I figured I'd better ask if this is something that could be fixed more easily (e.g., changing a setting on the server). -- Rosanne DiMesio <dimesio(a)earthlink.net>

3 3

Re: winewtsn: add a new program that shows a dialog to inform about a crash
by Alexandre Julliard 17 Dec '08

17 Dec '08

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > Currently, when a program is started from the KDE or Gnome menu and > it crashes, it simply disappears from the screen without any > explanation what happened - the information that goes to the console > is not visible. This program uses a similar technique as Windows' dr > Watson to register itself as a debugger and show a dialog about a > crash. It then calls winedbg, so, if the program is run from a > terminal, the dump will be still visible. As a bonus feature, one can > Shift+right click on the dialog to start an interactive session of > winedbg. The patch has an effect only on new wineprefixes, as the > debugger setting is not overwritten after a Wine upgrade. I'd suggest to do that in winedbg, there's no need to add another Wine-specific program for that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl
by Dmitry Timoshkov 17 Dec '08

17 Dec '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Needed to get +relay working in wine64 You should have used CDECL instead of __cdecl, have a look how it's done in msvcrt.dll. -- Dmitry.

2 1

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl
by Alexandre Julliard 17 Dec '08

17 Dec '08

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -33,9 +33,9 @@ > WINE_DEFAULT_DEBUG_CHANNEL(bitmap); > > > -static HGDIOBJ BITMAP_SelectObject( HGDIOBJ handle, HDC hdc ); > -static INT BITMAP_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > -static BOOL BITMAP_DeleteObject( HGDIOBJ handle, void *obj ); > +static HGDIOBJ __cdecl BITMAP_SelectObject( HGDIOBJ handle, HDC hdc ); > +static INT __cdecl BITMAP_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID buffer ); > +static BOOL __cdecl BITMAP_DeleteObject( HGDIOBJ handle, void *obj ); You shouldn't need to change these. -- Alexandre Julliard julliard(a)winehq.org

1 0

Making the shell32/appbar tests pass on Vista
by Paul Vriens 17 Dec '08

17 Dec '08

Hi Vincent, I was trying to have the appbar tests succeed on Vista. One way I could make it work is with the attached patch. Does this make sense? Or should we have another possible outcome of the test? (or even a broken()?). The change to do_events_until was only for my troubleshooting purposes. (Vista times out without the patch). -- Cheers, Paul. diff --git a/dlls/shell32/tests/appbar.c b/dlls/shell32/tests/appbar.c index d11a999..8dff9a8 100644 --- a/dlls/shell32/tests/appbar.c +++ b/dlls/shell32/tests/appbar.c @@ -128,8 +128,13 @@ static void do_events_until(boolean_function test) TranslateMessage(&msg); DispatchMessageA(&msg); } - if (timedout || test()) + if (test()) break; + else if (timedout) + { + trace("Timed out waiting for condition to become true\n"); + break; + } WaitMessage(); } @@ -333,6 +338,8 @@ static void test_setpos(void) windows[0].registered = FALSE; DestroyWindow(windows[0].hwnd); + testwindow_setpos(windows[1].hwnd); + do_events_until(got_expected_bottom); ok(windows[1].allocated_rect.bottom == expected_bottom, "windows[1]'s bottom is %i, expected %i\n", windows[1].allocated_rect.bottom, expected_bottom);

1 0