December 2008 - Wine-devel - list.winehq.org

Re: [4/10] WineD3D: Some GL_EXT_fog_coord prototype fixes
by Henri Verbeet 15 Dec '08

15 Dec '08

2008/12/15 Stefan Dösinger <stefan(a)codeweavers.com>: > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDFVEXTPROC) (GLfloat intesity); > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDEXTPROC) (GLfloat intesity); > -typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDVEXTPROC) (GLfloat intesity); > +typedef void (WINE_GLAPI * PGLFNGLFOGCOORDFVEXTPROC) (const GLfloat *intesity); > +typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDEXTPROC) (GLdouble intesity); > +typedef void (WINE_GLAPI * PGLFNGLFOGCOORDDVEXTPROC) (const GLdouble *intesity); > You might as well fix the parameter names while you're at it :-)

1 0

Re: user32: Sign-compare warnings fix (Try 2)
by James Mckenzie 15 Dec '08

15 Dec '08

-----Original Message----- >From: Alexandre Julliard <julliard(a)winehq.org> >Sent: Dec 15, 2008 5:25 AM >To: Andrew Talbot <andrew.talbot(a)talbotville.com> >Cc: wine-devel(a)winehq.org >Subject: Re: user32: Sign-compare warnings fix (Try 2) > >Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > >> diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c >> index 9dd9083..4ea1959 100644 >> --- a/dlls/user32/dialog.c >> +++ b/dlls/user32/dialog.c >> @@ -84,9 +84,9 @@ typedef struct >> /* Radio button group */ >> typedef struct >> { >> - UINT firstID; >> - UINT lastID; >> - UINT checkID; >> + INT firstID; >> + INT lastID; >> + INT checkID; >> } RADIOGROUP; > >This change would need a test case. > Alexandre/Andrew: I don't think this change is necessary, unless there is checking against a -1 somewhere in the code. Also, I would like to see an array of 32K or so radio buttons somewhere in Windows code. James McKenzie

1 0

Re: user32: Sign-compare warnings fix (Try 2)
by Alexandre Julliard 15 Dec '08

15 Dec '08

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > diff --git a/dlls/user32/dialog.c b/dlls/user32/dialog.c > index 9dd9083..4ea1959 100644 > --- a/dlls/user32/dialog.c > +++ b/dlls/user32/dialog.c > @@ -84,9 +84,9 @@ typedef struct > /* Radio button group */ > typedef struct > { > - UINT firstID; > - UINT lastID; > - UINT checkID; > + INT firstID; > + INT lastID; > + INT checkID; > } RADIOGROUP; This change would need a test case. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: richedit: OpenClipboard doesn't need to be given a window handle.
by Alexandre Julliard 15 Dec '08

15 Dec '08

"Dylan Smith" <dylan.ah.smith(a)gmail.com> writes: > I have been looking to reduce the number of places where window handles > are used, so I did a relay trace to see if native richedit controls gave > a non-null handle when calling OpenClipboard. The relay trace showed > that NULL was being used, even for normal windowed richedit controls. Please don't do that. The calls that native makes are part of the internal workings that you are not supposed to peek into. You should treat native as a black box and only replicate behavior that can be observed through test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine64 hello world app runs!
by Maarten Lankhorst 15 Dec '08

15 Dec '08

Hi guys, I can finally report success on the first ever win64 program running on wine. The program was a textbook classic, but to make it work gcc had to be changed a lot. This was done by Kai Tietz, who has put a lot of effort in the task of making gcc accept the calling convention. There are still a lot of things which should be done before this will be able to get into mainline though. My repository is at http://repo.or.cz/w/wine/wine64.git , but in order to actually get it working you need gcc checked out from subversion with some experimental patches. They are expected to get merged soon, so until then it is not recommended to even try. :) There are a bunch of things in my tree which are not merged with mainline. A few of them are hacks (disabling SEGV handling for example). There are also some changes which should be accepted, but still need some work. For example wineserver, AJ wants something with regards to fd handling, but I didn't find him clear on what exactly. va_list also is incompatible, and should be replaced with ms_va_list where appropiate. Once again, thanks to Kai Tietz for making this possible. Cheers, Maarten.

2 2

Regression - Photoshop CS3 tryout won't install anymore?
by Dan Kegel 14 Dec '08

14 Dec '08

Bleah: http://bugs.winehq.org/show_bug.cgi?id=15590 Golly. After all the work we put into getting Photoshop running, I hope we don't regress...

1 0

IE, mshtml.dll, oledb32.dll and vulnerability in XML parsing / data binding
by Saulius Krasuckas 14 Dec '08

14 Dec '08

Hello, I noticed article about some IE issue: [1] And couldn't stop smiling at the amount and spectre of the workarounds needed to prevent attacks ;) And maybe Jacek (or some other mshtml guy) could test Wine's html engine against the external test case [2] to see whether we are better at handling [3] such XMLs. [1] http://www.pcmag.com/article2/0,2817,2336831,00.asp [2] http://www.milw0rm.com/exploits/7410 [3] http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2008-4844

1 0

Re: amstream: Some fixes
by Vincent Povirk 14 Dec '08

14 Dec '08

Please send a separate patch for each group of related changes, per http://winehq.org/sending_patches Vincent Povirk On Sun, Dec 14, 2008 at 12:07 PM, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > > > >

1 0

Re: [resend2] gdi32/tests: Add a test for GdiGetCodePage().
by Peter Oberndorfer 14 Dec '08

14 Dec '08

On Sonntag 14 Dezember 2008, ByeongSik Jeon wrote: > http://bugs.winehq.org/show_bug.cgi?id=16325 > > 2008-12-14 (Sun), 13:34 +0100, Paul Vriens wrote: > > Could you turn the skip in this piece of code: > > > > + if (!pGdiGetCodePage) > > + { > > + skip("GdiGetCodePage not available on this platform\n"); > > + return; > > + } > > > > into a win_skip? That way we fail if the function is not available in Wine. > > > I changed it to the trace(). > > Another thing I'm not sure about though is that in the for() loop you > > don't do a DeleteObject( hfont ). Is that only needed at the end? > > Thanks. > > --- > dlls/gdi32/tests/Makefile.in | 2 +- > dlls/gdi32/tests/font.c | 153 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 154 insertions(+), 1 deletions(-) > Hi, some small style notes. > + CHARSETINFO csi; > + > + if ( ( ansi_assoc == -1 || oem_assoc == -1 ) && > + RegOpenKeyA ( HKEY_LOCAL_MACHINE, associated_charset, &hkey) == ERROR_SUCCESS ) > + { > + RegQueryInfoKeyA ( hkey, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &max_data_len, NULL, NULL ); > + data = HeapAlloc ( GetProcessHeap(), 0, max_data_len ); > + please try to use similar spacing like other parts of the file no space before and after '(' when calling a function. > + case MAC_CHARSET: > + acp = GetACP(); > + cp = ( acp == 932 || acp == 936 || acp == 949 || acp == 950 )? 1252 : CP_ACP; > + break; Please try to avoid trailing whitespace > + JOHAB_CHARSET, > + VISCII_CHARSET, > + TCVN_CHARSET, > + KOI8_CHARSET, > + ISO3_CHARSET, > + ISO4_CHARSET, > + ISO10_CHARSET, > + CELTIC_CHARSET, also some trailing whitespace here. Thanks for you patch. Greetings Peter

1 0

Re: [resend2] gdi32/tests: Add a test for GdiGetCodePage().
by Paul Vriens 14 Dec '08

14 Dec '08

ByeongSik Jeon wrote: > http://bugs.winehq.org/show_bug.cgi?id=16325 > > 2008-12-14 (Sun), 13:34 +0100, Paul Vriens wrote: >> Could you turn the skip in this piece of code: >> >> + if (!pGdiGetCodePage) >> + { >> + skip("GdiGetCodePage not available on this platform\n"); >> + return; >> + } >> >> into a win_skip? That way we fail if the function is not available in Wine. >> > I changed it to the trace(). >> Another thing I'm not sure about though is that in the for() loop you >> don't do a DeleteObject( hfont ). Is that only needed at the end? > > Thanks. > > --- > dlls/gdi32/tests/Makefile.in | 2 +- > dlls/gdi32/tests/font.c | 153 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 154 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, The trace() is worse. The first one should be a win_skip() the second one a skip(), so: if (!pGdiGetCodePage) { win_skip("GdiGetCodePage not available on this platform\n"); return; } if (!is_font_installed( "Arial" ) ) { skip("Arial is not installed\n"); return; } The win_skip() means we skip the test on Windows if this function is not present but it will fail on Wine if this function is not there(exported). This will make sure that nobody messes up this function . The skip() will make sure we skip the tests on all platforms if Arial is not available. For that second item. Isn't it enough to put the GetDC() before the for-loop and the ReleaseDC after the for-loop? -- Cheers, Paul.

1 0