December 2008 - Wine-devel - list.winehq.org

Bugzilla's down again
by Austin English 01 Dec '08

01 Dec '08

Different error than usual though: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>500 Internal Server Error</title> </head><body> <h1>Internal Server Error</h1> <p>The server encountered an internal error or misconfiguration and was unable to complete your request.</p> <p>Please contact the server administrator, bugs-admin(a)winehq.org and inform them of the time the error occurred, and anything you might have done that may have caused the error.</p> <p>More information about this error may be available in the server error log.</p> </body></html> Is there anything we can do to prevent it from going down so much? -- -Austin

3 3

Patchwatcher locked up?
by Michael Stefaniuc 01 Dec '08

01 Dec '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello Dan, did the patchwatcher look up? The last patch it shows is from 30-Nov-2008 14:01. bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org iD8DBQFJNCYg08alQ5mXm14RAnsPAJ44C2vVFmSnD5OknaoMGPkSuB+VFQCfbb6J PhbFmQ4U1nOrHIw5JycPWbc= =005q -----END PGP SIGNATURE-----

1 0

Re: Did anyone have any trouble compiling wine today? Or was it just me ....
by Susan Cragin 01 Dec '08

01 Dec '08

>On Mon, Dec 1, 2008 at 9:06 AM, Susan Cragin <susancragin(a)earthlink.net> wrote: >>>>I don't know off hand then. I'd say run a regression test. As a guess, >>>>you might try removing: >>>>#ifdef HAVE_LINUX_SERIAL_H >>>>#include <linux/serial.h> >>>>#endif >>>> >>>>but that would just be a kludgy workaround. >>>> >>>>-- >>>>-Austin >>> >>>Will try both tomorrow. >>>Thanks. >> >> Austin: >> Did not see above section, but did see this, so removed it. >> #ifdef HAVE_LINUX_INPUT_H >> #include <linux/input.h> >> #endif >> Did not work. Got same error. :( > >Regression test? As Detleft said, it may be kernel related. > >-- >-Austin Found something similar to what Detlef found, so filed a Ubuntu bug against the kernel. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/303711 Also tried new kernel, 2.6.28-1-ub, but got same result. Susan

1 0

netapi32: Why my patch is ignored?
by Vitaly Perov 01 Dec '08

01 Dec '08

What is wrong with my patch? I have fixed all errors found by Juan Lang. I resent this patch several times, but hasn't received any answer. Why my patch is ignored? Maybe something is still wrong, but why somebody just tell me about it? "Juan Lang" <juan.lang(a)gmail.com> wrote: >Hi Vitaliy, overall your patch looks pretty good. A few minor points: > >+ FIXME("(%s %d %p) partially implemented\n", >debugstr_w(servername), level, buf); >Because you add a more specific FIXME for every unimplemented path, it >seems to me this would be better as a TRACE. > >+ result = RegCreateKeyExA(HKEY_LOCAL_MACHINE, regKey, 0, NULL, 0, >KEY_WRITE, >+ NULL, &hKey, &disposition); >+ if (result != ERROR_SUCCESS) >+ { >+ FIXME("Unable to open/create key 'HKLM\\%s'\n", regKey); >+ return result; >This shouldn't be a FIXME, as there's nothing to "fix" in the code: >if the key couldn't be created, there's a setup problem or some other >unrecoverable error. A TRACE is fine. >+ /* FIXME: A duplicate patch checking should be implemented here */ >Do you mean a duplicate path? -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

3 3

Re: mshtml: suppress module unloading while gecko is loaded
by Paul Bryan Roberts 01 Dec '08

01 Dec '08

> Dan Kegel wrote: > Thanks to Mike Hearn for pointing out that mshtml reference > counting was wrong, and Jacek for pointing out how to fix > it for now. > > Once gecko is loaded, don't let mshtml unload. > This fixes a crash in starting Sketchup (bug 16164), > and probably fixes a number of other apps that > went pear-shaped after unloading mshtml... > Bug 14065 is another instance of the same thing. I did a quick survey of DllCanUnloadNow() on the Wine 1.1.8 code base a couple of weeks ago ... 55 DllCanUnloadNow routines (in some 272 dll subdirectories) 11 FIXME stubs return S_FALSE 7 FIXME stubs return S_OK 3 without FIXME return S_FALSE 2 without FIXME return S_OK 32 appear to be real implementations However, the first in the list (alphabetically) is in astream/main.c. It's reference counter (ddl_ref) is not incremented or decremented anywhere. I count four pairs of inc/dec omissions. In mshtml, I count 7 dll reference count inc/dec pairs, including the server lock pair, in main.c, htmldoc.c and protocol.c I count 28 pairs of InterlockedDecrement / InterlockedIncrement calls around the creation / destruction of active objects throughout the dll. That would seem to imply 22 missing reference count inc/dec pairs. If I finish my script, it will report how many pairs are missing for which dlls and in which source files, which might help make a decision whether the take up Mike Hearn's suggestion of never unloading anything. Even that should involve work taking out the reference counts that are already there. I do not see how the classic WinAPI regression tests can catch this kind of bug other than being a tautologous test of the creation/destruction all the known active objects. If Mike Hearn's suggestion is not taken up, the script might also be useful for regression test purposes. Cheers,

2 1

Re: [1/4] winemenubuilder: move path normalization to Process_Link and Process_URL
by Francois Gouget 01 Dec '08

01 Dec '08

On Sun, 30 Nov 2008, Ambroz Bizjak wrote: [...] > To allow that, I've modified winemenubuilder to record created shortcuts to > registry, and my service will obtain and maintain the list of .lnk/url files > from there. The general idea is good, but I don't think you should store these paths in the registry. Instead the daemon should ask for file change notifications for the relevant special folders (CSIDL_STARTMENU, etc) and act accordingly when a .lnk or .url file gets added / deleted somewhere in thes directories. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Advice is what we ask for when we already know the answer but wish we didn't -- Eric Jong

2 1

Re: Did anyone have any trouble compiling wine today? Or was it just me ....
by Susan Cragin 01 Dec '08

01 Dec '08

>>I don't know off hand then. I'd say run a regression test. As a guess, >>you might try removing: >>#ifdef HAVE_LINUX_SERIAL_H >>#include <linux/serial.h> >>#endif >> >>but that would just be a kludgy workaround. >> >>-- >>-Austin > >Will try both tomorrow. >Thanks. Austin: Did not see above section, but did see this, so removed it. #ifdef HAVE_LINUX_INPUT_H #include <linux/input.h> #endif Did not work. Got same error. :(

1 0

Re: [2/2] shell32/autocomplete: add unit tests for autocomplete
by Paul Vriens 01 Dec '08

01 Dec '08

Jan de Mooij wrote: > Tests pass on 98, XP and Wine (after applying my previous patch) > > > ------------------------------------------------------------------------ > > There is an unrelated change to shelllink.c in this patch. -- Cheers, Paul.

2 2

Fwd: [1/2] shell32/autocomplete: fix handling of WM_KILLFOCUS messages (try 2)
by Jan de Mooij 01 Dec '08

01 Dec '08

Hello, Anybody knows why this patch was rejected? Thanks in advance. ---------- Forwarded message ---------- From: Jan de Mooij <jandemooij(a)gmail.com> Date: Sat, Nov 29, 2008 at 8:57 PM Subject: [1/2] shell32/autocomplete: fix handling of WM_KILLFOCUS messages (try 2) To: wine-patches(a)winehq.org

1 0

Re: wined3d: Sign-compare warnings fix
by Austin English 01 Dec '08

01 Dec '08

On Sat, Nov 29, 2008 at 11:42 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > wined3d: Sign-compare warnings fix. > > @@ -504,7 +504,7 @@ static void shader_generate_glsl_declarations(IWineD3DBaseShader *iface, const s > IWineD3DBaseShaderImpl* This = (IWineD3DBaseShaderImpl*) iface; > IWineD3DDeviceImpl *device = (IWineD3DDeviceImpl *) This->baseShader.device; > int i; > - unsigned int extra_constants_needed = 0; > + unsigned int i, extra_constants_needed = 0; > const local_constant *lconst; > > /* There are some minor differences between pixel and vertex shaders */ > > > You forgot to remove 'int i' here. -- -Austin

2 1