December 2008 - Wine-devel - list.winehq.org

Re: [PATCH] comdlg32: Avoid passing NULL to FILEDLG95_LOOKIN_InsertItemAfterParent.
by Vincent Povirk 04 Dec '08

04 Dec '08

Hi, I think you need to free the pidl you get from SHGetSpecialFolderLocation. Vincent Povirk On Thu, Dec 4, 2008 at 4:57 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is my second attempt to fix bug 16332. We can make sure > FILEDLG95_LOOKIN_InsertItemAfterParent() doesn't infinite loop by > always giving it a non-null pidl. The Desktop folder seems like a > sensible default. > > > >

1 0

Re: patch for gdi32
by Dan Kegel 04 Dec '08

04 Dec '08

On Wed, Dec 3, 2008 at 1:24 PM, Dan Kegel <dank(a)kegel.com> wrote: > Hi Xiangrong, > you forgot to attach the patch, I think. Aha. You attached the wrong format. We want a plain text file, i.e. not .odt, but .txt. The nice description in your .odt/.pdf belongs in a bug report in http://bugs.winehq.org. (And, as somebody mentioned, there may be related bugs already, e.g. http://bugs.winehq.org/show_bug.cgi?id=4065 ) If you don't want to use "git diff" to generate the patch, use 'diff -u'. See http://kegel.com/academy/opensource.html#patches Good luck, and welcome to Wine development! - Dan

3 3

re: wineconsole: Wait on events in curses backend using select instead of poll
by Dan Kegel 04 Dec '08

04 Dec '08

James McKenzie wrote: > This will have to be setup so that it only works for Macs. > ... it does not belong in the Wine code stack. Why? Select is a perfectly reasonable choice -- and arguably preferable to poll -- when you are absolutely sure that no file descriptor higher than 1023 can be passed to it. (e.g. when you're using it in a program that does not open many file descriptors, or when you're using it with no file descriptors, as a nice sleep). I think wineconsole is an example of an app that does not open many file descriptors, so select is fine there. - Dan

1 0

Re: dsound: fix remaining ds3d, dsound, dsound8 test failures shown on test.winehq.org
by Paul Vriens 04 Dec '08

04 Dec '08

Jeff Zaroyko wrote: > This should clear up the remaining dsound test failures shown for the > Win98 and WinME test results. > > > ------------------------------------------------------------------------ > > Hi Jeff, Would be a nice-to-have if you could add the platforms as comments to the different return values. -- Cheers, Paul.

2 2

Any problems with these wineconsole patches?
by Martin Storsjö 04 Dec '08

04 Dec '08

Hi, In addition to the select vs poll patch to wineconsole, I sent two other unrelated minor patches for wineconsole last Friday (attached here); are there any obvious problems with these, prohibiting them from getting merged? The first one simply makes fallbacks from the curses to the user backend work if the curses library isn't found; not only in the case when the curses backend isn't compiled in at all. The second one makes --use-event not resetting the backend to user, since that's already the default. By setting the environment variable WINECONSOLE="wineconsole --backend=curses", the user could make all implicitly opened consoles be curses based consoles -- if --use-event wouldn't reset the backend back to user as it does at the moment. Regards, // Martin

1 0

Re: wineconsole: Wait on events in curses backend using select instead of poll
by Kai Blin 04 Dec '08

04 Dec '08

On Sunday 30 November 2008 00:52:57 Martin Storsjö wrote: > poll can't handle terminal devices on Darwin, since Tiger. See the > following discussion: > http://lists.apple.com/archives/Darwin-dev/2006/Apr/msg00066.html There's reasons we switched from select to poll. You can't just switch back to select to work around a OSX _bug_. If Apple can't get their act together to fix this, this needs to go behind a configure check/ifdef. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 3

Re: patch for gdi32
by Henri Verbeet 03 Dec '08

03 Dec '08

Isn't this the same issue a bug 4065? (http://bugs.winehq.org/show_bug.cgi?id=4065)

1 0

Mono integration to Wine
by Kornél Pál 03 Dec '08

03 Dec '08

Hi, Wine is still using Mono by creating a new process altough it has support for _CorExeMain and _CorDllMain. There is a MonoFixupCorEE method exported by mono.dll that could be used. I also did some research on executing exe assemblies without creating a mono.exe process on MS Windows by injecting code to the new process before initialization to load Mono. Note that because mscoree.dll is loaded at a very early process initilization stage no side-by-side manifests can be used that is required by newer MSVCRTs so I'll most likely create a separate DLL that will load mono.dll later in _CorExeMain or _CorDllMain. For the above mentioned reason it may be better not to use MonoFixupCorEE yet. I would like to receive comments on mixed-mode assembly support of Mono on Wine and if there are people willing to update the Loader to call _CorValidateImage, _CorExeMain (real entry point is not called for EXEs) and _CorImageUnloading for managed images. MSVCRT also should call CorExitProcess on exit. Kornél

2 1

Re: [2/2] gdiplus: fix a warning in GdipMultiplyTextureTransform
by Henri Verbeet 03 Dec '08

03 Dec '08

2008/12/3 Nikolay Sivov <bunglehead(a)gmail.com>: > - return GdipMultiplyMatrix(brush->transform, matrix, order); > + return GdipMultiplyMatrix(brush->transform, (GpMatrix*)matrix, order); I don't think casting const away makes it much better. Considering what the function does, and the fact that the matrix *is* const in the prototype for Matrix::Multiply(), I'd say it would be better to just change the prototype for GdipMultiplyMatrix. MS doesn't seem to care a whole lot about their plain C interfaces these days. Slightly OT, the code in matrix_multiply() isn't quite the most efficient way to multiply two 2x3 matrices, although if you're lucky the compiler will unroll the loop for you and fold the constants.

2 2

IServiceProvider::QueryService tests
by Konstantin Kondratyuk 03 Dec '08

03 Dec '08

In dlls/mshtml/tests/htmldoc.c there is a comment: /* * Services used by HTMLDocument: * * IOleUndoManager * IInternetSecurityManager * ITargetFrame * {D5F78C80-5252-11CF-90FA-00AA0042106E} * HTMLFrameBase * IShellObject * {3050F312-98B5-11CF-BB82-00AA00BDCE0B} * {53A2D5B1-D2FC-11D0-84E0-006097C9987D} * {AD7F6C62-F6BD-11D2-959B-006097C553C8} * DefView (?) * {6D12FE80-7911-11CF-9534-0000C05BAE0B} * IElementBehaviorFactory * {3050F429-98B5-11CF-BB82-00AA00BDCE0B} * STopLevelBrowser * IHTMLWindow2 * IInternetProtocol * IWebBrowserApp * UrlHostory * IHTMLEditHost * IHlinkFrame */ It is confirmed by tests? I have not found. It seems to me, also there should be IHTMLEditServices interface support. How it is correct to add the test on IServiceProvider::QueryService? Thanks. -- Best regards, Konstantin Kondratyuk.

1 0