February 2008 - Wine-devel - list.winehq.org

Re: msvcrt: Implemented wcscpy_s
by Dmitry Timoshkov 22 Feb '08

22 Feb '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > --- a/dlls/msvcrt/msvcrt.spec > +++ b/dlls/msvcrt/msvcrt.spec > @@ -761,6 +761,7 @@ > @ cdecl wcscmp(wstr wstr) ntdll.wcscmp > @ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll > @ cdecl wcscpy(ptr wstr) ntdll.wcscpy > +@ cdecl wcscpy_s(wstr long wstr) MSVCRT_wcscpy_s Type of the first parameter should be ptr, not wstr. -- Dmitry.

1 0

Re: appdb: Increase readability by using slightly softer colours on Warning and Notes
by Francois Gouget 22 Feb '08

22 Feb '08

On Wed, 20 Feb 2008, Jeff Zaroyko wrote: > The default colours for warnings and notes on the appdb pages feel > rather strong, this patch changes the red and blue to be a bit softer. > > I think this makes it more readable. A comparison can be seen here: > http://jeffz.name/tmp/ In new.png the green looks darker than the others. Maybe it should be lightened up a bit too. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ In a world without fences who needs Gates?

4 7

Re: dmband: Indirection levels fix
by Robert Shearman 21 Feb '08

21 Feb '08

Andrew Talbot wrote: > diff --git a/dlls/dmband/band.c b/dlls/dmband/band.c > index 891fb5a..8b89573 100644 > --- a/dlls/dmband/band.c > +++ b/dlls/dmband/band.c > @@ -173,7 +173,7 @@ static HRESULT WINAPI IDirectMusicBandImpl_IDirectMusicObject_SetDescriptor (LPD > This->pDesc->ftDate = pDesc->ftDate; > if (pDesc->dwValidData & DMUS_OBJ_MEMORY) { > This->pDesc->llMemLength = pDesc->llMemLength; > - memcpy (This->pDesc->pbMemData, pDesc->pbMemData, sizeof (pDesc->pbMemData)); > + memcpy (&This->pDesc->pbMemData, &pDesc->pbMemData, sizeof (pDesc->pbMemData)); > } > if (pDesc->dwValidData & DMUS_OBJ_STREAM) { > /* according to MSDN, we copy the stream */ This isn't correct. Judging by the surrounding code, this should be allocating a block of memory of This->pDesc->pbMemData and then passing pDesc->llMemLength into memcpy, possibly validating that pDesc->llMemLength isn't greater than UINT_MAX to avoid an overflow. -- Rob Shearman

2 1

Re: [1/2] ddraw: release interfaces when exiting with error
by Stefan Dösinger 21 Feb '08

21 Feb '08

Am Mittwoch, 20. Februar 2008 22:03:51 schrieben Sie: > --- > dlls/ddraw/texture.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) Just a general comment(not specific to comments): For such cleanup work it works quite nice to use goto(!), as shown below. Your patch is OK as it is, but I think its a good idea to use this scheme in all places because it helps to prevent new problems from coming in when the code is changed. void *a = NULL, *b = NULL, *c = NULL; a = malloc(10); if(!a) goto error; b = malloc(10); if(!b) goto error; c = malloc(10); if(!c) goto error; if(dosomethingelse() == FAIL) goto error; return SUCCESS; error: f(c) free(c); f(b) free(b); f(a) free(a); return FAIL;

1 0

Re: dplayx: Fix incorrect check in DirectPlayLobbyAImpl_EnumLocalApplications and IDirectPlayLobbyAImpl_EnumAddressTypes.
by Marcus Meissner 21 Feb '08

21 Feb '08

On Thu, Feb 21, 2008 at 04:44:34PM +0000, Robert Shearman wrote: > > Dereferencing a function pointer and checking it against NULL doesn't make > any sense, so remove the checks. > - if( !lpEnumAddressTypeCallback || !*lpEnumAddressTypeCallback ) > + if( !lpEnumAddressTypeCallback ) It looks as if they were meant as &&, but that does not make much sense either. Ciao, Marcus

1 0

Re: James Hawkins : itircl: Add a stub implementation of itircl.dll.
by Detlef Riekenberg 21 Feb '08

21 Feb '08

On Sa, 2008-02-16 at 09:57 -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 58b0686e951364686c3b5b55c18566df0960fd96 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=58b0686e951364686c3b5b55c… > > Author: James Hawkins <jhawkins(a)codeweavers.com> > Date: Fri Feb 15 17:39:46 2008 -0600 > > itircl: Add a stub implementation of itircl.dll. Hi James. While adding your Patch to http://wiki.winehq.org/Developers-Hints , I found this Page: http://www.helpware.net/aphelp/info.htm itircl.dll: HTML Help 1 (found on w2k and xp) itircl52.dll: MS Help 2 apircl.dll: Assistance Platform 1.0 (Vista) -- By by ... Detlef

1 0

Re: slc: Added stub for SLGetWindowsInformationDWORD
by Paul Vriens 21 Feb '08

21 Feb '08

On Thu, Feb 21, 2008 at 10:20 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added stub for SLGetWindowsInformationDWORD > > Best Regards > Alistair Leslie-Hughes > Hi Alistair, I know that function descriptions should always be your own words but I guess this is also true for header files. The comments in slerror.h are exactly like the comments on MSDN: http://msdn2.microsoft.com/en-us/library/aa965835(VS.85).aspx Cheers, Paul.

3 2

Re: Adding devices in setupapi
by Erich Hoover 21 Feb '08

21 Feb '08

> > I think it probably does something similar to: > http://www.codeproject.com/KB/system/RemoveDriveByLetter.aspx > > Except instead of mapping a drive to usb device, it does it the other > way around. > > After looking more into it it really looks like this is the thing it > does. (I need a bunch of hacks for it to work, but alas.) However it > doesn't get me much further since our IOCTL_STORAGE_GET_DEVICE_NUMBER > ioctl is a stub. I would need something that can at least guarantee > uniqueness per volume for it, perhaps a conversion of drive letter to > integer. Now I just need to figure that one out. > > Cheers, > Maarten. > > I do not believe the device number matching is the problem, I have been exploring this problem a little with RemoveDriveByLetter and I believe that it is not working because the SymbolicLink entry is not added as a "real" thing in Wine. Performing an experiment with accessing the same drive letter in three different ways (results below, last parameter is "hDrive") I see that only the call with the registry-returned value for the drive fails (even if it is added to "HKLM/System/MountedDevices"). I believe that a call to IoCreateSymbolicLink must be made in order for the name returned by the registry to be recognized as an alias for the drive. I think iTunes is probably going through the device tree looking for its vendor and product code. It should get this back from CM_Get_Device_ID, but I do not have Windows so I cannot fake iTunes out to confirm this. SetupDiGetDeviceInterfaceDetail '\\?\USBSTOR#Disk&Ven_Apple&Prod_iPod&Rev_1.62#000A27001420C124&0#{53f56307-b6bf-11d0-94f2-00a0c91efb8b}': -1 SetupDiGetDeviceInterfaceDetail '\\?\Volume{00000000-0000-0000-0000-000000000048}': 60 SetupDiGetDeviceInterfaceDetail '\\.\H:': 64 Device number comparison: 1 1

1 0

No new Wine Weekly News?
by Austin English 21 Feb '08

21 Feb '08

Hasn't been a new Wine Weekly News in about a month...quite a bit has been going on, with CS2 working out of the box, test suite fixes, etc. Anyone know what's going on? -Austin

2 1

Re: appdb: database issues
by Chris Morgan 21 Feb '08

21 Feb '08

In include/query.php in query_appdb() we only call mysql_connect() if the global $hAppdbLink isn't a valid resource. So, when a user connects to display a page the first query should open the connection and upon completion of the script $hAppdbLink will be freed and the connection should be closed. So I'm not sure that this is the cause of the out-of-connections issue although I don't see a reason why we shouldn't just let php take care of this internally and apply a variation of your change where we always attempt to connect and select the appropriate database and remove the global handle and the resource check etc. Chris On Wed, Feb 20, 2008 at 6:01 PM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > The mysql database for the appdb/bugzilla appears to have gone down again, > I decided to look at the connection code in the appdb, as the appdb is thought > to be the culprit. > > I came across the call to mysql_connect which is using the new_link parameter > set to true, which is supposedly to force a new connection to be established. > > So, I searched through the git commit history using gitk and saw that Paul van > Schayck made a change introducing this, apparently because mysql was having > stability issues, back in 2005. > > http://www.winehq.org/pipermail/wine-patches/2005-January/014985.html > > my understanding is that php will automagically reuse connections if this is not > set, would there by any objection to trialling a removal of this > option to see if > stability increases? > > > >

1 0