February 2008 - Wine-devel - list.winehq.org

Re: [1/2] user32:scroll: Added some tests for scrollbar [try2]
by Alexandre Julliard 20 Feb '08

20 Feb '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > Changelog: > Added some tests for scrollbar The tests fail: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so scroll.c && touch scroll.ok scroll.c:56: Test failed: The scrollbar window should be disabled. scroll.c:122: Test failed: The ShowScrollBar() should failed. make: *** [scroll.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Adding devices to registry with the help of hal
by Christian Gmeiner 20 Feb '08

20 Feb '08

Hi all, I want you to present my current proof-of-conecpt. It shows how we can use hal.c of explorer to create registry keys for devices. Keep in mind that it only creates one registry key for each usb device at the moment. Before I investigate more time in this, I want to get some feedback about my method. If you are happy with it, I will finish this suftt :) Greets, Christian

1 0

re: Do we need a forum?
by Dan Kegel 20 Feb '08

20 Feb '08

Steven Edwards wrote: > My thoughts, as well as > Tom's was that by creating a "blessed" location, all third parties as > well as vendors that develop Wine related products could say "if you > want to discuss using a vendor provided Wine product in a > non-supported manner all are advised to go here and share information" Yes, of course, it would be nice if there were One True Place to go, but the closest we're ever going to get is essentially the status quo, where the wine-users mailing list is the place of record for user support, the appdb is the place of record for looking for tips for a particular app, and all the other areas are secondary. We can improve slightly on this by linking to other popular wine forums as they pop up, emphasizing all the while that they are secondary. - Dan

5 8

Fwd: Adding devices in setupapi
by Maarten Lankhorst 20 Feb '08

20 Feb '08

Hi Juan, 2008/2/19, Juan Lang <juan.lang(a)gmail.com>: > > I stubbed CM_get_parent by returning itself, however that makes it go > > in an infinite loop. > > Hm. > > > My guess is that I need to have some hub and usb ehci device as well. > > I don't know why it would want to call CreateFile on the device though > > but my expertise on that part is very limited, perhaps it allows > > communication to the ipod by accessing the device in a raw way? > > Perhaps, or perhaps it's just making sure you don't have a fake device :-/ > --Juan The only way to be sure would be to create my own test program that would do the same, and see what happens. How hard is it to create a stub forwarder dll for setupapi and cfgmgr32? Cheers, Maarten.

1 0

Saulius sent you a friend request on Yaari...
by Saulius 20 Feb '08

20 Feb '08

1 0

Adding devices in setupapi
by Maarten Lankhorst 20 Feb '08

20 Feb '08

Hi all, I'm trying to add the ipod detection from crossover wine to winehq. However it seems to be not compatibel due to changes to setupapi in the last 3 years. Basically what I want to do is add an usb mass storage device with the correct device path and register it with setupapi. Composing the string is easy but I'm not 100% sure what the locations are. The code seems a bit vague in that aspect. The snippet iTunes uses for detection is shown below: SetupDiGetClassDevsExW {53f56307-b6bf-11d0-94f2-00a0c91efb8b} (null) (nil) 0x00000012 (nil) (null) (nil) SetupDiEnumDeviceInterfaces 0x136638, (nil), {53f56307-b6bf-11d0-94f2-00a0c91efb8b}, 0, 0x7aa2140c How do I get my device listed in SetupDiEnumDeviceInterfaces there so iTunes can pick it up? Cheers, Maarten.

3 2

Making use of setupapi
by Maarten Lankhorst 19 Feb '08

19 Feb '08

Hi folks, Any one around who understands setupapi? For iTunes I would need to add appropriate registry keys so that my usb device is detected. My idea is to use libusb to find the things like guid, revision etc and then adding the keys. However I am not 100% what the layout of the keys is. Cheers, Maarten.

3 3

Re: ddraw: Assign to structs instead of using memcpy
by Stefan Dösinger 19 Feb '08

19 Feb '08

Am Samstag, 16. Februar 2008 23:33:37 schrieb Andrew Talbot: > Here, I am assuming that the "dwSize" elements in all these cases should be > set to the size of the struct each is in, respectively. Please advise if > this assumption is wrong. It's not necessarily true. Sometimes there are multiple versions of the same structure. You can check ddraw.h and d3dtypes.h. If there is only one version your assumption should be true. If there isn't, then your assumption may still be true. In that case there are some tests how the Setter methods deal with newer or older structures(in some cases we may need more tests) > Thanks, > > -- Andy. > --- > Changelog: > ddraw: Assign to structs instead of using memcpy. > > diff --git a/dlls/ddraw/device.c b/dlls/ddraw/device.c > index b60b6f3..03ccea8 100644 > --- a/dlls/ddraw/device.c > +++ b/dlls/ddraw/device.c > @@ -704,7 +704,7 @@ > IDirect3DDeviceImpl_1_CreateExecuteBuffer(IDirect3DDevice *iface, > object->d3ddev = This; > > /* Initializes memory */ > - memcpy(&object->desc, Desc, Desc->dwSize); > + object->desc = *Desc; > > /* No buffer given */ > if ((object->desc.dwFlags & D3DDEB_LPDATA) == 0) > diff --git a/dlls/ddraw/material.c b/dlls/ddraw/material.c > index d6b9a7c..8e17174 100644 > --- a/dlls/ddraw/material.c > +++ b/dlls/ddraw/material.c > @@ -250,7 +250,7 @@ IDirect3DMaterialImpl_SetMaterial(IDirect3DMaterial3 > *iface, /* Stores the material */ > EnterCriticalSection(&ddraw_cs); > memset(&This->mat, 0, sizeof(This->mat)); > - memcpy(&This->mat, lpMat, lpMat->dwSize); > + This->mat = *lpMat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > @@ -285,7 +285,7 @@ IDirect3DMaterialImpl_GetMaterial(IDirect3DMaterial3 > *iface, EnterCriticalSection(&ddraw_cs); > dwSize = lpMat->dwSize; > memset(lpMat, 0, dwSize); > - memcpy(lpMat, &This->mat, dwSize); > + *lpMat = This->mat; > LeaveCriticalSection(&ddraw_cs); > > return DD_OK; > diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c > index deb4146..8dfc015 100644 > --- a/dlls/ddraw/viewport.c > +++ b/dlls/ddraw/viewport.c > @@ -261,7 +261,7 @@ IDirect3DViewportImpl_GetViewport(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp1), dwSize); > + *lpData = This->viewports.vp1; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT :\n"); > @@ -301,7 +301,7 @@ IDirect3DViewportImpl_SetViewport(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 0; > memset(&(This->viewports.vp1), 0, sizeof(This->viewports.vp1)); > - memcpy(&(This->viewports.vp1), lpData, lpData->dwSize); > + This->viewports.vp1 = *lpData; > > /* Tests on two games show that these values are never used properly > so override them with proper ones :-) > @@ -856,7 +856,7 @@ IDirect3DViewportImpl_GetViewport2(IDirect3DViewport3 > *iface, } > dwSize = lpData->dwSize; > memset(lpData, 0, dwSize); > - memcpy(lpData, &(This->viewports.vp2), dwSize); > + *lpData = This->viewports.vp2; > > if (TRACE_ON(d3d7)) { > TRACE(" returning D3DVIEWPORT2 :\n"); > @@ -895,7 +895,7 @@ IDirect3DViewportImpl_SetViewport2(IDirect3DViewport3 > *iface, EnterCriticalSection(&ddraw_cs); > This->use_vp2 = 1; > memset(&(This->viewports.vp2), 0, sizeof(This->viewports.vp2)); > - memcpy(&(This->viewports.vp2), lpData, lpData->dwSize); > + This->viewports.vp2 = *lpData; > > if (This->active_device) { > > IDirect3DDevice3_GetCurrentViewport(ICOM_INTERFACE(This->active_device, > IDirect3DDevice3), &current_viewport);

2 3

Re: WineD3D: let flush_to_framebuffer_drawpixels use a valid rect
by Stefan Dösinger 19 Feb '08

19 Feb '08

Am Dienstag, 19. Februar 2008 21:26:24 schrieben Sie: > Hi, > > Originally flush_to_framebuffer_drawpixels was called from UnlockRect, so > in that case LockedRect was always set. These days it can also be called > (through LoadLocation) from other places. This patch makes it use the > LockedRect when the surface is locked else the whole surface is uploaded. > This fixes rendering issues in Red Alert and other apps. Wouldn't it be better to make sure that the caller passes the correct rectangle to flush_to_framebuffer_* ? > - if(dxVersion >= 8) { > + if(0 && dxVersion >= 8) { Is this intentional?

1 0

Re: slc: Initial stub DLL (try 2)
by Robert Shearman 19 Feb '08

19 Feb '08

Alistair Leslie-Hughes wrote: > slc: Initial stub dll I'm not sure we want to go down the path of implementing the functions in this DLL. Furthermore, this file isn't present on an XP SP2 installation. Can you give some information as to why this is needed and how the application depends on this DLL? -- Rob Shearman

3 3