February 2008 - Wine-devel - list.winehq.org

Re: Make.rules.in: Pass the --nounistd flag to flex since unistd.h is a header that might not be present on all systems.
by Alexandre Julliard 19 Feb '08

19 Feb '08

Robert Shearman <rob(a)codeweavers.com> writes: > If we do need it, we can include it in the .l file after config.h and > with an appropriate include guard. You should instead put a %option in the files that need it. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: Pass parms through to PdhLookupPerfIndexByNameW for checking
by Dmitry Timoshkov 19 Feb '08

19 Feb '08

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + if (machine && !(machineW = pdh_strdup_aw( machine ))) return PDH_MEMORY_ALLOCATION_FAILURE; > > - if (machine) > - { > - FIXME("remote machine not supported\n"); > - return PDH_CSTATUS_NO_MACHINE; > - } > if (!(nameW = pdh_strdup_aw( name ))) > return PDH_MEMORY_ALLOCATION_FAILURE; > > ret = PdhLookupPerfIndexByNameW( NULL, nameW, index ); You forgot to actually pass machineW to PdhLookupPerfIndexByNameW. -- Dmitry.

1 0

re: Do we need a forum?
by Dan Kegel 19 Feb '08

19 Feb '08

Anybody who thinks we need another forum needs his head examined. There is no shortage of Wine forums. We just need to use the ones that already exist. Adding a new one will just fragment the community further. In particular, there are two forums right now that people already use to discuss wine problems: a generic one at http://www.linuxforums.org/forum/wine/ and an Ubuntu-specific one at http://ubuntuforums.org/forumdisplay.php?f=313 Let's just link to them. I'll submit a patch to do that in a minute. And I like Griswold's idea (on IRC) of improving the current appdb in small ways, e.g. changing the reply behavior to not open up a new page. For goodness' sake, don't create yet another new forum! - Dan

3 2

Re: slc: Add Initial DLL
by John Klehm 19 Feb '08

19 Feb '08

On Feb 18, 2008 10:48 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > Changelog: > slc: Added Initial DLL > > Best Regards > Alistair Leslie-Hughes > > > > No Patch?

1 0

Re: iTunes
by Maarten Lankhorst 19 Feb '08

19 Feb '08

Hi Christopher, Christopher Harvey wrote: > What needs to get done for iTunes to work? v7.6 basically works if you set windows version to windows vista, and find out why the installer fails to create the 'Bonjour service' registry stuff properly. I submitted 8 or so stub dll's to wine-patches that make iTunes v7.6 actually start after installation. It checks for the dll's and silently fails if they don't exist. I haven't done any further testing yet though, but it looks like it is probably a small installer bug that prevents itunes v7.6 from installing without first manually creating those registry keys. Cheers, Maarten.

6 17

Re: Usable Wine interface
by Remco 19 Feb '08

19 Feb '08

----- Original Message ---- > From: Vitaliy Margolen <wine-devel(a)kievinfo.com> > To: wine-devel(a)winehq.org > Sent: Monday, February 18, 2008 4:16:17 AM > Subject: Re: Usable Wine interface > > Remco wrote: > > I'd like to add a feature-request (should this go somewhereelse?) > Yes, bugzilla -> enhancement. > > Vitaliy. Ok, thanks for the info. I added an entry: http://bugs.winehq.org/show_bug.cgi?id=11629 Remco ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

5 5

Re: dlls/user32/edit.c -- remove superflous check (RESEND)
by Alexandre Julliard 19 Feb '08

19 Feb '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn't, but the function returns a LONG, and can (and probably should) return negative values on error. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] Environment variable to specify X11 window for desktop
by Robert Shearman 19 Feb '08

19 Feb '08

Timothy Lee wrote: > The attached patch allows the WINE desktop to be embedded within an > existing X11 window, and is similar to the windowed mode in WINE. > > I've tested this feature using MS PowerPoint Viewer 2007, so that a > fullscreen slideshow can be fitted inside any X11 window. I'm struggling to imagine a case where the behaviour you've implemented is useful. -- Rob Shearman

6 13

Re: [PATCH 2/3] gdi32: Move EnumFontFamiliesEx16() and helper functions to gdi16.c.
by Michael Stefaniuc 18 Feb '08

18 Feb '08

Michael Stefaniuc wrote: > --- > This duplicates for now the FONT_LogFont16ToW() function but Alexandre It duplicates FONT_LogFontWTo16() and not FONT_LogFont16ToW() (that one was already duplicated). > told me on irc that he removed the other user of it in an yet unpublished > patch. Thus FONT_LogFont16ToW() can be removed from font.c in a later FONT_LogFontWTo16() can be removed later on. > patch. > bye michael

1 0

Re: [1/16] msxml3: Support functions for typelib
by Alexandre Julliard 18 Feb '08

18 Feb '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + ITypeLib *tl; > + > + hres = LoadRegTypeLib(&LIBID_MSXML2, 3, 0, LOCALE_SYSTEM_DEFAULT, &tl); > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)&typelib, tl, NULL)) > + ITypeLib_Release(tl); > + } > + > + if(!typeinfos[tid]) { > + ITypeInfo *typeinfo; > + > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], &typeinfo); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + > + if(InterlockedCompareExchangePointer((void**)(typeinfos+tid), typeinfo, NULL)) > + ITypeInfo_Release(typeinfo); > + } > + > + *typeinfo = typeinfos[tid]; > + return S_OK; You should increment the ref count when you are returning a pointer, even if it's also stored in a global variable. -- Alexandre Julliard julliard(a)winehq.org

2 3