March 2008 - Wine-devel - list.winehq.org

Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 19 Mar '08

19 Mar '08

Wine has two bugs filed for this also: http://bugs.winehq.org/show_bug.cgi?id=10495 http://bugs.winehq.org/show_bug.cgi?id=10910 I am worried that everyone (WINE, ALSA, Pulse, Ubuntu) is not on the same page. Will try cross-posting bug information. Part of the problem seems to be that the most-missed application is Skype, and some are trying to get away with blaming closed-source issues. Tom -- I should include the link to your patch, yes, so that other developers have access to it? Susan Dan -- What do you think? Good idea? -----Original Message----- >From: Tomas Carnecky <tom(a)dbservice.com> >Sent: Mar 18, 2008 5:14 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio > >Susan Cragin wrote: >> The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. >> https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 > >Applications that use ALSA should work fine with the alsa pulse plugin - > should. Unfortunately the plugin has a few bugs, and the developers >(of both pulseaudio and alsa) have been unresponsive in this matter. See > - http://www.pulseaudio.org/ticket/198 > - https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2601 > >> Question -- what does WINE do with pulseaudio? > >Some suggested to create a native PulseAudio wine driver. That would >yield the best results as far as the performance and reliability goes. >Unfortunately we'll be stuck with the alsa driver for some time to come, >so I tried to do the best to make the alsa pulse plugin to work with >wine. I had to patch both the wine alsa driver as well as the alsa pulse >plugin and it worked fine for my taste. > >I submitted the patch to wine-patches: >http://www.winehq.org/pipermail/wine-patches/2008-February/050561.html > >I don't know if the relevant alsa pulse plugin patch is publicly >available, I haven't looked at that matter in a long time. Some of the >needed patches are probably still in my local repositories. It makes no >sense for me to work on this anymore until the developers respond to my >questions. > >> http://forum.skype.com/index.php?showtopic=112021 > >I heard that the skype developers are very interested in getting skype >working with pulseaudio, even helped tisting some patches. I have gotten >skype to work with pulseaudio, I think if you apply the second patch >attached to alsa bug #2601 skype will work. I haven't looked at the code >since because apparently nobody from the alsa team is interested in >fixing the bug. > >tom

3 2

Alexandre Julliard : winex11: Fix bug report address
by Groeschel, Volker 19 Mar '08

19 Mar '08

The Patch points to wine-cvs. Shouldn't it point to wine-devel.

5 11

Version of Windows
by Chris Teague 19 Mar '08

19 Mar '08

This is probably trivial, but I'm having a tough time figuring out the current version of Windows that Wine is mimicking. I have a situation where I need to behave differently if the version is NT (0x0500) versus when it is XP (0x0600). I see the WINVER #define, but that doesn't seem right to me since this must be a runtime variable. Can someone point me at an example of how to tell what the current version of Windows is? Thanks, Chris

4 4

Re: Maarten Lankhorst : winmm: Fix midi deadlock by not holding lock on release .
by Ken Thomases 19 Mar '08

19 Mar '08

This has a whiff of the double-checked locking anti-pattern. I can't see a way where it would really bite us in this case, but that anti- pattern has several subtleties. So, I just wanted to prompt people to double-check it (pun acknowledged). Cheers, Ken On Mar 18, 2008, at 7:44 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 15907b5035ea7f03b369a0463ab1f6ac2b24704e > URL: http://source.winehq.org/git/wine.git/?a=commit;h=15907b5035ea7f03b369a0463… > > Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Mon Mar 17 13:15:42 2008 -0700 > > winmm: Fix midi deadlock by not holding lock on release. > > --- > > dlls/winmm/mci.c | 22 ++++++++++++++-------- > 1 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/dlls/winmm/mci.c b/dlls/winmm/mci.c > index b7b5ac2..c792d18 100644 > --- a/dlls/winmm/mci.c > +++ b/dlls/winmm/mci.c > @@ -1767,19 +1767,25 @@ static DWORD MCI_Close(UINT16 wDevID, DWORD > dwParam, LPMCI_GENERIC_PARMS lpParms > TRACE("(%04x, %08X, %p)\n", wDevID, dwParam, lpParms); > > if (wDevID == MCI_ALL_DEVICE_ID) { > - LPWINE_MCIDRIVER next; > - > - EnterCriticalSection(&WINMM_cs); > /* FIXME: shall I notify once after all is done, or for > * each of the open drivers ? if the latest, which notif > * to return when only one fails ? > */ > - for (wmd = MciDrivers; wmd; ) { > - next = wmd->lpNext; > - MCI_Close(wmd->wDeviceID, dwParam, lpParms); > - wmd = next; > + while (MciDrivers) { > + /* Retrieve the device ID under lock, but send the > message without, > + * the driver might be calling some winmm functions > from another > + * thread before being fully stopped. > + */ > + EnterCriticalSection(&WINMM_cs); > + if (!MciDrivers) > + { > + LeaveCriticalSection(&WINMM_cs); > + break; > + } > + wDevID = MciDrivers->wDeviceID; > + LeaveCriticalSection(&WINMM_cs); > + MCI_Close(wDevID, dwParam, lpParms); > } > - LeaveCriticalSection(&WINMM_cs); > return 0; > } > > > >

1 0

Alexandre Julliard : winex11: Fix bug report address
by Groeschel, Volker 19 Mar '08

19 Mar '08

The Patch points to wine-cvs. Shouldn't it point to wine-devel.

1 0

Re: [Try 2] A nicer icon for msiexec
by Alexandre Julliard 19 Mar '08

19 Mar '08

Hervÿffffe9 Chanal <chanal_herve(a)yahoo.fr> writes: > It's a nicer icon for msiexec. From the last submit, several size are > now included in the icon file. The icons are generated using a script > i submitted to wine-patch a long time ago. The svg source is not in > this patch. I can submit it too. Yes, we should include the svg source, and make sure we can rebuild the icons from it. Last time I tried to do that using your script I didn't get good results, the image was all mangled, so we need to look into this further. Can you please resubmit the svg? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] qmgr: Add a stub implementation of IBackgroundCopyJob2.
by Alexandre Julliard 19 Mar '08

19 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -93,6 +93,10 @@ typedef struct > const IClassFactoryVtbl *lpVtbl; > } ClassFactoryImpl; > > +/* This makes it easier to upgrade to IBackgroundCopyJob3, IBackgroundCopyJob4, > + and whatever else MS decides to tack on later. */ > +typedef IBackgroundCopyJob2 BITS_IBackgroundCopyJob; Please don't do that, vtable entries should use the correct types, otherwise it will be very confusing. You'll just have to rename them when switching to a newer version of the interface. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Handle arbitrary length composed input.
by Marcus Meissner 19 Mar '08

19 Mar '08

On Wed, Mar 19, 2008 at 06:16:36PM +0900, Kusanagi Kouichi wrote: > Fix bug #9838. http://bugs.winehq.org/show_bug.cgi?id=9838 > --- > dlls/winex11.drv/keyboard.c | 25 ++++++++++++++++--------- > dlls/winex11.drv/xim.c | 16 ++++++++++------ > 2 files changed, 26 insertions(+), 15 deletions(-) > > diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c > index 33640db..386a471 100644 > --- a/dlls/winex11.drv/keyboard.c > +++ b/dlls/winex11.drv/keyboard.c > @@ -1365,22 +1365,29 @@ void X11DRV_KeyEvent( HWND hwnd, XEvent *xev ) > wine_tsx11_lock(); > /* Clients should pass only KeyPress events to XmbLookupString */ > if (xic && event->type == KeyPress) > + { > ascii_chars = XmbLookupString(xic, event, Str, sizeof(Str), &keysym, &status); > + > + if (status == XBufferOverflow) > + { > + char buf[ascii_chars]; You should not use dynamic sized arrays. Use HeapAlloc() to allocate them. Ciao, Marcus

1 0

cygwin runs!
by Dan Kegel 19 Mar '08

19 Mar '08

Hey! Cygwin actually installs and runs inside Wine! There are a few problems (gcc can't compile "hello, world" yet, symlinks like the one for vi don't work yet, the setup utility doesn't resize properly, and mkpasswd -l aborts), but the shell starts up fine and vim runs inside it! Hats off to the Wine team! - Dan

3 2

Wine wiki cleanup
by Dan Kegel 19 Mar '08

19 Mar '08

Over time, the Wine wiki front page grew rather unwieldy, so I split the developer information off into two new pages, leaving only a simplified front page behind, mostly aimed at users. It's radically simpler. Hopefully it'll be more welcoming to new users. Comments?

2 1