March 2008 - Wine-devel - list.winehq.org

Re: ntoskrnl.exe: Implement MmIsAddressValid (bug 11082)
by Dmitry Timoshkov 18 Mar '08

18 Mar '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > + len = VirtualQuery(VirtualAddress, &info, sizeof(MEMORY_BASIC_INFORMATION)); > + > + if ((len == sizeof(MEMORY_BASIC_INFORMATION)) && > + (info.Protect & (PAGE_READWRITE || PAGE_EXECUTE_READWRITE)) && > + ((info.Protect & PAGE_NOACCESS) == 0) && > + (info.Type & MEM_COMMIT)) > + { > + return TRUE; > + } Besides the already pointed out '||' vs. '|' mismatch your code doesn't handle PAGE_READONLY and others implying read-only access. Probably checking for PAGE_NOACCESS and MEM_COMMIT should be enough. -- Dmitry.

2 1

Re: ntoskrnl.exe: Implement MmIsAddressValid (bug 11082)
by Chris Robinson 18 Mar '08

18 Mar '08

On Monday 17 March 2008 04:09:20 pm Detlef Riekenberg wrote: > + (info.Protect & (PAGE_READWRITE || PAGE_EXECUTE_READWRITE)) && Did you mean | instead of || there?

2 1

Bugzilla request: add new milestone 1.2.0
by Dan Kegel 18 Mar '08

18 Mar '08

Ping. I need this so I can start deferring 1.0 bugs to 1.2. (Deferring them to 1.1 doesn't make a whole lot of sense.)

1 0

Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 18 Mar '08

18 Mar '08

The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 Question -- what does WINE do with pulseaudio? http://forum.skype.com/index.php?showtopic=112021

3 2

Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio
by Susan Cragin 18 Mar '08

18 Mar '08

http://www.pulseaudio.org/ticket/198 I'm not sure it's possible to use the pulseaudio plugin. Pulse seems to think it's a wine defect. -----Original Message----- >From: Marcus Meissner <marcus(a)jet.franken.de> >Sent: Mar 18, 2008 3:15 PM >To: Susan Cragin <susancragin(a)earthlink.net> >Cc: wine-devel(a)winehq.org >Subject: Re: Hardy Heron -- Pulseaudio interferes with non-gnome audio > >On Tue, Mar 18, 2008 at 12:46:16PM -0400, Susan Cragin wrote: >> The new default pulseaudio in Hardy screws up every program that isn't gnome, delivering terrible sound. >> https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/198453 >> Question -- what does WINE do with pulseaudio? >> http://forum.skype.com/index.php?showtopic=112021 > >Just tell the pulseaudio guys to take it a notch down. > >Or use the ALSA pulseaudio wrapper plugin. > >Ciao, Marcus

1 0

Fresh valgrind errors in richedit
by Dan Kegel 18 Mar '08

18 Mar '08

Eric, could you have a look at http://kegel.com/wine/valgrind/logs-2008-03-17/vg-riched20_editor-diff.txt There are several new errors of the sort: + Conditional jump or move depends on uninitialised value(s) + at ME_SetParaFormat (para.c:400) + by ME_SetSelectionParaFormat (para.c:436) + by ME_RTFReadHook (editor.c:662) + by RTFGetToken (reader.c:417) + by RTFRead (reader.c:333) + by ME_StreamIn (editor.c:1095) + by RichEditWndProc_common (editor.c:2432) + by RichEditWndProcA (editor.c:3237) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_call_window (winproc.c:2207) + by call_window_proc (message.c:1615) + by send_message (message.c:2430) + by SendMessageA (message.c:2575) + by test_EM_SETTEXTMODE (editor.c:471) + by func_editor (editor.c:2705) + by run_test (test.h:406) + by main (test.h:455)

2 1

Translations and Wine 1.0
by Michael Stefaniuc 18 Mar '08

18 Mar '08

Hello! We should try to update the translations of Wine to other languages for 1.0. The code freeze during the release candidate time frame is perfect for this as the translations don't have to track a moving target. Somebody had scripts/a web page to check for missing translations or broken ones in the .rc files. But I seem to not enter the right search words to find any info regarding that; if somebody has a pointer please let me know. It would be nice if we could run that scripts regularly during the release candidate time. bye michael

5 6

Re: user32: Test destroying the cursor of a parent process.
by Eric Pouech 18 Mar '08

18 Mar '08

Andrew Riedi a écrit : > changelog: user32: Test destroying the cursor of a parent process. > > -- > Andrew Riedi > ------------------------------------------------------------------------ > > From 25a6a6a2eee92c4325d730ff85bd7cdf01bf2ace Mon Sep 17 00:00:00 2001 > From: Andrew Riedi <andrewriedi(a)gmail.com> > Date: Tue, 8 Jan 2008 05:03:55 -0800 > Subject: [PATCH] user32: Test destroying the cursor of a parent process. > > --- > dlls/user32/tests/cursoricon.c | 201 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 201 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c > index 781282c..c2beffa 100644 > --- a/dlls/user32/tests/cursoricon.c > +++ b/dlls/user32/tests/cursoricon.c > @@ -32,6 +32,205 @@ > #include "wingdi.h" > #include "winuser.h" > > +static char **test_argv; > +static int test_argc; > +static HWND child = 0; > +static HWND parent = 0; > +static HANDLE child_process; > + > +#define PROC_INIT (WM_USER+1) > + > +LRESULT CALLBACK callback_child(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + BOOL ret; > + DWORD error; > + > + switch (msg) > + { > + /* Destroy the cursor. */ > + case WM_USER+1: > + SetLastError(0xdeadbeef); > + ret = DestroyCursor((HCURSOR) lParam); > + error = GetLastError(); > + todo_wine { > + ok(!ret, "DestroyCursor on the active cursor succeeded.\n"); > + ok(error == ERROR_DESTROY_OBJECT_OF_OTHER_THREAD, > + "Last error: 0x%08x\n", error); > + } > + return TRUE; > + case WM_DESTROY: > + PostQuitMessage(0); > + return 0; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +LRESULT CALLBACK callback_parent(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + if (msg == PROC_INIT) > + { > + child = (HWND) wParam; > + return TRUE; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +static void do_child(void) > +{ > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_child; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_child"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + child = CreateWindowA("cursor_child", "cursor_child", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(child != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Let the parent know our HWND. */ > + PostMessage(parent, PROC_INIT, (WPARAM) child, 0); > + > + /* Receive messages. */ > + while ((ret = GetMessage(&msg, child, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void do_parent(void) > +{ > + char path_name[MAX_PATH]; > + PROCESS_INFORMATION info; > + STARTUPINFOA startup; > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_parent; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_parent"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + parent = CreateWindowA("cursor_parent", "cursor_parent", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(parent != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Start child process. */ > + memset(&startup, 0, sizeof(startup)); > + startup.cb = sizeof(startup); > + startup.dwFlags = STARTF_USESHOWWINDOW; > + startup.wShowWindow = SW_SHOWNORMAL; > + > + sprintf(path_name, "%s cursoricon %x", test_argv[0], (unsigned int) parent); > + ok(CreateProcessA(NULL, path_name, NULL, NULL, FALSE, 0L, NULL, NULL, &startup, &info), "CreateProcess failed.\n"); > + child_process = info.hProcess; > + > + /* Wait for child window handle. */ > + while ((child == 0) && (ret = GetMessage(&msg, parent, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void init(void) > +{ > + test_argc = winetest_get_mainargs(&test_argv); > + > + /* Child process. */ > + if (test_argc >= 3) > + { > + sscanf (test_argv[2], "%x", (unsigned int *) &parent); > + > + ok(parent != NULL, "Parent not found.\n"); > + if (parent == NULL) > + exit(1); > + > + do_child(); > + exit(0); > + } > + else > + { > + do_parent(); > + } > +} > + > +static void finish_process(void) > +{ > + DWORD exit_code; > + BOOL ret; > + > + SendMessage(child, WM_CLOSE, 0, 0); > + ok(WaitForSingleObject(child_process, 30000) == WAIT_OBJECT_0, "Child process termination failed.\n"); > + > + ret = GetExitCodeProcess(child_process, &exit_code); > + ok(ret, "GetExitCodeProcess() failed. Error: 0x%08x\n", GetLastError()); > + ok(exit_code == 0, "Exit code == %d.\n", exit_code); > +} > + > +static void test_child_process(void) > +{ > + static const BYTE bmp_bits[4096]; > + HCURSOR cursor; > + ICONINFO cursorInfo; > + UINT display_bpp; > + HDC hdc; > + > + /* Create and set a dummy cursor. */ > + hdc = GetDC(0); > + display_bpp = GetDeviceCaps(hdc, BITSPIXEL); > + ReleaseDC(0, hdc); > + > + cursorInfo.fIcon = FALSE; > + cursorInfo.xHotspot = 0; > + cursorInfo.yHotspot = 0; > + cursorInfo.hbmMask = CreateBitmap(32, 32, 1, 1, bmp_bits); > + cursorInfo.hbmColor = CreateBitmap(32, 32, 1, display_bpp, bmp_bits); > + > + cursor = CreateIconIndirect(&cursorInfo); > + ok(cursor != NULL, "CreateIconIndirect returned %p.\n", cursor); > + > + SetCursor(cursor); > + > + /* Destroy the cursor. */ > + SendMessage(child, WM_USER+1, (WPARAM) parent, (LPARAM) cursor); > + > + /* Finish the child process. */ > + finish_process(); > +} > + > static void test_CopyImage_Check(HBITMAP bitmap, UINT flags, INT copyWidth, INT copyHeight, > INT expectedWidth, INT expectedHeight, WORD expectedDepth, BOOL dibExpected) > { > @@ -471,6 +670,7 @@ static void test_DestroyCursor(void) > > START_TEST(cursoricon) > { > + init(); > test_CopyImage_Bitmap(1); > test_CopyImage_Bitmap(4); > test_CopyImage_Bitmap(8); > @@ -480,4 +680,5 @@ START_TEST(cursoricon) > test_initial_cursor(); > test_CreateIcon(); > test_DestroyCursor(); > + test_child_process(); > } > > ------------------------------------------------------------------------ > > > IMO, the ok() tests in the child process are a bad idea (they won't be counted, nor returned as errors, by the parent process) all the tests should be done in parent, see kernel32/tests/process.c for some example on how to do it properly A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 2

Please create 1.2.0 milestone in Bugzilla
by Dan Kegel 18 Mar '08

18 Mar '08

The 1.1.x releases will be development releases, so a 1.1.0 milestone doesn't make much sense. Please create a 1.2.0 milestone in Bugzilla. Thanks! - Dan

4 4

Which IRC room to send SoC people to?
by Dan Kegel 18 Mar '08

18 Mar '08

http://wiki.winehq.org/SummerOfCode currently sends people to #WineHQ. Should it send them to #winehackers?

4 3