March 2008 - Wine-devel - list.winehq.org

Re: GdipGraphicsClear function implementation and tests
by Alexandre Julliard 31 Mar '08

31 Mar '08

"Gynvael Coldwind" <gynvael(a)vexillium.org> writes: > + /* get width and height > + */ > + width = GetDeviceCaps(graphics->hdc, HORZRES); > + height = GetDeviceCaps(graphics->hdc, VERTRES); This won't do what you want. You should probably use something like GetClipBox() here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] winex11drv: Distinguish left and right keys for shift, ctrl and alt. (try 5)
by Alexandre Julliard 31 Mar '08

31 Mar '08

Vitaliy <vitaliy(a)kievinfo.com> writes: > Resending. > > Try 5: > Split out change to user32 as a separate patch. > > Try 4: > This time with lots of tests that exposed number of other problems that were fixed. > > I could not separate this patch into separate pieces - they all linked together and > fixing one problem meant fixing or breaking something else. The message tests don't work: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so input.c && touch input.ok input.c:755: Test failed: a2/2: the msg sequence is not complete: expected 0000 - actual 000f make: *** [input.ok] Error 1 You most likely need to ignore all non-key messages. -- Alexandre Julliard julliard(a)winehq.org

1 0

midl question
by Alistair Leslie-Hughes 31 Mar '08

31 Mar '08

Hi, In an IDL file I need to define the following typedef HRESULT (__stdcall *FExecuteInAppDomainCallback) (void* cookie); How do i get midl to understand what __stdcall is defined to? Best Regards Alistair Leslie-Hughes

3 6

Direct3D shader compiler infrastructure
by Stefan Dösinger 31 Mar '08

31 Mar '08

Hello, So, I am getting serious about a shader compiler and related things now, and I've made a design proposal. First of all, let us collect a few things we want regarding shader handling: -> D3DXCompileShader & Friends -> D3DXAssembleShader & Friends -> D3DXDisassembleShader & Friends -> A way to deal with d3d9 and d3d10 shader language differences All these items are related in some way, so I am proposing the following design of a shader library: The core part of the library is a wine internal shader language representing D3D assembler shaders. Shaders in this language can be created from D3D Bytecode("SlDisassembleShader"), D3D ASM("SlAssembleShader") and from HLSL("SlCompileShader"). From the intermediate language, D3D bytecode can be generated in various versions(SlGenBytecode), as well as D3D Text asm(SlGenAsm). Unlike regular D3D asm languages, this language does not have a version token, it is a superset of all asm language versions. It does have a pixel / vertex / geometry shader flag though. The motivation behind an intermediate language is to avoid writing many different code generators, which is a big part of the HLSL compiler. We also need a WineD3D intermediate language to share our shader generator between d3d9 and d3d10, and use it for both kinds of shaders. The requirements for both intermediate asm languages are the same. This motivates making the language the same to reuse code. With those functions, the D3DX functions are pretty streightforward: D3DXAssembleShader: bytecode = SlGenBytecode(SlAssembleShader(char *asm_text)); D3DXCompileShader: bytecode = SlGenBytecode(SlCompileShader(char *hlsl_text)); D3DXDisassembleShader asm_text = SlGenAsm(SlDisassembleShader(DWORD *bytecode)); WineD3D can be changed to use this shader language as shader input. In this case, d3d8, d3d9 and d3d10 run their shader bytecode through SlDisassembleShader, and pass the returned pointer to WineD3D. This in turn calls SlCopyShader to make a copy it owns, and d3d8/9/10 free their copy using SlDestroyShader. With WineD3D working on the same language, we have to share the language definition between the shader library and WineD3D, or put the shader compiler into WineD3D as well. I do not like the 2nd way, as it puts things together that don't have to be in one lib, and wastes runtime memory. A 3rd way I have to consider was a SlReadShader() function with callbacks which takes over the current role of shader_generate_main() in WineD3D. I am not quite convinced by this either. Attached are a few files for reference: shaderlib.gif: A diagram explaining the roles of the languages(No, it is not UML 2.0) uses.gif: Illustrating various uses of the shader library shader-lang: A very early pseudocode definition of the language The intermediate asm language follows the same principles as D3D bytecode. A shader contains any number of instructions, each instruction has one destination register and any number of source registers. The instructions have an opcode, writemask, modifiers. A register has a type, an index, information about relative addressing, source modifiers, and a swizzle. Appart of the instructions, the shader contains a header with informations about the shader. Declarations, input/output semantics, special registers used, etc. This replaces the shader_get_registers_used() pass in WineD3D. It is done by the shader library, and it also generates the declarations for 1.x pixel shaders. (We still have to find out which texture type to read from in wined3d). Thanks, Stefan

2 6

Firefox 3 beta 4 working, only a couple bugs...
by Dan Kegel 31 Mar '08

31 Mar '08

I tried Firefox 3 beta 4 just now, and there were a few bugs that stood out in the first few minutes: 12305 Firefox 3 beta 4 font problem: colon displayed as 0038 unicode glyph-missing glyph 12306 Firefox 3 beta shows one-pixel-high black line when rendering some images 12307 firefox 3 beta 4 crash on some web pages Youtube seemed slow and hangy on the first video I tried, http://www.youtube.com/watch?v=jwMj3PJDxuo although it was fine in native firefox at the same time; perhaps the Windows version of the flash plugin is less resistant to network errors -- or Wine doesn't support some network feature that only matters during bad internet weather. That same video was fine later, as was a different video http://www.youtube.com/watch?v=OGxdgNJ_lZM (both worth watching, btw). It also output quite a few messages like fixme:ntdll:NtLockFile I/O completion on lock not implemented yet fixme:font:ExtTextOutW flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented Firefox 3 rc1 will be out in May, and release will be in early June, according to http://blog.wired.com/monkeybites/2008/03/mozilla-final-v.html Given that a lot of people have in the past used windows Firefox in wine to run native plugins, maybe we should get firefox 3 working well. Probably only five or six main issues. - Dan

1 0

Re: [1/2] WineD3D: Support clipplanes with GLSL shaders
by Alexandre Julliard 31 Mar '08

31 Mar '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > From 1cb24469eb0f53f7e67dea2c7659ad070b86f21d Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 28 Mar 2008 16:11:06 +0100 > Subject: [PATCH] WineD3D: Support clipplanes with GLSL shaders > > This patch removes the shader clipplane disabling code from the > common/fixed function state table and enables GLSL shaders to write to > the clipcoord output attribute. The ARB specific clipplane disabling is > handled in the ARB shader backend. It doesn't work for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:4738: Test failed: vs_3_0 returned color 0x00110000, expected 0x00203366 visual.c:4743: Test failed: vs_1_1 returned color 0x00110000, expected 0x00808080 visual.c:4748: Test failed: vs_2_0 returned color 0x00110000, expected 0x00000000 visual.c:4929: Test failed: ps_3_0 returned color 0x00193300, expected 0x0080ffe5 make[2]: *** [visual.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0

iPod sync news?
by Rainer M Krug 31 Mar '08

31 Mar '08

Hi are there any news on the iPod Touch sync front? Any patches available? Thanks Rainer

1 0

ws2_32 janitorial questions
by Andrew Talbot 31 Mar '08

31 Mar '08

Hi, ws2_32/async.c has the following global declarations: /* protoptypes of some functions in socket.c */ UINT16 wsaErrno(void); UINT16 wsaHerrno(int errnr); ws2_32/socket.c has the following global declarations: UINT wsaErrno(void); UINT wsaHerrno(int errnr); Where are these functions defined? And, assuming that the above are conflicting declarations, what type does each of these functions actually return? Thanks, -- Andy.

2 1

Re: setupapi: prevent page faults in SetupDiDeleteDeviceInterfaceRegKey
by Vitaliy Margolen 31 Mar '08

31 Mar '08

Christopher wrote: > Changelog: > Check that the handle and pointer passed to > SetupDiDeleteDeviceInterfaceRegKey are valid to read from. This patch > continues to address bug #12242 > > - if (!DeviceInterfaceData || > + if (!DeviceInterfaceData || IsBadReadPtr(DeviceInterfaceData, sizeof(SP_DEVICE_INTERFACE_DATA)) || Don't ever use IsBadReadPtr and IsBadWritePtr functions. They are bad and even MS stopped using them. You have to use TRY-EXCEPT block around an access to the memory. For example see implementation of lstrcpyA (kernel32/string.c: 359). > + ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, \ > +with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); This is bad way to split strings in c. Do something like this: ok(!ret && GetLastError() == ERROR_INVALID_HANDLE, "Expected SetupDiDeleteDeviceInterfaceRegKey to return FALSE, got %s, " "with error code: 6, got %d\n", ret ? "TRUE" : "FALSE", GetLastError()); Vitaliy.

1 0

Wine 1.0 status: T minus 68 days. 73 open bugs.
by Dan Kegel 31 Mar '08

31 Mar '08

40 days to code freeze. One bug fixed in last couple days: 9459 -unknown 8 FIFA 2007 crashes with the recent versions One bug added: 12246 -unknown 0 "make test" gives different results with and without warn+heap One bug deferred: 4971 -unknown 3 Corel Draw 12 demo install fails History: 3/22: 87 bugs, 76 days to go 3/23: 82 bugs, 75 days to go 3/24: 78 bugs, 74 days to go 3/26: 74 bugs, 72 days to go 3/30: 73 bugs, 69 days to go Here's the current list of open bugs: 5948 -unknown 1 Star Trek: Armada does not install 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 7477 -unknown 1 Uplink demo crashes 12097 -unknown 2 Wine 1.0 should not ship out-of-sync resource translations 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5844 -unknown 11 tray minimize 11281 -unknown 2 CJK input many issues 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 5402 -unknown 0 Trying to run PhotoStitch 3.1 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 9916 -unknown 6 "make test" usually fails 9178 -unknown 7 "hello world" dos program hangs 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 12246 -unknown 0 "make test" gives different results with and without warn+heap 8125 -unknown 0 Marratech 6.1 crashes on start 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 11681 directx- 14 Add support for video overlay 5955 directx- 8 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 2 Stabilize Winelib User Guide Table of Contents 638 document 9 Document Wine debugging channels 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 9926 gdi32 5 gdi32.dll should not have exported function pointers 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 17 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 12 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 9 Drag and Drop not working 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 8095 ole 0 PQ Teaching toy crashes 4770 ole 3 BlackBerry Device Manager fails to install under wine 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 8439 shell32 8 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3023 user32 5 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 1990 winex11. 1 modifier keys not released when switching desktop 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 5625 wininet 3 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

4 4