March 2008 - Wine-devel - list.winehq.org

Implement VBScript for Google Summer of Code
by Jim Chen 28 Mar '08

28 Mar '08

Hi everyone, I have this idea of implementing vbscript.dll for Google SoC. Any comment would be appreciated before I start working on my proposal. The reason for implementing vbscript.dll is because right now there's nothing in the trunk about it. jscript.dll has a stub, but vbscript.dll doesn't, and it's an area that I think I can work on. VBScript is used by the Windows Installer, can be potentially be used for DirectMusic script (from http://wiki.winehq.org/DirectX-ToDo) and some applications use it. Just the core language/runtime (vbscript.dll) is implemented, no extra COM/OLE objects such as FSO (file system object), etc. (unless I have time). The language by itself is designed to be simple and easy, so an interpreter shouldn't be hard. I wrote a C-style script interpreter in Java this past year. For a few years I used to hack VB, and I know the language and VBScript is just a cousin of VB. The runtime library is not big, and writing it shouldn't take too much time either. I think the hardest part would be to implement the COM interfaces that deal with scripting. And that's the area I know least about. Thanks! Jim

4 5

[Fwd: gdi32: PlgBlt implementation (resend)]
by Nikolay Sivov 28 Mar '08

28 Mar '08

What about this patch? > Changelog (since first patch): > - HAVE_FLOAT_H used for #include > - all declarations moved to the beginning Index: dlls/gdi32/bitblt.c =================================================================== RCS file: /home/wine/wine/dlls/gdi32/bitblt.c,v retrieving revision 1.4 diff -u -r1.4 bitblt.c --- dlls/gdi32/bitblt.c 18 Sep 2007 10:32:56 -0000 1.4 +++ dlls/gdi32/bitblt.c 26 Mar 2008 22:48:50 -0000 @@ -20,6 +20,11 @@ #include <stdarg.h> +#include <math.h> +#if defined(HAVE_FLOAT_H) +#include <float.h> +#endif + #include "windef.h" #include "winbase.h" #include "wingdi.h" @@ -522,9 +527,75 @@ * */ BOOL WINAPI PlgBlt( HDC hdcDest, const POINT *lpPoint, - HDC hdcSrc, INT nXDest, INT nYDest, INT nWidth, + HDC hdcSrc, INT nXSrc, INT nYSrc, INT nWidth, INT nHeight, HBITMAP hbmMask, INT xMask, INT yMask) { - FIXME("PlgBlt, stub\n"); - return 1; + int oldgMode; + /* parallelogram coords */ + POINT plg[3]; + /* rect coords */ + POINT rect[3]; + XFORM xf; + XFORM SrcXf; + XFORM oldDestXf; + FLOAT det; + + /* save actual mode, set GM_ADVANCED */ + oldgMode = SetGraphicsMode(hdcDest,GM_ADVANCED); + if (oldgMode == 0) + return FALSE; + + memcpy(plg,lpPoint,sizeof(POINT)*3); + rect[0].x = nXSrc; + rect[0].y = nYSrc; + rect[1].x = nXSrc + nWidth; + rect[1].y = nYSrc; + rect[2].x = nXSrc; + rect[2].y = nYSrc + nHeight; + /* calc XFORM matrix to transform hdcDest -> hdcSrc (parallelogram to rectangle) */ + /* determinant */ + det = (FLOAT)(rect[1].x*(rect[2].y - rect[0].y) - rect[2].x*(rect[1].y - rect[0].y) - rect[0].x*(rect[2].y - rect[1].y)); + + if (fabs(det) < FLT_EPSILON) + { + SetGraphicsMode(hdcDest,oldgMode); + return FALSE; + } + + TRACE("hdcSrc=%p %d,%d,%dx%d -> hdcDest=%p %d,%d,%d,%d,%d,%d\n", + hdcSrc, nXSrc, nYSrc, nWidth, nHeight, hdcDest, plg[0].x, plg[0].y, plg[1].x, plg[1].y, plg[2].x, plg[2].y); + + /* X components */ + xf.eM11 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; + xf.eM21 = (rect[1].x*(plg[2].x - plg[0].x) - rect[2].x*(plg[1].x - plg[0].x) - rect[0].x*(plg[2].x - plg[1].x)) / det; + xf.eDx = (rect[0].x*(rect[1].y*plg[2].x - rect[2].y*plg[1].x) - + rect[1].x*(rect[0].y*plg[2].x - rect[2].y*plg[0].x) + + rect[2].x*(rect[0].y*plg[1].x - rect[1].y*plg[0].x) + ) / det; + + /* Y components */ + xf.eM12 = (plg[1].y*(rect[2].y - rect[0].y) - plg[2].y*(rect[1].y - rect[0].y) - plg[0].y*(rect[2].y - rect[1].y)) / det; + xf.eM22 = (plg[1].x*(rect[2].y - rect[0].y) - plg[2].x*(rect[1].y - rect[0].y) - plg[0].x*(rect[2].y - rect[1].y)) / det; + xf.eDy = (rect[0].x*(rect[1].y*plg[2].y - rect[2].y*plg[1].y) - + rect[1].x*(rect[0].y*plg[2].y - rect[2].y*plg[0].y) + + rect[2].x*(rect[0].y*plg[1].y - rect[1].y*plg[0].y) + ) / det; + + GetWorldTransform(hdcSrc,&SrcXf); + CombineTransform(&xf,&xf,&SrcXf); + + /* save actual dest transform */ + GetWorldTransform(hdcDest,&oldDestXf); + + SetWorldTransform(hdcDest,&xf); + /* now destination and source DCs use same coords */ + MaskBlt(hdcDest,nXSrc,nYSrc,nWidth,nHeight, + hdcSrc, nXSrc,nYSrc, + hbmMask,xMask,yMask, + SRCCOPY); + /* restore dest DC */ + SetWorldTransform(hdcDest,&oldDestXf); + SetGraphicsMode(hdcDest,oldgMode); + + return TRUE; }

1 0

Re: wined3d: Improve detection of device palette change.
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 20:34:11 schrieb Alexander Dorofeyev: > ENTER_GL(); > + if (This->resource.format == WINED3DFMT_P8 || This->resource.format == > WINED3DFMT_A8P8) { > + for (i = 0; i < This->baseTexture.levels; i++) { > + if(palette9_changed((IWineD3DSurfaceImpl *)This->surfaces[i])){ Why are you doing this inside ENTER_GL? I think LoadLocation locks on its own.

2 2

Re: mscoree: Add missing interfaces
by Alistair Leslie-Hughes 28 Mar '08

28 Mar '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fsg1am$7ip$1(a)ger.gmane.org... > Hi, > > Changelog: > mscoree: Add missing interfaces > Anything wrong with this patch? Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 3/7] services: Start a local RPC server.
by Alexandre Julliard 28 Mar '08

28 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > +handle_t __RPC_USER MACHINE_HANDLEW_bind(MACHINE_HANDLEW MachineName) > +{ > + WCHAR transport[] = SVCCTL_TRANSPORT; > + WCHAR endpoint[] = SVCCTL_ENDPOINT; > + LPWSTR server_copy = NULL; > + RPC_WSTR binding_str; > + RPC_STATUS status; > + handle_t rpc_handle; > + > + /* unlike Windows we start services.exe on demand. We start it always as > + * checking if this is our address can be tricky */ > + if (!check_services_exe()) > + return NULL; I think it would be OK to assume that services.exe is started by wineboot and is always running, since we'll have at least the mountmgr service running all the time. > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +cpp_quote("#define SVCCTL_STARTED_EVENT (const WCHAR[]){'_','_','w','i','n','e','_','S','v','c','c','t','l','S','t','a','r','t','e','d',0}") That's gcc-specific syntax, it would need some #ifdefs. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: amstream: IMediaStream::GetMultiMediaStream
by Robert Shearman 28 Mar '08

28 Mar '08

Nikolay Sivov wrote: > @@ -109,9 +109,14 @@ > { > IMediaStreamImpl *This = (IMediaStreamImpl *)iface; > > - FIXME("(%p/%p)->(%p) stub!\n", This, iface, ppMultiMediaStream); > + TRACE("(%p/%p)->(%p)\n", This, iface, ppMultiMediaStream); > > - return S_FALSE; > + if(!(*ppMultiMediaStream)) > + return E_POINTER; > + > + *ppMultiMediaStream = This->Parent; > + > + return S_OK; > } > Although I haven't looked at the context, you also likely need to add a reference to the returned COM object here. -- Rob Shearman

1 0

Re: [2/2] [try 2] Setupapi patch
by Juan Lang 28 Mar '08

28 Mar '08

Hi Alexander, > Changelog: > 1 - Creating device interface keys in registry as in Windows XP > 2 - Creating DeviceInstance value in registry > 3 - Creating SymbolicLink value in registry as in Windows XP > 4 - SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > allocating new memory block for their array One fix per patch, please. --Juan

1 0

Re: [Tools 5/6] winetest: Add statistics for the number of unit tests with errors or todos.
by Paul Vriens 28 Mar '08

28 Mar '08

Francois Gouget wrote: > Also tweak the headers and footers a bit. > --- > > This gives us a better idea of how many unit tests are failing. > > winetest/gather | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++---- > 1 files changed, 62 insertions(+), 5 deletions(-) > > diff --git a/winetest/gather b/winetest/gather Hi Francois, I think something is 'wrong' with the statistics for the Wine group: http://test.winehq.org/data/200803211000/#group_Wine They are the same for every box with respect to the "X + Y". The title (on mouse over) is correct though. -- Cheers, Paul.

2 2

GSOC proposal: DirectPlay4
by Matthew Canterbury 28 Mar '08

28 Mar '08

Hello everybody, I plan on applying for Google's Summer of Code to work on DirectPlay4 support in wine. (This was mentioned on the ideas page, http://wiki.winehq.org/SummerOfCode) I've looked at the code currently in wine, and it looks like there is some work done, but a number of the functions exported in the corresponding dlls are stubs or partial stubs. Alot of work needs to be done to dplay to make it more compliant (or at least more functional). This would allow several games that depend on DirectPlay to work without copying dll's from a windows partition. So I intend to makes sure the IDirectPlay4 COM interface is sufficiently implemented and that it meets the requirements set forth in in the DirectPlay4 specification. If time permits, I'd like to look into the Reliable Specification for DirectPlay4, but i think implementing just the core specification will keep me busy. I've never worked on an open source project before, but I have wanted to for quite some time. I'm looking forward to contributing to a project that I've used quite a bit in the past few years. ;) I thought I would introduce myself a bit here. I'm currently a computer engineering student at a University in the United States. I've been programming since I was about 13, and I've had all kinds of personal projects from a somewhat functional 3D game engines to a ray tracer. I was also chosen to participate on our school's team for the ACM programming competition. In short, I'm a programmer at heart. I'm putting the final touches on my application and would greatly appreciate any thoughts or comments before I submit it through Google. Thanks, Matthew Canterbury

2 1

Re: [3/5] WineD3D: Support clipplanes with GLSL shaders
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 02:57:46 schrieb Stefan Dösinger: Please do not apply this patch yet. We are not sure if we should write the Z corrected coord as clip coord or not

1 0