March 2008 - Wine-devel - list.winehq.org

Re: 2/2 WineD3D: initial post pixelshader blending support
by Stefan Dösinger 28 Mar '08

28 Mar '08

Am Freitag, 28. März 2008 10:25:31 schrieb Roderick Colenbrander: > Hi, > > Store a flag whether a format supports blending in the formats table. This > patch uses the flag in the blending code and in a few other places to > verify if we should turn on blending for the given format. A next patch > will also us e this flag for a CheckPixelShaderBlendingCapability call for > CheckDeviceFormat. Later on I plan to move more of the Check*Capability > functions over to the table. Regarding the glDisable(GL_BLEND) in the CTXUSAGE_CLEAR setup: You have to mark the D3D state dirty in the context when doing that, otherwise blending might not be re-enabled properly on the next draw. I also think that disabling blending for clearing is orthogonal to the rest of the patch and should be done in a separate patch. > +#define WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING 1 Maybe use 0x1 instead of 1? That will make adding new flags beyond 8 clearer. Otherwise it looks good!

1 0

Re: amstream: IAMMultiMediaStream::EnumMediaStreams
by Robert Shearman 28 Mar '08

28 Mar '08

Nikolay Sivov wrote: > @@ -144,9 +144,18 @@ > { > IAMMultiMediaStreamImpl *This = (IAMMultiMediaStreamImpl *)iface; > > - FIXME("(%p/%p)->(%ld,%p) stub!\n", This, iface, Index, ppMediaStream); > + TRACE("(%p/%p)->(%d,%p)\n", This, iface, Index, ppMediaStream); > > - return E_NOTIMPL; > + /* check out of range */ > + if(Index < 0 || Index >= This->nbStreams) > + return S_FALSE; > + /* NULL pointer */ > + if(!(*ppMediaStream)) > + return E_POINTER; > + > + *ppMediaStream = This->pStreams[Index]; > + > + return S_OK; > } > You need to call IMediaStream_AddRef on the returned stream. -- Rob Shearman

1 0

Re: [1/2] Added a test: registering device interface and getting devicepath
by Dmitry Timoshkov 28 Mar '08

28 Mar '08

"Alexander Morozov" <amorozov(a)etersoft.ru> wrote: > Changelog: > Added a test for setupapi: registering device interface and getting device > path Please consistently print GetLastError() values as %u (not %08x or %d), otherwise the test looks good to me. -- Dmitry.

4 8

fuse-iso and remote named pipes for GSOC
by Cesar Izurieta 28 Mar '08

28 Mar '08

Besides the FUSE project for GSOC I see two items listed on the http://wiki.winehq.org/SummerOfCode page: # Better ISO FUSE file system integration # A FUSE wrapper for remote named pipes using libsmbclient Can anybody elaborate a little bit more on this?

3 3

Re: GSOC proposal - control panel
by pure_evil＠mail.bg 27 Mar '08

27 Mar '08

<off-topic>Sorry bout that, went a lil' /too/ paranoid. Thing is, I've spent so many days obsessing with the cpls, trying to get anything resembling a somewhat stable dev environment to produce anything resembling a *compilable* code, reverse-engineering Makefiles, and Makefile.ins, and defs and specs and C and gcc and ReactOS cpls and so forth /and being handed a code whose dev jumped on me for trying to cross-compile it, though that was what I asked for in the first place btw/ and when finally, SOMETHING compiled (a sample cpl included in Reactos 3.0. source code), I suddenly discovered that A.) They can't be done the normal way /e.g. compiled against wine's source-tree by winegcc/ B.) If they could, they would've been done long ago (Reactos has 'em; Someone would've ported them by now, if not do 'em from scratch) It was just too much for two weeks, sorry again. </off-topic> On-topic: CPls the normal way -> no-go. Binary CPls compiled on 'doze or with a 'doze compiler under wine -> yes. Sorry again.

2 1

Fw: Re: Google Summer of Code 2008 - joined openprinting+wine project?
by Hin-Tak Leung 27 Mar '08

27 Mar '08

Hi, anybody on wine-devel want to take this on and make this more concrete? --- On Wed, 26/3/08, Till Kamppeter <till.kamppeter(a)gmail.com> wrote: > From: Till Kamppeter <till.kamppeter(a)gmail.com> > Subject: Re: Google Summer of Code 2008 - Some general instructions for reviewing the student's applications > To: "Hin-Tak Leung" <hintak_leung(a)yahoo.co.uk> > Cc: "Casey Schaufler" <casey(a)schaufler-ca.com>, "'Glen Petrie'" <glen.petrie(a)eitc.epson.com>, "Rik van Riel" <riel(a)redhat.com>, "Jeff Licquia" <licquia(a)debian.org>, "Jon Masters" <jonmasters(a)gmail.com>, "Jonathan Riddell" <jriddell(a)ubuntu.com>, "Josef Spillner" <spillner(a)kde.org>, Matt_Domsch(a)dell.com, "Pekka Enberg" <penberg(a)cs.helsinki.fi> > Date: Wednesday, 26 March, 2008, 4:34 PM > Hin-Tak Leung wrote: > > Hi Till and the rest of the gang. > > > > Two people had got in touch with with about the > IJS+PDF workflow, and I replied. > > (sorry I don't check the "other" e-mail > often - I probably should set up re-direction). > > > > Great! > > > I thought I should also mentioned that it has just > came to my attention in some unrelated discussion on > wine-devel - been doing some non-printing wine-related > stuff lately - that there *was* a google summer of code > 2007 project for a > > wine-based native printer driver proxy - this is the > sort of thing I have had in mind > > for a while and I thought it would be interesting to > do but I don't have in-depth > > windows knowledge to make it happen, but the wine > people already did! > > http://google-summer-of-code-2007-wine.googlecode.com/ > > > > I just downloaded the gsoc 2007 printerproxy code. It > seems that it is just for use > > from within wine, but it just might be interesting to > make it more general - via opvp > > or IJS. We should follow up on this. > > If this project still requires coding, it is not too late > to add it as > project idea to the ideas pages of both the Linux > Foundation and WINE > (having it presented at two mentoring organizations raises > the chances > to find a student). > > Our ideas page is a Wiki and you can simply edit it: > > https://www.linux-foundation.org/en/Google_Summer_of_Code > > Till __________________________________________________________ Sent from Yahoo! Mail. More Ways to Keep in Touch. http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: comdlg32->printdlg: bug fixed
by Michael Stefaniuc 27 Mar '08

27 Mar '08

Vitaly Perov wrote: > Bug is the following: > When a application is responsible for printing multiple copies printer prints > X^2 copies (4 instead of 2, 9 instead of 3 ...) > It happen bacause application already prepared requested copies, and printer > driver prints copies ( number placed in dmCopies) of whole document. > > Changelog: > - When PD_USEDEVMODECOPIESANDCOLLATE flag is not set dmCopies must be 1. You didn't attached the diff but the whole file. bye michael

1 0

Re: prevents WM_DISPLAYCHANGE message being sent when a call to ChangeDisplaySettingsEx fails due to the requested change to the display not occurring.
by Reece Dunn 27 Mar '08

27 Mar '08

On 24/03/2008, chris morgan <cmorgan(a)mail.leather-wallet.co.uk> wrote: > test code run on windows nt4 sp6, messages checked using ms spk++: > > DEVMODE dev_mode; > memset(&dev_mode,0,sizeof(DEVMODE)); > dev_mode.dmSize = sizeof(DEVMODE); > > // Get the current display settings > if (!EnumDisplaySettings(NULL,ENUM_CURRENT_SETTINGS,&dev_mode)) > { > printf("Could not EnumDisplaySettings, giving up.\n"); > return 0; > } > > // Call ChangeDisplaySettings with the current settings, > // No WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); > > // Change something (that works) > dev_mode.dmBitsPerPel = 32; > > // WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); > > // Change something to an impossible value > dev_mode.dmBitsPerPel = 999; > > // No WM_DISPLAYCHANGE message sent > ChangeDisplaySettings(&dev_mode, 0); This should be incorporated into a conformance/regression test. That way, this bug will not reappear and can also be verified as the correct behaviour on different versions of Windows. > + if (width == screen_width && height == screen_height) > + { > + return; > + } w.r.t. the implementation: * ChangeDisplaySettings returns a long (http://msdn2.microsoft.com/en-us/library/ms533260(VS.85).aspx) so the correct value must be returned on error; * the fix does not match the test cases (screen size vs colour depth). In addition, your tests should: * check that changing the screen resolution causes a WM_DISPLAYCHANGE message to be sent; * if there are no other tests, ChangeDisplaySettings should be checked to see what happens with invalid arguments (for completeness); * the return value is not checked for expected values (see http://msdn2.microsoft.com/en-us/library/ms533260(VS.85).aspx) * GetLastError() is not checked to see what it is set to (see other tests for examples); * restore the display settings back to what they were before the tests. Thanks for improving Wine, - Reece

2 1

RE: GSOC proposal - control panel
by pure_evil＠mail.bg 27 Mar '08

27 Mar '08

No dice. CPls are DLLs that export a function - CPlApplet(). winegcc coughs on dllexport. - not implemented. I've been hacking at it for days on end now. Result: CPl can be compiled under windows and run under wine. CPls compiled with winegcc don't export that function => not treated as control panel applets. software to aid anyone: dllexp.exe. Download and run on any dll/cpl of windows, you get exports in it; run on wine dlls - nada. (hence, No Template in wine's source. Twain DLL exports some methods though.) MICROSOFT ISSUE: EASY TO DISTINGUISH BETWEEN WINE DLLS AND WINDOWS DLLS. If dllexp.exe can do it, so can they. Solution: M$ implements a code that *checks for a dll version* (based on what the DLL exports). Doesn't find export => coughs and dies with an "Incompatible DLL version". Happened before with OS2 / Windows. Maybe has happened now with all M$ that cough on wine. Not enough intimate knowledge => can a soft cough and die based on a call to a DLL export which isn't there, without being designed to do so?

4 4

GSOC proposal - control panel
by Owen Rudge 27 Mar '08

27 Mar '08

Hi everyone, I'm intending to apply for a Google Summer of Code placement working on the Wine control panel support. My main intention is to work on a proper Control Panel application for Wine that accepts standard .cpl files, and turn winecfg's configuration sections into appropriate control panels. (I notice that pure_evil @ mail.bg has been doing some work on this - if I were to get accepted to work on this, then I would like to continue his line of work, or assist him with it.) However, as I don't believe that project alone would necessarily take up an entire summer, my intention would also be to work on some new control panel applets for Wine. The examples given on the GSOC wiki pages (basic desktop/screen resizing, general network information, and font details) would be good applets for me to implement, but I would also be interested in working on some other applets, such as an Add/Remove Programs applet, or a Multimedia applet. Obviously, there wouldn't necessarily be time to implement all of these, so my intention would be to get the main control panel and basic Wine control panel applets from winecfg working well first, and then look at other applets that could be implemented. I've developed applications and, indeed, Control Panel applets for Windows for many years now (I started programming using the Windows API when I was 12!), so I feel confident that this is a task I would be able to handle. I believe that a good configuration interface for Wine that supports third-party control panels is something that would be very useful for end-users. If anyone has any comments or suggestions regarding my proposal, I'd very much appreciate any feedback. Regards, -- Owen Rudge http://www.owenrudge.net/

4 6