April 2008 - Wine-devel - list.winehq.org

Re: d3dx9_36: Add stubs and implementations for D3DXCreateTexturexx
by tony.wasserka＠freenet.de 18 Apr '08

18 Apr '08

> I have a hacky implementation of D3DXLoadSurfaceFromMemory and > D3DXLoadSurfaceFromSurface, as well as a pretty good implementation of > D3DXCreateTexture and D3DXCheckTextureRequirements. > > I'll send in the patch for the last two when I have time, and have > looked it over a final time. I pretty much abandoned the first two, > because there's got to be a whole lot of code somewhere in the tree > already. It does work in some cases, however. Attached in case it > might be helpful. Nice, I hope I can do something with the D3DXLoadSurfaceFromMemory/Surface implementations when my D3DXLoadXXFromFile functions are ready, thank you! However, I don't wanna push you, but can you send me your current code for D3DXCreateTexture+D3DXCheckTextureRequirements so that I can work on D3DXLoadXXFromFile and the other functions until it's in the main tree? Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

New winetricks 20080418: add wmp10, windows codecs, accept new flash version
by Dan Kegel 18 Apr '08

18 Apr '08

Another day, another Winetricks. Changes since yesterday's annoucement: Switch to listing simpler synonyms for changing windows version (long ones still valid) Correct description of volnum verb (it's still needed) Fix typo in sha1sum check that caused it to be ignored! Update sha1sum for flash player (see comment for URL about the update) Much better error reporting for gui users. Add wmp10 Installing wmp9 or wmp10 also gets codecs now Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com

1 0

Re: user32:mdi.c Fix creating MDI child window according with test.
by Dmitry Timoshkov 18 Apr '08

18 Apr '08

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > --- dlls/user32/mdi.c 5 Mar 2008 19:42:23 -0000 1.24 > +++ dlls/user32/mdi.c 18 Apr 2008 12:07:50 -0000 > @@ -649,6 +728,9 @@ static LONG MDI_ChildActivate( HWND clie > } > > SendMessageW( child, WM_MDIACTIVATE, (WPARAM)prevActiveWnd, (LPARAM)child ); > + > + SetWindowPos( frame, HWND_TOP, 0, 0, 0, 0, SWP_NOMOVE|SWP_NOSIZE|SWP_NOACTIVATE|SWP_FRAMECHANGED ); SWP_NOZORDER should be there for sure, and in that case HWND_TOP doesn't make sense, so just use 0 (although HWND_TOP == 0) instead. -- Dmitry.

2 1

Re: shell32: implement SHGetFolderPathAndSubDirA/W [try2][resend]
by Alexandre Julliard 18 Apr '08

18 Apr '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > @@ -1758,7 +1836,7 @@ > */ > if (!(nFolder & CSIDL_FLAG_CREATE)) > { > - hr = HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND); > + hr = HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); > goto end; Why is it using a different error code here? Do you have a test case for this? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: correct the case where Content-Length is set as well as Transer-Encoding = chunked
by Hans Leidekker 18 Apr '08

18 Apr '08

On Thursday 17 April 2008 20:05:41 Aric Stewart wrote: > + /* Correct the case where both a Content-Length and Transfer-encoding = chuncked are set */ > + > + dwBufferSize = sizeof(encoding); > + if (HTTP_HttpQueryInfoW(lpwhr, HTTP_QUERY_TRANSFER_ENCODING, encoding, &dwBufferSize, NULL) && > + !strcmpiW(encoding, szChunked)) > + { > + lpwhr->dwContentLength = -1; > + } I think the right thing to do is to strip the Transfer-Encoding header from the request because we don't support chunked transfers in the sending direction. Would that work for you? -Hans

2 3

Strange waveOutGetDevCaps calls in winmm/tests/wave.c
by Peter Åstrand 18 Apr '08

18 Apr '08

winmm/tests/wave.c currently contains: rc=waveOutGetDevCapsA(device,&capsA,4); ok(rc==MMSYSERR_NOERROR, "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", dev_name(device),wave_out_error(rc)); rc=waveOutGetDevCapsW(device,&capsW,4); ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " "expected, got %s\n",dev_name(device),wave_out_error(rc)); This seems wrong to me; the last argument should be the size of the WAVEOUTCAPS structure, and there are no such structures that have size 4. The CapsW test fails with our sound driver (tlsnd) as well as Microsofts Terminal Services driver (rdpsnd). The CapsA test doesn't fail, probably since winmm wraps CapsA calls with CapsW calls and then does memcpy. In either case, calling waveOutGetDevCaps sith size=4 is not valid, as far as I can tell. Theoretically, it might be in the future, though, if some small caps structure is invented. I suggest that these tests are removed altogether: --- wave.c 29 Feb 2008 12:18:36 -0000 1.67 +++ wave.c 16 Apr 2008 12:03:44 -0000 @@ -853,16 +853,6 @@ "expected, got %s\n",dev_name(device),wave_out_error(rc)); } - rc=waveOutGetDevCapsA(device,&capsA,4); - ok(rc==MMSYSERR_NOERROR, - "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", - dev_name(device),wave_out_error(rc)); - - rc=waveOutGetDevCapsW(device,&capsW,4); - ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, - "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " - "expected, got %s\n",dev_name(device),wave_out_error(rc)); - nameA=NULL; rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYDEVICEINTERFACESIZE, (DWORD_PTR)&size, 0); Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00

2 2

Re: wininet: improve stub for FindNextUrlCacheEntryW a tiny bit
by Dmitry Timoshkov 18 Apr '08

18 Apr '08

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > @@ -3113,6 +3113,7 @@ BOOL WINAPI FindNextUrlCacheEntryW( > LPDWORD lpdwNextCacheEntryInfoBufferSize > ) > { > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > FIXME("(%p, %p, %p) stub\n", hEnumHandle, lpNextCacheEntryInfo, lpdwNextCacheEntryInfoBufferSize); > return FALSE; > } You should put SetLastError() immediately before return, any calls after it may potentially change last error value. -- Dmitry.

1 0

Wine Status Page
by Joel Holdsworth 17 Apr '08

17 Apr '08

Hi All, Are there any plans to update the percentages on the Wine status page any time soon? I'm curious to know how much progress has been made in the past 10 months. Regards Joel Holdsworth

2 1

new Valgrind errors in oleaut32
by Dan Kegel 17 Apr '08

17 Apr '08

James just barely touched the oleaut32 tests, and as a side effect, we now have several more warnings of the sort + Conditional jump or move depends on uninitialised value(s) + at VARIANT_DI_tostringW (vartype.c:4852) + by VarBstrFromCy (vartype.c:6519) + by VariantChangeTypeEx (variant.c:433) + by VarCat (variant.c:2555) + by test_VarCat (vartest.c:5246) + by func_vartest (vartest.c:8436) + by run_test (test.h:406) + by main (test.h:455) and + Conditional jump or move depends on uninitialised value(s) + at __printf_fp (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vfprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vsprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by sprintf (in /lib/tls/i686/cmov/libc-2.6.1.so) + by vsnprintfW (string.c:408) + by sprintfW (string.c:455) + by VARIANT_BstrFromReal (vartype.c:6406) + by VarBstrFromR4 (vartype.c:6457) + by VariantChangeTypeEx (variant.c:430) + by VarCat (variant.c:2555) + by test_VarCat (vartest.c:5246) + by func_vartest (vartest.c:8454) + by run_test (test.h:406) + by main (test.h:455) See http://kegel.com/wine/valgrind/logs-2008-04-17/vg-oleaut32_vartest-diff.txt

1 0

Towards pure wine: a step by step approach
by Dan Kegel 17 Apr '08

17 Apr '08

Errors reported by valgrind, coverity, and our conformance test suite are all worth fixing... but fixing them *all* is like shovelling out the dung from an infinitely large barn. Various people have tried fixing one kind of error or the other, but maybe a combined attack, where we went module by module and fixed *all* of the valgrind, coverity, and conformance test errors might be more fruitful (or at least more satisfying). Such an attempt should probably start at the bottom, cleaning up modules in the order wineserver, ntdll, kernel32, gdi32, user32, ... To that end, here are the combined known errors for the first few modules. wineserver: coverity: cv219 FORWARD_NULL UNINSPECTED set_console_input_info base/src/wine/server/console.c cv220 FORWARD_NULL UNINSPECTED connect_process_winstation base/src/wine/server/winstation.c ntdll: coverity: cv48 FORWARD_NULL UNINSPECTED RtlAllocateHandle base/src/wine/dlls/ntdll/handletable.c cv55 FORWARD_NULL UNINSPECTED RtlCreateEnvironment base/src/wine/dlls/ntdll/env.c cv227 NEGATIVE_RETURNS UNINSPECTED read_changes_apc base/src/wine/dlls/ntdll/directory.c cv248 NULL_RETURNS UNINSPECTED HEAP_FindFreeBlock base/src/wine/dlls/ntdll/heap.c cv343 REVERSE_INULL UNINSPECTED NtOpenSection base/src/wine/dlls/ntdll/virtual.c cv538 NULL_RETURNS UNINSPECTED HEApNtEnumerateSubKey base/src/wine/dlls/ntdll/reg.c cv644 REVERSE_INULL UNINSPECTED NtQueryInformationProcess base/src/wine/dlls/ntdll/process.c cv658 FORWARD_NULL RNS UNINSPECTED RtlQueryRegistryValues base/src/wine/dlls/ntdll/reg.cdlls/ole32/ole2.c valgrind: http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_env.txt http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_exception.txt http://kegel.com/wine/valgrind/logs-2008-04-10/vg-ntdll_file.txt conformance tests: http://test.winehq.org/data/200804161000/#group_Wine:ntdll:change http://test.winehq.org/data/200804161000/#group_XP:ntdll:exception There, that doesn't look too awful, does it? Only a few dozen little problems to solve and we'll have server and ntdll spic and span... and then on to the next module. If we start with a small circle of pure modules, and vigorously defend the modules in that circle against regressions in any of valgrind, coverity, and conformance tests, we might make a noticable improvement in Wine's quality. - Dan

2 2