April 2008 - Wine-devel - list.winehq.org

Something strange: installers not waiting for subinstallers any more?
by Dan Kegel 16 Apr '08

16 Apr '08

I just installed Photoshop CS2 trial using yesterday morning's cvs, and there seemed to be two odd failure: 1) gecko didn't install properly 2) the outer installer declared victory way before the inner installer was done unpacking Mysterious, very mysterious. Ah, well, I'll close my eyes and hope it goes away :-)

1 0

quartz: FOURCC Error in compiling
by Sònia Xapellí Brú 15 Apr '08

15 Apr '08

When I try to compile the wine tree of today I get an error compiling avisplit.o: There is no rule to build fourcc.h needed for avisplit.o /make[2]: *** No hay ninguna regla para construir el objetivo `fourcc.h', necesario para `avisplit.o'. Alto. make[2]: se sale del directorio `/wine-git/dlls/quartz' make[1]: *** [quartz] Error 2 make[1]: se sale del directorio `/wine-git/dlls' make: *** [dlls] Error 2 /

2 1

Re: dinput: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -142,13 +142,12 @@ static INT find_joystick_devices(void) > { > CHAR device_name[MAX_PATH], *str; > INT len; > - int fd; > > len = sprintf(device_name, "%s%d", JOYDEV_NEW, i) + 1; > - if ((fd = open(device_name, O_RDONLY)) < 0) > + if (open(device_name, O_RDONLY) < 0) > { > len = sprintf(device_name, "%s%d", JOYDEV_OLD, i) + 1; > - if ((fd = open(device_name, O_RDONLY)) < 0) continue; > + if (open(device_name, O_RDONLY) < 0) continue; > } > > if (!(str = HeapAlloc(GetProcessHeap(), 0, len))) break; Again, this needs to be fixed in another way as fd is being leaked. -- Rob Shearman

2 1

Re: browseui: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -299,7 +299,6 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface, > { > ProgressDialog *This = (ProgressDialog *)iface; > struct create_params params; > - HANDLE hThread; > > TRACE("(%p, %p, %x, %p)\n", iface, punkEnableModeless, dwFlags, reserved); > if (punkEnableModeless || reserved) > @@ -321,7 +320,7 @@ static HRESULT WINAPI ProgressDialog_StartProgressDialog(IProgressDialog *iface, > params.hwndParent = hwndParent; > params.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > > - hThread = CreateThread(NULL, 0, dialog_thread, &params, 0, NULL); > + CreateThread(NULL, 0, dialog_thread, &params, 0, NULL); > WaitForSingleObject(params.hEvent, INFINITE); > > This->hwndDisabledParent = NULL; A correct fix is to call CloseHandle(hThread), otherwise the handle is leaked. -- Rob Shearman

2 1

Re: comctl32: Remove unused variables
by Robert Shearman 15 Apr '08

15 Apr '08

Andrew Talbot wrote: > @@ -967,16 +967,14 @@ static HFONT SYSLINK_SetFont (SYSLINK_INFO *infoPtr, HFONT hFont, BOOL bRedraw) > */ > static LRESULT SYSLINK_SetText (SYSLINK_INFO *infoPtr, LPCWSTR Text) > { > - int textlen; > - > /* clear the document */ > SYSLINK_ClearDoc(infoPtr); > - > - if(Text == NULL || (textlen = lstrlenW(Text)) == 0) > + > + if(Text == NULL || lstrlenW(Text) == 0) > { > A better fix would be to use "*Text == 0" instead of "lstrlenW(Text) == 0". -- Rob Shearman

1 0

RFC: Fix for IWineMsiRemotePackage::FormatRecord
by Robert Shearman 15 Apr '08

15 Apr '08

Hi, Currently, the [out] value parameter for IWineMsiRemotePackage::FormatRecord doesn't have a level of indirection associated with it and so I would be very surprised if the typelib marshaller actually does the right thing in this case. Compiling with MIDL and with a future update to widl causes an error for this parameter. I'm proposing the attached patch to fix things, but I'm not able to test that this works correctly. Thanks, -- Rob Shearman

2 1

Full Screen Desktop Mode
by Jeremy Newman 15 Apr '08

15 Apr '08

Here is a feature request that I'd had in my head for quite some time now. I don't usually pass my crazy ideas on down through the devel pipe, but I feel this one is too good to pass up on. Many of us still use desktop mode to get around issues with various window managers (compiz, metacity, etc). But running a game in desktop mode, you loose out on running full screen. It would be slick if the Wine desktop could be switched into full screen on the fly with a hotkey (say Ctrl + Alt + Enter). So if you are running a 1280x800 Wine desktop on a 1680x1050 screen, and you hit the hotkey, the resolution would be switched to 1280x800 and the Wine desktop is your screen until you hit the hotkey to switch back, or you exit the program. Sound fun?

1 0

Feature Request: Registry / winecfg entry for launching an application in a wineexplorer window
by Scott Ritchie 15 Apr '08

15 Apr '08

I have a few full screen applications that I'd like to run contained in small windows. Currently, in order to run them this way, I have to either open winecfg and set a virtual desktop or launch the application on the terminal with: wine explorer /desktop=name,1024x768 app.exe What I'd like is something that does this for me similar to app defaults. That way I could run the application by double clicking it (or from the shortcut in the start menu) and have it contained in the window I want. Ideally I'd be able to enable this setting from a right click->properties menu, however that work isn't necessarily needed within Wine other than support for modifying this new key using something like reg.exe on the terminal. It seems like it'd be fairly simple to implement, too. Any thoughts? Thanks, Scott Ritchie

6 7

Re: [WineHQ] Assorted spelling fixes.
by Jeremy Newman 15 Apr '08

15 Apr '08

This patch does not apply for me, I get the following errors: jnewman(a)jnewman:/home/httpd/html/winehq_org$ git am ~/Downloads/patch.eml Applying Assorted spelling fixes. .dotest/patch:38: trailing whitespace. between GDI/USER and the KERNEL, that is not absolutely needed, must be .dotest/patch:47: trailing whitespace. <quote who="Patrick Stridvall">I think your original suggestion making Wine .dotest/patch:60: trailing whitespace. not very optimized so I wouldn't be surprised if it is _much_ slower. .dotest/patch:69: trailing whitespace. Ove's pthread hack is a good way to make more libc functions usable .dotest/patch:82: trailing whitespace. It is of course also possible to override these settings by explicitly using Wine's --dll command-line error: patch failed: wwn/wn19990627_2.xml:474 error: wwn/wn19990627_2.xml: patch does not apply error: patch failed: wwn/wn19990718_4.xml:394 error: wwn/wn19990718_4.xml: patch does not apply error: patch failed: wwn/wn20000605_46.xml:364 error: wwn/wn20000605_46.xml: patch does not apply error: patch failed: wwn/wn20001106_68.xml:566 error: wwn/wn20001106_68.xml: patch does not apply error: patch failed: wwn/wn20010718_100.xml:342 error: wwn/wn20010718_100.xml: patch does not apply error: patch failed: wwn/wn20011021_106.xml:422 error: wwn/wn20011021_106.xml: patch does not apply error: patch failed: wwn/wn20020308_117.xml:720 error: wwn/wn20020308_117.xml: patch does not apply error: patch failed: wwn/wn20030103_151.xml:437 error: wwn/wn20030103_151.xml: patch does not apply error: patch failed: wwn/wn20030228_159.xml:566 error: wwn/wn20030228_159.xml: patch does not apply error: patch failed: wwn/wn20030725_180.xml:165 error: wwn/wn20030725_180.xml: patch does not apply error: patch failed: wwn/wn20030829_185.xml:381 error: wwn/wn20030829_185.xml: patch does not apply error: patch failed: wwn/wn20041022_245.xml:162 error: wwn/wn20041022_245.xml: patch does not apply error: patch failed: wwn/wn20041126_250.xml:337 error: wwn/wn20041126_250.xml: patch does not apply error: patch failed: wwn/wn20050415_270.xml:257 error: wwn/wn20050415_270.xml: patch does not apply error: patch failed: wwn/wn20050506_273.xml:354 error: wwn/wn20050506_273.xml: patch does not apply error: patch failed: wwn/wn20050819_288.xml:286 error: wwn/wn20050819_288.xml: patch does not apply error: patch failed: wwn/wn20051014_294.xml:155 error: wwn/wn20051014_294.xml: patch does not apply error: patch failed: wwn/wn20051125_299.xml:294 error: wwn/wn20051125_299.xml: patch does not apply error: patch failed: wwn/wn20060226_306.xml:208 error: wwn/wn20060226_306.xml: patch does not apply error: patch failed: wwn/wn20060410_311.xml:321 error: wwn/wn20060410_311.xml: patch does not apply error: patch failed: wwn/wn20060428_312.xml:287 error: wwn/wn20060428_312.xml: patch does not apply error: patch failed: wwn/wn20070416_329.xml:304 error: wwn/wn20070416_329.xml: patch does not apply Patch failed at 0001. When you have resolved this problem run "git-am --resolved". If you would prefer to skip this patch, instead run "git-am --skip". Francois Gouget wrote: > --- > > The attachement will probably look a bit strange but it should work > anyway. > > wwn/wn19990627_2.xml | 4 ++-- > wwn/wn19990718_4.xml | 4 ++-- > wwn/wn20000605_46.xml | 2 +- > wwn/wn20001106_68.xml | 2 +- > wwn/wn20010718_100.xml | 2 +- > wwn/wn20011021_106.xml | 2 +- > wwn/wn20020308_117.xml | 2 +- > wwn/wn20030103_151.xml | 6 +++--- > wwn/wn20030228_159.xml | 2 +- > wwn/wn20030725_180.xml | 2 +- > wwn/wn20030829_185.xml | 4 ++-- > wwn/wn20041022_245.xml | 2 +- > wwn/wn20041126_250.xml | 2 +- > wwn/wn20050415_270.xml | 2 +- > wwn/wn20050506_273.xml | 4 ++-- > wwn/wn20050819_288.xml | 2 +- > wwn/wn20051014_294.xml | 2 +- > wwn/wn20051125_299.xml | 2 +- > wwn/wn20060226_306.xml | 2 +- > wwn/wn20060410_311.xml | 2 +- > wwn/wn20060428_312.xml | 4 ++-- > wwn/wn20070416_329.xml | 2 +- > 22 files changed, 29 insertions(+), 29 deletions(-) > > > ------------------------------------------------------------------------ > >

1 0

quartz: FOURCC Error in compiling
by Luis Busquets 15 Apr '08

15 Apr '08

When I try to compile the wine tree of today I get an error compiling avisplit.o: There is no rule to build fourcc.h needed for avisplit.o /make[2]: *** No hay ninguna regla para construir el objetivo `fourcc.h', necesario para `avisplit.o'. Alto. make[2]: se sale del directorio `/wine-git/dlls/quartz' make[1]: *** [quartz] Error 2 make[1]: se sale del directorio `/wine-git/dlls' make: *** [dlls] Error 2 /

2 1