April 2008 - Wine-devel - list.winehq.org

error: `XICCallback' undeclared (Solaris build problem)
by Petr Sumbera 15 Apr '08

15 Apr '08

Hi all, It seems that following change from last Friday broke Solaris build: http://source.winehq.org/git/wine.git/?a=commitdiff;h=185157cb6eb25bc5e75e9… This is probably because Solaris /usr/include/X11/Xlib.h doesn't define XICCallback. -bash-3.2$ grep XICCallback /usr/include/X11/Xlib.h -bash-3.2$ Compilation error is following: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -std=gnu99 -o xim.o xim.c xim.c: In function `X11DRV_DestroyIM': xim.c:371: warning: passing arg 5 of `XRegisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_OpenIM': xim.c:398: warning: assignment from incompatible pointer type xim.c:475: warning: passing arg 5 of `XUnregisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_SetupXIM': xim.c:485: warning: passing arg 5 of `XRegisterIMInstantiateCallback' from incompatible pointer type xim.c: In function `X11DRV_CreateIC': xim.c:504: error: `XICCallback' undeclared (first use in this function) xim.c:504: error: (Each undeclared identifier is reported only once xim.c:504: error: for each function it appears in.) xim.c:504: error: syntax error before "destroy" xim.c:500: warning: unused variable `spot' xim.c:501: warning: unused variable `preedit' xim.c:502: warning: unused variable `status' xim.c:503: warning: unused variable `xic' ... Any idea or comment to this? Thanks, Petr

4 7

Re: [1/2] shlwapi: Fixed the todo blocks in the SHCreateStreamOnFile tests. [try 2]
by Alexandre Julliard 15 Apr '08

15 Apr '08

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > @@ -120,12 +119,12 @@ static HRESULT WINAPI IStream_fnRead(IStream *iface, void* pv, ULONG cb, ULONG* > TRACE("(%p,%p,0x%08x,%p)\n", This, pv, cb, pcbRead); > > if (!pv) > - return STG_E_INVALIDPOINTER; > + return S_OK; It's very unlikely that this is the correct behavior in all cases. > @@ -459,7 +458,9 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR lpszPath, DWORD dwMode, > switch(STGM_CREATE_MODE(dwMode)) > { > case STGM_FAILIFTHERE: > - dwCreate = OPEN_EXISTING; > + if (bCreate && PathFileExistsW(lpszPath)) > + return HRESULT_FROM_WIN32(ERROR_FILE_EXISTS); > + dwCreate = bCreate ? CREATE_ALWAYS : OPEN_EXISTING; That case should be handled by CreateFile, you shouldn't check for the file existence explicitly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
by Juan Lang 14 Apr '08

14 Apr '08

Hi Tomasz, - info->WinType.pszToc = strdupW(info->pCHMInfo->defToc); + info->WinType.pszToc = strdupW(info->pCHMInfo->defToc ? info->pCHMInfo->defToc : null); Please don't use null, it's not portable. Also, what has this change accomplished? If strdupW succeeds when passed NULL, the existing line would already have done the same thing, so you've added a test for no benefit. --Juan

1 0

Re: winex11: Standardize a stub trace and add a trailing '\n'.
by Stefan Leichter 14 Apr '08

14 Apr '08

Am Monday 14 April 2008 01:01 schrieb Francois Gouget: > --- > + FIXME("(%p, %x): stub\n"); You forgot the parameters hIMC and fFlag Bye Stefan

1 0

Re: [PATCH 1/6] includes: update aviriff header file
by Alexandre Julliard 14 Apr '08

14 Apr '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > @@ -161,4 +186,135 @@ typedef struct _avimetaindex > DWORD adwIndex[0]; > } AVIMETAINDEX; > > -/* FIXME: index structures missing */ > +#define ckidAVISUPERINDEX FCC('i','n','d','x') > +typedef struct _avisuperindex { > + FOURCC fcc; > + UINT cb; > + WORD wLongsPerEntry; > + BYTE bIndexSubType; > + BYTE bIndexType; > + DWORD nEntriesInUse; > + DWORD dwChunkId; > + DWORD dwReserved[3]; > + struct _avisuperindex_entry { > + DWORDLONG qwOffset; > + DWORD dwSize; > + DWORD dwDuration; > + } aIndex[0]; > +} AVISUPERINDEX; Zero-size arrays are not portable, and this is not what the MS header does anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: gdiplus: (try2) GdipCloneStringFormat
by Juan Lang 14 Apr '08

14 Apr '08

Hi Nikolay, +GpStatus WINGDIPAPI GdipCloneStrinFormat(GDIPCONST Typo: s/StrinFormat/StringFormat/ --Juan

1 0

Re: IWineD3DBaseTextureImpl_SetAutoGenFilterType missing break inside switch
by Stefan Dösinger 14 Apr '08

14 Apr '08

Am Montag, 14. April 2008 17:16:25 schrieb Hoehle, Joerg-Cyril: > Hi, > > regardless of issue > http://bugs.winehq.org/show_bug.cgi?id=11167 > which suggests that the function is incorrect it its use of GL parameters, > so it needs fixing, you may wish to apply the following (minor) patch. > > dlls/wined3d/basetexture.c:IWineD3DBaseTextureImpl_SetAutoGenFilterType > missing break inside switch The patch looks ok.

1 0

ws2_32: Work around the host name resolving to 127.x.x.x when using that for binding.
by Kirill K. Smirnov 14 Apr '08

14 Apr '08

Hi, nitpick: > + /* Trying to bind to the default hots interface, using Typo in word 'host'? -- Kirill

2 1

Lug Radio Live 2008 wine talk. Slides online, comments welcome.
by Dan Kegel 14 Apr '08

14 Apr '08

I'm going to be giving a Wine talk at LugRadio Live 2008, April 12-13, in San Francisco. My talk is Saturday at 2:30; see http://lugradio.org/live/USA2008/schedule In a mixup at my favorite coffeehouse today (Stir Crazy), I was accidentally overcaffeinated, and wrote my entire presentation in about one sitting. It's online at http://kegel.com/wine/lugradiolive2008/ The slides are pretty basic; I'll talk a lot around them. If anybody feels like reviewing the slides and giving feedback, I'd appreciate it. If anybody's planning on attending the event, let's get together for lunch or coffee or something. - Dan

3 2

Re: wine.info add fake dlls for msacm32.drv and midimap.dll
by Dmitry Timoshkov 14 Apr '08

14 Apr '08

"Steven Edwards" <winehacker(a)gmail.com> wrote: > trace:winmm:DllMain 0x7e250000 0x1 (nil) > trace:winmm:MMDRV_Init () trace:winmm:MMDRV_Install > ('winealsa.drv', 'winealsa.drv', mapper=N); > warn:winmm:MMDRV_Install Couldn't open driver 'winealsa.drv' > trace:winmm:MMDRV_Install ('wineoss.drv', 'wineoss.drv', > mapper=N); warn:winmm:MMDRV_Install Couldn't open driver 'wineoss.drv' > trace:winmm:MMDRV_Install ('winecoreaudio.drv', > 'winecoreaudio.drv', mapper=N); warn:winmm:MMDRV_Install > Couldn't open driver 'winecoreaudio.drv' > trace:winmm:MMDRV_Install ('wavemapper', 'msacm32.drv', > mapper=Y); warn:winmm:MMDRV_Install Couldn't open driver 'msacm32.drv' > trace:winmm:MMDRV_Install ('midimapper', 'midimap.dll', > mapper=Y); warn:winmm:MMDRV_Install Couldn't open driver 'midimap.dll' > > With this patch the firefox thinstall demo bug 10905 now works. I > expect there may be other problems with other thinstall applications > as he thinks there may be some changes that need to be done on their > end to better accommodate Wine. I don't know if this really should be > the case as it works on Windows and we should try to mimic that > behavior. DLLs are being added to wine.inf only if an app does check for a dll existence, which is not the case here. You need to investigate further what is going on. -- Dmitry.

3 3