April 2008 - Wine-devel - list.winehq.org

Re: shell32: implement SHGetFolderPathAndSubDirA/W [2nd resend]
by Alexandre Julliard 14 Apr '08

14 Apr '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + if (pszSubPath && (length = MultiByteToWideChar(CP_ACP, 0, pszSubPath, -1, NULL, 0))) { > + pszSubPathW = HeapAlloc(GetProcessHeap(), 0, length * sizeof(WCHAR)); > + if(!pszSubPathW) > + return HRESULT_FROM_WIN32(ERROR_NOT_ENOUGH_MEMORY); You are leaking memory on error. Also I don't think it makes sense to test the return value of MultiByteToWideChar, it shouldn't fail in this case (or if you test it, then you need to handle the error properly, not use an empty path instead). -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: WineD3D: WineD3D: Use the shader backend to enable / disable atifs and nvts
by Stefan Dösinger 14 Apr '08

14 Apr '08

Am Freitag, 11. April 2008 00:31:13 schrieb Stefan Dösinger: > The drawback of this is that now the workaround for the mesa atifs bug > minimally affects nvidia cards too. It's a bit tricky to design around > driver bugs :-/ Use this patch instead, the last one had a small but pretty bad bug that broken GLSL

4 25

Wine 1.0 status: T minus 61 days, 69 bugs to go
by Dan Kegel 14 Apr '08

14 Apr '08

19 days to code freeze (!) Big news of the week is an apparant regression in one of the release criteria apps. Also, happily, two bugs I had pushed off to 1.2 got fixed anyway (demonstrating the honorary nature of the release manager position :-) Changes since last week: Deferred earlier, but fixed anyway: 3534 user32 14 Systray icons are not transparent... Deferred earlier, but patch that really fixes it submitted, so undeferred: 10905 shell32 0 thinstall firefox demo requires native msvcrt Deferred: 6254 richedit 4 Installer infinite loop from rich text error New: 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression Here's the full list of current bugs: 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 4372 comctl32 1 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 17 Planescape:Torment doesn't work 9030 directx- 0 army men hangs on black screen 11681 directx- 17 Add support for video overlay 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 42 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5351 kernel32 11 Windows Installer 3.1 cannot install because of non-standard drive labeling 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 9484 kernel32 19 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 8783 ntdll 13 USB serial ports do not work 9356 ntdll 8 Serial communication not working since wine-0.9.33 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 6607 ole 10 Drag and Drop not working 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 5163 setupapi 13 Office XP 2002 crashes on installation 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 13 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 8 Visual Studio .NET (7) install fails 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 12 tray minimize 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 7477 -unknown 1 Uplink demo crashes 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 8 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 9959 -unknown 9 Make wine updates work even if the registry changed 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 4 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 664 user32 7 The help menu functionality inside programs is broken (messaging problem) 3023 user32 5 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 25 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

2 1

Better sound support
by Kacper Pluta 13 Apr '08

13 Apr '08

Hey, do you plan on enabling handling of 24bit sound and sampling frequencies 96000 or 192000? Lots of musicians using Linux need to use VST and VSTi plugins (through FST and other methods). Unfortunately quality of music you can acquire isn't realy high if you wish to use it professionally. I'd also suggest correcting MIDI handling and integrating wine with wineasio, which would enable using VST and VSTi on a quite high level, as well as use other programmes.

3 2

cachedmetrics - still used?
by Austin English 13 Apr '08

13 Apr '08

Looking at documentation/PACKAGING, it seems there's quite a bit of outdated info (hasn't been updated in 2-3 years...). Anywho, I'm preparing a few updates for it, but wanted to verify that cachedmetrics is no longer used. There's a few references to it on AppDB, but only one reference in the code, and a few on wine-devel (all of which are pretty old). Is it safe to remove this info? -Austin

2 2

Re: [5/6] winspool: Implement DeleteFormA/W
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > + formNameW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, pFormName, -1, formNameW, len); > + return DeleteFormW(hPrinter, formNameW); Memory-leak: formnameW -- By by ... Detlef

1 0

Re: [3/6] winspool: Implement AddFormA/W for level 1 forms
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > + * > + * FIXME: no level 2 support > + * > */ > BOOL WINAPI AddFormW(HANDLE hPrinter, DWORD Level, LPBYTE pForm) "FIXME:" is not a valid section in our API-Documentation Please use "NOTES" or "BUGS" -- By by ... Detlef

1 0

Re: [2/6] winspool/tests: Add tests for AddForm
by Detlef Riekenberg 13 Apr '08

13 Apr '08

On So, 2008-04-13 at 02:18 +0200, Marcel Partap wrote: > Subject: [PATCH] winspool/tests: Add tests for AddForm A test for AddForm / DeleteForm can't work with the stubs in our "winspool.drv". The implementation is needed first. > + SetLastError(MAGIC_DEAD); Plase do not use MAGIG_DEAD, it was a mistake in my first Patchset. Use the real Value instead. > + res = AddFormA(NULL, 0, NULL); > + RETURN_ON_DEACTIVATED_SPOOLER(res); > + ok( !res && (GetLastError() == ERROR_INVALID_LEVEL), > + "returned %d with %d (expected '0' with ERROR_INVALID_LEVEL)\n", res, GetLastError()); > + > + SetLastError(MAGIC_DEAD); > + res = AddFormA((HANDLE)MAGIC_DEAD, 1, NULL); > + RETURN_ON_DEACTIVATED_SPOOLER(res); Use this macro only once. I did not test, which AddFormA return RPC_S_SERVER_UNAVAILABLE. Did you test the code with a non - admin account? Many functions in winspool.drv return ERROR_ACCESS_DENIED -- By by ... Detlef

1 0

re: loader: print a better message about reserving memory
by Dan Kegel 13 Apr '08

13 Apr '08

Vitaliy wrote: >Austin English wrote: >> With ubuntu updating to the 2.6.24 kernel, a lot more people are >> running into errors about reserving memory. This patch adds a >> suggestion to check /etc/sysctl.conf. >> >> You may need to edit /etc/sysctl.conf to give Wine access to this memory.\n", > >Can you be more specific what did Ubuntu do to break Wine? It would have been helpful if Austin had linked to the bug report from his patch. I went and filed a (very well documented :-) bug report http://bugs.winehq.org/show_bug.cgi?id=12548 that turned out to be a dup of the one Austin had been discussing the bug in. Austin's patch is helpful, but I think we can do better. For instance, we could ship a helper app that pops up a gui and asks whether the user wants us to work around the problem (by doing gksudo sysctl -w vm.mmap_min_addr=0, say) and run it in the preloader if we can't map the lowest page.

2 1

re: Trying to get a grip on how to handle bug reports.
by Dan Kegel 13 Apr '08

13 Apr '08

James wrote: > If you'll actually read what I said, I made no threats, nor was I rude. IMHO the cumulative attitude of your comments, especially http://bugs.winehq.org/show_bug.cgi?id=11639#c18 Stop posting in a closed bug report! You've already been told to open a new bug report.. was in fact somewhat rude. - Dan

1 0