May 2008 - Wine-devel - list.winehq.org

Re: kernel32: Enumerate the Greek language group locales instead of Western Europe
by Alexandre Julliard 22 May '08

22 May '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > Any objections to this patch? The point of the test is to enumerate > locales of a language group, which still happens. The failure in > win2k3 can't easily be caught, so this works around that. Looking at the test results it seems the failure is because it passes an lcid of 0, that seems pretty trivial to catch. Did I miss something? -- Alexandre Julliard julliard(a)winehq.org

1 0

Take the Wine 1.0 Dogfood Challenge!
by Dan Kegel 22 May '08

22 May '08

As I wrote two years ago: if we're expecting people to use Wine for real work, maybe we should start doing that ourselves. How's about everybody start using Wine for *everything*? See http://wiki.winehq.org/DogfoodChallenge

1 0

Re: headers: Update aviriff header to use 1 byte alignment
by Dmitry Timoshkov 22 May '08

22 May '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > These structures are on disk formats, so normal alignment rules don't > apply here. PSDK has a different idea about aviriff.h alignment. -- Dmitry.

1 0

Thunderbird warning repeat - use --attach
by Jeremy White 22 May '08

22 May '08

So it seems as though every month or so, some id10t is bit by the Thunderbird bug where it mangles perfectly reasonable looking git-format-patch drafts. This month, I won the prize! :-) I had always habitually done --attach, because that's what GitWine says to do. But after scratching my head, reading man pages, and checking my drafts, I decided that was lame; inline is always nicer, and I dropped the --attach. Big mistake; the draft may look okay, but the end result is mangled somehow. Thanks to Dmitry for alerting me. I've filed a bug with Mozilla over this: https://bugzilla.mozilla.org/show_bug.cgi?id=435020 My sense is that its a subtle bug of some kind; I've had a hard time articulating a strategy to reproduce it (which, by Occam's razor, immediately suggests I'm just missing something :-/). So if others are bit by this and can share any clues or tips for the Mozilla devs on how to reproduce it, I'd appreciate it. Cheers, Jeremy

4 4

Crosstests - Too large of log files?
by Austin English 21 May '08

21 May '08

In the past 2 days, when running the cross tests on my work XP box, I keep getting an error that the log file is too big (1.6 Mb > 1.5 Mb max). Anyone else seeing this? It's submitting partial reports, which may or may not be useful. Can we get some compression going, or increase the max log size? -Austin

4 6

Re: mlang: accept character set names like ISO8859-1
by James Hawkins 21 May '08

21 May '08

On Wed, May 21, 2008 at 6:22 PM, Dan Kegel <dank(a)kegel.com> wrote: > Accept names both with and without dash after ISO. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=13340 > > The ugly string comparison could be avoided by > canonicalizing the input character set name, > though that would mean making a copy. Would > you prefer it that way instead? > > This doesn't change the miserable status of the > mlang tests on XP: > http://test.winehq.org/data/200805211000/#group_XP:mlang:mlang > Those are fixed by this patch: http://winehq.org/pipermail/wine-patches/2008-May/054961.html Julliard is suspicious of the ZeroMemory I had to add, so I need to add another test case to prove it. -- James Hawkins

1 0

Re: wined3d: Remove unneeded "extern" from function definition
by James Hawkins 21 May '08

21 May '08

On Wed, May 21, 2008 at 3:50 PM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > wined3d: Remove unneeded "extern" from function definition. > > diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c > index 7a1a355..684690b 100644 > --- a/dlls/wined3d/surface.c > +++ b/dlls/wined3d/surface.c > @@ -2489,7 +2489,7 @@ HRESULT WINAPI IWineD3DSurfaceImpl_SaveSnapshot(IWineD3DSurface *iface, const ch > /** > * Slightly inefficient way to handle multiple dirty rects but it works :) > */ > -extern HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) { > +HRESULT WINAPI IWineD3DSurfaceImpl_AddDirtyRect(IWineD3DSurface *iface, CONST RECT* pDirtyRect) { > IWineD3DSurfaceImpl *This = (IWineD3DSurfaceImpl *)iface; > IWineD3DBaseTexture *baseTexture = NULL; > These interface implementations could even be made static. -- James Hawkins

2 2

fedora 9/gcc 4.3 internal compiler error with wine 1.0 rc1
by Hin-Tak Leung 21 May '08

21 May '08

This is probably a bug with gcc 4.3, but just in case there are some people who are knowledgeable with gcc in wine-devel, who may want to fix gcc so that wine can be built on f9: https://bugzilla.redhat.com/show_bug.cgi?id=445494 __________________________________________________________ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: crypt32: String resource IDs
by Juan Lang 21 May '08

21 May '08

Don't forget to cc wine-devel on replies.. On Wed, May 21, 2008 at 9:55 AM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > do we define "rsaenh.dll" as "application"? Not usually, as it's part of Windows and doesn't come with other applications. > So we do not currently have the needed strings (they seem to decribe > actions, for logging, error reporting or progress indication). The > strings we do have are differently numbered, but up to now, I don't know > about any code relying on those numbers. In that case, we just need to add some strings for it. The text values of the strings don't have to match for now. > Thats right. But for rsaenh.dll I need strings wine does not currently > have. The question is how I legally get these strings into wine. Now you're asking for advice I'm not qualified to give. Perhaps someone here can give better guidance. In particular you might ask Jeremy whether the SFLC has given any hints about the proper way to add UI elements to Wine. --Juan

1 0

Re: Patch against bug [13112]
by John Klehm 21 May '08

21 May '08

On Tue, May 20, 2008 at 3:14 PM, Josep Maria Antolín Segura <jaz(a)pastnotecut.org> wrote: > Hello, > > I am resending here the patch attached to the bug # 13112 on bugzilla, regarding > the trackbar control of the comctl32.dll file. You forgot to attach the patch. --John

1 0