May 2008 - Wine-devel - list.winehq.org

Removinig CVS/GIT version from bugzilla
by Vitaliy Margolen 25 May '08

25 May '08

I'm copying my response here to continue the conversation. Please don't remove cvs/git version. What should be done is: 1. Leave old bugs alone or modify them case-by-case 2. All bugs with "cvs/git" version from now on can be filed on the development branch between releases only. 3. After the next release, if the bug is still present, modify version to that release. Of course no modifying of old bugs. Vitaliy.

4 5

winetest failure summary for 1.0rc2
by Dan Kegel 25 May '08

25 May '08

Wow, lots of people submitted test results for 1.0rc2 already! I ran my skipgood filter on it, put the digested data up at http://kegel.com/wine/failing-1.0-rc2.html and added a little analysis to http://wiki.winehq.org/MakeTestFailures To wit: -- snip --- Tests that fail on most versions of Windows As of 1.0-rc2, the following tests all fail on 2000, XP, 2003, and Vista: comctl32:listview ddraw:d3d gdi32:metafile kernel32:toolhelp mshtml:htmldoc oleaut32:olefont and a bunch more fail on most of those versions of Windows. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on XP As of 1.0-rc2, the following tests fail on all machines running XP: comctl32:listview ddraw:d3d gdi32:metafile kernel32:actctx kernel32:toolhelp mshtml:htmldoc msvcrt:cpp oleaut32:olefont urlmon:url user32:input user32:listbox user32:msg and a whole mess fail for nearly all reporters. See http://kegel.com/wine/failing-1.0-rc2.html for the full data. Most Common Failures on Wine As of 1.0-rc2, here are the tests that fail on some Wine systems, and how many people they fail for: 14 user32:msg 12 user32:win 9 user32:input 6 dsound:ds3d dsound:ds3d8 kernel32:path user32:monitor 5 kernel32:process msi:install msi:package riched20:editor 4 comctl32:listview ddraw:visual dinput:device gdi32:font gdi32:metafile kernel32:profile kernel32:sync kernel32:virtual snmpapi:util urlmon:protocol user32:class wininet:internet 3 comctl32:monthcal ddraw:d3d kernel32:volume msi:msi setupapi:devinst shell32:shlfolder user32:menu userenv:userenv 2 advapi32:registry advapi32:security advapi32:service comctl32:tooltips d3d8:visual d3d9:visual ddraw:dsurface dsound:dsound kernel32:version msvcrt:time ntdll:exception psapi:psapi_main qedit:mediadet 1 advpack:advpack advpack:install ...[many deleted]... wininet:http winmm:wave winspool.drv:info Whew, that's a lot of data. I looked at all the ones that failed for five or more people: user32:msg, user32:win, and user32:input are probably people running non-blessed window managers; Alexandre's position is that we can ignore these, since upstream gnome's WM is fixed. dsound:ds3d is mostly "ds3d.c:891: Test failed: The primary volume changed from -27 to -960" (worrisome, random) plus "ds3d.c:896: Test failed: The primary pan changed from -5594 to -5595" (rounding error, just add slop of 1?). dsound:ds3d8 is the same. kernel32:path is mostly "path.c:899:TMP=c:\windows\temp"..."path.c:1178: Test failed: expected buf[0] upper case letter got c", probably people whose ~/.wine is old and has a windir that starts with a lowercase drive letter?! Has that changed recently? msi:install is mostly "install.c:4414: Test failed: File installed". msi:package is mostly "package.c:1661: Test failed: wrong return val (0)" riched20:editor has several failures. --- snip ---

6 8

Regression in wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation.
by Markus 25 May '08

25 May '08

Hi, after investigating reports for the game 'World in Conflict', I identified the following patch to cause the game graphics to freeze (ambient sounds are still played though): ---- ba90a740beb9ce9a839cc843db8d87f5a37becdd is first bad commit commit ba90a740beb9ce9a839cc843db8d87f5a37becdd Author: Roderick Colenbrander <thunderbird2k(a)gmx.net> Date: Sun Feb 10 22:20:15 2008 +0100 wined3d: Add read_from_framebuffer_texture which combines code from read_from_framebuffer (drawpixels) and LoadLocation. This makes the code easier to read and the pieces borrowed from read_from_framebuffer are more correct than the code in LoadLocation. :040000 040000 74e4bdc73e367c8f38cd3d0818df0fc86eb788bf 3e54409be7c9d2964efbf3d3c2f3d3b84a267047 M dlls ---- The freezes only seem to occur if the native (Windows) dxdiagn.dll is used, as it lets the game properly detect the graphics card and thus enables additional graphics options (highend shaders, high-res textures, etc.). Apparently the freeze is only triggered with these options active. The game uses events in its drawing code and ("always") hangs after the following output: fixme:d3d9:D3DPERF_BeginEvent (color 0xffffffff, name L"Update verlet cloth") : stub fixme:d3d9:D3DPERF_EndEvent (void) : stub At one point, it was followed by this error: err:d3d_surface:surface_prepare_system_memory Surface without memory or pbo has SFLAG_INSYSMEM set! The point of the freeze appears to depend on many factors. If I move the camera around, it appears to freeze earlier than just letting the game run (e.g. a replay of a match). But once the patch is excluded, the game no longer freezes. If more info is needed, please specify how I can obtain it. -- Markus

3 2

winetest for 1.0rc2 - small post-run error message
by Susan Cragin 25 May '08

25 May '08

Network transfer: Done (1116026 of 1116026) Finished susan(a)ubuntu:~/wine-git/programs/winetest$ fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for 8000000a susan(a)ubuntu:~/wine-git/programs/winetest$

1 0

Readme: Updates needed
by Austin English 25 May '08

25 May '08

Alexandre committed a few fixed to the README today, but I still see a few things that may need fixing: ./tool/wineinstall - Has been mentioned to be deprecated a few times in bugzilla. If it's deprecated, we need to remove it. If not, we need to fix whatever it's doing wrong and stop discouraging its use. 3. REQUIREMENTS Linux version 2.0.36 or above FreeBSD 6.2 or later Solaris x86 2.5 or later NetBSD-current Mac OS X 10.4 or later Need to check these versions. FreeBSD should be 6.3, with patches, or preferably 7.0. Others, I don't know. Lastly, the translated READMEs under /documentation likely need _a lot_ of work. Those of you that are bilingual might take a stab at it... There were a couple other minor things that I've sent a patch for: urls lacking trailing backslash, mentioning version .9 instead of 1.0, using solitare as an example program (which we don't include, so I replaced with notepad), etc. -Austin

4 3

Re: msi: fix tab order
by James Hawkins 25 May '08

25 May '08

On Sat, May 24, 2008 at 7:10 PM, Dan Kegel <dank(a)kegel.com> wrote: > When you press Tab in an msi dialog, focus moves the wrong way. > You can confirm the correct tab order by viewing the msi > file in Orca and looking at the Dialog and Control tables. > > It seems that tab order in user32 is equal to z order, > and SetWindowPos() is the function used to control both. > Our msi currently seems to get the first two args backwards; > reversing them fixes http://bugs.winehq.org/show_bug.cgi?id=10147 > and at least superficially makes more sense. > This change is wrong and breaks tab order in (at least) the office installer. -- James Hawkins

1 0

Re: [5/5] d3d9: Test our texop implementation
by Stefan Dösinger 24 May '08

24 May '08

Am Samstag, 24. Mai 2008 10:33:42 schrieb H. Verbeet: > The color_match() function which this test introduces should be used > for the other visual tests that require an approximate match as well, > but doing this is outside the scope of this patch. Dan recently added color_near() for this purpose. Is there any difference between the functions(I see that yours passes the hardcoded slop as a parameter). Do you have any preference towards any implementation? I'm inclined to use yours because of the additional parameter and the better checking with abs()

2 1

Re: RFC: comctl32 indentations
by Hin-Tak Leung 24 May '08

24 May '08

Andrew Talbot wrote: <snipped> > If, in this case, it turns out that the braces should be added, and doing so > would fix some longstanding bug with Photoshop CS2, say, then I doubt that > too many people would accuse me of having wasted their time. This is still a waste of time - I am not going to talk about 'what if's'. Show me the code and show you that you are right. Don't try to tell me that you 'may be' right.

1 0

Re: crypt32: CertComparePublicKeyInfo must ignore the leading zero
by Juan Lang 24 May '08

24 May '08

This one's bugged me for ages, but I never tracked it down. Thanks! --Juan

1 0

Adding d3d9x_xx dlls to winetricks?
by Dan Kegel 24 May '08

24 May '08

So... lots of people are going around installing all of directx, and maybe all they needed was, say, d3d9x_35. That's not good. This sounds like a job for winetricks! But I know nothing about direct3d. Could somebody have a look at this draft and see if it suffices? All I added was d3d9x_35 and d3d9x_36, is that the right set?

7 13