May 2008 - Wine-devel - list.winehq.org

Re: wined3d: Use higher precision to convert floats into text.
by Chris Robinson 27 May '08

27 May '08

On Monday 26 May 2008 12:37:04 pm Vitaliy Margolen wrote: > - shader_addline(buffer, "PARAM srgb_mul_low = {%f, %f, %f, > 1.0};\n", > + shader_addline(buffer, "PARAM srgb_mul_low = {%.12f, > %.12f, %.12f, 1.0};\n", I don't know if ARB shaders would except the notation (GLSL does), but would %.8e or somesuch work better than %.12f at maintaining accuracy?

4 6

listview maintainer review, please...
by Dan Kegel 27 May '08

27 May '08

The curious Valgrind error + Conditional jump or move depends on uninitialised value(s) + at SetWindowPos (winpos.c:2034) + by LISTVIEW_UpdateSize (listview.c:9380) + by LISTVIEW_Size (listview.c:9320) + by LISTVIEW_WindowProc (listview.c:9949) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_CallProcAtoW (winproc.c:901) + by CallWindowProcA (winproc.c:2282) + by listview_subclass_proc (listview.c:231) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + by call_window_proc (winproc.c:457) + by WINPROC_CallProcWtoA (winproc.c:1267) + by WINPROC_call_window (winproc.c:2200) + by call_window_proc (message.c:1610) + by send_message (message.c:2434) + by SendMessageW (message.c:2557) + by DEFWND_DefWinProc (defwnd.c:746) + by DefWindowProcW (defwnd.c:1037) + by LISTVIEW_WindowProc (listview.c:9994) + by (within /home/dank/wine-git/dlls/user32/user32.dll.so) + Uninitialised value was created by a stack allocation + at LISTVIEW_UpdateSize (listview.c:9351) started happening recently. Looking at LISTVIEW_UpdateSize, it seems clear that if SendMessageW( infoPtr->hwndHeader, HDM_LAYOUT, 0, (LPARAM)&hl ); fails for whatever reason, hl will be undefined, and that's what Valgrind is complaining about. Here's a patch that skips the rest of the function if that line fails; it makes Valgrind happy, and doesn't seem to hurt the conformance tests. Can somebody familiar with the code have a look at that function and explain what's going on here? Thanks! - Dan

2 1

Re: [PATCH] Add Ex critical section initialisers for msvcrt
by Rob Shearman 27 May '08

27 May '08

2008/5/26 Jon Griffiths <jon_p_griffiths(a)yahoo.com>: > The latest msvcrt needs InitializeCriticalSectionEx to load (e.g. > http://forum.utorrent.com/viewtopic.php?id=37243) I don't believe we should be adding new functions during code freeze, especially not totally implemented ones with no corresponding tests. However, I would encourage you to create a bug and to submit the patch when we start thawing. -- Rob Shearman

1 0

Re: user32: Allow scrolling via mouse drag outside scrollbar
by James Hawkins 27 May '08

27 May '08

On Mon, May 26, 2008 at 1:46 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > When dragging the scrollbar thumb with the mouse, the mouse is able to > move away from the scrollbar and keep scrolling so long as it isn't too > far away from the scrollbar. This makes it easier to quickly scroll > with the mouse. > > This patch is an alternative to the Windows approach of allowing the > mouse to be dragged a certain distance from the scrollbar, and instead > allows the mouse to be dragged any distance away and still scroll. > Although this is different from Windows, it shouldn't result in any > compatibility issues. > > It is my personal opinion that this is a simpler and more usable > approach. > It doesn't matter if you think it's simpler and more usable. We are bug-for-bug compatible with Windows. -- James Hawkins

3 2

Re: fusion: improve UninstallAssembly stub slightly, fix typo in test
by James Hawkins 26 May '08

26 May '08

On Mon, May 26, 2008 at 9:24 PM, Dan Kegel <dank(a)kegel.com> wrote: > Improve stub slightly so callers (like our test) looking for a > disposition find one. > Also fix a minor typo in the test. > diff --git a/dlls/fusion/asmcache.c b/dlls/fusion/asmcache.c index 7da79f4..5697433 100644 --- a/dlls/fusion/asmcache.c +++ b/dlls/fusion/asmcache.c @@ -151,6 +151,9 @@ static HRESULT WINAPI IAssemblyCacheImpl_UninstallAssembly(IAssemblyCache *iface { FIXME("(%p, %d, %s, %p, %p) stub!\n", iface, dwFlags, debugstr_w(pszAssemblyName), pRefData, pulDisposition); + /* caller might test disposition to see why it failed, so come up with some excuse... */ + if (pulDisposition) + *pulDisposition = IASSEMBLYCACHE_UNINSTALL_DISPOSITION_STILL_IN_USE; return E_NOTIMPL; } I disagree with this change. If you want to fix the valgrind warning, the test should set the disposition before calling UninstallAssembly. This disposition is misleading anyway. Hypothetically, a user of this API could sit in a loop waiting for the assembly to not be in use. -- James Hawkins

1 0

Re: fusion: use HeapAlloc, not strdup, to avoid malloc/HeapFree mismatch; don't test variable if not set
by James Hawkins 26 May '08

26 May '08

On Mon, May 26, 2008 at 4:21 PM, Dan Kegel <dank(a)kegel.com> wrote: > Can't mix strdup and HeapFree. > > Fixes three valgrind errors > http://kegel.com/wine/valgrind/logs-2008-05-25/vg-fusion_asmcache.txt > diff --git a/dlls/fusion/tests/asmcache.c b/dlls/fusion/tests/asmcache.c index a160b0a..dcf26a0 100644 --- a/dlls/fusion/tests/asmcache.c +++ b/dlls/fusion/tests/asmcache.c @@ -922,8 +922,10 @@ static void test_InstallAssembly(void) todo_wine { ok(hr == S_OK, "Expected S_OK, got %d\n", S_OK); - ok(disp == IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, - "Expected IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, got %d\n", disp); + if (hr == S_OK) { + ok(disp == IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, + "Expected IASSEMBLYCACHE_UNINSTALL_DISPOSITION_UNINSTALLED, got %d\n", disp); + } } Why did you add this change? The value of disp is independent of the value of hr. Also, the style of the braces doesn't match the rest of the file. -- James Hawkins

1 0

Best place for HOWTO documents for your favourite application?
by Reece Dunn 26 May '08

26 May '08

Hi, I have been trying our various Oberon Media games. The thing that is holding this up from working is the hyperlinks on the intro screen (I am going to enter a bug report later on). I have worked out how to run and register the games (given a valid registration key that you have purchased) so that they will work under Wine. So this got me wondering... where do I put this? This complements the appdb, but is in a way orthogonal to it (that is there may be HOWTOs relating to individual games/applications, to vendors or to other areas such as installing Windows themes like the Zune theme). It will also help when more people start using Wine and want to get their favorite application running. My initial thoughts are that the wiki seems like a good place for this. Thoughts? Comments? - Reece

4 4

Re: user32: Increased area for scrolling via mouse drag outside scrollbar
by Dylan Smith 26 May '08

26 May '08

I just realized that the behaviour of Windows in this situation feels buggy. To me it would actually be more usable to allow the mouse to be dragged anywhere on the screen, as long as the mouse button stays down, instead of just within some area close to the scrollbar. KDE and Gnome applications that I am running all appear to allow the mouse to be dragged anywhere on the screen to scroll. Therefore, I would like to know what other people think. Do we actually want to copy Windows when it makes usability worse and doesn't affect compatibility? Wouldn't it be cool to have a better implementation of the Windows platform? I still think this patch is an improvement, just not the best solution. On Mon, May 26, 2008 at 12:59 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > When dragging the scrollbar thumb with the mouse, the mouse is able to > move away from the scrollbar and keep scrolling so long as it isn't too > far away from the scrollbar. This makes it easier to quickly scroll > with the mouse. > > All that this patch changes is the distance that the mouse can be moved > away from the scrollbar before it is consider outside of the scrollbar > and returns to its original position. The constants are only > approximate, since I only tested visually against Windows XP SP3, so it > should at least feel the same. > --- > dlls/user32/scroll.c | 19 +++++++++++++++---- > 1 files changed, 15 insertions(+), 4 deletions(-) >

1 0

Re: README: Few more updates
by Aurimas Fischer 26 May '08

26 May '08

Austin English wrote: > - Go to http://www.winehq.org/site/git for more information. > + Go to http://www.winehq.org/site/git/ for more information. this is not correct, second link returns 404 page.

2 1

Re: [PATCH] - fall back to the main HWND when there is no IMM HWND
by James Hawkins 26 May '08

26 May '08

On Sun, May 25, 2008 at 6:59 PM, Christopher GAUTIER <krys(a)via.ecp.fr> wrote: > > Description: > > It is apparently valid to call ImmGetDefaultIMEWnd() without first > opening the IME with ImmSetOpenStatus(). In such cases, > ImmGetDefaultIMEWnd returns NULL (the value of hwndDefault), which > indicates a failure according to MSDN. As a result, some applications > may report a IME failure. Fallbacking to the main window handle fixes > this. > > > Changelog: > - dlls/imm32/imm.c: fall back to the main HWND when there is no IMM > HWND in ImmGetDefaultIMEWnd() > Please add a test case to prove this behavior is correct. -- James Hawkins

2 1