June 2008 - Wine-devel - list.winehq.org

Re: dinput: Fix name clashes (Resend #2)
by Alexandre Julliard 23 Jun '08

23 Jun '08

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > Is there anything wrong with this patch? (Having two "JoystickImpl" types in > the same dll confounds some static analyisis programs.) The types are local to the C file so there is no clash. If some tools don't understand that they need to be fixed. -- Alexandre Julliard julliard(a)winehq.org

2 3

wine 1.0
by Damoun D. 23 Jun '08

23 Jun '08

Hi Dan, I just want to say that Wine 1.0 is fantastic! Also, I was wondering if by any chance you have a Google Grandcentral invite you can send me. Thanks so much, Damoun

1 0

Re: richedit: (9/8) EM_POSFROMCHAR tests
by Alex Villacís Lasso 23 Jun '08

23 Jun '08

Alex Villacís Lasso escribió: > Found while debugging #13864 . While it does not solve the bug, it is > worthwhile to get this out of the way. > > EM_POSFROMCHAR can return the position of the requested character > through either a pointer to a POINTL through wParam, or through the > result value. When using the pointer method, native returns 0, builtin > returns MAKELONG(x,y) (just like the return method). Builtin should > choose one or the other, but not both at the same time. > > Changelog: > * When returning position through wParam pointer, EM_POSFROMCHAR must > return 0 as LRESULT. > * Add tests for EM_POSFROMCHAR for 1.0 and 2.0. > > ------------------------------------------------------------------------ > > Was there something wrong with this patch? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

oleaut32/tests: initialize pointer before sending it over the wire??
by Dan Kegel 23 Jun '08

23 Jun '08

While looking at the valgrind warning in http://kegel.com/wine/valgrind/logs-2008-06-20/vg-oleaut32_tmarshal.txt Conditional jump or move depends on uninitialised value(s) at serialize_param (tmarshal.c:736) by serialize_param (tmarshal.c:744) by xCall (tmarshal.c:1414) by ??? by func_tmarshal (tmarshal.c:1179) by run_test (test.h:449) by main (test.h:498) Uninitialised value was created by a stack allocation at test_typelibmarshal (tmarshal.c:762) The problem happens during a call to this method where widget is a pointer to an uninitialized pointer which will receive the pointer to the widget: interface IKindaEnumWidget : IUnknown { HRESULT Next( [out] IWidget **widget); I discovered that the attached patch prevented the problem. I don't quite understand why; at first glance, widget is an out parameter from the function, why would it be dereferenced while serializing the call?

3 3

Missed Patches
by Alistair Leslie-Hughes 23 Jun '08

23 Jun '08

Hi, Any wrong with my patches gdi32: stop crash in font tests mapi32: stop crash under win98 secur32: fix crash under win98 shell32: Stop crash when an error occurs msxml3: Added xml Input Callbacks to support loading files from a Wine windows drive Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH] comctl32: Use ms sans serif in ip controls.
by Alexandre Julliard 23 Jun '08

23 Jun '08

"Lei Zhang" <thestig(a)google.com> writes: > @@ -191,6 +194,10 @@ static LRESULT IPADDRESS_Create (HWND hwnd, const CREATESTRUCTA *lpCreate) > infoPtr->Enabled = TRUE; > infoPtr->Notify = lpCreate->hwndParent; > > + SystemParametersInfoW(SPI_GETICONTITLELOGFONT, 0, &logFont, 0); > + strcpyW(logFont.lfFaceName, MSSanSerif); > + hFont = CreateFontIndirectW(&logFont); Do you really need to hardcode MS Sans Serif? The other controls don't do that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Development plans
by Alexandre Julliard 23 Jun '08

23 Jun '08

Hi folks, Again, congrats to everybody for the 1.0 release! Now that I'm starting to recover from the shock of having actually shipped 1.0, here are a few notes on future development: 1) Code freeze is over, patches are accepted again. If you sent patches and they didn't get applied during code freeze, please rebase them against 1.0 and resend them. 2) Development will continue as usual in the git "master" branch. The 1.1.x development releases will be made from that branch every other Friday. 3) There is now a git "stable" branch, where only important bug fixes will be committed. The 1.0.x maintenance releases will be made from that branch whenever enough changes have accumulated to justify a release. The process I suggest for the 1.0.1 release is as follows: - all bugs should be fixed in the master branch first - once a bug fix has been committed to master, the corresponding bug report should be marked fixed, with the sha1 of the commit fixing it - the bug report should then be put into the 1.0.1 milestone. This will allow me to periodically query for 1.0.1 bugs that are fixed in master and cherry-pick the corresponding commits into the stable branch. -- Alexandre Julliard julliard(a)winehq.org

6 8

Re: avifil32: The importlib has the name vfw32
by Alexandre Julliard 23 Jun '08

23 Jun '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > avifil32: The importlib has the name vfw32 Not really, vfw32 is a common import lib for several dlls, not just avifil32. This will require some work to fix properly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/3] riched20: Implement ITextDocument_fnGetSelection.
by Alexandre Julliard 23 Jun '08

23 Jun '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -532,6 +538,709 @@ static const ITextDocumentVtbl tdvt = { > ITextDocument_fnRangeFromPoint > }; > > +/*** IUnknown methods ***/ > +static HRESULT WINAPI ITextSelection_fnQueryInterface( > + ITextSelection *me, > + REFIID riid, > + void **ppvObj) > +{ > + ITextSelectionImpl *This = (ITextSelectionImpl *) me; > + > + TRACE("%p %s\n", This, debugstr_guid(riid)); > + > + *ppvObj = NULL; > + if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ITextSelection)) > + { > + *ppvObj = me; > + return S_OK; > + } > + > + return E_NOINTERFACE; > +} > + > +static ULONG WINAPI ITextSelection_fnAddRef( > + ITextSelection *me) > +{ > + return 2; > +} > + > +static ULONG WINAPI ITextSelection_fnRelease( > + ITextSelection *me) > +{ > + return 1; > +} The ref counting isn't correct. Most likely ITextSelection should be implemented directly by the main object, and share its ref count. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winecfg: Added Windows registration information setting
by Dmitry Timoshkov 23 Jun '08

23 Jun '08

"Filipe Ferreira" <filipe(a)tinypad.net> wrote: > Added english controls to winecfg About tab for registration info in En.rc > Added code for retrieving and setting registration info in main.c > Added textbox identifiers in resource.h Please add all the required changes to all .rc files, not only to En.rc. Otherwise all previously valid language resources become suddenly out of the sync. -- Dmitry.

1 0