June 2008 - Wine-devel - list.winehq.org

Re: README: Add Russian translation
by Nikolay Sivov 22 Jun '08

22 Jun '08

Well done! It's a good starting point, but this translation is rather awry. It contains a lot of punctuation mistakes and inaccurately translated words, but I still hope it'll be committed to work on it further..

1 0

Re: README: Add Russian translation
by Dmitry Timoshkov 22 Jun '08

22 Jun '08

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > --- /dev/null > +++ b/documentation/README.ru > @@ -0,0 +1,187 @@ > +1. ВВЕДЕНИЕ > + > +Wine это программа которая позволяет запускать программы Microsoft Windows > +(включая DOS, Windows 3.x и Win32) на Unix. Она состоит из программы загрузки > +которая загружает и выполняет программы Microsoft Windows, > +и библиотеки (Winelib) которая реализует вызовы Windows > +API используя их Unix или X11 эквиваленты. > +Библиотека также может быть использована для портирования > +кода Win32 в исполняемые файлы Unix. Please fix the text formatting here and everywhere else so that the strings in each paragraph have a comparable length. Right now it's plain ugly. -- Dmitry.

1 0

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL
by Eric Pouech 22 Jun '08

22 Jun '08

Andrew Talbot a écrit : > Changelog: > dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL. > > diff --git a/dlls/dbghelp/stabs.c b/dlls/dbghelp/stabs.c > index d550633..3c69eec 100644 > --- a/dlls/dbghelp/stabs.c > +++ b/dlls/dbghelp/stabs.c > @@ -896,10 +896,10 @@ static int stabs_pts_read_type_def(struct ParseTypedefData* ptd, const char* typ > * removed > */ > l1 = strlen(udt->hash_elt.name); > - l2 = strlen(typename); > - if (l1 > l2 || strcmp(udt->hash_elt.name, typename + l2 - l1)) > + l2 = typename ? strlen(typename) : 0; > + if (l1 > l2 || (typename && strcmp(udt->hash_elt.name, typename + l2 - l1))) > ERR("Forward declaration name mismatch %s <> %s\n", > - udt->hash_elt.name, typename); > + udt->hash_elt.name, typename ? typename : "(null)"); > new_dt = &udt->symt; > } > PTS_ABORTIF(ptd, stabs_pts_read_aggregate(ptd, udt) == -1); > @@ -1003,7 +1003,7 @@ static int stabs_pts_read_type_def(struct ParseTypedefData* ptd, const char* typ > > *stabs_find_ref(filenr1, subnr1) = *ret_dt = new_dt; > > - TRACE("Adding (%ld,%ld) %s\n", filenr1, subnr1, typename); > + TRACE("Adding (%ld,%ld) %s\n", filenr1, subnr1, typename ? typename : "(null)"); > > return 0; > } > > > > > looks like a bit strange to me that you get a null typename here can you send me the DLL/.so file on which you get the seg fault A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Re: implement MsiSetExternalUIRecord
by Dmitry Timoshkov 22 Jun '08

22 Jun '08

"Paolo Abeni" <paolo.abeni(a)gmail.com> wrote: > Changelog: > * add basic implementation for MsiSetExternalUIRecord The only place where new stuff is used is package.c, why did you add it to msi_main.c and msipriv.h? -- Dmitry.

2 1

'Interactive' tests on Windows 2003
by Francois Gouget 22 Jun '08

22 Jun '08

Someone asked to check which tests require interaction when running in my Windows 2003 VM. However I cannot find the corresponding email (it might have been on irc), so I'm sending this data to the list. So the only interaction that was needed was caused by this IE security dialog: Content within this application coming from the Web site listed below is being blocked by Internet Explorer Enhanced Security Configuration. Only three tests were impacted: * mshtml_test dom -> 1508 tests run but 0 failures happened when just closing the dialog. * mshtml_test script (about:security_mshtml_test.exe) -> 21 tests run and 13 failures if the dialog is just closed, and 0 failures if mshtml_test is manually added to the 'allowed' list. * urlmon_test misc -> 923 tests run but 0 failures if the dialog is just closed. When run by winetest these tests just time out though. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

3 3

Valgrind regression in "rpcrt4: Use abrtitrary pointer identifiers when marshalling pointers instead of using pointer values."?
by Dan Kegel 22 Jun '08

22 Jun '08

This Valgrind error popped up for the first time today. To reproduce, make sure you have an up to date valgrind from svn, apply something like http://kegel.com/wine/valgrind/runtest.patch, and do e.g. $ cd dlls/rpcrt4/tests $ RUNTEST_USE_VALGRIND=1 make server.ok Reverting http://source.winehq.org/git/wine.git/?a=commit;h=4bde42aaa20df0492e45a965c… makes it go away, though I can't for the life of me see how. Rob, can you have a look? Syscall param socketcall.send(msg) points to uninitialised byte(s) at 0x40007F2: (within /lib/ld-2.7.so) by 0x4CEA13A: rpcrt4_conn_write (rpc_binding.h:171) by 0x4CEA006: RPCRT4_SendWithAuth (rpc_message.c:533) by 0x4CEA784: RPCRT4_Send (rpc_message.c:675) by 0x4CED074: process_request_packet (rpc_server.c:313) by 0x4CED34E: RPCRT4_process_packet (rpc_server.c:345) by 0x4CED422: RPCRT4_worker_thread (rpc_server.c:362) by 0x475F8C0: worker_thread_proc (threadpool.c:113) by 0x475D2A1: ??? (thread.c:128) by 0x475D329: call_thread_func (thread.c:383) by 0x475D58D: start_thread (thread.c:443) by 0x41754FA: start_thread (in /lib/tls/i686/cmov/libpthread-2.7.so) by 0x425FE5D: clone (in /lib/tls/i686/cmov/libc-2.7.so) Address 0x7f013870 is 24 bytes inside a block of size 49 alloc'd at 0x472C516: notify_alloc (heap.c:191) by 0x472C3DD: RtlAllocateHeap (heap.c:1231) by 0x4CE9E3C: RPCRT4_SendWithAuth (rpc_message.c:492) by 0x4CEA784: RPCRT4_Send (rpc_message.c:675) by 0x4CED074: process_request_packet (rpc_server.c:313) by 0x4CED34E: RPCRT4_process_packet (rpc_server.c:345) by 0x4CED422: RPCRT4_worker_thread (rpc_server.c:362) by 0x475F8C0: worker_thread_proc (threadpool.c:113) by 0x475D2A1: ??? (thread.c:128) by 0x475D329: call_thread_func (thread.c:383) by 0x475D58D: start_thread (thread.c:443) by 0x41754FA: start_thread (in /lib/tls/i686/cmov/libpthread-2.7.so) by 0x425FE5D: clone (in /lib/tls/i686/cmov/libc-2.7.so) Uninitialised value was created by a stack allocation at 0x496FBFB: IServer_get_filename (server_s.c:4697)

2 1

wininet:http new test failures
by James Hawkins 21 Jun '08

21 Jun '08

Hi all, I can't narrow down the commit that is causing the failures, but we're getting several new failures in the wininet:http tests that we weren't getting before. Looking through the recent changelog, Hans has added tests recently that might be the culprit. Can you take a look at the test results and see what's going on? http://test.winehq.org Thanks, James Hawkins

1 0

user32:msg new failing tests
by James Hawkins 21 Jun '08

21 Jun '08

Hi Dmitry, Tests added in the following commit fail for all platforms in which the tests are run: commit bbd8ae432256d32d99e75580b1896002045223b9 Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Wed Jun 18 12:34:01 2008 +0900 user32: Add a test for MNS_NOTIFYBYPOS, make it pass under Wine. -- James Hawkins

1 0

Re: dxdiagn: PhysicalMemory parameter is a string not long long
by Rob Shearman 21 Jun '08

21 Jun '08

2008/6/21 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > @@ -300,6 +300,7 @@ static HRESULT DXDiag_InitDXDiagSystemInfoContainer(IDxDiagContainer* pSubCont) > GlobalMemoryStatusEx( &msex ); > V_VT(&v) = VT_UI8; > V_UI8(&v) = msex.ullTotalPhys; > + VariantChangeType(&v, &v, 0, VT_BSTR); > IDxDiagContainerImpl_AddProp(pSubCont, ullPhysicalMemory, &v); > > info.dwOSVersionInfoSize = sizeof(info); You need to call VariantClear otherwise you will leak memory. -- Rob Shearman

2 1

Re: [3/3] gdi32: Return the correct value from GetTextFace.
by Alexandre Julliard 21 Jun '08

21 Jun '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > INT WINAPI GetTextFaceA( HDC hdc, INT count, LPSTR name ) > { > - INT res = GetTextFaceW(hdc, 0, NULL); > - LPWSTR nameW = HeapAlloc( GetProcessHeap(), 0, res * 2 ); > - GetTextFaceW( hdc, res, nameW ); > - > if (name) > { > - if (count && !WideCharToMultiByte( CP_ACP, 0, nameW, -1, name, count, NULL, NULL)) > + LPWSTR nameW = HeapAlloc( GetProcessHeap(), 0, count * sizeof nameW[0] ); > + INT res = GetTextFaceW( hdc, count, nameW ); > + if (count && res) > + { > + WideCharToMultiByte( CP_ACP, 0, nameW, -1, name, count, NULL, NULL); > name[count-1] = 0; > - res = strlen(name); > + } > + HeapFree( GetProcessHeap(), 0, nameW ); > + /* GetTextFaceA does NOT include the nul byte in the return count. */ > + return res ? res - 1 : 0; > } > else > - res = WideCharToMultiByte( CP_ACP, 0, nameW, -1, NULL, 0, NULL, NULL); > - HeapFree( GetProcessHeap(), 0, nameW ); > - return res; > + return GetTextFaceW(hdc, 0, NULL); > } This is wrong, you can't return the W length from the A function. -- Alexandre Julliard julliard(a)winehq.org

1 0