June 2008 - Wine-devel - list.winehq.org

Nominating bugs for 1.0.1
by Dan Kegel 12 Jun '08

12 Jun '08

Since Alexandre is now planning to do a 1.0.1 release, I created a 1.0.1 target in bugzilla, and have targeted a very few high priority and/or fixed-but-not-in-time bugs to it. Many of the bugs currently targeted for 1.2 are not good candidates for targeting to 1.0.1 because the bug is not yet well understood and/or a fix is not yet known. I think the rule of thumb for further nominations should be something like "if it's already fixed in trunk, and the fix is easy to backport to 1.0, then it should be nominated for 1.0.1."

1 0

Re: advapi32: fix a test failure on NT4
by Paul Vriens 12 Jun '08

12 Jun '08

Austin English wrote: > > ------------------------------------------------------------------------ > > Hi, This patch is not correct. That last error actually came from the first of the two GetServiceDisplayNameA's just before that and wasn't reset by NT4. I'll sent a more correct one. -- Cheers, Paul.

1 1

Re: advapi32: fix a test failure on NT4
by James Hawkins 12 Jun '08

12 Jun '08

On Thu, Jun 12, 2008 at 9:29 AM, Austin English <austinenglish(a)gmail.com> wrote: > + ok(GetLastError() == ERROR_SERVICE_DOES_NOT_EXIST || + GetLastError() == ERROR_INSUFFICIENT_BUFFER /* NT 4 */, + "Expected ERROR_SERVICE_DOES_NOT_EXIST or ERROR_INSUFFICIENT_BUFFER, got %d\n", GetLastError()); You can't see it with this paste, but it looks like you used tabs instead of spaces, or at least the indentation is off. -- James Hawkins

1 0

Re: gdi32: GetCharacterPlacement should accept NULL lpResults (fixes bug 13094)
by James Hawkins 12 Jun '08

12 Jun '08

On Thu, Jun 12, 2008 at 3:39 AM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > Changelog: > - Fixes GetCharacterPlacement with NULL lpResults argument (fix for bug 13094) > > --- > dlls/gdi32/font.c | 34 ++++++++++++++++++++++++---------- > 1 files changed, 24 insertions(+), 10 deletions(-) > > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index 1bfd97a..34aabd1 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -2709,27 +2709,35 @@ GetCharacterPlacementA(HDC hdc, LPCSTR lpString, INT uCount, > WCHAR *lpStringW; > INT uCountW; > GCP_RESULTSW resultsW; > + GCP_RESULTSW *presults = NULL; > DWORD ret; > UINT font_cp; > > TRACE("%s, %d, %d, 0x%08x\n", > debugstr_an(lpString, uCount), uCount, nMaxExtent, dwFlags); > > - /* both structs are equal in size */ > - memcpy(&resultsW, lpResults, sizeof(resultsW)); > + if(lpResults){ > + /* both structs are equal in size */ > + memcpy(&resultsW, lpResults, sizeof(resultsW)); > + > + if(lpResults->lpOutString) > + resultsW.lpOutString = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*uCountW); > + > + presults = &resultsW; > + } > > lpStringW = FONT_mbtowc(hdc, lpString, uCount, &uCountW, &font_cp); > - if(lpResults->lpOutString) > - resultsW.lpOutString = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*uCountW); > > - ret = GetCharacterPlacementW(hdc, lpStringW, uCountW, nMaxExtent, &resultsW, dwFlags); > + ret = GetCharacterPlacementW(hdc, lpStringW, uCountW, nMaxExtent, presults, dwFlags); > > - lpResults->nGlyphs = resultsW.nGlyphs; > - lpResults->nMaxFit = resultsW.nMaxFit; > + if(lpResults){ > + lpResults->nGlyphs = resultsW.nGlyphs; > + lpResults->nMaxFit = resultsW.nMaxFit; > > - if(lpResults->lpOutString) { > - WideCharToMultiByte(font_cp, 0, resultsW.lpOutString, uCountW, > - lpResults->lpOutString, uCount, NULL, NULL ); > + if(lpResults->lpOutString) { > + WideCharToMultiByte(font_cp, 0, resultsW.lpOutString, uCountW, > + lpResults->lpOutString, uCount, NULL, NULL ); > + } > } > > HeapFree(GetProcessHeap(), 0, lpStringW); > @@ -2780,6 +2788,10 @@ GetCharacterPlacementW( > lpResults->lpGlyphs, lpResults->nGlyphs, lpResults->nMaxFit); > > if(dwFlags&(~GCP_REORDER)) FIXME("flags 0x%08x ignored\n", dwFlags); > + > + /* with NULL lpResults return GetTextExtentPoint32 result */ > + if(!lpResults) goto nullres; > + > if(lpResults->lpClass) FIXME("classes not implemented\n"); > if (lpResults->lpCaretPos && (dwFlags & GCP_REORDER)) > FIXME("Caret positions for complex scripts not implemented\n"); > @@ -2833,6 +2845,8 @@ GetCharacterPlacementW( > if(lpResults->lpGlyphs) > GetGlyphIndicesW(hdc, lpString, nSet, lpResults->lpGlyphs, 0); > > +nullres: > + > if (GetTextExtentPoint32W(hdc, lpString, uCount, &size)) > ret = MAKELONG(size.cx, size.cy); > You need to write a test for this behavior, especially this close to a release. -- James Hawkins

1 0

Fwd: [Wine] Wine 1.0 release date to clash with Firefox 3
by Austin English 12 Jun '08

12 Jun '08

---------- Forwarded message ---------- From: Bamm <wineforum-user(a)winehq.org> Date: Thu, Jun 12, 2008 at 6:32 AM Subject: [Wine] Wine 1.0 release date to clash with Firefox 3 To: wine-users(a)winehq.org According to http://wiki.winehq.org/WineReleasePlan the new release date for Wine 1.0 is set to June 17. However the Firefox 3.0 release date is also set to June 17. http://developer.mozilla.org/devnews/index.php/2008/06/11/coming-tuesday-ju… Their release is planned to be high profile and they even plan to set a Guinness world record for downloads in a single day! http://www.tuaw.com/2008/05/30/help-firefox-set-a-guinness-world-record/ With this, I fear that the Wine release would be drowned out in the euphoria and excitement for Firefox 3. I respectfully suggest, therefore, that we move the Wine 1.0 release date to another date besides June 17. This way we can attract more press and attention. I hope others agree with my observation. Regards, Bamm

2 1

Re: [website] wine 1.0 update
by Michael Stefaniuc 12 Jun '08

12 Jun '08

Dan Kegel wrote: > The penultimate update? > > > ------------------------------------------------------------------------ > 1.0 bugs deferred to 1.0.1 since May 27th: > +<li><a href="http://bugs.winehq.org/show_bug.cgi?id=12097">12097</a> Wine 1.0 should not ship out-of-sync resource translations This bug is fixed as soon as Alexandre commits the patch from http://www.winehq.org/pipermail/wine-patches/2008-June/055761.html . http://pf128.krakow.sdi.tpnet.pl/wine-transl/ shows an other "error" in the Japanese user32 translation but that's only an extra FONT element in DIALOG MSGBOX. I think the FONT element can be removed but i need to cross check that. Anyway, the resource/dialog is not broken at all for Japanese and thus the bug #12097 can be considered fixed after todays commit round. bye michael

1 0

Re: Add German translation for xcopy
by Rico Schüller 12 Jun '08

12 Jun '08

Michael Karcher wrote: > --- > programs/xcopy/De.rc | 79 ++++++++++++++++++++++++++++++++++++++++++++++++ > programs/xcopy/rsrc.rc | 1 + > 2 files changed, 80 insertions(+), 0 deletions(-) > create mode 100644 programs/xcopy/De.rc > > > ------------------------------------------------------------------------ > > Does this work for you? When I apply the attached patch and run wine xcopy /? I get garbled German umlauts in the output (also tried with SUBLANG_NEUTRAL) . Is it the same for you? I think you forgot something to translate: STRING_INVPARM, "Unbekannter Parameter '%s' - Use xcopy /? for help\n" should be something like STRING_INVPARM, "Unbekannter Parameter '%s' - xcopy /? zeigt Hilfe an\n" Cheers Rico

3 2

Re: Wine-1.0 release notes
by Susan Cragin 12 Jun '08

12 Jun '08

I would agree and go further. Wine has made Linux handicapped-accessible for a great number of people, including me, who have mild repetitive-motion difficulties that make typing for any length of time uncomfortable. Many of the people who use Linux are programmers and are technically proficient, and they seem to want a lot from their computer, but here I sit, comfortably churning out text at the rate of almost the spoken word. I transcribe interviews, write letters, complain to my congresspeople, and am writing this, with no effort (and sometimes, not much thought either, because you see, it's not an effort to type). Dragon NaturallySpeaking is a tremendously complex program, and it is a miracle that it has been made to run on Linux. Now, it runs in basic form. Many of its "special features" don't work. But on the other hand, if it were being sold as simply a text recognition medium, it would still sell. That's what it does well. It recognizes spoken words and writes them down, fast. In addition, I expect that soon wine and Linux will run Dragon NaturallySpeaking faster than Windows will. Windows Vista will run it better, because more of its features will be enabled, but Linux will run it faster. And faster means better, means more words PLUS more accurate recognition. As soon as some of the bugs get worked out Ubuntu and ALSA sound, and I get better accuracy scores from my microphone, I expect Dragon NaturallySpeaking to recognize text better on Linux than it does on Windows. What that means for transcription services, for court reporting, etc., is anybody's guess. But I plan to find out when I take a speed test on the last day of July. Dragon NaturallySpeaking is a unique program. Just ask those folks at IBM who worked on ViaVoice. That program was abandoned. Ask the people at Carnegie Mellon who worked on Sphinx for Linux. Ask Microsoft, which is trying to develop its own. Dragon NaturallySpeaking is the type of program that isn't going to have a rival for 10 years. Now that I've gotten that particular rant off my chest -- and don't worry about my fingers, it only took me a minute to do it -- I'd like to mention another very useful program that wine runs flawlessly. This is keynote, a note-taking program used by academic researchers. Here is another little thought to ponder. Massachusetts USA developed a state requirement for "open document format" but it has been delayed because, as one lobbyist put it, "there are no office applications with native ODF support that provide accessibility for persons who use assistive technology devices." I mean, how proud do we need to be about not running everything? Susan -----Original Message----- >From: Reece Dunn <msclrhd(a)googlemail.com> >Sent: Jun 11, 2008 8:02 PM >To: Vitaliy Margolen <wine-devel(a)kievinfo.com> >Cc: Wine Develop <wine-devel(a)winehq.org> >Subject: Re: Wine-1.0 release notes > >2008/6/11 Vitaliy Margolen <wine-devel(a)kievinfo.com>: >> In short - that after everyone's hard work and 15 years of development >> wine-1.0 is just a release tag nothing more. > >I think that this is overly harsh. It's like saying that you should >not celebrate a birthday, as that is just you aging just a day, >nothing more. > >Wine is in a strange position as it is trying to make any Windows >application (ultimately) run on any suitable posix system with a >suitable X server. Given that a new version of Windows is usually >released every 2-3 years, with new features, APIs and functionality, >the landscape is constantly changing. Couple this with each successive >release of an application supporting newer technologies and APIs - the >set of which differs from application to application, makes it harder >to support. > >Yes, regressions will happen. Yes, applications will crash/fail to >work. But think of all the applications that *do* work; given what >Wine is working against, this is an amasing achievement. Wine can and >does run Office, Photoshop, ITunes, Oblivion, Peggle and a myriad >other applications (some better than others). > >So yes, highlight the known issues in the release notes, list the >major applications (with corresponding version numbers) that are known >to work and refer the user to the AppDB for more information. However, >don't sell it short either. > >I am personally using Wine to run the Cepstral SwiftTalker >text-to-speech program, play Oberon/PopCap/casual games like Peggle, >Bejeweled 2 and Bloom on my Ubuntu laptop. I'm sure that other people >have other success stories as well, such as Susan Cragin, who uses >Dragon Naturally Speaking 9. > >Maybe what we need is a "What I use Wine for" set of documents or >mini-articles where people describe what Windows applications they are >running, what works/does not work for them. Dan's Spouse test is also >a good idea. Perhaps we can get some feedback on the Spouses >experiences of using the applications under Wine. > >NOTE: I have been testing various casual games from Oberon with the >various RC releases and have found that over 50% of those tested >(around 14 at the moment) worked out of the box when ran directly from >their install directory. While this does not seem a lot, given what >Wine is developing against, I think this is a huge success. > >NOTE: I am not saying Wine is perfect, I'm saying that the message >should be positive and realistic instead of unduly negative. > >- Reece > >

1 0

unhide .update-timestamp
by Lei Zhang 11 Jun '08

11 Jun '08

Hi, Can we rename $WINEPREFIX/.update-timestamp to $WINEPREFIX/update-timestamp? There's been times when I cleaned my $WINEPREFIX directory by going into that directory and running rm -Rf... except .update-timestamp didn't get removed. Then I run wine, but wineboot is a bit confused and does not invoke InstallHinfSectionW(), thus creating a $WINEPREFIX/drive_c with lots of missing files.

1 0

Compiling wine-1.0-rc3 (2)
by Alexandrov Anton 11 Jun '08

11 Jun '08

Hello. I solved this problem. In my case wine couldn't be compiled with "-malign-double" option. I compiled it successfully after I had removed this option in my $CFLAGS and $CXXFLAGS. -- All the best, Alexandrov Anton.

1 0