June 2008 - Wine-devel - list.winehq.org

Re: ddraw: Fix Setmaterial with a test
by Vitaliy Margolen 10 Jun '08

10 Jun '08

David Adam wrote: > The test succeded in my windows XP box. > You have only ddraw test and no d3d test. Vitaliy.

1 0

Re: [ole32/tests 2/2] Fix crash on NT4 and below
by Rob Shearman 10 Jun '08

10 Jun '08

2008/6/10 Paul Vriens <paul.vriens.wine(a)gmail.com>: > This 'fixes' the crash on win9x and NT4. > > @@ -1130,11 +1130,15 @@ static void test_data_cache(void) > hr = IOleCache_Uncache(pOleCache, 0xdeadbeef); > ok(hr == OLE_E_NOCONNECTION, "IOleCache_Uncache with invalid value should return OLE_E_NOCONNECTION instead of 0x%x\n", hr); > > - hr = IOleCache_Cache(pOleCache, NULL, 0, &dwConnection); > - ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL fmtetc should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + /* Both tests crash on NT4 and below */ > + if (0) > + { > + hr = IOleCache_Cache(pOleCache, NULL, 0, &dwConnection); > + ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL fmtetc should have returned E_INVALIDARG instead of 0x%08x\n", hr); > > - hr = IOleCache_Cache(pOleCache, NULL, 0, NULL); > - ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL pdwConnection should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + hr = IOleCache_Cache(pOleCache, NULL, 0, NULL); > + ok(hr == E_INVALIDARG, "IOleCache_Cache with NULL pdwConnection should have returned E_INVALIDARG instead of 0x%08x\n", hr); > + } > > for (fmtetc.cfFormat = CF_TEXT; fmtetc.cfFormat < CF_MAX; fmtetc.cfFormat++) > { This test was added in response to a real application doing exactly this, so I think the test does have value when run on Win 2000+. Therefore, I think a version check would be better than "if (0)". -- Rob Shearman

2 1

Re: shell32: stop shlfolder tests crashing under win98
by Paul Vriens 10 Jun '08

10 Jun '08

Alistair Leslie-Hughes wrote: > Hi, > Moved the null pointer checker to before it's first used. > > Changelog: > shell32: stop shlfolder tests crashing under win98 > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > While your at it, could you add a skip message? -- Cheers, Paul.

1 0

Re: gdi32: Use 0xffff as a default character as Vista does
by Reece Dunn 10 Jun '08

10 Jun '08

2008/6/10 Dmitry Timoshkov <dmitry(a)codeweavers.com>: > Hello, > > this patch fixes the problem reported in the bug 12305. In Wine Tahoma > character ':' is mapped to glyph index 0x1f, and that seems to be confusing > Firefox. > + TM.tmDefaultChar = pOS2->usDefaultChar ? pOS2->usDefaultChar : 0xffff; There is a UNICODE_NOCHAR constant for this. - Reece

2 1

Re: msxml3: tests/xmlelem.c: VT_EMPTY is not a string
by Michael Stefaniuc 09 Jun '08

09 Jun '08

Dan Kegel wrote: > Casting a VT_EMPTY to a string gets you a null string. > The test was doing that and taking the string length, then comparing to zero. > Better to simply compare to null; that's a stronger test, and > avoids generating a behind-the-scenes exception. > > Passes on Wine and XP, and makes Valgrind output a bit easier on the eyes. > > > ------------------------------------------------------------------------ > diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c > index 61a2300..229de78 100644 > --- a/dlls/msxml3/tests/xmlelem.c > +++ b/dlls/msxml3/tests/xmlelem.c > @@ -78,7 +78,7 @@ static void test_xmlelem(void) > hr = IXMLElement_getAttribute(element, str, &vValue); > ok(hr == S_FALSE, "Expected S_FALSE, got %d\n", hr); > ok(V_VT(&vValue) == VT_EMPTY, "Expected VT_EMPTY, got %d\n", V_VT(&vValue)); > - ok(lstrlenW(V_BSTR(&vValue)) == 0, "Expected empty value\n"); > + ok(V_BSTR(&vValue) == (void *)0, "Expected null value\n"); Is there a problem with using NULL instead of (void *)0? bye michael

2 1

Re: notepad: updated French translation
by Laurent Vromman 09 Jun '08

09 Jun '08

Hi, I don't know if it is important since the translation is grammatically correct, but in windows (I checked on XP SP2), the exact translation is "À &propos du Bloc-notes..." and not "À &propos de Bloc-notes..." Laurent Jonathan Ernst wrote: > ------------------------------------------------------------------------ > > >

3 4

Please have a look at the current Valgrind warnings
by Dan Kegel 09 Jun '08

09 Jun '08

After a few days of cleaning up Valgrind warnings in the Wine source tree, and adding suppressions where it made sense. I've whittled the list of Valgrind warnings down to 300 or so. This list is short enough that a mortal can look upon it without dispair, and even see a number of things that might be real bugs. The histogram of frequent errors is at http://kegel.com/wine/valgrind/logs-2008-06-08.counts.txt and shows one call stack per line (only top three locations are represented for each call stack). A few groups of warnings stand out: 10 of them are invalid calls to free() or friends, 30 of them involve WideCharToMultiByte, 50 of them are in ds3d or ds3d8, and 60 of them are in Gecko. (Ooodles and oodles are caused by nvidia's libgl, libfontconfig, libexpat, and libc; most of these are suppressed, or you'd die of bordom or anger reading the logs.) As before, the log broken out by directory is at http://kegel.com/wine/valgrind/logs-2008-06-08/ The full log is at http://kegel.com/wine/valgrind/logs-2008-06-08.log.gz This is run with --track-origins=yes, so you get nifty stack tracebacks for where the undefined values got their initial, um, nonvalue. This is often quite helpful for narrowing down the cause. The diff against CVS of the tree I ran this on is at http://kegel.com/wine/valgrind/logs-2008-06-08-patch.txt and is mostly the valgrind cleanup patches I've written that have not yet been committed (plus one rough one from Juan). It's given for completeness; I'll resubmit the individual patches once 1.0 is out. Oh, and the suppressions file I use is rather bigger now. As always, it's at http://kegel.com/wine/valgrind/valgrind-suppressions If you've read this far, congratulations and thanks. Please consider triaging one of these warnings. Just pick one at random, and if you really figure it out, please submit a fix; be sure to include the valgrind warning in the description of the patch. Even if all you figure out is how to improve the test and thereby not generate Valgrind warnings, that's great, please send in your patch. Every test we make squeaky-clean improves the signal-to-noise ratio for finding real problems. (But please don't submit any change you don't really understand, or that seems risky. The goal is not to clean up Valgrind warnings; it's to improve the quality of the test suite.) - Dan

2 1

Wine Profiling
by Stephen Eilert 09 Jun '08

09 Jun '08

Hi, I'd like to know what's the procedure being used to profile Wine's code. More specifically, I want to try to track down slowdowns in some applcations, which requires profiling to identify where the bottlenecks are. Are there any specific procedures or utilities to instrument and generate profiling reports? Stephen

3 2

Re: Downgrade lack of libxslt from configure warning to notice
by Vitaliy Margolen 08 Jun '08

08 Jun '08

Gerald Pfeifer wrote: > On a test system of mine which does not feature too many packages I am > getting the following: > > configure: libsane development files not found, scanners won't be supported. > configure: libgphoto2 development files not found, digital cameras won't be supported. > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > configure: libcapi20 development files not found, ISDN won't be supported. > configure: WARNING: libxslt development files not found, xslt won't be supported. > > Looking that libxslt only seems to be used by msxml3, I am wondering > whether this really is worth a warning? > No, if anything any missing part should stop configure and exit with error. And if you force compiling without some feature Wine should be marked "tainted". So all bug reports and calls for help can be easily filtered and ignored. In short NEVER ignore missing dependencies. You never know what windows app might use and why. Vitaliy.

1 0

Re: Downgrade lack of libxslt from configure warning to notice
by Marcus Meissner 08 Jun '08

08 Jun '08

On Sun, Jun 08, 2008 at 10:42:32PM +0200, Gerald Pfeifer wrote: > On a test system of mine which does not feature too many packages I am > getting the following: > > configure: libsane development files not found, scanners won't be supported. > configure: libgphoto2 development files not found, digital cameras won't be supported. > configure: libldap (OpenLDAP) development files not found, LDAP won't be supported. > configure: libcapi20 development files not found, ISDN won't be supported. > configure: WARNING: libxslt development files not found, xslt won't be supported. > > Looking that libxslt only seems to be used by msxml3, I am wondering > whether this really is worth a warning? > > How about the patch below? It probably should be an error, since otherwise msxml3 is only partial functional aka "broken". Ciao, Marcus

1 0