June 2008 - Wine-devel - list.winehq.org

Re: [PATCH] shell32: SHFileOperation: test added
by James Hawkins 11 Jun '08

11 Jun '08

On Wed, Jun 11, 2008 at 12:01 PM, Vitaly Perov <vitperov(a)etersoft.ru> wrote: > Changelog: > - shell32: test added. It check whether SHFileOperation could correctly work > with input files mask '*.*' > + retval = SHFileOperationA(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(!file_exists("testdir2\\one.txt"), "Expected one.txt to not exist\n"); Please don't add more of the weird spacing for the ok's. That is a byproduct of a huge patch that I sent to reduce the number of changes, and it just hasn't been fixed yet. -- James Hawkins

1 0

Compiling wine-1.0-rc3
by Alexandrov Anton 11 Jun '08

11 Jun '08

Good afternoon. I tried to compile wine-1.0-rc3 and got this message: ------ ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./acledit.spec main.o -o acledit.dll.so -lkernel32 ../../libs/port/libwine_port.a winebuild: Cannot read main.o winegcc: ../../tools/winebuild/winebuild failed ------ I hadn't use any special options (only "./configure", "make depend && make"). gcc version: 4.1.2 linux kernel: 2.6.24 -- All the best, Alexandrov Anton.

1 0

Re: dsound: notification order
by Vitaliy Margolen 11 Jun '08

11 Jun '08

Ulrich Hecht wrote: > Hi! > > This fixes sound in Ootake (http://www.ouma.jp/ootake/) Looks like > DSBPN_OFFSETSTOP is not always the last element. > > - /* DSBPN_OFFSETSTOP has to be the last element. So this is */ > - /* OK. [Inside DirectX, p274] */ > - /* */ > - /* This also means we can't sort the entries by offset, */ > - /* because DSBPN_OFFSETSTOP == -1 */ > + /* DSBPN_OFFSETSTOP is not necessarily the last element. */ Don't remove all the comments. They are still mostly valid. Just add that it's not always true for some broken apps. > if (offset == DSBPN_OFFSETSTOP) { > if (dsb->state == STATE_STOPPED) { > SetEvent(event->hEventNotify); > TRACE("signalled event %p (%d)\n", event->hEventNotify, i); > - return; > - } else > - return; Much better fix and easier to understand would be replacing "returns" for "continue". Then you won't need to reformat the whole block. Something like: @@ -247,9 +247,8 @@ void DSOUND_CheckEvent(const IDirectSoundBufferImpl *dsb, DWORD playpos, int len if (dsb->state == STATE_STOPPED) { SetEvent(event->hEventNotify); TRACE("signalled event %p (%d)\n", event->hEventNotify, i); - return; - } else - return; + } + continue; Vitaliy.

1 0

Wine + Fedora
by Louis Lenders 11 Jun '08

11 Jun '08

Hi, just thought dropping a note here so you'd know: the troubles reported for wine+fedora 9, now also affect fedora 8. Last saturday i did a 'yum update', and after that about all wine-applications froze my computer. Only a hard reboot helped... Solved it by reverting back to kernel 2.6.24.7-92.fc8 Just in case a new wine-1.0 release comes out, and fedora-users start whining "wine 1.0 is really crap, it freezes my computer" , hope this will be fixed soon.

3 5

RE: ddraw: modify Direct3D device name
by Stefan Dösinger 11 Jun '08

11 Jun '08

> Descent FreeSpace: The Great War and Descent FreeSpace 2 fail to detect > hardware acceleration through Direct3D when enumerating devices, they > expect the device name string to begin with "Direct3D - " > > This patch enables the Direct3D mode to be used. I am not entirely sure about this. I think there were other apps(Quicktime?) which depend on some other name. I think the best is to see which name Windows uses, make ddraw.dll read the name from WineD3D, and make WineD3D return the same name Windows does for the detected card.

2 2

Re: wininet: Make sure URL is terminated in InternetCrackUrlA.
by Alexandre Julliard 10 Jun '08

10 Jun '08

Hans Leidekker <hans(a)it.vu.nl> writes: > Fixes http://bugs.winehq.org/show_bug.cgi?id=1968 > as well as a bunch of Valgrind warnings in the url test module. > > -Hans > > Changelog > Make sure URL is terminated in InternetCrackUrlA. The bug is in InternetCrackUrlW, it shouldn't require the string to be null-terminated. -- Alexandre Julliard julliard(a)winehq.org

3 3

Trying to build rc4 for MacOS, having problems with libpng, libjpeg, etc.
by Timothy Normand Miller 10 Jun '08

10 Jun '08

Hi. I'm not subscribed. I'm trying to build rc4 for MacOS (Leopard), and I'm running into some problems, and I hope I'm not a bother to ask for some help. When I do ./configure, I get the following messages: onfigure: WARNING: libjpeg development files not found, JPEG won't be supported. configure: WARNING: libpng development files not found, PNG won't be supported. (and several other similar ones) I know for a fact that these libraries are installed under /sw (via Fink), along with the include files, but no matter what I do, I can't get get configure to find them. Here's how I'm trying to do it so far: export LDFLAGS=-L/sw/lib export LIBS="-lpng -ljpeg" ./configure --prefix=/sw --exec-prefix=/sw What am I missing? Thanks! -- Timothy Normand Miller http://www.cse.ohio-state.edu/~millerti Open Graphics Project

2 3

Re: gdi32: stop gdi font test crashing under win98
by Dmitry Timoshkov 10 Jun '08

10 Jun '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */ > { > + LOGFONT lf; > + memset(&lf, 0, sizeof(LOGFONT)); > + > efd.total = 0; > SetLastError(0xdeadbeef); > ret = EnumFontFamilies(hdc, NULL, arial_enum_proc, (LPARAM)&efd); > @@ -1333,7 +1336,7 @@ static void test_EnumFontFamilies(const char *font_name, INT font_charset) > > efd.total = 0; > SetLastError(0xdeadbeef); > - ret = EnumFontFamiliesEx(hdc, NULL, arial_enum_proc, (LPARAM)&efd, 0); > + ret = EnumFontFamiliesEx(hdc, &lf, arial_enum_proc, (LPARAM)&efd, 0); The test must use NULL in order to match the EnumFontFamilies results above. If it causes the crash under Win9x the test should be explicitly skipped on that platform. -- Dmitry.

1 0

Re: winex11.drv: Do not crash if UploadGlyph failed
by Alexandre Julliard 10 Jun '08

10 Jun '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes the Firefox crashes reported in the bugs 4762 and 12307. > > Changelog: > winex11.drv: Do not crash if UploadGlyph failed. I don't think that's correct, it should still display the valid glyphs and use a replacement char for the invalid ones. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Stop shlfileop tests crashing under win98
by Dan Kegel 10 Jun '08

10 Jun '08

Alistair wrote: >- /* try an invalid list, only one null terminator */ >- init_shfo_tests(); >- shfo.pFrom = ""; >- shfo.wFunc = FO_DELETE; >- ret = SHFileOperation(&shfo); >- ok(ret == ERROR_ACCESS_DENIED, "Expected ERROR_ACCESS_DENIED, got %d\n", ret); >- ok(file_exists("test1.txt"), "Expected test1.txt to exist\n"); >+ /* This crashes under win98 */ >+ if(0) >+ { >+ /* try an invalid list, only one null terminator */ Hey Allistair, that paragraph looks like it was buggy - it should have had test1.txt followed by a single nul and then twice MAXPATH nonnulls and then a double nul, like the similar tests I fixed in http://www.winehq.org/pipermail/wine-patches/2008-May/055371.html As it is, there's no way FO_DELETE could see test1.txt to maybe delete it. James, do you agree? Perhaps you could leave it enabled if you fixed it like the ones I fixed. (Or tried to fix; sadly, Alexandre hasn't committed it yet. Why?) - Dan

3 3